mirror of
https://github.com/github/spec-kit.git
synced 2026-04-03 03:03:09 +00:00
6eb15a7a3e
Add 5 new core command templates inspired by Garry Tan's GStack to complete the spec-driven development lifecycle: - /speckit.critique: Dual-lens product + engineering review before implementation - /speckit.review: Staff-level code review (correctness, security, performance) - /speckit.qa: Systematic QA testing (browser-driven and CLI modes) - /speckit.ship: Release automation (pre-flight, changelog, CI, PR creation) - /speckit.retro: Sprint retrospective with metrics and improvement suggestions Each command includes: - Command template in templates/commands/ - Output report template in templates/ - Extension hook support (before_*/after_*) - YAML frontmatter with prerequisite scripts Updated README.md workflow from 6 to 11 steps and added CHANGELOG entry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
76 lines
2.0 KiB
Markdown
76 lines
2.0 KiB
Markdown
# Code Review Report: [FEATURE NAME]
|
|
|
|
**Reviewer**: AI Agent (Staff Engineer Perspective)
|
|
**Date**: [DATE]
|
|
**Feature**: [Link to spec.md]
|
|
**Branch**: [Feature branch name]
|
|
**Verdict**: [✅ APPROVED / ⚠️ APPROVED WITH CONDITIONS / ❌ CHANGES REQUIRED]
|
|
|
|
---
|
|
|
|
## Executive Summary
|
|
|
|
[One-paragraph overall assessment of the implementation quality, key strengths, and primary concerns.]
|
|
|
|
---
|
|
|
|
## Review Findings
|
|
|
|
| ID | Severity | File | Line(s) | Category | Finding | Recommendation |
|
|
|----|----------|------|---------|----------|---------|----------------|
|
|
| R001 | 🔴 Blocker | [file] | [lines] | [category] | [description] | [fix suggestion] |
|
|
| R002 | 🟡 Warning | [file] | [lines] | [category] | [description] | [fix suggestion] |
|
|
| R003 | 🟢 Suggestion | [file] | [lines] | [category] | [description] | [fix suggestion] |
|
|
|
|
**Categories**: Correctness, Security, Performance, Spec Compliance, Error Handling, Test Quality, Architecture
|
|
|
|
---
|
|
|
|
## Spec Coverage Matrix
|
|
|
|
| Requirement | Status | Implementation Notes |
|
|
|-------------|--------|---------------------|
|
|
| FR-001: [requirement] | ✅ Implemented | [notes] |
|
|
| FR-002: [requirement] | ⚠️ Partial | [what's missing] |
|
|
| FR-003: [requirement] | ❌ Missing | [recommendation] |
|
|
|
|
**Coverage**: [X]/[Y] requirements implemented ([Z]%)
|
|
|
|
---
|
|
|
|
## Test Coverage Assessment
|
|
|
|
| Area | Tests Exist? | Coverage | Gaps |
|
|
|------|-------------|----------|------|
|
|
| [Module/Feature] | ✅/❌ | [%] | [untested paths] |
|
|
|
|
---
|
|
|
|
## Metrics Summary
|
|
|
|
| Metric | Value |
|
|
|--------|-------|
|
|
| Files reviewed | [count] |
|
|
| 🔴 Blockers | [count] |
|
|
| 🟡 Warnings | [count] |
|
|
| 🟢 Suggestions | [count] |
|
|
| Spec coverage | [%] |
|
|
| Test coverage | [%] |
|
|
|
|
---
|
|
|
|
## Recommended Actions
|
|
|
|
### Must Fix (Blockers)
|
|
1. [Action item with specific file and fix description]
|
|
|
|
### Should Fix (Warnings)
|
|
1. [Action item]
|
|
|
|
### Nice to Fix (Suggestions)
|
|
1. [Action item]
|
|
|
|
---
|
|
|
|
*Generated by `/speckit.review` — Staff-level code review for spec-driven development.*
|