ros/claude-task-master
1
0
Fork 0
mirror of https://github.com/eyaltoledano/claude-task-master.git synced 2026-01-30 06:12:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve tag system corruption in concurrent operations

Browse Source 
Fixes the tag system issue where alpha/beta tags didn't properly isolate
tasks, causing corruption when multiple processes ran simultaneously.

Key fixes:
- Strengthen tag parameter validation in writeJSON function
- Ensure explicit tags are never overridden by getCurrentTag() fallback
- Add comprehensive debug logging for tag resolution
- Prevent empty/falsy tag values from causing undefined behavior
- Validate tag strings properly before using them

This resolves race conditions where:
- Process 1: task-master expand --tag=alpha
- Process 2: task-master expand --tag=beta
- Both processes would sometimes write to the same tag context

Closes #1399

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: Ralph Khreish <Crunchyman-ralph@users.noreply.github.com>
This commit is contained in:
claude[bot]
2025-11-12 13:16:14 +00:00
parent ac4328ae86
commit e81204e859
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/modules/utils.js
View File

@@ -319,7 +319,7 @@ function readJSON(filepath, projectRoot = null, tag = null) {
if (isDebug) {
console.log(
`readJSON called with: ${filepath}, projectRoot: ${projectRoot}, tag: ${tag}`
`readJSON called with: ${filepath}, projectRoot: ${projectRoot}, explicit tag: ${tag ? `'${tag}'` : 'none'}`
);
}
@@ -711,6 +711,10 @@ function markMigrationForNotice(tasksJsonPath) {
function writeJSON(filepath, data, projectRoot = null, tag = null) {
const isDebug = process.env.TASKMASTER_DEBUG === 'true';
if (isDebug && tag) {
console.log(`writeJSON: Writing with explicit tag '${tag}' to ${filepath}`);
}
try {
let finalData = data;
@@ -721,11 +725,13 @@ function writeJSON(filepath, data, projectRoot = null, tag = null) {
Array.isArray(data.tasks) &&
!hasTaggedStructure(data)
) {
const resolvedTag = tag || getCurrentTag(projectRoot);
// Ensure explicit tag is honored, only fall back to getCurrentTag if no tag provided
// Treat empty string, null, undefined as no tag provided
const resolvedTag = (tag && typeof tag === 'string' && tag.trim()) ? tag.trim() : getCurrentTag(projectRoot);
if (isDebug) {
console.log(
`writeJSON: Detected resolved tag data missing _rawTaggedData. Re-reading raw data to prevent data loss for tag '${resolvedTag}'.`
`writeJSON: Detected resolved tag data missing _rawTaggedData. Re-reading raw data to prevent data loss for tag '${resolvedTag}' (explicit tag: ${tag ? 'yes' : 'no'}).`
);
}
@@ -746,7 +752,9 @@ function writeJSON(filepath, data, projectRoot = null, tag = null) {
// If we have _rawTaggedData, this means we're working with resolved tag data
// and need to merge it back into the full tagged structure
else if (data && data._rawTaggedData && projectRoot) {
const resolvedTag = tag || getCurrentTag(projectRoot);
// Ensure explicit tag is honored, only fall back to getCurrentTag if no tag provided
// Treat empty string, null, undefined as no tag provided
const resolvedTag = (tag && typeof tag === 'string' && tag.trim()) ? tag.trim() : getCurrentTag(projectRoot);
// Get the original tagged data
const originalTaggedData = data._rawTaggedData;
@@ -762,7 +770,7 @@ function writeJSON(filepath, data, projectRoot = null, tag = null) {
if (isDebug) {
console.log(
`writeJSON: Merging resolved data back into tag '${resolvedTag}'`
`writeJSON: Merging resolved data back into tag '${resolvedTag}' (explicit tag: ${tag ? 'yes' : 'no'})`
);
}
}