Add validation to prevent bash permission rules with unbalanced quotes
from being saved to settings.local.json. Previously, malformed commands
could be saved, causing settings to fail validation on load with error:
"Unmatched " in Bash pattern".
The fix adds validation before saving rules to ensure:
- Quotes are properly balanced
- Permission patterns are well-formed
Bug reported via Slack: permission rule "Bash(250/0.029 \")" was being
stored, which has an unbalanced quote.
Includes:
- Detailed bug analysis in .claude/bash-permission-bug-analysis.md
- CHANGELOG entry for the fix
Fixes#12170
The ralph-wiggum slash commands had multi-line bash scripts in their
```! blocks. Claude Code's security check blocks commands with
newlines to prevent command injection, causing the error:
"Command contains newlines that could separate multiple commands"
Changes:
ralph-loop.md:
- Remove multi-line bash from code block
- Keep single-line call to setup script
- Keep scoped allowed-tools for security
cancel-ralph.md:
- Replace multi-line bash with step-by-step instructions
- Tighten allowed-tools to specific file paths
setup-ralph-loop.sh:
- Add completion promise display logic (moved from ralph-loop.md)
- Uses COMPLETION_PROMISE variable directly instead of reading from file
Suggestions must include all necessary changes. If a fix requires
additional work elsewhere (e.g., renaming a variable requires updating
usages), use the Claude Code prompt format instead of a partial suggestion.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Only post a summary comment when no issues are found. When issues
exist, post inline comments directly without a redundant summary block.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Change the default behavior of /code-review to output to the terminal
instead of posting a PR comment. Users can use the --comment flag to
explicitly post the review as a PR comment when desired.
This is more suitable for local development workflows where posting
comments to the PR is not always needed.
Remove the "Generated with Claude Code" footer and feedback CTA
from the code review comment template as it adds noise without
providing value after the first viewing.
