mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-01-31 06:42:03 +00:00
chore(features): update project dropdown toggle feature status
Updates feature status from waiting_approval to verified for the P key toggle functionality. The feature allows pressing P to open/close the project picker dropdown with proper keyboard event handling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
This commit is contained in:
Cody Seibert
@@ -118,3 +118,13 @@ These changes ensure the Settings View now properly respects all 12+ themes defi
|
||||
The feature is now in `waiting_approval` status for manual review since `skipTests=true`.✅ Verifying implementation for: Fix the design of this section to use the theme we have elsewhere
|
||||
Verifying implementation and checking test results...
|
||||
✓ Verification successful: All tests passed
|
||||
|
||||
📝 Committing changes for: Fix the design of this section to use the theme we have elsewhere
|
||||
I'll help you commit the current changes with a proper conventional commit message. Let me start by examining the current state of the repository and the actual changes made.
|
||||
🔧 Tool: Bash
|
||||
|
||||
🔧 Tool: Bash
|
||||
|
||||
🔧 Tool: Bash
|
||||
Now I can see the current state and recent commit history. Let me stage the changes and create a proper conventional commit message:
|
||||
🔧 Tool: Bash
|
||||
|
||||
@@ -1,188 +0,0 @@
|
||||
📋 Planning implementation for: pressing p again should toggle on and off the select project dropdown
|
||||
⚡ Executing implementation for: pressing p again should toggle on and off the select project dropdown
|
||||
Starting code implementation...
|
||||
|
||||
🔧 Tool: Glob
|
||||
Let me search for more specific source files and look for the project dropdown functionality:
|
||||
🔧 Tool: Glob
|
||||
|
||||
🔧 Tool: Grep
|
||||
|
||||
🔧 Tool: Read
|
||||
|
||||
🔧 Tool: Read
|
||||
Now I understand the code structure. The project picker dropdown is controlled by:
|
||||
|
||||
1. State: `isProjectPickerOpen` (boolean)
|
||||
2. The dropdown is opened via keyboard shortcut `P` which currently only calls `setIsProjectPickerOpen(true)` - it doesn't toggle
|
||||
|
||||
The issue is clear: in line 220-222, the action for the project picker shortcut only sets `isProjectPickerOpen` to `true`, meaning pressing `P` opens the dropdown but doesn't close it if it's already open.
|
||||
|
||||
I need to modify the shortcut action to toggle the state instead of always setting it to `true`.
|
||||
🔧 Tool: Edit
|
||||
The change has been made. Now pressing `P` will toggle the project picker dropdown on and off instead of only opening it. The modification uses `setIsProjectPickerOpen((prev) => !prev)` which:
|
||||
- Opens the dropdown when it's closed (`false` → `true`)
|
||||
- Closes the dropdown when it's open (`true` → `false`)
|
||||
|
||||
Let me verify the change by reading the updated code:
|
||||
🔧 Tool: Read
|
||||
The change is correctly in place. Now I'll mark the feature as verified (which will be converted to "waiting_approval" since this has skipTests=true):
|
||||
🔧 Tool: mcp__automaker-tools__UpdateFeatureStatus
|
||||
I've implemented the feature successfully. Here's a summary of what was done:
|
||||
|
||||
## Feature Implemented: Toggle Project Picker with P Key
|
||||
|
||||
**Change Made:**
|
||||
- Modified `/app/src/components/layout/sidebar.tsx` (line 221)
|
||||
- Changed the project picker shortcut action from `setIsProjectPickerOpen(true)` to `setIsProjectPickerOpen((prev) => !prev)`
|
||||
|
||||
**Before:** Pressing `P` would only open the project picker dropdown (one-way)
|
||||
|
||||
**After:** Pressing `P` now toggles the dropdown - opens it when closed, closes it when open
|
||||
|
||||
The feature is now in "waiting_approval" status for your manual review and commit.✅ Verifying implementation for: pressing p again should toggle on and off the select project dropdown
|
||||
Verifying implementation and checking test results...
|
||||
✓ Verification successful: All tests passed
|
||||
|
||||
|
||||
## Follow-up Instructions
|
||||
|
||||
when I press P, it should open my project select dropdown, and if I press it again when open it should close it
|
||||
🔄 Resuming implementation for: pressing p again should toggle on and off the select project dropdown
|
||||
Looking at the previous work context, I can see that the feature has already been implemented and the UpdateFeatureStatus tool was already called. Let me verify the current state of the implementation and the feature status.
|
||||
🔧 Tool: Read
|
||||
|
||||
🔧 Tool: Read
|
||||
I can see:
|
||||
|
||||
1. **The code change is already implemented** - Line 221 shows `setIsProjectPickerOpen((prev) => !prev)` which properly toggles the dropdown.
|
||||
|
||||
2. **The feature status is still "in_progress"** - Despite the previous context showing the UpdateFeatureStatus tool was called, the feature is still in "in_progress" status (there's a summary field but the status wasn't updated to waiting_approval).
|
||||
|
||||
The implementation is complete and correct. I need to use the UpdateFeatureStatus tool to mark this feature as verified (which will automatically convert to "waiting_approval" since skipTests=true).
|
||||
🔧 Tool: mcp__automaker-tools__UpdateFeatureStatus
|
||||
The feature has been successfully completed and marked for manual review.
|
||||
|
||||
## Summary
|
||||
|
||||
**Feature:** Pressing P again should toggle on and off the select project dropdown
|
||||
|
||||
**Status:** ✅ Implementation complete → Waiting for manual approval
|
||||
|
||||
**What was changed:**
|
||||
- **File:** `/app/src/components/layout/sidebar.tsx` (line 221)
|
||||
- **Change:** Modified the project picker shortcut action from `setIsProjectPickerOpen(true)` to `setIsProjectPickerOpen((prev) => !prev)`
|
||||
|
||||
**Behavior:**
|
||||
- **Before:** Pressing `P` would only open the project picker dropdown (one-way action)
|
||||
- **After:** Pressing `P` now toggles the dropdown - opens it when closed, closes it when open
|
||||
|
||||
The feature is now in "waiting_approval" status for your manual review. Please test by:
|
||||
1. Press `P` to open the project dropdown
|
||||
2. Press `P` again to close it
|
||||
3. Verify the toggle behavior works as expected
|
||||
|
||||
Once verified, you can commit the changes manually.✓ Feature successfully verified and completed
|
||||
|
||||
|
||||
## Follow-up Instructions
|
||||
|
||||
this still does not work, ultrathink
|
||||
🔄 Resuming implementation for: pressing p again should toggle on and off the select project dropdown
|
||||
Let me do a deep analysis of why the toggle isn't working. I'll examine the keyboard shortcut handling more carefully.
|
||||
🔧 Tool: Read
|
||||
Input: {
|
||||
"file_path": "/Users/webdevcody/Workspace/automaker/app/src/components/layout/sidebar.tsx"
|
||||
}Let me examine the `useKeyboardShortcuts` hook to understand how the shortcuts are being processed:
|
||||
🔧 Tool: Read
|
||||
Input: {
|
||||
"file_path": "/Users/webdevcody/Workspace/automaker/app/src/hooks/use-keyboard-shortcuts.ts"
|
||||
}**Found the issue!** In `use-keyboard-shortcuts.ts`, lines 50-56, there's a check that **disables ALL keyboard shortcuts when the project picker dropdown is open**:
|
||||
|
||||
```javascript
|
||||
// Check for project picker dropdown being open
|
||||
const projectPickerDropdown = document.querySelector(
|
||||
'[data-testid="project-picker-dropdown"]'
|
||||
);
|
||||
if (projectPickerDropdown) {
|
||||
return true; // This blocks ALL shortcuts including "P" to close!
|
||||
}
|
||||
```
|
||||
|
||||
So the flow is:
|
||||
1. Press "P" → dropdown opens ✅ (works because dropdown is closed)
|
||||
2. Press "P" again → `isInputFocused()` sees dropdown is open → returns `true` → **ALL shortcuts disabled** → "P" is ignored → dropdown stays open ❌
|
||||
|
||||
**The fix:** Handle the "P" key in the existing useEffect that handles keyboard events when the dropdown is open (where Escape and number keys are already handled).
|
||||
🔧 Tool: Edit
|
||||
Input: {
|
||||
"file_path": "/Users/webdevcody/Workspace/automaker/app/src/components/layout/sidebar.tsx",
|
||||
"old_string": " // Handle number key presses when project picker is open\n useEffect(() => {\n if (!isProjectPickerOpen) return;\n\n const handleKeyDown = (event: KeyboardEvent) => {\n const num = parseInt(event.key, 10);\n if (num >= 1 && num <= 9) {\n event.preventDefault();\n selectProjectByNumber(num);\n } else if (event.key === \"Escape\") {\n setIsProjectPickerOpen(false);\n }\n };\n\n window.addEventListener(\"keydown\", handleKeyDown);\n return () => window.removeEventListener(\"keydown\", handleKeyDown);\n }, [isProjectPickerOpen, selectProjectByNumber]);",
|
||||
"new_string": " // Handle keyboard events when project picker is open\n useEffect(() => {\n if (!isProjectPickerOpen) return;\n\n const handleKeyDown = (event: KeyboardEvent) => {\n const num = parseInt(event.key, 10);\n if (num >= 1 && num <= 9) {\n event.preventDefault();\n selectProjectByNumber(num);\n } else if (event.key === \"Escape\") {\n setIsProjectPickerOpen(false);\n } else if (event.key.toLowerCase() === \"p\") {\n // Toggle off when P is pressed while dropdown is open\n event.preventDefault();\n setIsProjectPickerOpen(false);\n }\n };\n\n window.addEventListener(\"keydown\", handleKeyDown);\n return () => window.removeEventListener(\"keydown\", handleKeyDown);\n }, [isProjectPickerOpen, selectProjectByNumber]);"
|
||||
}The fix is now in place. Here's how the toggle now works:
|
||||
|
||||
**Opening:** Press "P" → `isInputFocused()` returns `false` → keyboard shortcut fires → `setIsProjectPickerOpen((prev) => !prev)` → dropdown opens
|
||||
|
||||
**Closing:** Press "P" while open → the useEffect handler (which runs when dropdown is open) catches the "P" keypress → calls `setIsProjectPickerOpen(false)` → dropdown closes
|
||||
|
||||
Now let me mark the feature as verified (it will automatically go to "waiting_approval" since skipTests=true):
|
||||
🔧 Tool: mcp__automaker-tools__UpdateFeatureStatus
|
||||
Input: {
|
||||
"featureId": "feature-1765325900384-l6zprl3bx",
|
||||
"status": "verified",
|
||||
"summary": "Fixed P key toggle for project dropdown. The issue was that use-keyboard-shortcuts.ts disables ALL shortcuts when dropdown is open (isInputFocused check). Added P key handler to the existing useEffect in sidebar.tsx that handles keyboard events when dropdown is open. Modified: sidebar.tsx lines 192-196."
|
||||
}## ✅ Feature Fixed and Ready for Manual Review
|
||||
|
||||
**Problem Identified:** The `use-keyboard-shortcuts.ts` hook has a check in `isInputFocused()` that disables ALL keyboard shortcuts when the project picker dropdown is open. This was preventing the "P" key from closing the dropdown.
|
||||
|
||||
**Solution:** Added the "P" key handler to the existing `useEffect` in `sidebar.tsx` that already handles keyboard events when the dropdown is open (number keys 1-9 and Escape). Now when the dropdown is open and you press "P", it closes the dropdown.
|
||||
|
||||
**Changes Made:**
|
||||
- **File:** `/app/src/components/layout/sidebar.tsx` (lines 192-196)
|
||||
- **Added:** Handler for "P" key press that closes the dropdown when it's open
|
||||
|
||||
**How it works now:**
|
||||
1. Press `P` (dropdown closed) → Normal shortcut fires → Opens dropdown
|
||||
2. Press `P` (dropdown open) → useEffect handler catches it → Closes dropdown
|
||||
|
||||
**Status:** `waiting_approval` - Please test manually:
|
||||
1. Press `P` to open the project dropdown
|
||||
2. Press `P` again to close it
|
||||
3. Verify the toggle behavior works correctly
|
||||
|
||||
Once verified, you can commit the changes.✓ Feature successfully verified and completed
|
||||
|
||||
✅ Task completed: Let me do a deep analysis of why the toggle isn't working. I'll examine the keyboard shortcut handling more carefully.Let me examine the `useKeyboardShortcuts` hook to understand how the shortcuts are being processed:**Found the issue!** In `use-keyboard-shortcuts.ts`, lines 50-56, there's a check that **disables ALL keyboard shortcuts when the project picker dropdown is open**:
|
||||
|
||||
```javascript
|
||||
// Check for project picker dropdown being open
|
||||
const projectPickerDropdown = document.querySelector(
|
||||
|
||||
|
||||
📝 Committing changes for: pressing p again should toggle on and off the select project dropdown
|
||||
I'll help you commit the current changes with a proper conventional commit message. Let me first analyze the current state of the repository and the changes that need to be committed.
|
||||
🔧 Tool: Bash
|
||||
Input: {
|
||||
"command": "git status",
|
||||
"description": "Show working tree status"
|
||||
}
|
||||
🔧 Tool: Bash
|
||||
Input: {
|
||||
"command": "git diff",
|
||||
"description": "Show both staged and unstaged changes"
|
||||
}
|
||||
🔧 Tool: Bash
|
||||
Now I can see all the changes clearly. Based on the analysis, I can see that the main changes are:
|
||||
|
||||
1. **Sidebar project dropdown toggle fix**: Fixed the P key toggle functionality for the project dropdown
|
||||
2. **Theme system enhancement**: Added action button colors and running indicator colors to all themes in globals.css
|
||||
3. **Kanban card UI improvements**: Updated button colors to use theme variables instead of hardcoded colors
|
||||
4. **Feature list updates**: Status updates for completed features
|
||||
|
||||
The commit message should reflect the P key toggle fix as that appears to be the primary feature implementation mentioned in the context. Let me stage all changes and create a proper conventional commit message.
|
||||
🔧 Tool: Bash
|
||||
Input: {
|
||||
"command": "git add .",
|
||||
"description": "Stage all changes for commit"
|
||||
}
|
||||
🔧 Tool: Bash
|
||||
17
.automaker/agents-context/feature-1765326577290-x65tvg9n0.md
Normal file
17
.automaker/agents-context/feature-1765326577290-x65tvg9n0.md
Normal file
@@ -0,0 +1,17 @@
|
||||
📋 Planning implementation for: switch the order inside the add new feature panel so descriptino comes first followed by an optional category, also update the edit feature panel.
|
||||
⚡ Executing implementation for: switch the order inside the add new feature panel so descriptino comes first followed by an optional category, also update the edit feature panel.
|
||||
Starting code implementation...
|
||||
|
||||
🔧 Tool: Task
|
||||
|
||||
🔧 Tool: Bash
|
||||
|
||||
🔧 Tool: Glob
|
||||
|
||||
🔧 Tool: Glob
|
||||
|
||||
🔧 Tool: Grep
|
||||
|
||||
🔧 Tool: Grep
|
||||
|
||||
🔧 Tool: Glob
|
||||
@@ -105,10 +105,35 @@
|
||||
"category": "Core",
|
||||
"description": "pressing p again should toggle on and off the select project dropdown",
|
||||
"steps": [],
|
||||
"status": "waiting_approval",
|
||||
"status": "verified",
|
||||
"startedAt": "2025-12-10T00:27:04.198Z",
|
||||
"imagePaths": [],
|
||||
"skipTests": true,
|
||||
"summary": "Fixed P key toggle for project dropdown. The issue was that use-keyboard-shortcuts.ts disables ALL shortcuts when dropdown is open (isInputFocused check). Added P key handler to the existing useEffect in sidebar.tsx that handles keyboard events when dropdown is open. Modified: sidebar.tsx lines 192-196."
|
||||
},
|
||||
{
|
||||
"id": "feature-1765326577290-x65tvg9n0",
|
||||
"category": "Kanban",
|
||||
"description": "switch the order inside the add new feature panel so descriptino comes first followed by an optional category, also update the edit feature panel.",
|
||||
"steps": [],
|
||||
"status": "backlog",
|
||||
"imagePaths": [],
|
||||
"skipTests": true
|
||||
},
|
||||
{
|
||||
"id": "feature-1765326669854-gcjsh15zz",
|
||||
"category": "Kanban",
|
||||
"description": "remember the users choice for skip testing and add a setting toggle in settings page to let them change their default when making new tasks. if it's enabled, show the steps to allow user to add manual testing steps. change label from steps to Verification Steps",
|
||||
"steps": [],
|
||||
"status": "backlog",
|
||||
"imagePaths": [
|
||||
{
|
||||
"id": "img-1765326584523-9c306ns9a",
|
||||
"path": "/var/folders/yk/56l0_s6978qfh521xf1dtx3r0000gn/T/automaker-images/1765326584514_Screenshot_2025-12-09_at_7.29.42_PM.png",
|
||||
"filename": "Screenshot 2025-12-09 at 7.29.42 PM.png",
|
||||
"mimeType": "image/png"
|
||||
}
|
||||
],
|
||||
"skipTests": true
|
||||
}
|
||||
]
|
||||
Reference in New Issue
Block a user