ros/automaker
1
0
Fork 0
mirror of https://github.com/AutoMaker-Org/automaker.git synced 2026-02-04 21:23:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove redundant resolveModelString call in ideation service

Browse Source 
Address PR #650 review feedback from gemini-code-assist. The call to
resolveModelString was redundant because resolvePhaseModel already
returns the fully resolved canonical model ID. When providerId is set,
it returns the provider-specific model ID unchanged; otherwise, it
already calls resolveModelString internally.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Shirone
2026-01-21 22:23:10 +01:00
parent 4fa0923ff8
commit 6c47068f71
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/server/src/services/ideation-service.ts
View File

@@ -696,8 +696,8 @@ export class IdeationService {
'[IdeationService]' '[IdeationService]'
); );
const resolved = resolvePhaseModel(phaseResult.phaseModel); const resolved = resolvePhaseModel(phaseResult.phaseModel);
// Resolve model alias to canonical identifier (e.g., 'sonnet' → 'claude-sonnet-4-5-20250929') // resolvePhaseModel returns the canonical model identifier (e.g., 'sonnet' → 'claude-sonnet-4-5-20250929')
const modelId = resolveModelString(resolved.model); const modelId = resolved.model;
const claudeCompatibleProvider = phaseResult.provider; const claudeCompatibleProvider = phaseResult.provider;
const credentials = phaseResult.credentials; const credentials = phaseResult.credentials;