From 6c47068f7143f575fb52f955a581929869dd0559 Mon Sep 17 00:00:00 2001 From: Shirone Date: Wed, 21 Jan 2026 22:23:10 +0100 Subject: [PATCH] refactor: remove redundant resolveModelString call in ideation service MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address PR #650 review feedback from gemini-code-assist. The call to resolveModelString was redundant because resolvePhaseModel already returns the fully resolved canonical model ID. When providerId is set, it returns the provider-specific model ID unchanged; otherwise, it already calls resolveModelString internally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- apps/server/src/services/ideation-service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/server/src/services/ideation-service.ts b/apps/server/src/services/ideation-service.ts index ae0e567e..1035ce76 100644 --- a/apps/server/src/services/ideation-service.ts +++ b/apps/server/src/services/ideation-service.ts @@ -696,8 +696,8 @@ export class IdeationService { '[IdeationService]' ); const resolved = resolvePhaseModel(phaseResult.phaseModel); - // Resolve model alias to canonical identifier (e.g., 'sonnet' → 'claude-sonnet-4-5-20250929') - const modelId = resolveModelString(resolved.model); + // resolvePhaseModel returns the canonical model identifier (e.g., 'sonnet' → 'claude-sonnet-4-5-20250929') + const modelId = resolved.model; const claudeCompatibleProvider = phaseResult.provider; const credentials = phaseResult.credentials;