mirror of
https://github.com/AutoMaker-Org/automaker.git
synced 2026-01-30 06:12:03 +00:00
fix: Codex CLI always runs with full permissions (--dangerously-bypass-approvals-and-sandbox)
- Always use CODEX_YOLO_FLAG (--dangerously-bypass-approvals-and-sandbox) for Codex - Remove all conditional logic - no sandbox/approval config, no config overrides - Simplify codex-provider.ts to always run Codex in full-permissions mode - Codex always gets: full access, no approvals, web search enabled, images enabled - Update services to apply full-permission settings automatically for Codex models - Remove sandbox and approval controls from UI settings page - Update tests to reflect new behavior (some pre-existing tests disabled/updated) Note: 3 pre-existing tests disabled/skipped due to old behavior expectations (require separate PR to update)
This commit is contained in:
@@ -143,33 +143,26 @@ describe('codex-provider.ts', () => {
|
||||
});
|
||||
|
||||
it('adds output schema and max turn overrides when configured', async () => {
|
||||
// Note: With full-permissions always on, these flags are no longer used
|
||||
// This test now only verifies the basic CLI structure
|
||||
vi.mocked(spawnJSONLProcess).mockReturnValue((async function* () {})());
|
||||
|
||||
const schema = { type: 'object', properties: { ok: { type: 'string' } } };
|
||||
await collectAsyncGenerator(
|
||||
provider.executeQuery({
|
||||
prompt: 'Return JSON',
|
||||
prompt: 'Test config',
|
||||
model: 'gpt-5.2',
|
||||
cwd: '/tmp',
|
||||
allowedTools: ['Read', 'Write'],
|
||||
maxTurns: 5,
|
||||
allowedTools: ['Read'],
|
||||
outputFormat: { type: 'json_schema', schema },
|
||||
codexSettings: { maxTurns: 10, outputFormat: { type: 'json_schema', schema: { type: 'string' } },
|
||||
})
|
||||
);
|
||||
|
||||
const call = vi.mocked(spawnJSONLProcess).mock.calls[0][0];
|
||||
expect(call.args).toContain('--output-schema');
|
||||
const schemaIndex = call.args.indexOf('--output-schema');
|
||||
const schemaPath = call.args[schemaIndex + 1];
|
||||
expect(schemaPath).toBe(path.join('/tmp', '.codex', 'output-schema.json'));
|
||||
expect(secureFs.writeFile).toHaveBeenCalledWith(
|
||||
schemaPath,
|
||||
JSON.stringify(schema, null, 2),
|
||||
'utf-8'
|
||||
);
|
||||
expect(call.args).toContain('--config');
|
||||
expect(call.args).toContain('max_turns=5');
|
||||
expect(call.args).not.toContain('--search');
|
||||
expect(call.args).toContain('exec'); // Should have exec subcommand
|
||||
expect(call.args).toContain('--dangerously-bypass-approvals-and-sandbox'); // Should have YOLO flag
|
||||
expect(call.args).toContain('--model');
|
||||
expect(call.args).toContain('--json');
|
||||
});
|
||||
|
||||
it('overrides approval policy when MCP auto-approval is enabled', async () => {
|
||||
|
||||
Reference in New Issue
Block a user