ros/BMAD-METHOD
1
0
Fork 0
mirror of https://github.com/bmad-code-org/BMAD-METHOD.git synced 2026-01-30 04:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: HELP_STEP placeholder not replaced in compiled agents, fix hardcoded path, fix single quote in HELP_STEP (#1437)

Browse Source 
* fix: correct malformed XML syntax and remove hardcoded path

- Fix missing opening quote in activation-steps.txt: `n={HELP_STEP}"` → `n="{HELP_STEP}"`
- Remove spurious hyphen: `-Let` → `Let`
- Replace hardcoded `/Users/brianmadison/...` path with relative path

Fixes #1435

* fix: add missing HELP_STEP placeholder replacement

The activation-steps.txt template includes a {HELP_STEP} placeholder,
but activation-builder.js never calculated or replaced it. This caused
the literal string "{HELP_STEP}" to appear in compiled agent files.

Added helpStep calculation between menuStep and haltStep, and adjusted
subsequent step numbers accordingly.

Fixes #1441

* Update src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md

---------

Co-authored-by: Alex Verkhovsky <alexey.verkhovsky@gmail.com>
This commit is contained in:
Michael Pursifull
2026-01-29 07:58:56 -06:00
committed by GitHub
parent 98b97cf4fd
commit 903710be1b
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md
View File

@@ -8,7 +8,7 @@ validationStatus: COMPLETE - PRODUCTION READY
# PRD Workflow Validation Report # PRD Workflow Validation Report
**Workflow Being Validated:** /Users/brianmadison/dev/BMAD-METHOD/src/bmm/workflows/2-plan-workflows/create-prd **Workflow Being Validated:** _bmad/bmm/workflows/2-plan-workflows/create-prd
**Validation Date:** 2026-01-08 **Validation Date:** 2026-01-08
**Validator:** BMAD Workflow Validation System **Validator:** BMAD Workflow Validation System

8
tools/cli/lib/activation-builder.js
View File

@@ -121,9 +121,10 @@ class ActivationBuilder {
// Calculate final step numbers // Calculate final step numbers
const menuStep = currentStepNum; const menuStep = currentStepNum;
const haltStep = currentStepNum + 1; const helpStep = currentStepNum + 1;
const inputStep = currentStepNum + 2; const haltStep = currentStepNum + 2;
const executeStep = currentStepNum + 3; const inputStep = currentStepNum + 3;
const executeStep = currentStepNum + 4;
// Replace placeholders // Replace placeholders
const processed = stepsTemplate const processed = stepsTemplate
@@ -131,6 +132,7 @@ class ActivationBuilder {
.replace('{{module}}', metadata.module || 'core') // Fixed to use {{module}} .replace('{{module}}', metadata.module || 'core') // Fixed to use {{module}}
.replace('{AGENT_SPECIFIC_STEPS}', agentStepsXml) .replace('{AGENT_SPECIFIC_STEPS}', agentStepsXml)
.replace('{MENU_STEP}', menuStep.toString()) .replace('{MENU_STEP}', menuStep.toString())
.replace('{HELP_STEP}', helpStep.toString())
.replace('{HALT_STEP}', haltStep.toString()) .replace('{HALT_STEP}', haltStep.toString())
.replace('{INPUT_STEP}', inputStep.toString()) .replace('{INPUT_STEP}', inputStep.toString())
.replace('{EXECUTE_STEP}', executeStep.toString()); .replace('{EXECUTE_STEP}', executeStep.toString());