From 903710be1bb3688685df2b80cc0340c32e4d4e0e Mon Sep 17 00:00:00 2001 From: Michael Pursifull Date: Thu, 29 Jan 2026 07:58:56 -0600 Subject: [PATCH] fix: HELP_STEP placeholder not replaced in compiled agents, fix hardcoded path, fix single quote in HELP_STEP (#1437) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: correct malformed XML syntax and remove hardcoded path - Fix missing opening quote in activation-steps.txt: `n={HELP_STEP}"` → `n="{HELP_STEP}"` - Remove spurious hyphen: `-Let` → `Let` - Replace hardcoded `/Users/brianmadison/...` path with relative path Fixes #1435 * fix: add missing HELP_STEP placeholder replacement The activation-steps.txt template includes a {HELP_STEP} placeholder, but activation-builder.js never calculated or replaced it. This caused the literal string "{HELP_STEP}" to appear in compiled agent files. Added helpStep calculation between menuStep and haltStep, and adjusted subsequent step numbers accordingly. Fixes #1441 * Update src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md --------- Co-authored-by: Alex Verkhovsky --- .../create-prd/validation-report-prd-workflow.md | 2 +- tools/cli/lib/activation-builder.js | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md index 14407bfa..0a49b9f2 100644 --- a/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md +++ b/src/bmm/workflows/2-plan-workflows/create-prd/validation-report-prd-workflow.md @@ -8,7 +8,7 @@ validationStatus: COMPLETE - PRODUCTION READY # PRD Workflow Validation Report -**Workflow Being Validated:** /Users/brianmadison/dev/BMAD-METHOD/src/bmm/workflows/2-plan-workflows/create-prd +**Workflow Being Validated:** _bmad/bmm/workflows/2-plan-workflows/create-prd **Validation Date:** 2026-01-08 **Validator:** BMAD Workflow Validation System diff --git a/tools/cli/lib/activation-builder.js b/tools/cli/lib/activation-builder.js index 9b91c2a9..81e11158 100644 --- a/tools/cli/lib/activation-builder.js +++ b/tools/cli/lib/activation-builder.js @@ -121,9 +121,10 @@ class ActivationBuilder { // Calculate final step numbers const menuStep = currentStepNum; - const haltStep = currentStepNum + 1; - const inputStep = currentStepNum + 2; - const executeStep = currentStepNum + 3; + const helpStep = currentStepNum + 1; + const haltStep = currentStepNum + 2; + const inputStep = currentStepNum + 3; + const executeStep = currentStepNum + 4; // Replace placeholders const processed = stepsTemplate @@ -131,6 +132,7 @@ class ActivationBuilder { .replace('{{module}}', metadata.module || 'core') // Fixed to use {{module}} .replace('{AGENT_SPECIFIC_STEPS}', agentStepsXml) .replace('{MENU_STEP}', menuStep.toString()) + .replace('{HELP_STEP}', helpStep.toString()) .replace('{HALT_STEP}', haltStep.toString()) .replace('{INPUT_STEP}', inputStep.toString()) .replace('{EXECUTE_STEP}', executeStep.toString());