Merge pull request #918 from wfongcn/patch-1

Change loop condition to include last argument
Merge pull request #929 from isdaniel/fix/ide-agent-cli-checks
2026-02-03 06:23:36 +00:00 · 2025-10-18 20:03:39 -07:00 · 2025-10-18 20:03:14 -07:00 · 2025-10-17 23:53:47 +08:00 · 2025-10-17 09:03:47 +08:00
2 changed files with 14 additions and 7 deletions
--- a/scripts/bash/create-new-feature.sh
+++ b/scripts/bash/create-new-feature.sh
@@ -6,7 +6,7 @@ JSON_MODE=false
 SHORT_NAME=""
 ARGS=()
 i=0
-while [ $i -lt $# ]; do
+while [ $i -le $# ]; do
    arg="${!i}"
    case "$arg" in
        --json) 
--- a/src/specify_cli/init.py
+++ b/src/specify_cli/init.py
@@ -1168,9 +1168,16 @@ def check():
    agent_results = {}
    for agent_key, agent_config in AGENT_CONFIG.items():
        agent_name = agent_config["name"]
+        requires_cli = agent_config["requires_cli"]

        tracker.add(agent_key, agent_name)
-        agent_results[agent_key] = check_tool(agent_key, tracker=tracker)
+
+        if requires_cli:
+            agent_results[agent_key] = check_tool(agent_key, tracker=tracker)
+        else:
+            # IDE-based agent - skip CLI check and mark as optional
+            tracker.skip(agent_key, "IDE-based, no CLI check")
+            agent_results[agent_key] = False  # Don't count IDE agents as "found"

    # Check VS Code variants (not in agent config)
    tracker.add("code", "Visual Studio Code")
Author	SHA1	Message	Date
Den Delimarsky	7050a3151c	Merge pull request #918 from wfongcn/patch-1 Change loop condition to include last argument	2025-10-18 20:03:39 -07:00
Den Delimarsky	9e84f46e56	Merge pull request #929 from isdaniel/fix/ide-agent-cli-checks fix: Skip CLI checks for IDE-based agents in check command	2025-10-18 20:03:14 -07:00
danielshih	098380a46f	fix: Skip CLI checks for IDE-based agents in check command - Add requires_cli field handling to check() command - IDE-based agents (copilot, cursor-agent, windsurf, kilocode, roo) now properly skip CLI checks - Prevents false errors when checking for IDE-integrated agents that don't require CLI tools	2025-10-17 23:53:47 +08:00
Peter Wang	74f7e508a4	Change loop condition to include last argument The last argument is not processed. e.g. create-new-feature.sh -h doesn't show the help information.	2025-10-17 09:03:47 +08:00