From fd77f827601ac5249f2eaf9075e2a8d5e5093940 Mon Sep 17 00:00:00 2001 From: danielmeppiel Date: Tue, 16 Sep 2025 16:51:36 +0200 Subject: [PATCH] Implementing Copilot suggested fixes from the PR --- src/apm_cli/compilation/agents_compiler.py | 1 - src/apm_cli/compilation/distributed_compiler.py | 1 - src/apm_cli/core/script_runner.py | 4 +++- src/apm_cli/models/apm_package.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/apm_cli/compilation/agents_compiler.py b/src/apm_cli/compilation/agents_compiler.py index 8401558e..44b0e20c 100644 --- a/src/apm_cli/compilation/agents_compiler.py +++ b/src/apm_cli/compilation/agents_compiler.py @@ -89,7 +89,6 @@ class CompilationConfig: placement_config = compilation_config.get('placement', {}) if 'min_instructions_per_file' in placement_config: config.min_instructions_per_file = placement_config['min_instructions_per_file'] - # max_depth configuration removed - analyze full project structure # Source attribution if 'source_attribution' in compilation_config: diff --git a/src/apm_cli/compilation/distributed_compiler.py b/src/apm_cli/compilation/distributed_compiler.py index 0faf4735..1b4cac21 100644 --- a/src/apm_cli/compilation/distributed_compiler.py +++ b/src/apm_cli/compilation/distributed_compiler.py @@ -97,7 +97,6 @@ class DistributedAgentsCompiler: # Configuration with defaults aligned to Minimal Context Principle config = config or {} min_instructions = config.get('min_instructions_per_file', 1) # Default to 1 for minimal context - # max_depth configuration removed - analyze full project depth source_attribution = config.get('source_attribution', True) debug = config.get('debug', False) clean_orphaned = config.get('clean_orphaned', False) diff --git a/src/apm_cli/core/script_runner.py b/src/apm_cli/core/script_runner.py index 050e0415..099fdb82 100644 --- a/src/apm_cli/core/script_runner.py +++ b/src/apm_cli/core/script_runner.py @@ -380,9 +380,11 @@ class ScriptRunner: class PromptCompiler: """Compiles .prompt.md files with parameter substitution.""" + DEFAULT_COMPILED_DIR = Path('.apm/compiled') + def __init__(self): """Initialize compiler.""" - self.compiled_dir = Path('.apm/compiled') + self.compiled_dir = self.DEFAULT_COMPILED_DIR def compile(self, prompt_file: str, params: Dict[str, str]) -> str: """Compile a .prompt.md file with parameter substitution. diff --git a/src/apm_cli/models/apm_package.py b/src/apm_cli/models/apm_package.py index 78171998..70bee4a3 100644 --- a/src/apm_cli/models/apm_package.py +++ b/src/apm_cli/models/apm_package.py @@ -1,6 +1,7 @@ """APM Package data models and validation logic.""" import re +import urllib.parse import yaml from dataclasses import dataclass from enum import Enum @@ -113,7 +114,6 @@ class DependencyReference: repo_part = dependency_str # SECURITY: Use urllib.parse for all URL validation to avoid substring vulnerabilities - import urllib.parse repo_url = repo_part.strip()