ros/spec-kit
1
0
Fork 0
mirror of https://github.com/github/spec-kit.git synced 2026-03-21 21:03:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix code review issues: safe teardown for shared dirs, less brittle test assertions

Browse Source 
- Copilot: only remove .github/agents/ (preserves workflows, templates)
- Tabnine: only remove .tabnine/agent/ (preserves other config)
- Amp/Codex: only remove respective subdirs (commands/skills)
  to avoid deleting each other's files in shared .agents/ dir
- Tests: use flexible assertions instead of hardcoded >= 25 counts

Co-authored-by: mnriem <15701806+mnriem@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/spec-kit/sessions/ef8b4682-7f1a-4b04-a112-df0878236b6b
This commit is contained in:
copilot-swe-agent[bot]
2026-03-20 21:03:34 +00:00
committed by GitHub
parent 3212309e7c
commit ec5471af61
5 changed files with 57 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/test_agent_pack.py
View File

@@ -365,18 +365,22 @@ class TestDiscovery:
def test_list_embedded_agents_nonempty(self):
agents = list_embedded_agents()
assert len(agents) >= 25
assert len(agents) > 0
ids = {a.id for a in agents}
assert "claude" in ids
assert "gemini" in ids
assert "copilot" in ids
# Verify core agents are present
for core_agent in ("claude", "gemini", "copilot"):
assert core_agent in ids
def test_list_all_agents(self):
all_agents = list_all_agents()
assert len(all_agents) >= 25
assert len(all_agents) > 0
# Should be sorted by id
ids = [a.manifest.id for a in all_agents]
assert ids == sorted(ids)
# Verify core agents are present
id_set = set(ids)
for core_agent in ("claude", "gemini", "copilot"):
assert core_agent in id_set
# ===================================================================