ros/spec-kit
1
0
Fork 0
mirror of https://github.com/github/spec-kit.git synced 2026-03-24 14:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add explanatory comments to all empty except clauses (code quality)

Browse Source 
Co-authored-by: mnriem <15701806+mnriem@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/spec-kit/sessions/bb495c08-5d15-410f-9ba9-89d3fc413904
This commit is contained in:
copilot-swe-agent[bot]
2026-03-23 14:01:21 +00:00
committed by GitHub
parent 55bcbd3977
commit 795f1e7703
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/specify_cli/agent_pack.py
View File

@@ -336,7 +336,7 @@ class AgentBootstrap:
p.resolve().relative_to(agent_root_resolved) p.resolve().relative_to(agent_root_resolved)
all_agent.append(p) all_agent.append(p)
except ValueError: except ValueError:
pass pass # Path is outside the agent root — skip it
# Scan the agent's directory tree for files created by later # Scan the agent's directory tree for files created by later
# init pipeline steps (skills, presets, extensions) that # init pipeline steps (skills, presets, extensions) that
@@ -665,7 +665,7 @@ def resolve_agent_pack(
emb = AgentManifest.from_yaml(emb_file) emb = AgentManifest.from_yaml(emb_file)
overrides = f"embedded v{emb.version}" overrides = f"embedded v{emb.version}"
except AgentPackError: except AgentPackError:
pass pass # Embedded manifest unreadable — skip override info
return ResolvedPack( return ResolvedPack(
manifest=manifest, manifest=manifest,

6
tests/test_agent_pack.py
View File

@@ -967,7 +967,7 @@ def _run_init_via_cli(
tracker.start(key) tracker.start(key)
tracker.complete(key, "mocked") tracker.complete(key, "mocked")
except Exception: except Exception:
pass pass # Tracker key may not exist — safe to ignore in mock
flag = "--agent" if use_agent_flag else "--ai" flag = "--agent" if use_agent_flag else "--ai"
args = [ args = [
@@ -983,7 +983,7 @@ def _run_init_via_cli(
if agent in AGENT_SKILLS_MIGRATIONS: if agent in AGENT_SKILLS_MIGRATIONS:
args.append("--ai-skills") args.append("--ai-skills")
except (ImportError, AttributeError): except (ImportError, AttributeError):
pass pass # AGENT_SKILLS_MIGRATIONS may not exist — proceed without --ai-skills
with _patch( with _patch(
"specify_cli.download_and_extract_template", _mock_download, "specify_cli.download_and_extract_template", _mock_download,
@@ -1151,7 +1151,7 @@ class TestInitFlowParity:
f"(skills migration removes commands)") f"(skills migration removes commands)")
return return
except (ImportError, AttributeError): except (ImportError, AttributeError):
pass pass # AGENT_SKILLS_MIGRATIONS unavailable — fall through to failure
pytest.fail( pytest.fail(
f"Agent '{agent}': commands_dir " f"Agent '{agent}': commands_dir "