ros/spec-kit
1
0
Fork 0
mirror of https://github.com/github/spec-kit.git synced 2026-03-26 07:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address PR review round 2 — legacy rmtree confirmation, agent_pack flag, registrar alias, manifest ID validation

Browse Source 
- Legacy rmtree: prompt user before deleting agent directory in legacy
  fallback path (both no-manifest and AgentPackError cases), respects --force
- Set options['agent_pack'] = True during agent_switch so projects
  originally created with --ai reflect pack-based management after switch
- Add cursor-agent alias in CommandRegistrar.AGENT_CONFIGS so extension
  re-registration works when switching to/from cursor-agent
- Validate manifest.id matches agent_id in resolve_agent_pack() to
  prevent malicious override packs from injecting different IDs
This commit is contained in:
Manfred Riem
2026-03-23 10:58:58 -05:00
parent b94e541234
commit 790448294e
3 changed files with 27 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/specify_cli/__init__.py
View File

@@ -2697,6 +2697,12 @@ def agent_switch(
if agent_folder:
agent_dir = project_path / agent_folder.rstrip("/")
if agent_dir.is_dir():
if not force:
console.print(f"[yellow]No install manifest found for '{current_agent}' (legacy project).[/yellow]")
console.print(f" Directory to remove: {agent_dir}")
if not typer.confirm("Remove this directory?"):
console.print("[dim]Aborted. Use --force to skip this check.[/dim]")
raise typer.Exit(0)
shutil.rmtree(agent_dir)
console.print(f" [green]✓[/green] {current_agent} directory removed (legacy)")
else:
@@ -2708,6 +2714,12 @@ def agent_switch(
if agent_folder:
agent_dir = project_path / agent_folder.rstrip("/")
if agent_dir.is_dir():
if not force:
console.print(f"[yellow]No agent pack found for '{current_agent}' (legacy project).[/yellow]")
console.print(f" Directory to remove: {agent_dir}")
if not typer.confirm("Remove this directory?"):
console.print("[dim]Aborted. Use --force to skip this check.[/dim]")
raise typer.Exit(0)
shutil.rmtree(agent_dir)
console.print(f" [green]✓[/green] {current_agent} directory removed (legacy)")
@@ -2757,6 +2769,7 @@ def agent_switch(
# Update init options
options["ai"] = agent_id
options["agent_pack"] = True
options.pop("agent_switch_error", None) # clear any previous error
init_options_file.write_text(json.dumps(options, indent=2), encoding="utf-8")