fix: narrow empty except blocks and add explanatory comments

This commit is contained in:
Manfred Riem
2026-03-10 15:16:43 -05:00
parent 52f137ce84
commit 3ffef55954
2 changed files with 3 additions and 1 deletions

View File

@@ -1606,7 +1606,8 @@ def init(
# Clean up downloaded ZIP to avoid cache accumulation
try:
zip_path.unlink(missing_ok=True)
except Exception:
except OSError:
# Best-effort cleanup; failure to delete is non-fatal
pass
except PresetError:
console.print(f"[yellow]Warning:[/yellow] Preset '{preset}' not found in catalog. Skipping.")

View File

@@ -1145,6 +1145,7 @@ class PresetCatalog:
if metadata.get("catalog_url") == catalog_url:
return json.loads(self.cache_file.read_text())
except (json.JSONDecodeError, OSError):
# Cache is corrupt or unreadable; fall through to network fetch
pass
try: