mirror of
https://github.com/github/spec-kit.git
synced 2026-02-02 22:13:36 +00:00
fix regarding copilot suggestion
This commit is contained in:
@@ -34,14 +34,14 @@ You **MUST** consider the user input before proceeding (if not empty).
|
|||||||
- Calculate overall status:
|
- Calculate overall status:
|
||||||
* **PASS**: All checklists have 0 incomplete items
|
* **PASS**: All checklists have 0 incomplete items
|
||||||
* **FAIL**: One or more checklists have incomplete items
|
* **FAIL**: One or more checklists have incomplete items
|
||||||
|
|
||||||
- **If any checklist is incomplete**:
|
- **If any checklist is incomplete**:
|
||||||
* Display the table with incomplete item counts
|
* Display the table with incomplete item counts
|
||||||
* **STOP** and ask: "Some checklists are incomplete. Do you want to proceed with implementation anyway? (yes/no)"
|
* **STOP** and ask: "Some checklists are incomplete. Do you want to proceed with implementation anyway? (yes/no)"
|
||||||
* Wait for user response before continuing
|
* Wait for user response before continuing
|
||||||
* If user says "no" or "wait" or "stop", halt execution
|
* If user says "no" or "wait" or "stop", halt execution
|
||||||
* If user says "yes" or "proceed" or "continue", proceed to step 3
|
* If user says "yes" or "proceed" or "continue", proceed to step 3
|
||||||
|
|
||||||
- **If all checklists are complete**:
|
- **If all checklists are complete**:
|
||||||
* Display the table showing all checklists passed
|
* Display the table showing all checklists passed
|
||||||
* Automatically proceed to step 3
|
* Automatically proceed to step 3
|
||||||
@@ -56,7 +56,7 @@ You **MUST** consider the user input before proceeding (if not empty).
|
|||||||
|
|
||||||
4. **Project Setup Verification**:
|
4. **Project Setup Verification**:
|
||||||
- **REQUIRED**: Create/verify ignore files based on actual project setup:
|
- **REQUIRED**: Create/verify ignore files based on actual project setup:
|
||||||
|
|
||||||
**Detection & Creation Logic**:
|
**Detection & Creation Logic**:
|
||||||
- Check if the following command succeeds to determine if the repository is a git repo (create/verify .gitignore if so):
|
- Check if the following command succeeds to determine if the repository is a git repo (create/verify .gitignore if so):
|
||||||
|
|
||||||
@@ -69,10 +69,10 @@ You **MUST** consider the user input before proceeding (if not empty).
|
|||||||
- Check if .npmrc or package.json exists → create/verify .npmignore (if publishing)
|
- Check if .npmrc or package.json exists → create/verify .npmignore (if publishing)
|
||||||
- Check if terraform files (*.tf) exist → create/verify .terraformignore
|
- Check if terraform files (*.tf) exist → create/verify .terraformignore
|
||||||
- Check if .helmignore needed (helm charts present) → create/verify .helmignore
|
- Check if .helmignore needed (helm charts present) → create/verify .helmignore
|
||||||
|
|
||||||
**If ignore file already exists**: Verify it contains essential patterns, append missing critical patterns only
|
**If ignore file already exists**: Verify it contains essential patterns, append missing critical patterns only
|
||||||
**If ignore file missing**: Create with full pattern set for detected technology
|
**If ignore file missing**: Create with full pattern set for detected technology
|
||||||
|
|
||||||
**Common Patterns by Technology** (from plan.md tech stack):
|
**Common Patterns by Technology** (from plan.md tech stack):
|
||||||
- **Node.js/JavaScript/TypeScript**: `node_modules/`, `dist/`, `build/`, `*.log`, `.env*`
|
- **Node.js/JavaScript/TypeScript**: `node_modules/`, `dist/`, `build/`, `*.log`, `.env*`
|
||||||
- **Python**: `__pycache__/`, `*.pyc`, `.venv/`, `venv/`, `dist/`, `*.egg-info/`
|
- **Python**: `__pycache__/`, `*.pyc`, `.venv/`, `venv/`, `dist/`, `*.egg-info/`
|
||||||
@@ -85,10 +85,10 @@ You **MUST** consider the user input before proceeding (if not empty).
|
|||||||
- **Kotlin**: `build/`, `out/`, `.gradle/`, `.idea/`, `*.class`, `*.jar`, `*.iml`, `*.log`, `.env*`
|
- **Kotlin**: `build/`, `out/`, `.gradle/`, `.idea/`, `*.class`, `*.jar`, `*.iml`, `*.log`, `.env*`
|
||||||
- **C++**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.so`, `*.a`, `*.exe`, `*.dll`, `.idea/`, `*.log`, `.env*`
|
- **C++**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.so`, `*.a`, `*.exe`, `*.dll`, `.idea/`, `*.log`, `.env*`
|
||||||
- **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `Makefile`, `config.log`, `.idea/`, `*.log`, `.env*`
|
- **C**: `build/`, `bin/`, `obj/`, `out/`, `*.o`, `*.a`, `*.so`, `*.exe`, `Makefile`, `config.log`, `.idea/`, `*.log`, `.env*`
|
||||||
- **Swift**: `.build/`, `DerivedData/`, `*.xcodeproj/`, `*.xcworkspace/`, `*.swiftpm/`, `Packages/`
|
- **Swift**: `.build/`, `DerivedData/`, `*.swiftpm/`, `Packages/`
|
||||||
- **R**: `.Rproj.user/`, `.Rhistory`, `.RData`, `.Ruserdata`, `*.Rproj`, `packrat/`, `renv/`
|
- **R**: `.Rproj.user/`, `.Rhistory`, `.RData`, `.Ruserdata`, `*.Rproj`, `packrat/`, `renv/`
|
||||||
- **Universal**: `.DS_Store`, `Thumbs.db`, `*.tmp`, `*.swp`, `.vscode/`, `.idea/`
|
- **Universal**: `.DS_Store`, `Thumbs.db`, `*.tmp`, `*.swp`, `.vscode/`, `.idea/`
|
||||||
|
|
||||||
**Tool-Specific Patterns**:
|
**Tool-Specific Patterns**:
|
||||||
- **Docker**: `node_modules/`, `.git/`, `Dockerfile*`, `.dockerignore`, `*.log*`, `.env*`, `coverage/`
|
- **Docker**: `node_modules/`, `.git/`, `Dockerfile*`, `.dockerignore`, `*.log*`, `.env*`, `coverage/`
|
||||||
- **ESLint**: `node_modules/`, `dist/`, `build/`, `coverage/`, `*.min.js`
|
- **ESLint**: `node_modules/`, `dist/`, `build/`, `coverage/`, `*.min.js`
|
||||||
@@ -104,7 +104,7 @@ You **MUST** consider the user input before proceeding (if not empty).
|
|||||||
|
|
||||||
6. Execute implementation following the task plan:
|
6. Execute implementation following the task plan:
|
||||||
- **Phase-by-phase execution**: Complete each phase before moving to the next
|
- **Phase-by-phase execution**: Complete each phase before moving to the next
|
||||||
- **Respect dependencies**: Run sequential tasks in order, parallel tasks [P] can run together
|
- **Respect dependencies**: Run sequential tasks in order, parallel tasks [P] can run together
|
||||||
- **Follow TDD approach**: Execute test tasks before their corresponding implementation tasks
|
- **Follow TDD approach**: Execute test tasks before their corresponding implementation tasks
|
||||||
- **File-based coordination**: Tasks affecting the same files must run sequentially
|
- **File-based coordination**: Tasks affecting the same files must run sequentially
|
||||||
- **Validation checkpoints**: Verify each phase completion before proceeding
|
- **Validation checkpoints**: Verify each phase completion before proceeding
|
||||||
|
|||||||
Reference in New Issue
Block a user