ros/playwright-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: ros:v0.0.30
Branches Tags
ros:main ros:fix-npm-publishing ros:test ros:vscode-client-factory ros:copilot/fix-859 ros:copilot/fix-759 ros:copilot/fix-726 ros:copilot/fix-707 ros:copilot/fix-701 ros:copilot/fix-570 ros:copilot/fix-576 ros:roll-playwright-6-10
ros:v0.0.37 ros:v0.0.36 ros:v0.0.35 ros:v0.0.34 ros:v0.0.33 ros:v0.0.32 ros:v0.0.31 ros:v0.0.30 ros:v0.0.29 ros:v0.0.28 ros:v0.0.27 ros:v.0.0.26 ros:v0.0.25 ros:v0.0.24 ros:v0.0.22 ros:v0.0.21 ros:v0.0.20 ros:v0.0.19 ros:v0.0.18 ros:v0.0.17 ros:v0.0.16 ros:v0.0.15 ros:v0.0.14 ros:v0.0.13 ros:v0.0.12 ros:v0.0.11 ros:v0.0.10 ros:v0.0.9 ros:v0.0.8 ros:v0.0.7
...
compare: ros:copilot/fix-570
Branches Tags
ros:main ros:fix-npm-publishing ros:test ros:vscode-client-factory ros:copilot/fix-859 ros:copilot/fix-759 ros:copilot/fix-726 ros:copilot/fix-707 ros:copilot/fix-701 ros:copilot/fix-570 ros:copilot/fix-576 ros:roll-playwright-6-10
ros:v0.0.37 ros:v0.0.36 ros:v0.0.35 ros:v0.0.34 ros:v0.0.33 ros:v0.0.32 ros:v0.0.31 ros:v0.0.30 ros:v0.0.29 ros:v0.0.28 ros:v0.0.27 ros:v.0.0.26 ros:v0.0.25 ros:v0.0.24 ros:v0.0.22 ros:v0.0.21 ros:v0.0.20 ros:v0.0.19 ros:v0.0.18 ros:v0.0.17 ros:v0.0.16 ros:v0.0.15 ros:v0.0.14 ros:v0.0.13 ros:v0.0.12 ros:v0.0.11 ros:v0.0.10 ros:v0.0.9 ros:v0.0.8 ros:v0.0.7

5 Commits
v0.0.30 ... copilot/fi

Author SHA1 Message Date
copilot-swe-agent[bot]
2a233080f7 Update listTabsMarkdown to use 0-based indexing consistently 
Co-authored-by: dgozman <9881434+dgozman@users.noreply.github.com>
 2025-06-20 11:55:50 +00:00
copilot-swe-agent[bot]
f4bc6447eb Revert description changes to remove explicit 0-based indexing mentions 
Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>
 2025-06-19 09:50:55 +00:00
copilot-swe-agent[bot]
708aa6d6a5 Change tab selection to use 0-based indexing instead of 1-based 
Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>
 2025-06-19 09:38:10 +00:00
copilot-swe-agent[bot]
c82a17ddfd Clarify 1-based indexing in browser_tab_select and browser_tab_close tools 
Co-authored-by: Skn0tt <14912729+Skn0tt@users.noreply.github.com>
 2025-06-19 09:25:48 +00:00
copilot-swe-agent[bot]
8e0ccf770b Initial plan for issue 2025-06-19 08:34:03 +00:00
2 changed files with 20 additions and 20 deletions
Expand all files Collapse all files

6
src/context.ts
View File

@@ -101,7 +101,7 @@ export class Context {
} }
async selectTab(index: number) { async selectTab(index: number) {
this._currentTab = this._tabs[index - 1]; this._currentTab = this._tabs[index];
await this._currentTab.page.bringToFront(); await this._currentTab.page.bringToFront();
} }
@@ -121,13 +121,13 @@ export class Context {
const title = await tab.title(); const title = await tab.title();
const url = tab.page.url(); const url = tab.page.url();
const current = tab === this._currentTab ? ' (current)' : ''; const current = tab === this._currentTab ? ' (current)' : '';
lines.push(`- ${i + 1}:${current} [${title}] (${url})`); lines.push(`- ${i}:${current} [${title}] (${url})`);
} }
return lines.join('\n'); return lines.join('\n');
} }
async closeTab(index: number | undefined) { async closeTab(index: number | undefined) {
const tab = index === undefined ? this._currentTab : this._tabs[index - 1]; const tab = index === undefined ? this._currentTab : this._tabs[index];
await tab?.page.close(); await tab?.page.close();
return await this.listTabsMarkdown(); return await this.listTabsMarkdown();
} }

34
tests/tabs.spec.ts
View File

@@ -33,7 +33,7 @@ test('list initial tabs', async ({ client }) => {
expect(await client.callTool({ expect(await client.callTool({
name: 'browser_tab_list', name: 'browser_tab_list',
})).toHaveTextContent(`### Open tabs })).toHaveTextContent(`### Open tabs
- 1: (current) [] (about:blank)`); - 0: (current) [] (about:blank)`);
}); });
test('list first tab', async ({ client }) => { test('list first tab', async ({ client }) => {
@@ -41,8 +41,8 @@ test('list first tab', async ({ client }) => {
expect(await client.callTool({ expect(await client.callTool({
name: 'browser_tab_list', name: 'browser_tab_list',
})).toHaveTextContent(`### Open tabs })).toHaveTextContent(`### Open tabs
- 1: [] (about:blank) - 0: [] (about:blank)
- 2: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)`); - 1: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)`);
}); });
test('create new tab', async ({ client }) => { test('create new tab', async ({ client }) => {
@@ -53,8 +53,8 @@ test('create new tab', async ({ client }) => {
\`\`\` \`\`\`
### Open tabs ### Open tabs
- 1: [] (about:blank) - 0: [] (about:blank)
- 2: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>) - 1: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)
### Current tab ### Current tab
- Page URL: data:text/html,<title>Tab one</title><body>Body one</body> - Page URL: data:text/html,<title>Tab one</title><body>Body one</body>
@@ -71,9 +71,9 @@ test('create new tab', async ({ client }) => {
\`\`\` \`\`\`
### Open tabs ### Open tabs
- 1: [] (about:blank) - 0: [] (about:blank)
- 2: [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>) - 1: [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)
- 3: (current) [Tab two] (data:text/html,<title>Tab two</title><body>Body two</body>) - 2: (current) [Tab two] (data:text/html,<title>Tab two</title><body>Body two</body>)
### Current tab ### Current tab
- Page URL: data:text/html,<title>Tab two</title><body>Body two</body> - Page URL: data:text/html,<title>Tab two</title><body>Body two</body>
@@ -90,18 +90,18 @@ test('select tab', async ({ client }) => {
expect(await client.callTool({ expect(await client.callTool({
name: 'browser_tab_select', name: 'browser_tab_select',
arguments: { arguments: {
index: 2, index: 1,
}, },
})).toHaveTextContent(` })).toHaveTextContent(`
- Ran Playwright code: - Ran Playwright code:
\`\`\`js \`\`\`js
// <internal code to select tab 2> // <internal code to select tab 1>
\`\`\` \`\`\`
### Open tabs ### Open tabs
- 1: [] (about:blank) - 0: [] (about:blank)
- 2: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>) - 1: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)
- 3: [Tab two] (data:text/html,<title>Tab two</title><body>Body two</body>) - 2: [Tab two] (data:text/html,<title>Tab two</title><body>Body two</body>)
### Current tab ### Current tab
- Page URL: data:text/html,<title>Tab one</title><body>Body one</body> - Page URL: data:text/html,<title>Tab one</title><body>Body one</body>
@@ -118,17 +118,17 @@ test('close tab', async ({ client }) => {
expect(await client.callTool({ expect(await client.callTool({
name: 'browser_tab_close', name: 'browser_tab_close',
arguments: { arguments: {
index: 3, index: 2,
}, },
})).toHaveTextContent(` })).toHaveTextContent(`
- Ran Playwright code: - Ran Playwright code:
\`\`\`js \`\`\`js
// <internal code to close tab 3> // <internal code to close tab 2>
\`\`\` \`\`\`
### Open tabs ### Open tabs
- 1: [] (about:blank) - 0: [] (about:blank)
- 2: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>) - 1: (current) [Tab one] (data:text/html,<title>Tab one</title><body>Body one</body>)
### Current tab ### Current tab
- Page URL: data:text/html,<title>Tab one</title><body>Body one</body> - Page URL: data:text/html,<title>Tab one</title><body>Body one</body>