Files

czlonkowski c320eb4b35 fix: resolve workflow validator test failures for SplitInBatches validation

- Fix cycle detection to allow legitimate SplitInBatches loops while preventing other cycles
- Fix loop back detection by properly accessing workflow connections structure
- Update test expectations to match actual validation behavior:
  - Processing nodes on wrong outputs that loop back generate errors (not warnings)
  - Valid loop structures should generate no split-related warnings
  - Correct node naming in tests to avoid triggering unintended validation patterns
- Update node repository core tests to handle new outputs/outputNames columns
- Add comprehensive loop validation test coverage with 16 + 19 tests

All workflow validator tests now pass: 35/35 tests ✅

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-08-07 17:03:30 +02:00

__mocks__

fix: resolve TypeScript errors in test files

2025-07-28 20:28:45 +02:00

database-adapter-unit.test.ts

test: implement comprehensive testing improvements from PR #104 review

2025-07-30 13:44:35 +02:00

node-repository-core.test.ts

fix: resolve workflow validator test failures for SplitInBatches validation

2025-08-07 17:03:30 +02:00

node-repository-outputs.test.ts

fix: resolve SplitInBatches output confusion for AI assistants (#97 )

2025-08-07 15:58:40 +02:00

README.md

test: add comprehensive unit tests for database, parsers, loaders, and MCP tools

2025-07-28 20:16:38 +02:00

template-repository-core.test.ts

fix: resolve test hanging issue by separating MSW setup

2025-07-29 14:27:54 +02:00

README.md

Database Layer Unit Tests

This directory contains comprehensive unit tests for the database layer components of n8n-mcp.

Test Coverage

node-repository.ts - 100% Coverage ✅

saveNode method with JSON serialization
getNode method with JSON deserialization
getAITools method
safeJsonParse private method
Edge cases: large JSON, boolean conversion, invalid JSON handling

template-repository.ts - 80.31% Coverage ✅

FTS5 initialization and fallback
saveTemplate with sanitization
getTemplate and getTemplatesByNodes
searchTemplates with FTS5 and LIKE fallback
getTemplatesForTask with task mapping
Template statistics and maintenance operations
Uncovered: Some error paths in FTS5 operations

database-adapter.ts - Tested via Mocks

Interface compliance tests
PreparedStatement implementation
Transaction support
FTS5 detection logic
Error handling patterns

Test Strategy

The tests use a mock-based approach to:

Isolate database operations from actual database dependencies
Test business logic without requiring real SQLite/sql.js
Ensure consistent test execution across environments
Focus on behavior rather than implementation details

Key Test Files

node-repository-core.test.ts - Core NodeRepository functionality
template-repository-core.test.ts - Core TemplateRepository functionality
database-adapter-unit.test.ts - DatabaseAdapter interface and patterns

Running Tests

# Run all database tests
npm test -- tests/unit/database/

# Run with coverage
npm run test:coverage -- tests/unit/database/

# Run specific test file
npm test -- tests/unit/database/node-repository-core.test.ts

Mock Infrastructure

The tests use custom mock implementations:

MockDatabaseAdapter - Simulates database operations
MockPreparedStatement - Simulates SQL statement execution
Mock logger and template sanitizer for external dependencies

This approach ensures tests are fast, reliable, and maintainable.