czlonkowski 99518f71cf fix(issue-248): use unconditional empty settings object for cloud API compatibility ...

Issue #248 required three iterations to solve due to n8n API version differences:

1. First attempt: Whitelist filtering
   - Failed: API rejects ANY settings properties via update endpoint

2. Second attempt: Complete settings removal
   - Failed: Cloud API requires settings property to exist

3. Final solution: Unconditional empty settings object
   - Success: Satisfies both API requirements

Changes:
- src/services/n8n-validation.ts:153
  - Changed from conditional `if (cleanedWorkflow.settings)` to unconditional
  - Always sets `cleanedWorkflow.settings = {}`
  - Works for both cloud (requires property) and self-hosted (rejects properties)

- tests/unit/services/n8n-validation.test.ts
  - Updated all 4 tests to expect `settings: {}` instead of removed settings
  - Tests verify empty object approach works for all scenarios

Tested:
- ✅ localhost workflow (wwTodXf1jbUy3Ja5)
- ✅ cloud workflow (n8n.estyl.team/workflow/WKFeCRUjTeYbYhTf)
- ✅ All 72 unit tests passing

References:
- https://community.n8n.io/t/api-workflow-update-endpoint-doesnt-support-setting-callerpolicy/161916
- Tested with @agent-n8n-mcp-tester on production workflows

2025-10-02 16:33:11 +02:00

..

.gitkeep

feat: implement node parser and property extractor with versioned node support

2025-06-12 18:45:20 +02:00

nodes.db

fix(issue-248): use unconditional empty settings object for cloud API compatibility

2025-10-02 16:33:11 +02:00

nodes.db-shm

mostly working

2025-06-09 17:23:00 +02:00

nodes.db-wal

mostly working

2025-06-09 17:23:00 +02:00