mirror of
https://github.com/czlonkowski/n8n-mcp.git
synced 2026-02-06 05:23:08 +00:00
Fixes production search failures where 69% of user searches returned zero results for critical nodes (webhook, merge, split batch) despite nodes existing in database. Root Cause: - schema.sql missing nodes_fts FTS5 virtual table - No validation to detect empty database or missing FTS5 - rebuild.ts used schema without search index - Result: 9 of 13 searches failed in production Changes: 1. Schema Updates (src/database/schema.sql): - Added nodes_fts FTS5 virtual table with full-text indexing - Added INSERT/UPDATE/DELETE triggers for auto-sync - Indexes: node_type, display_name, description, documentation, operations 2. Database Validation (src/scripts/rebuild.ts): - Added empty database detection (fails if zero nodes) - Added FTS5 existence and synchronization validation - Added searchability tests for critical nodes - Added minimum node count check (500+) 3. Runtime Health Checks (src/mcp/server.ts): - Database health validation on first access - Detects empty database with clear error - Detects missing FTS5 with actionable warning 4. Test Suite (53 new tests): - tests/integration/database/node-fts5-search.test.ts (14 tests) - tests/integration/database/empty-database.test.ts (14 tests) - tests/integration/ci/database-population.test.ts (25 tests) 5. Database Rebuild: - data/nodes.db rebuilt with FTS5 index - 535 nodes fully synchronized with FTS5 Impact: - ✅ All critical searches now work (webhook, merge, split, code, http) - ✅ FTS5 provides fast ranked search (< 100ms) - ✅ Clear error messages if database empty - ✅ CI validates committed database integrity - ✅ Runtime health checks detect issues immediately Performance: - FTS5 search: < 100ms for typical queries - LIKE fallback: < 500ms (unchanged, still functional) Testing: LIKE search investigation revealed it was perfectly functional, only failed because database was empty. No changes needed. Related: Issue #296 Part 2 (Part 1: v2.18.4 fixed adapter bypass) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
254 lines
8.9 KiB
JavaScript
254 lines
8.9 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* Copyright (c) 2024 AiAdvisors Romuald Czlonkowski
|
|
* Licensed under the Sustainable Use License v1.0
|
|
*/
|
|
import { createDatabaseAdapter } from '../database/database-adapter';
|
|
import { N8nNodeLoader } from '../loaders/node-loader';
|
|
import { NodeParser, ParsedNode } from '../parsers/node-parser';
|
|
import { DocsMapper } from '../mappers/docs-mapper';
|
|
import { NodeRepository } from '../database/node-repository';
|
|
import { TemplateSanitizer } from '../utils/template-sanitizer';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
async function rebuild() {
|
|
console.log('🔄 Rebuilding n8n node database...\n');
|
|
|
|
const dbPath = process.env.NODE_DB_PATH || './data/nodes.db';
|
|
const db = await createDatabaseAdapter(dbPath);
|
|
const loader = new N8nNodeLoader();
|
|
const parser = new NodeParser();
|
|
const mapper = new DocsMapper();
|
|
const repository = new NodeRepository(db);
|
|
|
|
// Initialize database
|
|
const schema = fs.readFileSync(path.join(__dirname, '../../src/database/schema.sql'), 'utf8');
|
|
db.exec(schema);
|
|
|
|
// Clear existing data
|
|
db.exec('DELETE FROM nodes');
|
|
console.log('🗑️ Cleared existing data\n');
|
|
|
|
// Load all nodes
|
|
const nodes = await loader.loadAllNodes();
|
|
console.log(`📦 Loaded ${nodes.length} nodes from packages\n`);
|
|
|
|
// Statistics
|
|
const stats = {
|
|
successful: 0,
|
|
failed: 0,
|
|
aiTools: 0,
|
|
triggers: 0,
|
|
webhooks: 0,
|
|
withProperties: 0,
|
|
withOperations: 0,
|
|
withDocs: 0
|
|
};
|
|
|
|
// Process each node (documentation fetching must be outside transaction due to async)
|
|
console.log('🔄 Processing nodes...');
|
|
const processedNodes: Array<{ parsed: ParsedNode; docs: string | undefined; nodeName: string }> = [];
|
|
|
|
for (const { packageName, nodeName, NodeClass } of nodes) {
|
|
try {
|
|
// Parse node
|
|
const parsed = parser.parse(NodeClass, packageName);
|
|
|
|
// Validate parsed data
|
|
if (!parsed.nodeType || !parsed.displayName) {
|
|
throw new Error(`Missing required fields - nodeType: ${parsed.nodeType}, displayName: ${parsed.displayName}, packageName: ${parsed.packageName}`);
|
|
}
|
|
|
|
// Additional validation for required fields
|
|
if (!parsed.packageName) {
|
|
throw new Error(`Missing packageName for node ${nodeName}`);
|
|
}
|
|
|
|
// Get documentation
|
|
const docs = await mapper.fetchDocumentation(parsed.nodeType);
|
|
parsed.documentation = docs || undefined;
|
|
|
|
processedNodes.push({ parsed, docs: docs || undefined, nodeName });
|
|
} catch (error) {
|
|
stats.failed++;
|
|
const errorMessage = (error as Error).message;
|
|
console.error(`❌ Failed to process ${nodeName}: ${errorMessage}`);
|
|
}
|
|
}
|
|
|
|
// Now save all processed nodes to database
|
|
console.log(`\n💾 Saving ${processedNodes.length} processed nodes to database...`);
|
|
|
|
let saved = 0;
|
|
for (const { parsed, docs, nodeName } of processedNodes) {
|
|
try {
|
|
repository.saveNode(parsed);
|
|
saved++;
|
|
|
|
// Update statistics
|
|
stats.successful++;
|
|
if (parsed.isAITool) stats.aiTools++;
|
|
if (parsed.isTrigger) stats.triggers++;
|
|
if (parsed.isWebhook) stats.webhooks++;
|
|
if (parsed.properties.length > 0) stats.withProperties++;
|
|
if (parsed.operations.length > 0) stats.withOperations++;
|
|
if (docs) stats.withDocs++;
|
|
|
|
console.log(`✅ ${parsed.nodeType} [Props: ${parsed.properties.length}, Ops: ${parsed.operations.length}]`);
|
|
} catch (error) {
|
|
stats.failed++;
|
|
const errorMessage = (error as Error).message;
|
|
console.error(`❌ Failed to save ${nodeName}: ${errorMessage}`);
|
|
}
|
|
}
|
|
|
|
console.log(`💾 Save completed: ${saved} nodes saved successfully`);
|
|
|
|
// Validation check
|
|
console.log('\n🔍 Running validation checks...');
|
|
try {
|
|
const validationResults = validateDatabase(repository);
|
|
|
|
if (!validationResults.passed) {
|
|
console.log('⚠️ Validation Issues:');
|
|
validationResults.issues.forEach(issue => console.log(` - ${issue}`));
|
|
} else {
|
|
console.log('✅ All validation checks passed');
|
|
}
|
|
} catch (validationError) {
|
|
console.error('❌ Validation failed:', (validationError as Error).message);
|
|
console.log('⚠️ Skipping validation due to database compatibility issues');
|
|
}
|
|
|
|
// Summary
|
|
console.log('\n📊 Summary:');
|
|
console.log(` Total nodes: ${nodes.length}`);
|
|
console.log(` Successful: ${stats.successful}`);
|
|
console.log(` Failed: ${stats.failed}`);
|
|
console.log(` AI Tools: ${stats.aiTools}`);
|
|
console.log(` Triggers: ${stats.triggers}`);
|
|
console.log(` Webhooks: ${stats.webhooks}`);
|
|
console.log(` With Properties: ${stats.withProperties}`);
|
|
console.log(` With Operations: ${stats.withOperations}`);
|
|
console.log(` With Documentation: ${stats.withDocs}`);
|
|
|
|
// Sanitize templates if they exist
|
|
console.log('\n🧹 Checking for templates to sanitize...');
|
|
const templateCount = db.prepare('SELECT COUNT(*) as count FROM templates').get() as { count: number };
|
|
|
|
if (templateCount && templateCount.count > 0) {
|
|
console.log(` Found ${templateCount.count} templates, sanitizing...`);
|
|
const sanitizer = new TemplateSanitizer();
|
|
let sanitizedCount = 0;
|
|
|
|
const templates = db.prepare('SELECT id, name, workflow_json FROM templates').all() as any[];
|
|
for (const template of templates) {
|
|
const originalWorkflow = JSON.parse(template.workflow_json);
|
|
const { sanitized: sanitizedWorkflow, wasModified } = sanitizer.sanitizeWorkflow(originalWorkflow);
|
|
|
|
if (wasModified) {
|
|
const stmt = db.prepare('UPDATE templates SET workflow_json = ? WHERE id = ?');
|
|
stmt.run(JSON.stringify(sanitizedWorkflow), template.id);
|
|
sanitizedCount++;
|
|
console.log(` ✅ Sanitized template ${template.id}: ${template.name}`);
|
|
}
|
|
}
|
|
|
|
console.log(` Sanitization complete: ${sanitizedCount} templates cleaned`);
|
|
} else {
|
|
console.log(' No templates found in database');
|
|
}
|
|
|
|
console.log('\n✨ Rebuild complete!');
|
|
|
|
db.close();
|
|
}
|
|
|
|
function validateDatabase(repository: NodeRepository): { passed: boolean; issues: string[] } {
|
|
const issues = [];
|
|
|
|
try {
|
|
const db = (repository as any).db;
|
|
|
|
// CRITICAL: Check if database has any nodes at all
|
|
const nodeCount = db.prepare('SELECT COUNT(*) as count FROM nodes').get() as { count: number };
|
|
if (nodeCount.count === 0) {
|
|
issues.push('CRITICAL: Database is empty - no nodes found! Rebuild failed or was interrupted.');
|
|
return { passed: false, issues };
|
|
}
|
|
|
|
// Check minimum expected node count (should have at least 500 nodes from both packages)
|
|
if (nodeCount.count < 500) {
|
|
issues.push(`WARNING: Only ${nodeCount.count} nodes found - expected at least 500 (both n8n packages)`);
|
|
}
|
|
|
|
// Check critical nodes
|
|
const criticalNodes = ['nodes-base.httpRequest', 'nodes-base.code', 'nodes-base.webhook', 'nodes-base.slack'];
|
|
|
|
for (const nodeType of criticalNodes) {
|
|
const node = repository.getNode(nodeType);
|
|
|
|
if (!node) {
|
|
issues.push(`Critical node ${nodeType} not found`);
|
|
continue;
|
|
}
|
|
|
|
if (node.properties.length === 0) {
|
|
issues.push(`Node ${nodeType} has no properties`);
|
|
}
|
|
}
|
|
|
|
// Check AI tools
|
|
const aiTools = repository.getAITools();
|
|
if (aiTools.length === 0) {
|
|
issues.push('No AI tools found - check detection logic');
|
|
}
|
|
|
|
// Check FTS5 table existence and population
|
|
const ftsTableCheck = db.prepare(`
|
|
SELECT name FROM sqlite_master
|
|
WHERE type='table' AND name='nodes_fts'
|
|
`).get();
|
|
|
|
if (!ftsTableCheck) {
|
|
issues.push('CRITICAL: FTS5 table (nodes_fts) does not exist - searches will fail or be very slow');
|
|
} else {
|
|
// Check if FTS5 table is properly populated
|
|
const ftsCount = db.prepare('SELECT COUNT(*) as count FROM nodes_fts').get() as { count: number };
|
|
|
|
if (ftsCount.count === 0) {
|
|
issues.push('CRITICAL: FTS5 index is empty - searches will return zero results');
|
|
} else if (nodeCount.count !== ftsCount.count) {
|
|
issues.push(`FTS5 index out of sync: ${nodeCount.count} nodes but ${ftsCount.count} FTS5 entries`);
|
|
}
|
|
|
|
// Verify critical nodes are searchable via FTS5
|
|
const searchableNodes = ['webhook', 'merge', 'split'];
|
|
for (const searchTerm of searchableNodes) {
|
|
const searchResult = db.prepare(`
|
|
SELECT COUNT(*) as count FROM nodes_fts
|
|
WHERE nodes_fts MATCH ?
|
|
`).get(searchTerm);
|
|
|
|
if (searchResult.count === 0) {
|
|
issues.push(`CRITICAL: Search for "${searchTerm}" returns zero results in FTS5 index`);
|
|
}
|
|
}
|
|
}
|
|
} catch (error) {
|
|
// Catch any validation errors
|
|
const errorMessage = (error as Error).message;
|
|
issues.push(`Validation error: ${errorMessage}`);
|
|
}
|
|
|
|
return {
|
|
passed: issues.length === 0,
|
|
issues
|
|
};
|
|
}
|
|
|
|
// Run if called directly
|
|
if (require.main === module) {
|
|
rebuild().catch(console.error);
|
|
} |