mirror of
https://github.com/czlonkowski/n8n-mcp.git
synced 2026-01-30 06:22:04 +00:00
318986f546
* fix: Fix critical session cleanup stack overflow bug (v2.19.2) This commit fixes a critical P0 bug that caused stack overflow during container restart, making the service unusable for all users with session persistence enabled. Root Causes: 1. Missing await in cleanupExpiredSessions() line 206 caused overlapping async cleanup attempts 2. Transport event handlers (onclose, onerror) triggered recursive cleanup during shutdown 3. No recursion guard to prevent concurrent cleanup of same session Fixes Applied: - Added cleanupInProgress Set recursion guard - Added isShuttingDown flag to prevent recursive event handlers - Implemented safeCloseTransport() with timeout protection (3s) - Updated removeSession() with recursion guard and safe close - Fixed cleanupExpiredSessions() to properly await with error isolation - Updated all transport event handlers to check shutdown flag - Enhanced shutdown() method for proper sequential cleanup Impact: - Service now survives container restarts without stack overflow - No more hanging requests after restart - Individual session cleanup failures don't cascade - All 77 session lifecycle tests passing Version: 2.19.2 Severity: CRITICAL Priority: P0 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: Bump package.runtime.json to v2.19.2 * test: Fix transport cleanup test to work with safeCloseTransport The test was manually triggering mockTransport.onclose() to simulate cleanup, but our stack overflow fix sets transport.onclose = undefined in safeCloseTransport() before closing. Updated the test to call removeSession() directly instead of manually triggering the onclose handler. This properly tests the cleanup behavior with the new recursion-safe approach. Changes: - Call removeSession() directly to test cleanup - Verify transport.close() is called - Verify onclose and onerror handlers are cleared - Verify all session data structures are cleaned up Test Results: All 115 session tests passing ✅ 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>