Files
n8n-mcp/src/mcp/handlers-workflow-diff.ts
czlonkowski aeaba3b9ca fix: add smart parameters (branch, case, from, to) to Zod schema
The smart parameters implementation was incomplete - while the diff engine
correctly handled branch and case parameters, the Zod schema in
handlers-workflow-diff.ts was stripping them out before they reached the engine.

Found by n8n-mcp-tester: branch='false' parameter was being stripped,
causing connections to default to sourceIndex=0 instead of sourceIndex=1.

Added to Zod schema:
- branch: z.enum(['true', 'false']).optional() - For IF nodes
- case: z.number().optional() - For Switch nodes
- from: z.string().optional() - For rewireConnection operation
- to: z.string().optional() - For rewireConnection operation

All 141 tests passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-05 23:45:44 +02:00

174 lines
5.7 KiB
TypeScript

/**
* MCP Handler for Partial Workflow Updates
* Handles diff-based workflow modifications
*/
import { z } from 'zod';
import { McpToolResponse } from '../types/n8n-api';
import { WorkflowDiffRequest, WorkflowDiffOperation } from '../types/workflow-diff';
import { WorkflowDiffEngine } from '../services/workflow-diff-engine';
import { getN8nApiClient } from './handlers-n8n-manager';
import { N8nApiError, getUserFriendlyErrorMessage } from '../utils/n8n-errors';
import { logger } from '../utils/logger';
import { InstanceContext } from '../types/instance-context';
// Zod schema for the diff request
const workflowDiffSchema = z.object({
id: z.string(),
operations: z.array(z.object({
type: z.string(),
description: z.string().optional(),
// Node operations
node: z.any().optional(),
nodeId: z.string().optional(),
nodeName: z.string().optional(),
updates: z.any().optional(),
position: z.tuple([z.number(), z.number()]).optional(),
// Connection operations
source: z.string().optional(),
target: z.string().optional(),
from: z.string().optional(), // For rewireConnection
to: z.string().optional(), // For rewireConnection
sourceOutput: z.string().optional(),
targetInput: z.string().optional(),
sourceIndex: z.number().optional(),
targetIndex: z.number().optional(),
// Smart parameters (Phase 1 UX improvement)
branch: z.enum(['true', 'false']).optional(),
case: z.number().optional(),
ignoreErrors: z.boolean().optional(),
// Connection cleanup operations
dryRun: z.boolean().optional(),
connections: z.any().optional(),
// Metadata operations
settings: z.any().optional(),
name: z.string().optional(),
tag: z.string().optional(),
})),
validateOnly: z.boolean().optional(),
continueOnError: z.boolean().optional(),
});
export async function handleUpdatePartialWorkflow(args: unknown, context?: InstanceContext): Promise<McpToolResponse> {
try {
// Debug logging (only in debug mode)
if (process.env.DEBUG_MCP === 'true') {
logger.debug('Workflow diff request received', {
argsType: typeof args,
hasWorkflowId: args && typeof args === 'object' && 'workflowId' in args,
operationCount: args && typeof args === 'object' && 'operations' in args ?
(args as any).operations?.length : 0
});
}
// Validate input
const input = workflowDiffSchema.parse(args);
// Get API client
const client = getN8nApiClient(context);
if (!client) {
return {
success: false,
error: 'n8n API not configured. Please set N8N_API_URL and N8N_API_KEY environment variables.'
};
}
// Fetch current workflow
let workflow;
try {
workflow = await client.getWorkflow(input.id);
} catch (error) {
if (error instanceof N8nApiError) {
return {
success: false,
error: getUserFriendlyErrorMessage(error),
code: error.code
};
}
throw error;
}
// Apply diff operations
const diffEngine = new WorkflowDiffEngine();
const diffRequest = input as WorkflowDiffRequest;
const diffResult = await diffEngine.applyDiff(workflow, diffRequest);
// Check if this is a complete failure or partial success in continueOnError mode
if (!diffResult.success) {
// In continueOnError mode, partial success is still valuable
if (diffRequest.continueOnError && diffResult.workflow && diffResult.operationsApplied && diffResult.operationsApplied > 0) {
logger.info(`continueOnError mode: Applying ${diffResult.operationsApplied} successful operations despite ${diffResult.failed?.length || 0} failures`);
// Continue to update workflow with partial changes
} else {
// Complete failure - return error
return {
success: false,
error: 'Failed to apply diff operations',
details: {
errors: diffResult.errors,
operationsApplied: diffResult.operationsApplied,
applied: diffResult.applied,
failed: diffResult.failed
}
};
}
}
// If validateOnly, return validation result
if (input.validateOnly) {
return {
success: true,
message: diffResult.message,
data: {
valid: true,
operationsToApply: input.operations.length
}
};
}
// Update workflow via API
try {
const updatedWorkflow = await client.updateWorkflow(input.id, diffResult.workflow!);
return {
success: true,
data: updatedWorkflow,
message: `Workflow "${updatedWorkflow.name}" updated successfully. Applied ${diffResult.operationsApplied} operations.`,
details: {
operationsApplied: diffResult.operationsApplied,
workflowId: updatedWorkflow.id,
workflowName: updatedWorkflow.name,
applied: diffResult.applied,
failed: diffResult.failed,
errors: diffResult.errors
}
};
} catch (error) {
if (error instanceof N8nApiError) {
return {
success: false,
error: getUserFriendlyErrorMessage(error),
code: error.code,
details: error.details as Record<string, unknown> | undefined
};
}
throw error;
}
} catch (error) {
if (error instanceof z.ZodError) {
return {
success: false,
error: 'Invalid input',
details: { errors: error.errors }
};
}
logger.error('Failed to update partial workflow', error);
return {
success: false,
error: error instanceof Error ? error.message : 'Unknown error occurred'
};
}
}