ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-03-18 00:13:08 +00:00
Code Issues Packages Projects Releases Wiki Activity
641 Commits 61 Branches 158 Tags
b12a927a10d110b59e4d53fb867befad95a45c4f
Commit Graph

4 Commits

Author SHA1 Message Date
czlonkowski
f139d38c81 fix: prevent TypeError in getNodeTypeAlternatives with invalid inputs 
## Problem
Critical TypeError bugs affecting 60% of production errors (323/563 errors, 127 users):
- "Cannot read properties of undefined (reading 'split')" in get_node_essentials
- "Cannot read properties of undefined (reading 'includes')" in get_node_info

## Root Cause
getNodeTypeAlternatives() in src/utils/node-utils.ts called string methods
(toLowerCase, includes, split) without validating nodeType parameter.

When AI assistants passed undefined/null/empty nodeType values, the code
crashed with TypeError instead of returning a helpful error message.

## Solution (Defense in Depth)

### Layer 1: Defensive Programming (node-utils.ts:41-43)
Added type guard in getNodeTypeAlternatives():
- Returns empty array for undefined, null, non-string, or empty inputs
- Prevents TypeError crashes in utility function
- Allows calling code to handle "not found" gracefully

### Layer 2: Enhanced Validation (server.ts:607-609)
Improved validateToolParamsBasic() to catch empty strings:
- Detects empty string parameters before processing
- Provides clear error: "String parameters cannot be empty"
- Complements existing undefined/null validation

## Impact
- Eliminates 323 errors (57.4% of production errors)
- Helps 127 users (76.5% of users experiencing errors)
- Provides clear, actionable error messages instead of TypeErrors
- No performance impact on valid inputs

## Testing
- Added 21 comprehensive unit tests (all passing)
- Tested with n8n-mcp-tester agent (all scenarios verified)
- Confirmed no TypeErrors with invalid inputs
- Verified valid inputs continue to work perfectly

## Affected Tools
- get_node_essentials (208 errors → 0)
- get_node_info (115 errors → 0)
- get_node_documentation (17 errors → 0)

Resolves #275

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-06 00:02:48 +02:00
czlonkowski
f76e2247f9 fix: enhance node type format normalization for better AI agent compatibility (Issue #74) 
- Added support for n8n-nodes-langchain.* → nodes-langchain.* normalization
- Implemented case-insensitive node name matching (e.g., chattrigger → chatTrigger)
- Added smart camelCase detection for common patterns (trigger, request, sheets, etc.)
- Fixed get_node_documentation tool to use same normalization logic as other tools
- Updated all 7 node lookup locations to use normalized types for alternatives
- Enhanced getNodeTypeAlternatives() to normalize all generated alternatives

All MCP tools now consistently handle various format variations:
- nodes-langchain.chatTrigger (correct format)
- n8n-nodes-langchain.chatTrigger (package format)
- n8n-nodes-langchain.chattrigger (package + wrong case)
- nodes-langchain.chattrigger (wrong case only)
- @n8n/n8n-nodes-langchain.chatTrigger (full npm format)

Bump version to 2.7.19

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-18 16:25:20 +02:00
czlonkowski
92d1b7b273 feat: add workflowNodeType field to MCP tool responses for proper n8n workflow creation 
- Added workflowNodeType field to all node-returning MCP tools
- AI agents now receive both internal format (nodes-base.webhook) and workflow format (n8n-nodes-base.webhook)
- Created getWorkflowNodeType() utility to construct proper n8n format from package name
- Solves issue where AI agents would search nodes and use wrong format in workflows
- No database changes required - uses existing package_name field
- Updated: search_nodes, get_node_info, get_node_essentials, get_node_as_tool_info, validate_node_operation
- Updated CHANGELOG.md with comprehensive documentation of the changes

This completes the fix for issue #71, ensuring AI agents can seamlessly create workflows
with the correct node type format without manual intervention.
 2025-07-18 13:37:05 +02:00
czlonkowski
f8fa782d7f fix: normalize node type prefixes for n8n workflow exports (#71) 
- Add centralized normalizeNodeType utility to handle prefix conversion
  - n8n-nodes-base.* → nodes-base.*
  - @n8n/n8n-nodes-langchain.* → nodes-langchain.*
- Update all 9 affected MCP tools to use normalized node types
- AI agents can now use node types directly from n8n workflow exports
- Maintains backward compatibility with existing shortened prefixes
- Add comprehensive test coverage for all affected methods

Fixes #71

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-18 11:31:38 +02:00