Commit Graph

11 Commits

Author SHA1 Message Date
czlonkowski
a62e5f198c fix: case-insensitive 'not found' assertions in API client tests
N8nNotFoundError now passes through API messages directly instead of
wrapping them. The n8n API returns "Not found" (capital N) but tests
used .toContain('not found') (lowercase). Changed to case-insensitive.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-21 22:22:02 +01:00
Romuald Członkowski
be3d07dbdc feat: add n8n_manage_datatable MCP tool with full CRUD (#640) (#650)
* feat: add n8n_create_data_table MCP tool and projectId for create workflow (#640)

Add new MCP tool to create n8n data tables via the REST API:
- n8n_create_data_table tool definition with name + columns schema
- handleCreateDataTable handler with Zod validation and N8nApiError handling
- N8nApiClient.createDataTable() calling POST /data-tables
- DataTable, DataTableColumn, DataTableColumnResponse types per OpenAPI spec
- Column types: string | number | boolean | date | json
- Input validation: .min(1) on table name and column names
- Tool documentation with examples, use cases, and pitfalls

Also adds projectId parameter to n8n_create_workflow for enterprise
project support, and fixes stale management tool count in health check.

Based on work by @djakielski in PR #646.
Co-Authored-By: Dominik Jakielski <dominik.jakielski@urlaubsguru.de>

Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: replace n8n_create_data_table with n8n_manage_datatable (10 actions)

Replaces the single-purpose n8n_create_data_table tool with a comprehensive
n8n_manage_datatable tool covering all 10 n8n data table API endpoints:

Table operations: createTable, listTables, getTable, updateTable, deleteTable
Row operations: getRows, insertRows, updateRows, upsertRows, deleteRows

- Filter system with and/or logic and 8 condition operators
- Dry-run support for updateRows, upsertRows, deleteRows
- Pagination, sorting, and full-text search for row listing
- 9 new N8nApiClient methods for all data table endpoints
- Shared error handler and consolidated Zod schemas
- Comprehensive tool documentation with examples per action
- 36 handler tests + 18 API client tests

BREAKING: n8n_create_data_table removed. Use n8n_manage_datatable with
action="createTable" instead.

Based on work by @djakielski in PR #646.
Co-Authored-By: Dominik Jakielski <dominik.jakielski@urlaubsguru.de>

Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en
2026-03-21 19:06:22 +01:00
Romuald Członkowski
47a1cb135d feat: implement transferWorkflow operation in n8n_update_partial_workflow (#644) (#649)
Add transferWorkflow diff operation to move workflows between n8n projects:
- TransferWorkflowOperation type with destinationProjectId field
- WorkflowDiffEngine validates and tracks transfer intent
- Handler calls PUT /workflows/{id}/transfer after update
- N8nApiClient.transferWorkflow() method
- Zod schema validates destinationProjectId is non-empty
- Tool description and documentation updated
- inferIntentFromOperations case for transfer

Also fixes two pre-existing bugs found during review:
- continueOnError path now properly extracts/propagates activation flags
- Debug log in updateConnectionReferences shows correct old name

Based on work by @djakielski in PR #645.


Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en
2026-03-20 17:50:00 +01:00
Romuald Członkowski
9590f751d2 fix: resolve multiple n8n_update_partial_workflow bugs (#635)
* fix: use correct MCP SDK API for server capabilities in test

getServerVersion() returns Implementation (name/version only), not the
full init result. Use client.getServerCapabilities() instead to access
server capabilities, fixing the CI typecheck failure.

Concieved by Romuald Członkowski - www.aiadvisors.pl/en

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve multiple n8n_update_partial_workflow bugs (#592, #599, #610, #623, #624, #625, #629, #630, #633)

Phase 1 - Data loss prevention:
- Add missing unary operators (empty, notEmpty, exists, notExists) to sanitizer (#592)
- Preserve positional empty arrays in connections during removeNode/cleanStale (#610)
- Scope sanitization to modified nodes only, preventing unrelated node corruption
- Add empty body {} to activate/deactivate POST calls to fix 415 errors (#633)

Phase 2 - Error handling & response clarity:
- Serialize Zod errors to readable "path: message" strings (#630)
- Add saved:true/false field to all response paths (#625)
- Improve updateNode error hint with correct structure example (#623)
- Track removed node names for better removeConnection errors (#624)

Phase 3 - Connection & type fixes:
- Coerce sourceOutput/targetInput to String() consistently (#629)
- Accept numeric sourceOutput/targetInput at Zod schema level via transform

Phase 4 - Tag operations via dedicated API (#599):
- Track tags as tagsToAdd/tagsToRemove instead of mutating workflow.tags
- Orchestrate tag creation and association via listTags/createTag/updateWorkflowTags
- Reconcile conflicting add/remove for same tag (last operation wins)
- Tag failures produce warnings, not hard errors

Conceived by Romuald Członkowski - www.aiadvisors.pl/en

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* docs: add v2.37.0 changelog entry

Conceived by Romuald Członkowski - www.aiadvisors.pl/en

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: resolve pre-existing integration test failures in CI

- Create new MCP Server instance per connection in test helpers (SDK 1.27+
  requires separate Protocol instance per connection)
- Normalize database paths with path.resolve() in shared-database singleton
  to prevent path mismatch errors across test files
- Add no-op catch handler to deferred initialization promise in server.ts
  to prevent unhandled rejection warnings
- Properly call mcpServer.shutdown() in test helper close() to release
  shared database references

Conceived by Romuald Członkowski - www.aiadvisors.pl/en

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-14 17:27:33 +01:00
czlonkowski
3578f2cc31 test: Add comprehensive test coverage for workflow activation/deactivation
Added 25 new tests to improve coverage for workflow activation/deactivation feature:
- 7 tests for handlers-workflow-diff.test.ts (activation/deactivation handler logic)
- 8 tests for workflow-diff-engine.test.ts (validate/apply activate/deactivate operations)
- 10 tests for n8n-api-client.test.ts (API client activation/deactivation methods)

Coverage improvements:
- Branch coverage increased from 77% to 85.58%
- All 3512 tests passing

Tests cover:
- Successful workflow activation/deactivation after updates
- Error handling for activation/deactivation failures
- Validation of activatable trigger nodes (webhook, schedule, etc.)
- Rejection of workflows without activatable triggers
- API client error cases (not found, already active/inactive, server errors)

Conceived by Romuald Członkowski - www.aiadvisors.pl/en
2025-11-06 23:58:34 +01:00
czlonkowski
e522aec08c refactor: Eliminate DRY violation in n8n API response validation (issue #349)
Refactored defensive response validation from PR #367 to eliminate code duplication
and improve maintainability. Extracted duplicated validation logic into reusable
helper method with comprehensive test coverage.

Key improvements:
- Created validateListResponse<T>() helper method (75% code reduction)
- Added JSDoc documentation for backwards compatibility
- Added 29 comprehensive unit tests (100% coverage)
- Enhanced error messages with limited key exposure (max 5 keys)
- Consistent validation across all list operations

Testing:
- All 74 tests passing (including 29 new validation tests)
- TypeScript compilation successful
- Type checking passed

Related: PR #367, code review findings
Files: n8n-api-client.ts (refactored 4 methods), tests (+237 lines)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Conceived by Romuald Członkowski - www.aiadvisors.pl/en
2025-10-25 13:19:23 +02:00
czlonkowski
d207cc3723 fix: add DNS mocking to n8n-api-client tests for SSRF protection
Root Cause:
- SSRF protection added DNS resolution via dns/promises.lookup()
- n8n-api-client.test.ts did not mock DNS module
- Tests failed with "DNS resolution failed" error in CI

Fix:
- Added vi.mock('dns/promises') before imports
- Imported dns module for type safety
- Implemented DNS mock in beforeEach to simulate real behavior:
  - localhost → 127.0.0.1
  - IP addresses → returned as-is
  - Real hostnames → 8.8.8.8 (public IP)

Test Results:
- All 50 n8n-api-client tests now pass 
- Type checking passes 
- Matches pattern from ssrf-protection.test.ts

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-06 16:25:48 +02:00
czlonkowski
08e906739f fix: resolve type errors from tags parameter change
Fixed type errors caused by changing WorkflowListParams.tags from string[] to string:

1. cleanup-helpers.ts: Changed tags: [tag] to tags: tag (line 221)
2. n8n-api-client.test.ts: Changed tags: ['test'] to tags: 'test,production' (line 384)
3. Added unit tests for handleDeleteWorkflow and handleListWorkflows (100% coverage)

All tests pass, lint clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-04 23:57:08 +02:00
czlonkowski
2b54710fda test: add unit tests for n8n manager and workflow diff handlers 2025-07-28 18:15:21 +02:00
czlonkowski
a37054685f fix: resolve unhandled promise rejection in n8n-api-client tests
- Fixed simulateError helper to properly handle async error interceptors
- Made mock implementation async to handle promise rejections correctly
- Enabled all 7 previously skipped error handling tests
- All 666 tests now pass without unhandled promise rejections

This fixes the CI pipeline failure caused by unhandled promise rejections.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 17:17:01 +02:00
czlonkowski
8e8771b1f4 test: implement critical service tests achieving 80%+ coverage
Phase 3.5 - Added comprehensive tests for critical services:

- n8n-api-client: 0% → 83.87% coverage (50 tests)
  - All CRUD operations tested
  - Retry logic and error handling
  - Authentication and interceptors
  - 7 tests skipped due to flaky promise rejection (needs fix)

- workflow-diff-engine: 0% → 90.06% coverage (44 tests)
  - All diff operations tested
  - Two-pass processing verified
  - Workflow immutability ensured
  - Edge cases covered

- n8n-validation: 0% → comprehensive coverage (68 tests)
  - Zod schema validation
  - Workflow structure validation
  - Helper functions tested
  - Fixed credential schema bug

- node-specific-validators: 2.1% → 98.7% coverage (143 tests)
  - All major node types tested
  - Operation-specific validation
  - Security checks verified
  - Auto-fix suggestions tested

- enhanced-config-validator: 71.42% → 94.55% coverage (+20 tests)
  - Operation-specific paths covered
  - Profile filters tested
  - Error handling enhanced
  - Next steps generation tested

Overall: 659 tests passing, 7 skipped
Code review identified areas for improvement including flaky test fixes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-28 15:52:57 +02:00