- Fix variable name conflicts in mcp-telemetry.test.ts
- Fix process.exit mock type in batch-processor.test.ts
- Fix position tuple types in event-tracker.test.ts
- Import MockInstance type from vitest
- Fix event validator to not filter out generic 'key' property
- Handle compound key terms (apikey, api_key) while allowing standalone 'key'
- Fix batch processor test expectations to account for circuit breaker limits
- Adjust dead letter queue test to expect 25 items due to circuit breaker opening after 5 failures
- Fix test mocks to fail for all retry attempts before adding to dead letter queue
All 252 telemetry tests now passing with 90.75% code coverage
Major improvements to telemetry system addressing code review findings:
Architecture & Modularization:
- Split 636-line TelemetryManager into 7 focused modules
- Separated concerns: event tracking, batch processing, validation, rate limiting
- Lazy initialization pattern to avoid early singleton creation
- Clean separation of responsibilities
Security & Privacy:
- Added comprehensive input validation with Zod schemas
- Sanitization of sensitive data (URLs, API keys, emails)
- Expanded sensitive key detection patterns (25+ patterns)
- Row Level Security on Supabase backend
- Added data deletion contact info (romuald@n8n-mcp.com)
Performance & Reliability:
- Sliding window rate limiter (100 events/minute)
- Circuit breaker pattern for network failures
- Dead letter queue for failed events
- Exponential backoff with jitter for retries
- Performance monitoring with overhead tracking (<5%)
- Memory-safe array limits in rate limiter
Testing:
- Comprehensive test coverage (87%+ for core modules)
- Unit tests for all new modules
- Integration tests for MCP telemetry
- Fixed test isolation issues
Data Management:
- Clear user consent in welcome message
- Batch processing with deduplication
- Automatic workflow flushing
BREAKING CHANGE: TelemetryManager constructor is now private, use getInstance()
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
