ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-02-06 13:33:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
848 Commits 51 Branches 139 Tags
7f03f51e87bc7c45cfabdc1e61f9723cbb221aa8
Commit Graph

7 Commits

Author SHA1 Message Date
czlonkowski
3578f2cc31 test: Add comprehensive test coverage for workflow activation/deactivation 
Added 25 new tests to improve coverage for workflow activation/deactivation feature:
- 7 tests for handlers-workflow-diff.test.ts (activation/deactivation handler logic)
- 8 tests for workflow-diff-engine.test.ts (validate/apply activate/deactivate operations)
- 10 tests for n8n-api-client.test.ts (API client activation/deactivation methods)

Coverage improvements:
- Branch coverage increased from 77% to 85.58%
- All 3512 tests passing

Tests cover:
- Successful workflow activation/deactivation after updates
- Error handling for activation/deactivation failures
- Validation of activatable trigger nodes (webhook, schedule, etc.)
- Rejection of workflows without activatable triggers
- API client error cases (not found, already active/inactive, server errors)

Conceived by Romuald Członkowski - www.aiadvisors.pl/en
 2025-11-06 23:58:34 +01:00
czlonkowski
e522aec08c refactor: Eliminate DRY violation in n8n API response validation (issue #349) 
Refactored defensive response validation from PR #367 to eliminate code duplication
and improve maintainability. Extracted duplicated validation logic into reusable
helper method with comprehensive test coverage.

Key improvements:
- Created validateListResponse<T>() helper method (75% code reduction)
- Added JSDoc documentation for backwards compatibility
- Added 29 comprehensive unit tests (100% coverage)
- Enhanced error messages with limited key exposure (max 5 keys)
- Consistent validation across all list operations

Testing:
- All 74 tests passing (including 29 new validation tests)
- TypeScript compilation successful
- Type checking passed

Related: PR #367, code review findings
Files: n8n-api-client.ts (refactored 4 methods), tests (+237 lines)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Conceived by Romuald Członkowski - www.aiadvisors.pl/en
 2025-10-25 13:19:23 +02:00
czlonkowski
d207cc3723 fix: add DNS mocking to n8n-api-client tests for SSRF protection 
Root Cause:
- SSRF protection added DNS resolution via dns/promises.lookup()
- n8n-api-client.test.ts did not mock DNS module
- Tests failed with "DNS resolution failed" error in CI

Fix:
- Added vi.mock('dns/promises') before imports
- Imported dns module for type safety
- Implemented DNS mock in beforeEach to simulate real behavior:
  - localhost → 127.0.0.1
  - IP addresses → returned as-is
  - Real hostnames → 8.8.8.8 (public IP)

Test Results:
- All 50 n8n-api-client tests now pass ✅
- Type checking passes ✅
- Matches pattern from ssrf-protection.test.ts

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-06 16:25:48 +02:00
czlonkowski
08e906739f fix: resolve type errors from tags parameter change 
Fixed type errors caused by changing WorkflowListParams.tags from string[] to string:

1. cleanup-helpers.ts: Changed tags: [tag] to tags: tag (line 221)
2. n8n-api-client.test.ts: Changed tags: ['test'] to tags: 'test,production' (line 384)
3. Added unit tests for handleDeleteWorkflow and handleListWorkflows (100% coverage)

All tests pass, lint clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-04 23:57:08 +02:00
czlonkowski
2b54710fda test: add unit tests for n8n manager and workflow diff handlers 2025-07-28 18:15:21 +02:00
czlonkowski
a37054685f fix: resolve unhandled promise rejection in n8n-api-client tests 
- Fixed simulateError helper to properly handle async error interceptors
- Made mock implementation async to handle promise rejections correctly
- Enabled all 7 previously skipped error handling tests
- All 666 tests now pass without unhandled promise rejections

This fixes the CI pipeline failure caused by unhandled promise rejections.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-28 17:17:01 +02:00
czlonkowski
8e8771b1f4 test: implement critical service tests achieving 80%+ coverage 
Phase 3.5 - Added comprehensive tests for critical services:

- n8n-api-client: 0% → 83.87% coverage (50 tests)
  - All CRUD operations tested
  - Retry logic and error handling
  - Authentication and interceptors
  - 7 tests skipped due to flaky promise rejection (needs fix)

- workflow-diff-engine: 0% → 90.06% coverage (44 tests)
  - All diff operations tested
  - Two-pass processing verified
  - Workflow immutability ensured
  - Edge cases covered

- n8n-validation: 0% → comprehensive coverage (68 tests)
  - Zod schema validation
  - Workflow structure validation
  - Helper functions tested
  - Fixed credential schema bug

- node-specific-validators: 2.1% → 98.7% coverage (143 tests)
  - All major node types tested
  - Operation-specific validation
  - Security checks verified
  - Auto-fix suggestions tested

- enhanced-config-validator: 71.42% → 94.55% coverage (+20 tests)
  - Operation-specific paths covered
  - Profile filters tested
  - Error handling enhanced
  - Next steps generation tested

Overall: 659 tests passing, 7 skipped
Code review identified areas for improvement including flaky test fixes

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-07-28 15:52:57 +02:00