fix: resolve SplitInBatches output confusion for AI assistants (#97)

## Problem
AI assistants were consistently connecting SplitInBatches node outputs backwards because:
- Output index 0 = "done" (runs after loop completes)
- Output index 1 = "loop" (processes items inside loop)
This counterintuitive ordering caused incorrect workflow connections.

## Solution
Enhanced the n8n-mcp system to expose and clarify output information:

### Database & Schema
- Added `outputs` and `output_names` columns to nodes table
- Updated NodeRepository to store/retrieve output information

### Node Parsing
- Enhanced NodeParser to extract outputs and outputNames from nodes
- Properly handles versioned nodes like SplitInBatchesV3

### MCP Server
- Modified getNodeInfo to return detailed output descriptions
- Added connection guidance for each output
- Special handling for loop nodes (SplitInBatches, IF, Switch)

### Documentation
- Enhanced DocsMapper to inject critical output guidance
- Added warnings about counterintuitive output ordering
- Provides correct connection patterns for loop nodes

### Workflow Validation
- Added validateSplitInBatchesConnection method
- Detects reversed connections and provides specific errors
- Added checkForLoopBack with depth limit to prevent stack overflow
- Smart heuristics to identify likely connection mistakes

## Testing
- Created comprehensive test suite (81 tests)
- Unit tests for all modified components
- Edge case handling for malformed data
- Performance testing with large workflows

## Impact
AI assistants will now:
- See explicit output indices and names (e.g., "Output 0: done")
- Receive clear connection guidance
- Get validation errors when connections are reversed
- Have enhanced documentation explaining the correct pattern

Fixes #97

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
czlonkowski
2025-08-07 15:58:07 +02:00
parent a4e711a4e8
commit f508d9873b
12 changed files with 2895 additions and 12 deletions

View File

@@ -16,14 +16,19 @@ export interface ParsedNode {
isVersioned: boolean;
packageName: string;
documentation?: string;
outputs?: any[];
outputNames?: string[];
}
export class NodeParser {
private propertyExtractor = new PropertyExtractor();
private currentNodeClass: any = null;
parse(nodeClass: any, packageName: string): ParsedNode {
this.currentNodeClass = nodeClass;
// Get base description (handles versioned nodes)
const description = this.getNodeDescription(nodeClass);
const outputInfo = this.extractOutputs(description);
return {
style: this.detectStyle(nodeClass),
@@ -39,7 +44,9 @@ export class NodeParser {
operations: this.propertyExtractor.extractOperations(nodeClass),
version: this.extractVersion(nodeClass),
isVersioned: this.detectVersioned(nodeClass),
packageName: packageName
packageName: packageName,
outputs: outputInfo.outputs,
outputNames: outputInfo.outputNames
};
}
@@ -222,4 +229,51 @@ export class NodeParser {
return false;
}
private extractOutputs(description: any): { outputs?: any[], outputNames?: string[] } {
const result: { outputs?: any[], outputNames?: string[] } = {};
// First check the base description
if (description.outputs) {
result.outputs = Array.isArray(description.outputs) ? description.outputs : [description.outputs];
}
if (description.outputNames) {
result.outputNames = Array.isArray(description.outputNames) ? description.outputNames : [description.outputNames];
}
// If no outputs found and this is a versioned node, check the latest version
if (!result.outputs && !result.outputNames) {
const nodeClass = this.currentNodeClass; // We'll need to track this
if (nodeClass) {
try {
const instance = new nodeClass();
if (instance.nodeVersions) {
// Get the latest version
const versions = Object.keys(instance.nodeVersions).map(Number);
const latestVersion = Math.max(...versions);
const versionedDescription = instance.nodeVersions[latestVersion]?.description;
if (versionedDescription) {
if (versionedDescription.outputs) {
result.outputs = Array.isArray(versionedDescription.outputs)
? versionedDescription.outputs
: [versionedDescription.outputs];
}
if (versionedDescription.outputNames) {
result.outputNames = Array.isArray(versionedDescription.outputNames)
? versionedDescription.outputNames
: [versionedDescription.outputNames];
}
}
}
} catch (e) {
// Ignore errors from instantiating node
}
}
}
return result;
}
}