ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-02-06 21:43:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct version extraction and typeVersion validation for langchain nodes

Browse Source 
This commit fixes two critical bugs affecting AI Agent and other langchain nodes:

1. Version Extraction Bug (node-parser.ts)
   - AI Agent was returning version "3" instead of "2.2" (the defaultVersion)
   - Root cause: extractVersion() checked non-existent instance.baseDescription.defaultVersion
   - Fix: Updated priority to check currentVersion first, then description.defaultVersion
   - Impact: All VersionedNodeType nodes now return correct version

2. typeVersion Validation Bypass (workflow-validator.ts)
   - Langchain nodes with invalid typeVersion passed validation (even typeVersion: 99999)
   - Root cause: langchain skip happened before typeVersion validation
   - Fix: Moved typeVersion validation before langchain parameter skip
   - Impact: Invalid typeVersion values now properly caught for all nodes

Also includes:
- Database rebuilt with corrected version data (536 nodes)
- Version bump: 2.17.3 → 2.17.4
- Comprehensive CHANGELOG entry

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
czlonkowski
2025-10-07 20:16:45 +02:00
parent 2c536a25fd
commit b986beef2c
5 changed files with 123 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/parsers/node-parser.ts
View File

@@ -135,26 +135,32 @@ export class NodeParser {
}
private extractVersion(nodeClass: any): string {
// Check instance for baseDescription first
// Check instance properties first
try {
const instance = typeof nodeClass === 'function' ? new nodeClass() : nodeClass;
// Handle instance-level baseDescription
if (instance?.baseDescription?.defaultVersion) {
return instance.baseDescription.defaultVersion.toString();
// PRIORITY 1: Check currentVersion (what VersionedNodeType actually uses)
// For VersionedNodeType, currentVersion = defaultVersion ?? max(nodeVersions)
if (instance?.currentVersion !== undefined) {
return instance.currentVersion.toString();
}
// Handle instance-level nodeVersions
// PRIORITY 2: Handle instance-level description.defaultVersion
// VersionedNodeType stores baseDescription as 'description', not 'baseDescription'
if (instance?.description?.defaultVersion) {
return instance.description.defaultVersion.toString();
}
// PRIORITY 3: Handle instance-level nodeVersions (fallback to max)
if (instance?.nodeVersions) {
const versions = Object.keys(instance.nodeVersions);
return Math.max(...versions.map(Number)).toString();
}
// Handle version array in description (e.g., [1, 1.1, 1.2])
if (instance?.description?.version) {
const version = instance.description.version;
if (Array.isArray(version)) {
// Find the maximum version from the array
const maxVersion = Math.max(...version.map((v: any) => parseFloat(v.toString())));
return maxVersion.toString();
} else if (typeof version === 'number' || typeof version === 'string') {
@@ -165,18 +171,19 @@ export class NodeParser {
// Some nodes might require parameters to instantiate
// Try class-level properties
}
// Handle class-level VersionedNodeType with defaultVersion
if (nodeClass.baseDescription?.defaultVersion) {
return nodeClass.baseDescription.defaultVersion.toString();
// Note: Most VersionedNodeType classes don't have static properties
if (nodeClass.description?.defaultVersion) {
return nodeClass.description.defaultVersion.toString();
}
// Handle class-level VersionedNodeType with nodeVersions
if (nodeClass.nodeVersions) {
const versions = Object.keys(nodeClass.nodeVersions);
return Math.max(...versions.map(Number)).toString();
}
// Also check class-level description for version array
const description = this.getNodeDescription(nodeClass);
if (description?.version) {
@@ -187,7 +194,7 @@ export class NodeParser {
return description.version.toString();
}
}
// Default to version 1
return '1';
}