ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-02-05 21:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update tests for node type normalization changes

Browse Source 
Fixed 3 failing tests after P0-R1 normalization implementation:
- workflow-validator-comprehensive.test.ts: Updated expectations for normalized node type lookups
- handlers-n8n-manager.test.ts: Updated createWorkflow test for normalized input
- workflow-validator.ts: Fixed SplitInBatches detection to use short-form node types

All tests now passing. Node types are normalized to short form before validation,
so tests must expect short-form types in assertions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
czlonkowski
2025-10-02 13:55:13 +02:00
parent ed7de10fd2
commit a8e0b1ed34
3 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/workflow-validator.ts
View File

@@ -658,7 +658,7 @@ export class WorkflowValidator {
} }
// Special validation for SplitInBatches node // Special validation for SplitInBatches node
if (sourceNode && sourceNode.type === 'n8n-nodes-base.splitInBatches') { if (sourceNode && sourceNode.type === 'nodes-base.splitInBatches') {
this.validateSplitInBatchesConnection( this.validateSplitInBatchesConnection(
sourceNode, sourceNode,
outputIndex, outputIndex,
@@ -671,7 +671,7 @@ export class WorkflowValidator {
// Check for self-referencing connections // Check for self-referencing connections
if (connection.node === sourceName) { if (connection.node === sourceName) {
// This is only a warning for non-loop nodes // This is only a warning for non-loop nodes
if (sourceNode && sourceNode.type !== 'n8n-nodes-base.splitInBatches') { if (sourceNode && sourceNode.type !== 'nodes-base.splitInBatches') {
result.warnings.push({ result.warnings.push({
type: 'warning', type: 'warning',
message: `Node "${sourceName}" has a self-referencing connection. This can cause infinite loops.` message: `Node "${sourceName}" has a self-referencing connection. This can cause infinite loops.`

17
tests/unit/mcp/handlers-n8n-manager.test.ts
View File

@@ -230,8 +230,21 @@ describe('handlers-n8n-manager', () => {
data: testWorkflow, data: testWorkflow,
message: 'Workflow "Test Workflow" created successfully with ID: test-workflow-id', message: 'Workflow "Test Workflow" created successfully with ID: test-workflow-id',
}); });
expect(mockApiClient.createWorkflow).toHaveBeenCalledWith(input);
expect(n8nValidation.validateWorkflowStructure).toHaveBeenCalledWith(input); const expectedNormalizedInput = {
name: 'Test Workflow',
nodes: [{
id: 'node1',
name: 'Start',
type: 'nodes-base.start',
typeVersion: 1,
position: [100, 100],
parameters: {},
}],
connections: testWorkflow.connections,
};
expect(mockApiClient.createWorkflow).toHaveBeenCalledWith(expectedNormalizedInput);
expect(n8nValidation.validateWorkflowStructure).toHaveBeenCalledWith(expectedNormalizedInput);
}); });
it('should handle validation errors', async () => { it('should handle validation errors', async () => {

2
tests/unit/services/workflow-validator-comprehensive.test.ts
View File

@@ -579,7 +579,6 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
const result = await validator.validateWorkflow(workflow as any); const result = await validator.validateWorkflow(workflow as any);
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('n8n-nodes-base.webhook');
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-base.webhook'); expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-base.webhook');
}); });
@@ -599,7 +598,6 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
const result = await validator.validateWorkflow(workflow as any); const result = await validator.validateWorkflow(workflow as any);
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('@n8n/n8n-nodes-langchain.agent');
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-langchain.agent'); expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-langchain.agent');
}); });