From a8c3d04c12ce1ff21901bc90c17781f526c05753 Mon Sep 17 00:00:00 2001 From: czlonkowski <56956555+czlonkowski@users.noreply.github.com> Date: Tue, 29 Jul 2025 07:13:37 +0200 Subject: [PATCH] fix: resolve test environment loading race condition in CI - Move getTestConfig() calls from module level to test execution time - Add CI-specific debug logging to diagnose environment loading issues - Add verification step in CI workflow to check .env.test availability - Ensure environment variables are loaded before tests access config The issue was that config was being accessed at module import time, which could happen before the global setup runs in some CI environments. --- .github/workflows/test.yml | 9 ++++ tests/setup/global-setup.ts | 9 ++++ tests/setup/test-env.ts | 18 ++++++- tests/unit/test-env-example.test.ts | 74 ++++++++++++++++++----------- 4 files changed, 80 insertions(+), 30 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bdb3221..32efdbe 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,6 +19,15 @@ jobs: - name: Install dependencies run: npm ci + # Verify test environment setup + - name: Verify test environment + run: | + echo "Current directory: $(pwd)" + echo "Checking for .env.test file:" + ls -la .env.test || echo ".env.test not found!" + echo "First few lines of .env.test:" + head -5 .env.test || echo "Cannot read .env.test" + # Run tests with coverage and multiple reporters - name: Run tests with coverage run: npm run test:ci diff --git a/tests/setup/global-setup.ts b/tests/setup/global-setup.ts index 7b4cd7a..8ea4068 100644 --- a/tests/setup/global-setup.ts +++ b/tests/setup/global-setup.ts @@ -1,9 +1,18 @@ import { beforeEach, afterEach, vi } from 'vitest'; import { loadTestEnvironment, getTestConfig, getTestTimeout } from './test-env'; +// CI Debug: Log environment loading in CI only +if (process.env.CI === 'true') { + console.log('[CI-DEBUG] Global setup starting, NODE_ENV:', process.env.NODE_ENV); +} + // Load test environment configuration loadTestEnvironment(); +if (process.env.CI === 'true') { + console.log('[CI-DEBUG] Global setup complete, N8N_API_URL:', process.env.N8N_API_URL); +} + // Get test configuration const testConfig = getTestConfig(); diff --git a/tests/setup/test-env.ts b/tests/setup/test-env.ts index 7b709d0..a3cc473 100644 --- a/tests/setup/test-env.ts +++ b/tests/setup/test-env.ts @@ -11,10 +11,26 @@ import { existsSync } from 'fs'; // Load test environment variables export function loadTestEnvironment(): void { + // CI Debug logging + const isCI = process.env.CI === 'true'; + // Load base test environment const testEnvPath = path.resolve(process.cwd(), '.env.test'); + + if (isCI) { + console.log('[CI-DEBUG] Looking for .env.test at:', testEnvPath); + console.log('[CI-DEBUG] File exists?', existsSync(testEnvPath)); + } + if (existsSync(testEnvPath)) { - dotenv.config({ path: testEnvPath }); + const result = dotenv.config({ path: testEnvPath }); + if (isCI && result.error) { + console.error('[CI-DEBUG] Failed to load .env.test:', result.error); + } else if (isCI && result.parsed) { + console.log('[CI-DEBUG] Successfully loaded', Object.keys(result.parsed).length, 'env vars from .env.test'); + } + } else if (isCI) { + console.warn('[CI-DEBUG] .env.test file not found, will use defaults only'); } // Load local test overrides (for sensitive values) diff --git a/tests/unit/test-env-example.test.ts b/tests/unit/test-env-example.test.ts index c740e87..012ac6f 100644 --- a/tests/unit/test-env-example.test.ts +++ b/tests/unit/test-env-example.test.ts @@ -19,10 +19,14 @@ import { } from '@tests/helpers/env-helpers'; describe('Test Environment Configuration Example', () => { - const config = getTestConfig(); - const logger = createTestLogger('test-env-example'); + let config: ReturnType; + let logger: ReturnType; beforeAll(() => { + // Initialize config inside beforeAll to ensure environment is loaded + config = getTestConfig(); + logger = createTestLogger('test-env-example'); + logger.info('Test suite starting with configuration:', { environment: config.nodeEnv, database: config.database.path, @@ -35,20 +39,23 @@ describe('Test Environment Configuration Example', () => { }); it('should be in test mode', () => { + const testConfig = getTestConfig(); expect(isTestMode()).toBe(true); - expect(config.nodeEnv).toBe('test'); - expect(config.isTest).toBe(true); + expect(testConfig.nodeEnv).toBe('test'); + expect(testConfig.isTest).toBe(true); }); it('should have proper database configuration', () => { - expect(config.database.path).toBeDefined(); - expect(config.database.rebuildOnStart).toBe(false); - expect(config.database.seedData).toBe(true); + const testConfig = getTestConfig(); + expect(testConfig.database.path).toBeDefined(); + expect(testConfig.database.rebuildOnStart).toBe(false); + expect(testConfig.database.seedData).toBe(true); }); it('should have mock API configuration', () => { - expect(config.api.url).toMatch(/mock-api/); - expect(config.api.key).toBe('test-api-key-12345'); + const testConfig = getTestConfig(); + expect(testConfig.api.url).toMatch(/mock-api/); + expect(testConfig.api.key).toBe('test-api-key-12345'); }); it('should respect test timeouts', { timeout: getTestTimeout('unit') }, async () => { @@ -60,7 +67,8 @@ describe('Test Environment Configuration Example', () => { }); it('should support environment overrides', () => { - const originalLogLevel = config.logging.level; + const testConfig = getTestConfig(); + const originalLogLevel = testConfig.logging.level; const result = withEnvOverrides({ LOG_LEVEL: 'debug', @@ -73,7 +81,8 @@ describe('Test Environment Configuration Example', () => { }); expect(result).toBe('success'); - expect(config.logging.level).toBe(originalLogLevel); + const configAfter = getTestConfig(); + expect(configAfter.logging.level).toBe(originalLogLevel); }); it('should generate unique test database paths', () => { @@ -87,15 +96,17 @@ describe('Test Environment Configuration Example', () => { }); it('should construct mock API URLs', () => { + const testConfig = getTestConfig(); const baseUrl = getMockApiUrl(); const endpointUrl = getMockApiUrl('/nodes'); - expect(baseUrl).toBe(config.api.url); - expect(endpointUrl).toBe(`${config.api.url}/nodes`); + expect(baseUrl).toBe(testConfig.api.url); + expect(endpointUrl).toBe(`${testConfig.api.url}/nodes`); }); it.skipIf(!isFeatureEnabled('mockExternalApis'))('should check feature flags', () => { - expect(config.features.mockExternalApis).toBe(true); + const testConfig = getTestConfig(); + expect(testConfig.features.mockExternalApis).toBe(true); expect(isFeatureEnabled('mockExternalApis')).toBe(true); }); @@ -135,9 +146,10 @@ describe('Test Environment Configuration Example', () => { }); it('should have proper logging configuration', () => { - expect(config.logging.level).toBe('error'); - expect(config.logging.debug).toBe(false); - expect(config.logging.showStack).toBe(true); + const testConfig = getTestConfig(); + expect(testConfig.logging.level).toBe('error'); + expect(testConfig.logging.debug).toBe(false); + expect(testConfig.logging.showStack).toBe(true); // Logger should respect configuration logger.debug('This should not appear in test output'); @@ -145,26 +157,30 @@ describe('Test Environment Configuration Example', () => { }); it('should have performance thresholds', () => { - expect(config.performance.thresholds.apiResponse).toBe(100); - expect(config.performance.thresholds.dbQuery).toBe(50); - expect(config.performance.thresholds.nodeParse).toBe(200); + const testConfig = getTestConfig(); + expect(testConfig.performance.thresholds.apiResponse).toBe(100); + expect(testConfig.performance.thresholds.dbQuery).toBe(50); + expect(testConfig.performance.thresholds.nodeParse).toBe(200); }); it('should disable caching and rate limiting in tests', () => { - expect(config.cache.enabled).toBe(false); - expect(config.cache.ttl).toBe(0); - expect(config.rateLimiting.max).toBe(0); - expect(config.rateLimiting.window).toBe(0); + const testConfig = getTestConfig(); + expect(testConfig.cache.enabled).toBe(false); + expect(testConfig.cache.ttl).toBe(0); + expect(testConfig.rateLimiting.max).toBe(0); + expect(testConfig.rateLimiting.window).toBe(0); }); it('should configure test paths', () => { - expect(config.paths.fixtures).toBe('./tests/fixtures'); - expect(config.paths.data).toBe('./tests/data'); - expect(config.paths.snapshots).toBe('./tests/__snapshots__'); + const testConfig = getTestConfig(); + expect(testConfig.paths.fixtures).toBe('./tests/fixtures'); + expect(testConfig.paths.data).toBe('./tests/data'); + expect(testConfig.paths.snapshots).toBe('./tests/__snapshots__'); }); it('should support MSW configuration', () => { - expect(config.mocking.msw.enabled).toBe(true); - expect(config.mocking.msw.apiDelay).toBe(0); + const testConfig = getTestConfig(); + expect(testConfig.mocking.msw.enabled).toBe(true); + expect(testConfig.mocking.msw.apiDelay).toBe(0); }); }); \ No newline at end of file