From 9fa1c4414902b6526aace477297db8150bc9a478 Mon Sep 17 00:00:00 2001
From: czlonkowski <56956555+czlonkowski@users.noreply.github.com>
Date: Mon, 29 Sep 2025 18:18:54 +0200
Subject: [PATCH] fix: remove false positive validation for Code node syntax

- Removed overly simplistic parenthesis pattern check that flagged valid code
- Pattern /)\s*)\s*{/ was incorrectly flagging valid n8n Code node patterns like:
  - .first().json (node data access)
  - func()() (function chaining)
  - array.map().filter() (method chaining)
- These are all valid JavaScript patterns used in n8n Code nodes
- Only kept check for excessive closing braces at end of code

This eliminates false positives for workflow 85blKFvzQYvZXnLF which uses
valid  syntax in Code nodes.
---
 src/services/node-specific-validators.ts | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/services/node-specific-validators.ts b/src/services/node-specific-validators.ts
index 53da79f..0875ee9 100644
--- a/src/services/node-specific-validators.ts
+++ b/src/services/node-specific-validators.ts
@@ -1132,8 +1132,11 @@ export class NodeSpecificValidators {
     const syntaxPatterns = [
       { pattern: /const\s+const/, message: 'Duplicate const declaration' },
       { pattern: /let\s+let/, message: 'Duplicate let declaration' },
-      { pattern: /\)\s*\)\s*{/, message: 'Extra closing parenthesis before {' },
-      { pattern: /}\s*}$/, message: 'Extra closing brace at end' }
+      // Removed overly simplistic parenthesis check - it was causing false positives
+      // for valid patterns like $('NodeName').first().json or func()()
+      // { pattern: /\)\s*\)\s*{/, message: 'Extra closing parenthesis before {' },
+      // Only check for multiple closing braces at the very end (more likely to be an error)
+      { pattern: /}\s*}\s*}\s*}$/, message: 'Multiple closing braces at end - check your nesting' }
     ];
     
     syntaxPatterns.forEach(({ pattern, message }) => {