ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-03-21 18:03:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(tests): implement Phase 2 integration testing - workflow creation tests

Browse Source 
Implements comprehensive workflow creation tests against real n8n instance
with 15 test scenarios covering P0 bugs, base nodes, advanced features,
error scenarios, and edge cases.

Key Changes:
- Added 15 workflow creation test scenarios in create-workflow.test.ts
- Fixed critical MSW interference with real API calls
- Fixed environment loading priority (.env before test defaults)
- Implemented multi-level cleanup with webhook workflow preservation
- Migrated from webhook IDs to webhook URLs configuration
- Added TypeScript type safety fixes (26 errors resolved)
- Updated test names to reflect actual n8n API behavior

Bug Fixes:
- Removed MSW from integration test setup (was blocking real API calls)
- Fixed .env loading order to preserve real credentials over test defaults
- Added type guards for undefined workflow IDs
- Fixed position arrays to use proper tuple types [number, number]
- Added literal types for executionOrder and settings values

Test Coverage:
- P0: Critical bug verification (FULL vs SHORT node type format)
- P1: Base n8n nodes (webhook, HTTP, langchain, multi-node)
- P2: Advanced features (connections, settings, expressions, error handling)
- Error scenarios (documents actual n8n API validation behavior)
- Edge cases (minimal workflows, empty connections, no settings)

Technical Improvements:
- Cleanup strategy preserves pre-activated webhook workflows
- Single webhook URL accepts all HTTP methods (GET, POST, PUT, DELETE)
- Environment-aware credential loading with validation
- Comprehensive test context for resource tracking

All 15 tests passing ✅
TypeScript: 0 errors ✅

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
czlonkowski
2025-10-04 09:30:43 +02:00
parent 4b764c6110
commit 9e1a4129c0
9 changed files with 816 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
tests/integration/n8n-api/utils/cleanup-helpers.ts
View File

@@ -62,13 +62,22 @@ export async function cleanupOrphanedWorkflows(): Promise<string[]> {
throw error;
}
// Find test workflows
const testWorkflows = allWorkflows.filter(w =>
w.tags?.includes(creds.cleanup.tag) ||
w.name?.startsWith(creds.cleanup.namePrefix)
);
// Pre-activated webhook workflow that should NOT be deleted
// This is needed for webhook trigger integration tests
// Note: Single webhook accepts all HTTP methods (GET, POST, PUT, DELETE)
const preservedWorkflowNames = new Set([
'[MCP-TEST] Webhook All Methods'
]);
logger.info(`Found ${testWorkflows.length} orphaned test workflow(s)`);
// Find test workflows but exclude pre-activated webhook workflows
const testWorkflows = allWorkflows.filter(w => {
const isTestWorkflow = w.tags?.includes(creds.cleanup.tag) || w.name?.startsWith(creds.cleanup.namePrefix);
const isPreserved = preservedWorkflowNames.has(w.name);
return isTestWorkflow && !isPreserved;
});
logger.info(`Found ${testWorkflows.length} orphaned test workflow(s) (excluding ${preservedWorkflowNames.size} preserved webhook workflow)`);
if (testWorkflows.length === 0) {
return deleted;