mirror of
https://github.com/czlonkowski/n8n-mcp.git
synced 2026-01-30 06:22:04 +00:00
feat: enhance workflow mutation telemetry for better AI responses (#419)
* feat: add comprehensive telemetry for partial workflow updates Implement telemetry infrastructure to track workflow mutations from partial update operations. This enables data-driven improvements to partial update tooling by capturing: - Workflow state before and after mutations - User intent and operation patterns - Validation results and improvements - Change metrics (nodes/connections modified) - Success/failure rates and error patterns New Components: - Intent classifier: Categorizes mutation patterns - Intent sanitizer: Removes PII from user instructions - Mutation validator: Ensures data quality before tracking - Mutation tracker: Coordinates validation and metric calculation Extended Components: - TelemetryManager: New trackWorkflowMutation() method - EventTracker: Mutation queue management - BatchProcessor: Mutation data flushing to Supabase MCP Tool Enhancements: - n8n_update_partial_workflow: Added optional 'intent' parameter - n8n_update_full_workflow: Added optional 'intent' parameter - Both tools now track mutations asynchronously Database Schema: - New workflow_mutations table with 20+ fields - Comprehensive indexes for efficient querying - Supports deduplication and data analysis This telemetry system is: - Privacy-focused (PII sanitization, anonymized users) - Non-blocking (async tracking, silent failures) - Production-ready (batching, retries, circuit breaker) - Backward compatible (all parameters optional) Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en * fix: correct SQL syntax for expression index in workflow_mutations schema The expression index for significant changes needs double parentheses around the arithmetic expression to be valid PostgreSQL syntax. Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en * fix: enable RLS policies for workflow_mutations table Enable Row-Level Security and add policies: - Allow anonymous (anon) inserts for telemetry data collection - Allow authenticated reads for data analysis and querying These policies are required for the telemetry system to function correctly with Supabase, as the MCP server uses the anon key to insert mutation data. Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en * fix: reduce mutation auto-flush threshold from 5 to 2 Lower the auto-flush threshold for workflow mutations from 5 to 2 to ensure more timely data persistence. Since mutations are less frequent than regular telemetry events, a lower threshold provides: - Faster data persistence (don't wait for 5 mutations) - Better testing experience (easier to verify with fewer operations) - Reduced risk of data loss if process exits before threshold - More responsive telemetry for low-volume mutation scenarios This complements the existing 5-second periodic flush and process exit handlers, ensuring mutations are persisted promptly. Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en * fix: improve mutation telemetry error logging and diagnostics Changes: - Upgrade error logging from debug to warn level for better visibility - Add diagnostic logging to track mutation processing - Log telemetry disabled state explicitly - Add context info (sessionId, intent, operationCount) to error logs - Remove 'await' from telemetry calls to make them truly non-blocking This will help identify why mutations aren't being persisted to the workflow_mutations table despite successful workflow operations. Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en * feat: enhance workflow mutation telemetry for better AI responses Improve workflow mutation tracking to capture comprehensive data that helps provide better responses when users update workflows. This enhancement collects workflow state, user intent, and operation details to enable more context-aware assistance. Key improvements: - Reduce auto-flush threshold from 5 to 2 for more reliable mutation tracking - Add comprehensive workflow and credential sanitization to mutation tracker - Document intent parameter in workflow update tools for better UX - Fix mutation queue handling in telemetry manager (flush now handles 3 queues) - Add extensive unit tests for mutation tracking and validation (35 new tests) Technical changes: - mutation-tracker.ts: Multi-layer sanitization (workflow, node, parameter levels) - batch-processor.ts: Support mutation data flushing to Supabase - telemetry-manager.ts: Auto-flush mutations at threshold 2, track mutations queue - handlers-workflow-diff.ts: Track workflow mutations with sanitized data - Tests: 13 tests for mutation-tracker, 22 tests for mutation-validator The intent parameter messaging emphasizes user benefit ("helps to return better response") rather than technical implementation details. Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: bump version to 2.22.16 with telemetry changelog Updated package.json and package.runtime.json to version 2.22.16. Added comprehensive CHANGELOG entry documenting workflow mutation telemetry enhancements for better AI-powered workflow assistance. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en Co-Authored-By: Claude <noreply@anthropic.com> * fix: resolve TypeScript lint errors in telemetry tests Fixed type issues in mutation-tracker and mutation-validator tests: - Import and use MutationToolName enum instead of string literals - Fix ValidationResult.errors to use proper object structure - Add UpdateNodeOperation type assertion for operation with nodeName All TypeScript errors resolved, lint now passes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Romuald Członkowski
committed by
GitHub
GitHub
parent
77151e013e
commit
99c5907b71
577
tests/unit/telemetry/mutation-tracker.test.ts
Normal file
577
tests/unit/telemetry/mutation-tracker.test.ts
Normal file
@@ -0,0 +1,577 @@
|
||||
/**
|
||||
* Unit tests for MutationTracker - Sanitization and Processing
|
||||
*/
|
||||
|
||||
import { describe, it, expect, beforeEach, vi } from 'vitest';
|
||||
import { MutationTracker } from '../../../src/telemetry/mutation-tracker';
|
||||
import { WorkflowMutationData, MutationToolName } from '../../../src/telemetry/mutation-types';
|
||||
|
||||
describe('MutationTracker', () => {
|
||||
let tracker: MutationTracker;
|
||||
|
||||
beforeEach(() => {
|
||||
tracker = new MutationTracker();
|
||||
tracker.clearRecentMutations();
|
||||
});
|
||||
|
||||
describe('Workflow Sanitization', () => {
|
||||
it('should remove credentials from workflow level', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test sanitization',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {},
|
||||
credentials: { apiKey: 'secret-key-123' },
|
||||
sharedWorkflows: ['user1', 'user2'],
|
||||
ownedBy: { id: 'user1', email: 'user@example.com' }
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test Updated',
|
||||
nodes: [],
|
||||
connections: {},
|
||||
credentials: { apiKey: 'secret-key-456' }
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
expect(result!.workflowBefore).toBeDefined();
|
||||
expect(result!.workflowBefore.credentials).toBeUndefined();
|
||||
expect(result!.workflowBefore.sharedWorkflows).toBeUndefined();
|
||||
expect(result!.workflowBefore.ownedBy).toBeUndefined();
|
||||
expect(result!.workflowAfter.credentials).toBeUndefined();
|
||||
});
|
||||
|
||||
it('should remove credentials from node level', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test node credentials',
|
||||
operations: [{ type: 'addNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [100, 100],
|
||||
credentials: {
|
||||
httpBasicAuth: {
|
||||
id: 'cred-123',
|
||||
name: 'My Auth'
|
||||
}
|
||||
},
|
||||
parameters: {
|
||||
url: 'https://api.example.com'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [100, 100],
|
||||
credentials: {
|
||||
httpBasicAuth: {
|
||||
id: 'cred-456',
|
||||
name: 'Updated Auth'
|
||||
}
|
||||
},
|
||||
parameters: {
|
||||
url: 'https://api.example.com'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 150
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
expect(result!.workflowBefore.nodes[0].credentials).toBeUndefined();
|
||||
expect(result!.workflowAfter.nodes[0].credentials).toBeUndefined();
|
||||
});
|
||||
|
||||
it('should redact API keys in parameters', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test API key redaction',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'OpenAI',
|
||||
type: 'n8n-nodes-base.openAi',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
apiKeyField: 'sk-1234567890abcdef1234567890abcdef',
|
||||
tokenField: 'Bearer abc123def456',
|
||||
config: {
|
||||
passwordField: 'secret-password-123'
|
||||
}
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'OpenAI',
|
||||
type: 'n8n-nodes-base.openAi',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
apiKeyField: 'sk-newkey567890abcdef1234567890abcdef'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 200
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const params = result!.workflowBefore.nodes[0].parameters;
|
||||
// Fields with sensitive key names are redacted
|
||||
expect(params.apiKeyField).toBe('[REDACTED]');
|
||||
expect(params.tokenField).toBe('[REDACTED]');
|
||||
expect(params.config.passwordField).toBe('[REDACTED]');
|
||||
});
|
||||
|
||||
it('should redact URLs with authentication', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test URL redaction',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
url: 'https://user:password@api.example.com/endpoint',
|
||||
webhookUrl: 'http://admin:secret@webhook.example.com'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const params = result!.workflowBefore.nodes[0].parameters;
|
||||
// URL auth is redacted but path is preserved
|
||||
expect(params.url).toBe('[REDACTED_URL_WITH_AUTH]/endpoint');
|
||||
expect(params.webhookUrl).toBe('[REDACTED_URL_WITH_AUTH]');
|
||||
});
|
||||
|
||||
it('should redact long tokens (32+ characters)', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test token redaction',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'Slack',
|
||||
type: 'n8n-nodes-base.slack',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
message: 'Token: test-token-1234567890-1234567890123-abcdefghijklmnopqrstuvwx'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const message = result!.workflowBefore.nodes[0].parameters.message;
|
||||
expect(message).toContain('[REDACTED_TOKEN]');
|
||||
});
|
||||
|
||||
it('should redact OpenAI-style keys', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test OpenAI key redaction',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'Code',
|
||||
type: 'n8n-nodes-base.code',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
code: 'const apiKey = "sk-proj-abcd1234efgh5678ijkl9012mnop3456";'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const code = result!.workflowBefore.nodes[0].parameters.code;
|
||||
// The 32+ char regex runs before OpenAI-specific regex, so it becomes [REDACTED_TOKEN]
|
||||
expect(code).toContain('[REDACTED_TOKEN]');
|
||||
});
|
||||
|
||||
it('should redact Bearer tokens', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test Bearer token redaction',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
headerParameters: {
|
||||
parameter: [
|
||||
{
|
||||
name: 'Authorization',
|
||||
value: 'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJzdWIiOiIxMjM0NTY3ODkwIiwibmFtZSI6IkpvaG4gRG9lIiwiaWF0IjoxNTE2MjM5MDIyfQ.SflKxwRJSMeKKF2QT4fwpMeJf36POk6yJV_adQssw5c'
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const authValue = result!.workflowBefore.nodes[0].parameters.headerParameters.parameter[0].value;
|
||||
expect(authValue).toBe('Bearer [REDACTED]');
|
||||
});
|
||||
|
||||
it('should preserve workflow structure while sanitizing', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test structure preservation',
|
||||
operations: [{ type: 'addNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'My Workflow',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'Start',
|
||||
type: 'n8n-nodes-base.start',
|
||||
position: [100, 100],
|
||||
parameters: {}
|
||||
},
|
||||
{
|
||||
id: 'node2',
|
||||
name: 'HTTP',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [300, 100],
|
||||
parameters: {
|
||||
url: 'https://api.example.com',
|
||||
apiKey: 'secret-key'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {
|
||||
Start: {
|
||||
main: [[{ node: 'HTTP', type: 'main', index: 0 }]]
|
||||
}
|
||||
},
|
||||
active: true,
|
||||
credentials: { apiKey: 'workflow-secret' }
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'My Workflow',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 150
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
// Check structure preserved
|
||||
expect(result!.workflowBefore.id).toBe('wf1');
|
||||
expect(result!.workflowBefore.name).toBe('My Workflow');
|
||||
expect(result!.workflowBefore.nodes).toHaveLength(2);
|
||||
expect(result!.workflowBefore.connections).toBeDefined();
|
||||
expect(result!.workflowBefore.active).toBe(true);
|
||||
|
||||
// Check credentials removed
|
||||
expect(result!.workflowBefore.credentials).toBeUndefined();
|
||||
|
||||
// Check node parameters sanitized
|
||||
expect(result!.workflowBefore.nodes[1].parameters.apiKey).toBe('[REDACTED]');
|
||||
|
||||
// Check connections preserved
|
||||
expect(result!.workflowBefore.connections.Start).toBeDefined();
|
||||
});
|
||||
|
||||
it('should handle nested objects recursively', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test nested sanitization',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'Complex Node',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
authentication: {
|
||||
type: 'oauth2',
|
||||
// Use 'settings' instead of 'credentials' since 'credentials' is a sensitive key
|
||||
settings: {
|
||||
clientId: 'safe-client-id',
|
||||
clientSecret: 'very-secret-key',
|
||||
nested: {
|
||||
apiKeyValue: 'deep-secret-key',
|
||||
tokenValue: 'nested-token'
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = await tracker.processMutation(data, 'test-user');
|
||||
|
||||
expect(result).toBeTruthy();
|
||||
const auth = result!.workflowBefore.nodes[0].parameters.authentication;
|
||||
// The key 'authentication' contains 'auth' which is sensitive, so entire object is redacted
|
||||
expect(auth).toBe('[REDACTED]');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Deduplication', () => {
|
||||
it('should detect and skip duplicate mutations', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'First mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test Updated',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
// First mutation should succeed
|
||||
const result1 = await tracker.processMutation(data, 'test-user');
|
||||
expect(result1).toBeTruthy();
|
||||
|
||||
// Exact duplicate should be skipped
|
||||
const result2 = await tracker.processMutation(data, 'test-user');
|
||||
expect(result2).toBeNull();
|
||||
});
|
||||
|
||||
it('should allow mutations with different workflows', async () => {
|
||||
const data1: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'First mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test 1',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test 1 Updated',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const data2: WorkflowMutationData = {
|
||||
...data1,
|
||||
workflowBefore: {
|
||||
id: 'wf2',
|
||||
name: 'Test 2',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf2',
|
||||
name: 'Test 2 Updated',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
}
|
||||
};
|
||||
|
||||
const result1 = await tracker.processMutation(data1, 'test-user');
|
||||
const result2 = await tracker.processMutation(data2, 'test-user');
|
||||
|
||||
expect(result1).toBeTruthy();
|
||||
expect(result2).toBeTruthy();
|
||||
});
|
||||
});
|
||||
|
||||
describe('Statistics', () => {
|
||||
it('should track recent mutations count', async () => {
|
||||
expect(tracker.getRecentMutationsCount()).toBe(0);
|
||||
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test counting',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test Updated', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
await tracker.processMutation(data, 'test-user');
|
||||
expect(tracker.getRecentMutationsCount()).toBe(1);
|
||||
|
||||
// Process another with different workflow
|
||||
const data2 = { ...data, workflowBefore: { ...data.workflowBefore, id: 'wf2' } };
|
||||
await tracker.processMutation(data2, 'test-user');
|
||||
expect(tracker.getRecentMutationsCount()).toBe(2);
|
||||
});
|
||||
|
||||
it('should clear recent mutations', async () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test clearing',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test Updated', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
await tracker.processMutation(data, 'test-user');
|
||||
expect(tracker.getRecentMutationsCount()).toBe(1);
|
||||
|
||||
tracker.clearRecentMutations();
|
||||
expect(tracker.getRecentMutationsCount()).toBe(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
557
tests/unit/telemetry/mutation-validator.test.ts
Normal file
557
tests/unit/telemetry/mutation-validator.test.ts
Normal file
@@ -0,0 +1,557 @@
|
||||
/**
|
||||
* Unit tests for MutationValidator - Data Quality Validation
|
||||
*/
|
||||
|
||||
import { describe, it, expect, beforeEach } from 'vitest';
|
||||
import { MutationValidator } from '../../../src/telemetry/mutation-validator';
|
||||
import { WorkflowMutationData, MutationToolName } from '../../../src/telemetry/mutation-types';
|
||||
import type { UpdateNodeOperation } from '../../../src/types/workflow-diff';
|
||||
|
||||
describe('MutationValidator', () => {
|
||||
let validator: MutationValidator;
|
||||
|
||||
beforeEach(() => {
|
||||
validator = new MutationValidator();
|
||||
});
|
||||
|
||||
describe('Workflow Structure Validation', () => {
|
||||
it('should accept valid workflow structure', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Valid mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test Updated',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(true);
|
||||
expect(result.errors).toHaveLength(0);
|
||||
});
|
||||
|
||||
it('should reject workflow without nodes array', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Invalid mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
connections: {}
|
||||
} as any,
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors).toContain('Invalid workflow_before structure');
|
||||
});
|
||||
|
||||
it('should reject workflow without connections object', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Invalid mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: []
|
||||
} as any,
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors).toContain('Invalid workflow_before structure');
|
||||
});
|
||||
|
||||
it('should reject null workflow', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Invalid mutation',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: null as any,
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors).toContain('Invalid workflow_before structure');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Workflow Size Validation', () => {
|
||||
it('should accept workflows within size limit', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Size test',
|
||||
operations: [{ type: 'addNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [{
|
||||
id: 'node1',
|
||||
name: 'Start',
|
||||
type: 'n8n-nodes-base.start',
|
||||
position: [100, 100],
|
||||
parameters: {}
|
||||
}],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(true);
|
||||
expect(result.errors).not.toContain(expect.stringContaining('size'));
|
||||
});
|
||||
|
||||
it('should reject oversized workflows', () => {
|
||||
// Create a very large workflow (over 500KB default limit)
|
||||
// 600KB string = 600,000 characters
|
||||
const largeArray = new Array(600000).fill('x').join('');
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Oversized test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [{
|
||||
id: 'node1',
|
||||
name: 'Large',
|
||||
type: 'n8n-nodes-base.code',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
code: largeArray
|
||||
}
|
||||
}],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors.some(err => err.includes('size') && err.includes('exceeds'))).toBe(true);
|
||||
});
|
||||
|
||||
it('should respect custom size limit', () => {
|
||||
const customValidator = new MutationValidator({ maxWorkflowSizeKb: 1 });
|
||||
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Custom size test',
|
||||
operations: [{ type: 'addNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [{
|
||||
id: 'node1',
|
||||
name: 'Medium',
|
||||
type: 'n8n-nodes-base.code',
|
||||
position: [100, 100],
|
||||
parameters: {
|
||||
code: 'x'.repeat(2000) // ~2KB
|
||||
}
|
||||
}],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = customValidator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors.some(err => err.includes('exceeds maximum (1KB)'))).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Intent Validation', () => {
|
||||
it('should warn about empty intent', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: '',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('User intent is empty');
|
||||
});
|
||||
|
||||
it('should warn about very short intent', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'fix',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('User intent is too short (less than 5 characters)');
|
||||
});
|
||||
|
||||
it('should warn about very long intent', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'x'.repeat(1001),
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('User intent is very long (over 1000 characters)');
|
||||
});
|
||||
|
||||
it('should accept good intent length', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Add error handling to API nodes',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).not.toContain(expect.stringContaining('intent'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('Operations Validation', () => {
|
||||
it('should reject empty operations array', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors).toContain('No operations provided');
|
||||
});
|
||||
|
||||
it('should accept operations array with items', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [
|
||||
{ type: 'addNode' },
|
||||
{ type: 'addConnection' }
|
||||
],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(true);
|
||||
expect(result.errors).not.toContain('No operations provided');
|
||||
});
|
||||
});
|
||||
|
||||
describe('Duration Validation', () => {
|
||||
it('should reject negative duration', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: -100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors).toContain('Duration cannot be negative');
|
||||
});
|
||||
|
||||
it('should warn about very long duration', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 400000 // Over 5 minutes
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('Duration is very long (over 5 minutes)');
|
||||
});
|
||||
|
||||
it('should accept reasonable duration', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
mutationSuccess: true,
|
||||
durationMs: 150
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(true);
|
||||
expect(result.warnings).not.toContain(expect.stringContaining('Duration'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('Meaningful Change Detection', () => {
|
||||
it('should warn when workflows are identical', () => {
|
||||
const workflow = {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'Start',
|
||||
type: 'n8n-nodes-base.start',
|
||||
position: [100, 100],
|
||||
parameters: {}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
};
|
||||
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'No actual change',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: workflow,
|
||||
workflowAfter: JSON.parse(JSON.stringify(workflow)), // Deep clone
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('No meaningful change detected between before and after workflows');
|
||||
});
|
||||
|
||||
it('should not warn when workflows are different', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Real change',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'Test',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'Test Updated',
|
||||
nodes: [],
|
||||
connections: {}
|
||||
},
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).not.toContain(expect.stringContaining('meaningful change'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('Validation Data Consistency', () => {
|
||||
it('should warn about invalid validation structure', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
validationBefore: { valid: 'yes' } as any, // Invalid structure
|
||||
validationAfter: { valid: true, errors: [] },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).toContain('Invalid validation_before structure');
|
||||
});
|
||||
|
||||
it('should accept valid validation structure', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Test',
|
||||
operations: [{ type: 'updateNode' }],
|
||||
workflowBefore: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
workflowAfter: { id: 'wf1', name: 'Test', nodes: [], connections: {} },
|
||||
validationBefore: { valid: false, errors: [{ type: 'test_error', message: 'Error 1' }] },
|
||||
validationAfter: { valid: true, errors: [] },
|
||||
mutationSuccess: true,
|
||||
durationMs: 100
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.warnings).not.toContain(expect.stringContaining('validation'));
|
||||
});
|
||||
});
|
||||
|
||||
describe('Comprehensive Validation', () => {
|
||||
it('should collect multiple errors and warnings', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: '', // Empty - warning
|
||||
operations: [], // Empty - error
|
||||
workflowBefore: null as any, // Invalid - error
|
||||
workflowAfter: { nodes: [] } as any, // Missing connections - error
|
||||
mutationSuccess: true,
|
||||
durationMs: -50 // Negative - error
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(false);
|
||||
expect(result.errors.length).toBeGreaterThan(0);
|
||||
expect(result.warnings.length).toBeGreaterThan(0);
|
||||
});
|
||||
|
||||
it('should pass validation with all criteria met', () => {
|
||||
const data: WorkflowMutationData = {
|
||||
sessionId: 'test-session-123',
|
||||
toolName: MutationToolName.UPDATE_PARTIAL,
|
||||
userIntent: 'Add error handling to HTTP Request nodes',
|
||||
operations: [
|
||||
{ type: 'updateNode', nodeName: 'node1', updates: { onError: 'continueErrorOutput' } } as UpdateNodeOperation
|
||||
],
|
||||
workflowBefore: {
|
||||
id: 'wf1',
|
||||
name: 'API Workflow',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [300, 200],
|
||||
parameters: {
|
||||
url: 'https://api.example.com',
|
||||
method: 'GET'
|
||||
}
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
workflowAfter: {
|
||||
id: 'wf1',
|
||||
name: 'API Workflow',
|
||||
nodes: [
|
||||
{
|
||||
id: 'node1',
|
||||
name: 'HTTP Request',
|
||||
type: 'n8n-nodes-base.httpRequest',
|
||||
position: [300, 200],
|
||||
parameters: {
|
||||
url: 'https://api.example.com',
|
||||
method: 'GET'
|
||||
},
|
||||
onError: 'continueErrorOutput'
|
||||
}
|
||||
],
|
||||
connections: {}
|
||||
},
|
||||
validationBefore: { valid: true, errors: [] },
|
||||
validationAfter: { valid: true, errors: [] },
|
||||
mutationSuccess: true,
|
||||
durationMs: 245
|
||||
};
|
||||
|
||||
const result = validator.validate(data);
|
||||
expect(result.valid).toBe(true);
|
||||
expect(result.errors).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -70,13 +70,18 @@ describe('TelemetryManager', () => {
|
||||
updateToolSequence: vi.fn(),
|
||||
getEventQueue: vi.fn().mockReturnValue([]),
|
||||
getWorkflowQueue: vi.fn().mockReturnValue([]),
|
||||
getMutationQueue: vi.fn().mockReturnValue([]),
|
||||
clearEventQueue: vi.fn(),
|
||||
clearWorkflowQueue: vi.fn(),
|
||||
clearMutationQueue: vi.fn(),
|
||||
enqueueMutation: vi.fn(),
|
||||
getMutationQueueSize: vi.fn().mockReturnValue(0),
|
||||
getStats: vi.fn().mockReturnValue({
|
||||
rateLimiter: { currentEvents: 0, droppedEvents: 0 },
|
||||
validator: { successes: 0, errors: 0 },
|
||||
eventQueueSize: 0,
|
||||
workflowQueueSize: 0,
|
||||
mutationQueueSize: 0,
|
||||
performanceMetrics: {}
|
||||
})
|
||||
};
|
||||
@@ -317,17 +322,21 @@ describe('TelemetryManager', () => {
|
||||
it('should flush events and workflows', async () => {
|
||||
const mockEvents = [{ user_id: 'user1', event: 'test', properties: {} }];
|
||||
const mockWorkflows = [{ user_id: 'user1', workflow_hash: 'hash1' }];
|
||||
const mockMutations: any[] = [];
|
||||
|
||||
mockEventTracker.getEventQueue.mockReturnValue(mockEvents);
|
||||
mockEventTracker.getWorkflowQueue.mockReturnValue(mockWorkflows);
|
||||
mockEventTracker.getMutationQueue.mockReturnValue(mockMutations);
|
||||
|
||||
await manager.flush();
|
||||
|
||||
expect(mockEventTracker.getEventQueue).toHaveBeenCalled();
|
||||
expect(mockEventTracker.getWorkflowQueue).toHaveBeenCalled();
|
||||
expect(mockEventTracker.getMutationQueue).toHaveBeenCalled();
|
||||
expect(mockEventTracker.clearEventQueue).toHaveBeenCalled();
|
||||
expect(mockEventTracker.clearWorkflowQueue).toHaveBeenCalled();
|
||||
expect(mockBatchProcessor.flush).toHaveBeenCalledWith(mockEvents, mockWorkflows);
|
||||
expect(mockEventTracker.clearMutationQueue).toHaveBeenCalled();
|
||||
expect(mockBatchProcessor.flush).toHaveBeenCalledWith(mockEvents, mockWorkflows, mockMutations);
|
||||
});
|
||||
|
||||
it('should not flush when disabled', async () => {
|
||||
|
||||
Reference in New Issue
Block a user