mirror of
https://github.com/czlonkowski/n8n-mcp.git
synced 2026-03-21 09:53:08 +00:00
Revert to v2.18.10 - Remove session persistence (v2.19.0-v2.19.5) (#322)
After 5 consecutive hotfix attempts, session persistence has proven architecturally incompatible with the MCP SDK. Rolling back to last known stable version. ## Removed - 16 new files (session types, docs, tests, planning docs) - 1,100+ lines of session persistence code - Session restoration hooks and lifecycle events - Retry policy and warm-start implementations ## Restored - Stable v2.18.10 codebase - Library export fields (from PR #310) - All core MCP functionality ## Breaking Changes - Session persistence APIs removed - onSessionNotFound hook removed - Session lifecycle events removed This reverts commitsfe13091through1d34ad8. Restores commit4566253(v2.18.10, PR #310). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Romuald Członkowski
committed by
GitHub
GitHub
parent
fe1309151a
commit
8d20c64f5c
@@ -9,7 +9,6 @@ import { Request, Response } from 'express';
|
||||
import { SingleSessionHTTPServer } from './http-server-single-session';
|
||||
import { logger } from './utils/logger';
|
||||
import { InstanceContext } from './types/instance-context';
|
||||
import { SessionRestoreHook, SessionState } from './types/session-restoration';
|
||||
|
||||
export interface EngineHealth {
|
||||
status: 'healthy' | 'unhealthy';
|
||||
@@ -26,71 +25,6 @@ export interface EngineHealth {
|
||||
export interface EngineOptions {
|
||||
sessionTimeout?: number;
|
||||
logLevel?: 'error' | 'warn' | 'info' | 'debug';
|
||||
|
||||
/**
|
||||
* Session restoration hook for multi-tenant persistence
|
||||
* Called when a client tries to use an unknown session ID
|
||||
* Return instance context to restore the session, or null to reject
|
||||
*
|
||||
* @security IMPORTANT: Implement rate limiting in this hook to prevent abuse.
|
||||
* Malicious clients could trigger excessive database lookups by sending random
|
||||
* session IDs. Consider using express-rate-limit or similar middleware.
|
||||
*
|
||||
* @since 2.19.0
|
||||
*/
|
||||
onSessionNotFound?: SessionRestoreHook;
|
||||
|
||||
/**
|
||||
* Maximum time to wait for session restoration (milliseconds)
|
||||
* @default 5000 (5 seconds)
|
||||
* @since 2.19.0
|
||||
*/
|
||||
sessionRestorationTimeout?: number;
|
||||
|
||||
/**
|
||||
* Session lifecycle event handlers (Phase 3 - REQ-4)
|
||||
*
|
||||
* Optional callbacks for session lifecycle events:
|
||||
* - onSessionCreated: Called when a new session is created
|
||||
* - onSessionRestored: Called when a session is restored from storage
|
||||
* - onSessionAccessed: Called on EVERY request (consider throttling!)
|
||||
* - onSessionExpired: Called when a session expires
|
||||
* - onSessionDeleted: Called when a session is manually deleted
|
||||
*
|
||||
* All handlers are fire-and-forget (non-blocking).
|
||||
* Errors are logged but don't affect session operations.
|
||||
*
|
||||
* @since 2.19.0
|
||||
*/
|
||||
sessionEvents?: {
|
||||
onSessionCreated?: (sessionId: string, instanceContext: InstanceContext) => void | Promise<void>;
|
||||
onSessionRestored?: (sessionId: string, instanceContext: InstanceContext) => void | Promise<void>;
|
||||
onSessionAccessed?: (sessionId: string) => void | Promise<void>;
|
||||
onSessionExpired?: (sessionId: string) => void | Promise<void>;
|
||||
onSessionDeleted?: (sessionId: string) => void | Promise<void>;
|
||||
};
|
||||
|
||||
/**
|
||||
* Number of retry attempts for failed session restoration (Phase 4 - REQ-7)
|
||||
*
|
||||
* When the restoration hook throws an error, the system will retry
|
||||
* up to this many times with a delay between attempts.
|
||||
*
|
||||
* Timeout errors are NOT retried (already took too long).
|
||||
* The overall timeout applies to ALL retry attempts combined.
|
||||
*
|
||||
* @default 0 (no retries, opt-in)
|
||||
* @since 2.19.0
|
||||
*/
|
||||
sessionRestorationRetries?: number;
|
||||
|
||||
/**
|
||||
* Delay between retry attempts in milliseconds (Phase 4 - REQ-7)
|
||||
*
|
||||
* @default 100 (100 milliseconds)
|
||||
* @since 2.19.0
|
||||
*/
|
||||
sessionRestorationRetryDelay?: number;
|
||||
}
|
||||
|
||||
export class N8NMCPEngine {
|
||||
@@ -98,9 +32,9 @@ export class N8NMCPEngine {
|
||||
private startTime: Date;
|
||||
|
||||
constructor(options: EngineOptions = {}) {
|
||||
this.server = new SingleSessionHTTPServer(options);
|
||||
this.server = new SingleSessionHTTPServer();
|
||||
this.startTime = new Date();
|
||||
|
||||
|
||||
if (options.logLevel) {
|
||||
process.env.LOG_LEVEL = options.logLevel;
|
||||
}
|
||||
@@ -163,7 +97,7 @@ export class N8NMCPEngine {
|
||||
total: Math.round(memoryUsage.heapTotal / 1024 / 1024),
|
||||
unit: 'MB'
|
||||
},
|
||||
version: '2.19.4'
|
||||
version: '2.3.2'
|
||||
};
|
||||
} catch (error) {
|
||||
logger.error('Health check failed:', error);
|
||||
@@ -172,7 +106,7 @@ export class N8NMCPEngine {
|
||||
uptime: 0,
|
||||
sessionActive: false,
|
||||
memoryUsage: { used: 0, total: 0, unit: 'MB' },
|
||||
version: '2.19.4'
|
||||
version: '2.3.2'
|
||||
};
|
||||
}
|
||||
}
|
||||
@@ -184,118 +118,10 @@ export class N8NMCPEngine {
|
||||
getSessionInfo(): { active: boolean; sessionId?: string; age?: number } {
|
||||
return this.server.getSessionInfo();
|
||||
}
|
||||
|
||||
/**
|
||||
* Get all active session IDs (Phase 2 - REQ-5)
|
||||
* Returns array of currently active session IDs
|
||||
*
|
||||
* @returns Array of session IDs
|
||||
* @since 2.19.0
|
||||
*
|
||||
* @example
|
||||
* ```typescript
|
||||
* const engine = new N8NMCPEngine();
|
||||
* const sessionIds = engine.getActiveSessions();
|
||||
* console.log(`Active sessions: ${sessionIds.length}`);
|
||||
* ```
|
||||
*/
|
||||
getActiveSessions(): string[] {
|
||||
return this.server.getActiveSessions();
|
||||
}
|
||||
|
||||
/**
|
||||
* Get session state for a specific session (Phase 2 - REQ-5)
|
||||
* Returns session state or null if session doesn't exist
|
||||
*
|
||||
* @param sessionId - The session ID to get state for
|
||||
* @returns SessionState object or null
|
||||
* @since 2.19.0
|
||||
*
|
||||
* @example
|
||||
* ```typescript
|
||||
* const state = engine.getSessionState('session-123');
|
||||
* if (state) {
|
||||
* // Save to database
|
||||
* await db.saveSession(state);
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
getSessionState(sessionId: string): SessionState | null {
|
||||
return this.server.getSessionState(sessionId);
|
||||
}
|
||||
|
||||
/**
|
||||
* Get all session states (Phase 2 - REQ-5)
|
||||
* Returns array of all active session states for bulk backup
|
||||
*
|
||||
* @returns Array of SessionState objects
|
||||
* @since 2.19.0
|
||||
*
|
||||
* @example
|
||||
* ```typescript
|
||||
* // Periodic backup every 5 minutes
|
||||
* setInterval(async () => {
|
||||
* const states = engine.getAllSessionStates();
|
||||
* for (const state of states) {
|
||||
* await database.upsertSession(state);
|
||||
* }
|
||||
* }, 300000);
|
||||
* ```
|
||||
*/
|
||||
getAllSessionStates(): SessionState[] {
|
||||
return this.server.getAllSessionStates();
|
||||
}
|
||||
|
||||
/**
|
||||
* Manually restore a session (Phase 2 - REQ-5)
|
||||
* Creates a session with the given ID and instance context
|
||||
*
|
||||
* @param sessionId - The session ID to restore
|
||||
* @param instanceContext - Instance configuration
|
||||
* @returns true if session was restored successfully, false otherwise
|
||||
* @since 2.19.0
|
||||
*
|
||||
* @example
|
||||
* ```typescript
|
||||
* // Restore session from database
|
||||
* const session = await db.loadSession('session-123');
|
||||
* if (session) {
|
||||
* const restored = engine.restoreSession(
|
||||
* session.sessionId,
|
||||
* session.instanceContext
|
||||
* );
|
||||
* console.log(`Restored: ${restored}`);
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
restoreSession(sessionId: string, instanceContext: InstanceContext): boolean {
|
||||
return this.server.manuallyRestoreSession(sessionId, instanceContext);
|
||||
}
|
||||
|
||||
/**
|
||||
* Manually delete a session (Phase 2 - REQ-5)
|
||||
* Removes the session and cleans up resources
|
||||
*
|
||||
* @param sessionId - The session ID to delete
|
||||
* @returns true if session was deleted, false if not found
|
||||
* @since 2.19.0
|
||||
*
|
||||
* @example
|
||||
* ```typescript
|
||||
* // Delete expired session
|
||||
* const deleted = engine.deleteSession('session-123');
|
||||
* if (deleted) {
|
||||
* await db.deleteSession('session-123');
|
||||
* }
|
||||
* ```
|
||||
*/
|
||||
deleteSession(sessionId: string): boolean {
|
||||
return this.server.manuallyDeleteSession(sessionId);
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Graceful shutdown for service lifecycle
|
||||
*
|
||||
*
|
||||
* @example
|
||||
* process.on('SIGTERM', async () => {
|
||||
* await engine.shutdown();
|
||||
|
||||
Reference in New Issue
Block a user