Merge pull request #130 from czlonkowski/feature/validation-improvements
## [2.10.3] - 2025-08-07 ### Fixed - **Validation System Robustness**: Fixed multiple critical validation issues affecting AI agents and workflow validation (fixes #58, #68, #70, #73) - **Issue #73**: Fixed `validate_node_minimal` crash when config is undefined - Added safe property access with optional chaining (`config?.resource`) - Tool now handles undefined, null, and malformed configs gracefully - **Issue #58**: Fixed `validate_node_operation` crash on invalid nodeType - Added type checking before calling string methods - Prevents "Cannot read properties of undefined (reading 'replace')" error - **Issue #70**: Fixed validation profile settings being ignored - Extended profile parameter to all validation phases (nodes, connections, expressions) - Added Sticky Notes filtering to reduce false positives - Enhanced cycle detection to allow legitimate loops (SplitInBatches) - **Issue #68**: Added error recovery suggestions for AI agents - New `addErrorRecoverySuggestions()` method provides actionable recovery steps - Categorizes errors and suggests specific fixes for each type - Helps AI agents self-correct when validation fails ### Added - **Input Validation System**: Comprehensive validation for all MCP tool inputs - Created `validation-schemas.ts` with custom validation utilities - No external dependencies - pure TypeScript implementation - Tool-specific validation schemas for all MCP tools - Clear error messages with field-level details - **Enhanced Cycle Detection**: Improved detection of legitimate loops vs actual cycles - Recognizes SplitInBatches loop patterns as valid - Reduces false positive cycle warnings - **Comprehensive Test Suite**: Added 16 tests covering all validation fixes - Tests for crash prevention with malformed inputs - Tests for profile behavior across validation phases - Tests for error recovery suggestions - Tests for legitimate loop patterns ### Enhanced - **Validation Profiles**: Now consistently applied across all validation phases - `minimal`: Reduces warnings for basic validation - `runtime`: Standard validation for production workflows - `ai-friendly`: Optimized for AI agent workflow creation - `strict`: Maximum validation for critical workflows - **Error Messages**: More helpful and actionable for both humans and AI agents - Specific recovery suggestions for common errors - Clear guidance on fixing validation issues - Examples of correct configurations
This commit is contained in:
Romuald Członkowski
102
.claude/agents/n8n-mcp-tester.md
Normal file
102
.claude/agents/n8n-mcp-tester.md
Normal file
@@ -0,0 +1,102 @@
|
|||||||
|
---
|
||||||
|
name: n8n-mcp-tester
|
||||||
|
description: Use this agent when you need to test n8n-mcp functionality after implementing fixes or new features. This agent should be invoked proactively after code changes to validate that the MCP tools work correctly with real n8n workflows. The agent tests the actual MCP server tools, not just unit tests. Examples:\n\n<example>\nContext: Developer has just fixed a validation bug in the n8n-mcp server\nuser: "I've fixed the validation issue for HTTP Request nodes"\nassistant: "I've completed the fix. Now let me build the project and then test it."\n<builds project>\nassistant: "Project built successfully. Please reload the MCP server in Claude Desktop to apply the changes."\nuser: "Reloaded"\nassistant: "Great! Now let me invoke the n8n-mcp-tester agent to verify the fix works correctly."\n<commentary>\nSince a fix has been implemented and the MCP server reloaded, use the n8n-mcp-tester agent to validate the fix works in real-world usage.\n</commentary>\n</example>\n\n<example>\nContext: Developer has added a new MCP tool for workflow validation\nuser: "I've implemented the new workflow validation tool"\nassistant: "Implementation complete. Let me build and prepare for testing."\n<builds project>\nassistant: "Build successful. Please reload the MCP server to load the new tool."\nuser: "Done"\nassistant: "Perfect! I'll now use the n8n-mcp-tester agent to test the new workflow validation tool."\n<commentary>\nAfter implementing new MCP functionality and reloading the server, invoke n8n-mcp-tester to verify it works correctly.\n</commentary>\n</example>
|
||||||
|
tools: Glob, Grep, LS, Read, WebFetch, TodoWrite, WebSearch, mcp__puppeteer__puppeteer_navigate, mcp__puppeteer__puppeteer_screenshot, mcp__puppeteer__puppeteer_click, mcp__puppeteer__puppeteer_fill, mcp__puppeteer__puppeteer_select, mcp__puppeteer__puppeteer_hover, mcp__puppeteer__puppeteer_evaluate, ListMcpResourcesTool, ReadMcpResourceTool, mcp__supabase__list_organizations, mcp__supabase__get_organization, mcp__supabase__list_projects, mcp__supabase__get_project, mcp__supabase__get_cost, mcp__supabase__confirm_cost, mcp__supabase__create_project, mcp__supabase__pause_project, mcp__supabase__restore_project, mcp__supabase__create_branch, mcp__supabase__list_branches, mcp__supabase__delete_branch, mcp__supabase__merge_branch, mcp__supabase__reset_branch, mcp__supabase__rebase_branch, mcp__supabase__list_tables, mcp__supabase__list_extensions, mcp__supabase__list_migrations, mcp__supabase__apply_migration, mcp__supabase__execute_sql, mcp__supabase__get_logs, mcp__supabase__get_advisors, mcp__supabase__get_project_url, mcp__supabase__get_anon_key, mcp__supabase__generate_typescript_types, mcp__supabase__search_docs, mcp__supabase__list_edge_functions, mcp__supabase__deploy_edge_function, mcp__n8n-mcp__tools_documentation, mcp__n8n-mcp__list_nodes, mcp__n8n-mcp__get_node_info, mcp__n8n-mcp__search_nodes, mcp__n8n-mcp__list_ai_tools, mcp__n8n-mcp__get_node_documentation, mcp__n8n-mcp__get_database_statistics, mcp__n8n-mcp__get_node_essentials, mcp__n8n-mcp__search_node_properties, mcp__n8n-mcp__get_node_for_task, mcp__n8n-mcp__list_tasks, mcp__n8n-mcp__validate_node_operation, mcp__n8n-mcp__validate_node_minimal, mcp__n8n-mcp__get_property_dependencies, mcp__n8n-mcp__get_node_as_tool_info, mcp__n8n-mcp__list_node_templates, mcp__n8n-mcp__get_template, mcp__n8n-mcp__search_templates, mcp__n8n-mcp__get_templates_for_task, mcp__n8n-mcp__validate_workflow, mcp__n8n-mcp__validate_workflow_connections, mcp__n8n-mcp__validate_workflow_expressions, mcp__n8n-mcp__n8n_create_workflow, mcp__n8n-mcp__n8n_get_workflow, mcp__n8n-mcp__n8n_get_workflow_details, mcp__n8n-mcp__n8n_get_workflow_structure, mcp__n8n-mcp__n8n_get_workflow_minimal, mcp__n8n-mcp__n8n_update_full_workflow, mcp__n8n-mcp__n8n_update_partial_workflow, mcp__n8n-mcp__n8n_delete_workflow, mcp__n8n-mcp__n8n_list_workflows, mcp__n8n-mcp__n8n_validate_workflow, mcp__n8n-mcp__n8n_trigger_webhook_workflow, mcp__n8n-mcp__n8n_get_execution, mcp__n8n-mcp__n8n_list_executions, mcp__n8n-mcp__n8n_delete_execution, mcp__n8n-mcp__n8n_health_check, mcp__n8n-mcp__n8n_list_available_tools, mcp__n8n-mcp__n8n_diagnostic
|
||||||
|
model: sonnet
|
||||||
|
---
|
||||||
|
|
||||||
|
You are n8n-mcp-tester, a specialized testing agent for the n8n Model Context Protocol (MCP) server. You validate that MCP tools and functionality work correctly in real-world scenarios after fixes or new features are implemented.
|
||||||
|
|
||||||
|
## Your Core Responsibilities
|
||||||
|
|
||||||
|
You test the n8n-mcp server by:
|
||||||
|
1. Using MCP tools to build, validate, and manipulate n8n workflows
|
||||||
|
2. Verifying that recent fixes resolve the reported issues
|
||||||
|
3. Testing new functionality works as designed
|
||||||
|
4. Reporting clear, actionable results back to the invoking agent
|
||||||
|
|
||||||
|
## Testing Methodology
|
||||||
|
|
||||||
|
When invoked with a test request, you will:
|
||||||
|
|
||||||
|
1. **Understand the Context**: Identify what was fixed or added based on the instructions from the invoking agent
|
||||||
|
|
||||||
|
2. **Design Test Scenarios**: Create specific test cases that:
|
||||||
|
- Target the exact functionality that was changed
|
||||||
|
- Include both positive and negative test cases
|
||||||
|
- Test edge cases and boundary conditions
|
||||||
|
- Use realistic n8n workflow configurations
|
||||||
|
|
||||||
|
3. **Execute Tests Using MCP Tools**: You have access to all n8n-mcp tools including:
|
||||||
|
- `search_nodes`: Find relevant n8n nodes
|
||||||
|
- `get_node_info`: Get detailed node configuration
|
||||||
|
- `get_node_essentials`: Get simplified node information
|
||||||
|
- `validate_node_config`: Validate node configurations
|
||||||
|
- `n8n_validate_workflow`: Validate complete workflows
|
||||||
|
- `get_node_example`: Get working examples
|
||||||
|
- `search_templates`: Find workflow templates
|
||||||
|
- Additional tools as available in the MCP server
|
||||||
|
|
||||||
|
4. **Verify Expected Behavior**:
|
||||||
|
- Confirm fixes resolve the original issue
|
||||||
|
- Verify new features work as documented
|
||||||
|
- Check for regressions in related functionality
|
||||||
|
- Test error handling and edge cases
|
||||||
|
|
||||||
|
5. **Report Results**: Provide clear feedback including:
|
||||||
|
- What was tested (specific tools and scenarios)
|
||||||
|
- Whether the fix/feature works as expected
|
||||||
|
- Any unexpected behaviors or issues discovered
|
||||||
|
- Specific error messages if failures occur
|
||||||
|
- Recommendations for additional testing if needed
|
||||||
|
|
||||||
|
## Testing Guidelines
|
||||||
|
|
||||||
|
- **Be Thorough**: Test multiple variations and edge cases
|
||||||
|
- **Be Specific**: Use exact node types, properties, and configurations mentioned in the fix
|
||||||
|
- **Be Realistic**: Create test scenarios that mirror actual n8n usage
|
||||||
|
- **Be Clear**: Report results in a structured, easy-to-understand format
|
||||||
|
- **Be Efficient**: Focus testing on the changed functionality first
|
||||||
|
|
||||||
|
## Example Test Execution
|
||||||
|
|
||||||
|
If testing a validation fix for HTTP Request nodes:
|
||||||
|
1. Call `tools_documentation` to get a list of available tools and get documentation on `search_nodes` tool.
|
||||||
|
2. Search for HTTP Request node using `search_nodes`
|
||||||
|
3. Get node configuration with `get_node_info` or `get_node_essentials`
|
||||||
|
4. Create test configurations that previously failed
|
||||||
|
5. Validate using `validate_node_config` with different profiles
|
||||||
|
6. Test in a complete workflow using `n8n_validate_workflow`
|
||||||
|
6. Report whether validation now works correctly
|
||||||
|
|
||||||
|
## Important Constraints
|
||||||
|
|
||||||
|
- You can only test using the MCP tools available in the server
|
||||||
|
- You cannot modify code or files - only test existing functionality
|
||||||
|
- You must work with the current state of the MCP server (already reloaded)
|
||||||
|
- Focus on functional testing, not unit testing
|
||||||
|
- Report issues objectively without attempting to fix them
|
||||||
|
|
||||||
|
## Response Format
|
||||||
|
|
||||||
|
Structure your test results as:
|
||||||
|
|
||||||
|
```
|
||||||
|
### Test Report: [Feature/Fix Name]
|
||||||
|
|
||||||
|
**Test Objective**: [What was being tested]
|
||||||
|
|
||||||
|
**Test Scenarios**:
|
||||||
|
1. [Scenario 1]: ✅/❌ [Result]
|
||||||
|
2. [Scenario 2]: ✅/❌ [Result]
|
||||||
|
|
||||||
|
**Findings**:
|
||||||
|
- [Key finding 1]
|
||||||
|
- [Key finding 2]
|
||||||
|
|
||||||
|
**Conclusion**: [Overall assessment - works as expected / issues found]
|
||||||
|
|
||||||
|
**Details**: [Any error messages, unexpected behaviors, or additional context]
|
||||||
|
```
|
||||||
|
|
||||||
|
Remember: Your role is to validate that the n8n-mcp server works correctly in practice, providing confidence that fixes and new features function as intended before deployment.
|
||||||
@@ -180,6 +180,9 @@ The MCP server exposes tools in several categories:
|
|||||||
- Sub-agents are not allowed to spawn further sub-agents
|
- Sub-agents are not allowed to spawn further sub-agents
|
||||||
- When you use sub-agents, do not allow them to commit and push. That should be done by you
|
- When you use sub-agents, do not allow them to commit and push. That should be done by you
|
||||||
|
|
||||||
|
### Development Best Practices
|
||||||
|
- Run typecheck and lint after every code change
|
||||||
|
|
||||||
# important-instruction-reminders
|
# important-instruction-reminders
|
||||||
Do what has been asked; nothing more, nothing less.
|
Do what has been asked; nothing more, nothing less.
|
||||||
NEVER create files unless they're absolutely necessary for achieving your goal.
|
NEVER create files unless they're absolutely necessary for achieving your goal.
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
[](https://opensource.org/licenses/MIT)
|
[](https://opensource.org/licenses/MIT)
|
||||||
[](https://github.com/czlonkowski/n8n-mcp)
|
[](https://github.com/czlonkowski/n8n-mcp)
|
||||||
[](https://github.com/czlonkowski/n8n-mcp)
|
[](https://github.com/czlonkowski/n8n-mcp)
|
||||||
[](https://www.npmjs.com/package/n8n-mcp)
|
[](https://www.npmjs.com/package/n8n-mcp)
|
||||||
[](https://codecov.io/gh/czlonkowski/n8n-mcp)
|
[](https://codecov.io/gh/czlonkowski/n8n-mcp)
|
||||||
[](https://github.com/czlonkowski/n8n-mcp/actions)
|
[](https://github.com/czlonkowski/n8n-mcp/actions)
|
||||||
|
|||||||
BIN
data/nodes.db
BIN
data/nodes.db
Binary file not shown.
@@ -7,6 +7,51 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||||||
|
|
||||||
## [Unreleased]
|
## [Unreleased]
|
||||||
|
|
||||||
|
## [2.10.3] - 2025-08-07
|
||||||
|
|
||||||
|
### Fixed
|
||||||
|
- **Validation System Robustness**: Fixed multiple critical validation issues affecting AI agents and workflow validation (fixes #58, #68, #70, #73)
|
||||||
|
- **Issue #73**: Fixed `validate_node_minimal` crash when config is undefined
|
||||||
|
- Added safe property access with optional chaining (`config?.resource`)
|
||||||
|
- Tool now handles undefined, null, and malformed configs gracefully
|
||||||
|
- **Issue #58**: Fixed `validate_node_operation` crash on invalid nodeType
|
||||||
|
- Added type checking before calling string methods
|
||||||
|
- Prevents "Cannot read properties of undefined (reading 'replace')" error
|
||||||
|
- **Issue #70**: Fixed validation profile settings being ignored
|
||||||
|
- Extended profile parameter to all validation phases (nodes, connections, expressions)
|
||||||
|
- Added Sticky Notes filtering to reduce false positives
|
||||||
|
- Enhanced cycle detection to allow legitimate loops (SplitInBatches)
|
||||||
|
- **Issue #68**: Added error recovery suggestions for AI agents
|
||||||
|
- New `addErrorRecoverySuggestions()` method provides actionable recovery steps
|
||||||
|
- Categorizes errors and suggests specific fixes for each type
|
||||||
|
- Helps AI agents self-correct when validation fails
|
||||||
|
|
||||||
|
### Added
|
||||||
|
- **Input Validation System**: Comprehensive validation for all MCP tool inputs
|
||||||
|
- Created `validation-schemas.ts` with custom validation utilities
|
||||||
|
- No external dependencies - pure TypeScript implementation
|
||||||
|
- Tool-specific validation schemas for all MCP tools
|
||||||
|
- Clear error messages with field-level details
|
||||||
|
- **Enhanced Cycle Detection**: Improved detection of legitimate loops vs actual cycles
|
||||||
|
- Recognizes SplitInBatches loop patterns as valid
|
||||||
|
- Reduces false positive cycle warnings
|
||||||
|
- **Comprehensive Test Suite**: Added 16 tests covering all validation fixes
|
||||||
|
- Tests for crash prevention with malformed inputs
|
||||||
|
- Tests for profile behavior across validation phases
|
||||||
|
- Tests for error recovery suggestions
|
||||||
|
- Tests for legitimate loop patterns
|
||||||
|
|
||||||
|
### Enhanced
|
||||||
|
- **Validation Profiles**: Now consistently applied across all validation phases
|
||||||
|
- `minimal`: Reduces warnings for basic validation
|
||||||
|
- `runtime`: Standard validation for production workflows
|
||||||
|
- `ai-friendly`: Optimized for AI agent workflow creation
|
||||||
|
- `strict`: Maximum validation for critical workflows
|
||||||
|
- **Error Messages**: More helpful and actionable for both humans and AI agents
|
||||||
|
- Specific recovery suggestions for common errors
|
||||||
|
- Clear guidance on fixing validation issues
|
||||||
|
- Examples of correct configurations
|
||||||
|
|
||||||
## [2.10.2] - 2025-08-05
|
## [2.10.2] - 2025-08-05
|
||||||
|
|
||||||
### Updated
|
### Updated
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "n8n-mcp",
|
"name": "n8n-mcp",
|
||||||
"version": "2.10.2",
|
"version": "2.10.3",
|
||||||
"description": "Integration between n8n workflow automation and Model Context Protocol (MCP)",
|
"description": "Integration between n8n workflow automation and Model Context Protocol (MCP)",
|
||||||
"main": "dist/index.js",
|
"main": "dist/index.js",
|
||||||
"bin": {
|
"bin": {
|
||||||
|
|||||||
@@ -28,6 +28,7 @@ import { handleUpdatePartialWorkflow } from './handlers-workflow-diff';
|
|||||||
import { getToolDocumentation, getToolsOverview } from './tools-documentation';
|
import { getToolDocumentation, getToolsOverview } from './tools-documentation';
|
||||||
import { PROJECT_VERSION } from '../utils/version';
|
import { PROJECT_VERSION } from '../utils/version';
|
||||||
import { normalizeNodeType, getNodeTypeAlternatives, getWorkflowNodeType } from '../utils/node-utils';
|
import { normalizeNodeType, getNodeTypeAlternatives, getWorkflowNodeType } from '../utils/node-utils';
|
||||||
|
import { ToolValidation, Validator, ValidationError } from '../utils/validation-schemas';
|
||||||
import {
|
import {
|
||||||
negotiateProtocolVersion,
|
negotiateProtocolVersion,
|
||||||
logProtocolNegotiation,
|
logProtocolNegotiation,
|
||||||
@@ -460,9 +461,77 @@ export class N8NDocumentationMCPServer {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Validate required parameters for tool execution
|
* Enhanced parameter validation using schemas
|
||||||
*/
|
*/
|
||||||
private validateToolParams(toolName: string, args: any, requiredParams: string[]): void {
|
private validateToolParams(toolName: string, args: any, legacyRequiredParams?: string[]): void {
|
||||||
|
try {
|
||||||
|
// If legacy required params are provided, use the new validation but fall back to basic if needed
|
||||||
|
let validationResult;
|
||||||
|
|
||||||
|
switch (toolName) {
|
||||||
|
case 'validate_node_operation':
|
||||||
|
validationResult = ToolValidation.validateNodeOperation(args);
|
||||||
|
break;
|
||||||
|
case 'validate_node_minimal':
|
||||||
|
validationResult = ToolValidation.validateNodeMinimal(args);
|
||||||
|
break;
|
||||||
|
case 'validate_workflow':
|
||||||
|
case 'validate_workflow_connections':
|
||||||
|
case 'validate_workflow_expressions':
|
||||||
|
validationResult = ToolValidation.validateWorkflow(args);
|
||||||
|
break;
|
||||||
|
case 'search_nodes':
|
||||||
|
validationResult = ToolValidation.validateSearchNodes(args);
|
||||||
|
break;
|
||||||
|
case 'list_node_templates':
|
||||||
|
validationResult = ToolValidation.validateListNodeTemplates(args);
|
||||||
|
break;
|
||||||
|
case 'n8n_create_workflow':
|
||||||
|
validationResult = ToolValidation.validateCreateWorkflow(args);
|
||||||
|
break;
|
||||||
|
case 'n8n_get_workflow':
|
||||||
|
case 'n8n_get_workflow_details':
|
||||||
|
case 'n8n_get_workflow_structure':
|
||||||
|
case 'n8n_get_workflow_minimal':
|
||||||
|
case 'n8n_update_full_workflow':
|
||||||
|
case 'n8n_delete_workflow':
|
||||||
|
case 'n8n_validate_workflow':
|
||||||
|
case 'n8n_get_execution':
|
||||||
|
case 'n8n_delete_execution':
|
||||||
|
validationResult = ToolValidation.validateWorkflowId(args);
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
// For tools not yet migrated to schema validation, use basic validation
|
||||||
|
return this.validateToolParamsBasic(toolName, args, legacyRequiredParams || []);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!validationResult.valid) {
|
||||||
|
const errorMessage = Validator.formatErrors(validationResult, toolName);
|
||||||
|
logger.error(`Parameter validation failed for ${toolName}:`, errorMessage);
|
||||||
|
throw new ValidationError(errorMessage);
|
||||||
|
}
|
||||||
|
} catch (error) {
|
||||||
|
// Handle validation errors properly
|
||||||
|
if (error instanceof ValidationError) {
|
||||||
|
throw error; // Re-throw validation errors as-is
|
||||||
|
}
|
||||||
|
|
||||||
|
// Handle unexpected errors from validation system
|
||||||
|
logger.error(`Validation system error for ${toolName}:`, error);
|
||||||
|
|
||||||
|
// Provide a user-friendly error message
|
||||||
|
const errorMessage = error instanceof Error
|
||||||
|
? `Internal validation error: ${error.message}`
|
||||||
|
: `Internal validation error while processing ${toolName}`;
|
||||||
|
|
||||||
|
throw new Error(errorMessage);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Legacy parameter validation (fallback)
|
||||||
|
*/
|
||||||
|
private validateToolParamsBasic(toolName: string, args: any, requiredParams: string[]): void {
|
||||||
const missing: string[] = [];
|
const missing: string[] = [];
|
||||||
|
|
||||||
for (const param of requiredParams) {
|
for (const param of requiredParams) {
|
||||||
@@ -619,12 +688,17 @@ export class N8NDocumentationMCPServer {
|
|||||||
fix: 'Provide config as an object with node properties'
|
fix: 'Provide config as an object with node properties'
|
||||||
}],
|
}],
|
||||||
warnings: [],
|
warnings: [],
|
||||||
suggestions: [],
|
suggestions: [
|
||||||
|
'🔧 RECOVERY: Invalid config detected. Fix with:',
|
||||||
|
' • Ensure config is an object: { "resource": "...", "operation": "..." }',
|
||||||
|
' • Use get_node_essentials to see required fields for this node type',
|
||||||
|
' • Check if the node type is correct before configuring it'
|
||||||
|
],
|
||||||
summary: {
|
summary: {
|
||||||
hasErrors: true,
|
hasErrors: true,
|
||||||
errorCount: 1,
|
errorCount: 1,
|
||||||
warningCount: 0,
|
warningCount: 0,
|
||||||
suggestionCount: 0
|
suggestionCount: 3
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
@@ -638,7 +712,10 @@ export class N8NDocumentationMCPServer {
|
|||||||
nodeType: args.nodeType || 'unknown',
|
nodeType: args.nodeType || 'unknown',
|
||||||
displayName: 'Unknown Node',
|
displayName: 'Unknown Node',
|
||||||
valid: false,
|
valid: false,
|
||||||
missingRequiredFields: ['Invalid config format - expected object']
|
missingRequiredFields: [
|
||||||
|
'Invalid config format - expected object',
|
||||||
|
'🔧 RECOVERY: Use format { "resource": "...", "operation": "..." } or {} for empty config'
|
||||||
|
]
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
return this.validateNodeMinimal(args.nodeType, args.config);
|
return this.validateNodeMinimal(args.nodeType, args.config);
|
||||||
@@ -2141,12 +2218,12 @@ Full documentation is being prepared. For now, use get_node_essentials for confi
|
|||||||
// Get properties
|
// Get properties
|
||||||
const properties = node.properties || [];
|
const properties = node.properties || [];
|
||||||
|
|
||||||
// Extract operation context
|
// Extract operation context (safely handle undefined config properties)
|
||||||
const operationContext = {
|
const operationContext = {
|
||||||
resource: config.resource,
|
resource: config?.resource,
|
||||||
operation: config.operation,
|
operation: config?.operation,
|
||||||
action: config.action,
|
action: config?.action,
|
||||||
mode: config.mode
|
mode: config?.mode
|
||||||
};
|
};
|
||||||
|
|
||||||
// Find missing required fields
|
// Find missing required fields
|
||||||
@@ -2163,7 +2240,7 @@ Full documentation is being prepared. For now, use get_node_essentials for confi
|
|||||||
// Check show conditions
|
// Check show conditions
|
||||||
if (prop.displayOptions.show) {
|
if (prop.displayOptions.show) {
|
||||||
for (const [key, values] of Object.entries(prop.displayOptions.show)) {
|
for (const [key, values] of Object.entries(prop.displayOptions.show)) {
|
||||||
const configValue = config[key];
|
const configValue = config?.[key];
|
||||||
const expectedValues = Array.isArray(values) ? values : [values];
|
const expectedValues = Array.isArray(values) ? values : [values];
|
||||||
|
|
||||||
if (!expectedValues.includes(configValue)) {
|
if (!expectedValues.includes(configValue)) {
|
||||||
@@ -2176,7 +2253,7 @@ Full documentation is being prepared. For now, use get_node_essentials for confi
|
|||||||
// Check hide conditions
|
// Check hide conditions
|
||||||
if (isVisible && prop.displayOptions.hide) {
|
if (isVisible && prop.displayOptions.hide) {
|
||||||
for (const [key, values] of Object.entries(prop.displayOptions.hide)) {
|
for (const [key, values] of Object.entries(prop.displayOptions.hide)) {
|
||||||
const configValue = config[key];
|
const configValue = config?.[key];
|
||||||
const expectedValues = Array.isArray(values) ? values : [values];
|
const expectedValues = Array.isArray(values) ? values : [values];
|
||||||
|
|
||||||
if (expectedValues.includes(configValue)) {
|
if (expectedValues.includes(configValue)) {
|
||||||
@@ -2189,8 +2266,8 @@ Full documentation is being prepared. For now, use get_node_essentials for confi
|
|||||||
if (!isVisible) continue;
|
if (!isVisible) continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check if field is missing
|
// Check if field is missing (safely handle null/undefined config)
|
||||||
if (!(prop.name in config)) {
|
if (!config || !(prop.name in config)) {
|
||||||
missingFields.push(prop.displayName || prop.name);
|
missingFields.push(prop.displayName || prop.name);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -45,6 +45,19 @@ export class EnhancedConfigValidator extends ConfigValidator {
|
|||||||
mode: ValidationMode = 'operation',
|
mode: ValidationMode = 'operation',
|
||||||
profile: ValidationProfile = 'ai-friendly'
|
profile: ValidationProfile = 'ai-friendly'
|
||||||
): EnhancedValidationResult {
|
): EnhancedValidationResult {
|
||||||
|
// Input validation - ensure parameters are valid
|
||||||
|
if (typeof nodeType !== 'string') {
|
||||||
|
throw new Error(`Invalid nodeType: expected string, got ${typeof nodeType}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!config || typeof config !== 'object') {
|
||||||
|
throw new Error(`Invalid config: expected object, got ${typeof config}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!Array.isArray(properties)) {
|
||||||
|
throw new Error(`Invalid properties: expected array, got ${typeof properties}`);
|
||||||
|
}
|
||||||
|
|
||||||
// Extract operation context from config
|
// Extract operation context from config
|
||||||
const operationContext = this.extractOperationContext(config);
|
const operationContext = this.extractOperationContext(config);
|
||||||
|
|
||||||
@@ -190,6 +203,17 @@ export class EnhancedConfigValidator extends ConfigValidator {
|
|||||||
config: Record<string, any>,
|
config: Record<string, any>,
|
||||||
result: EnhancedValidationResult
|
result: EnhancedValidationResult
|
||||||
): void {
|
): void {
|
||||||
|
// Type safety check - this should never happen with proper validation
|
||||||
|
if (typeof nodeType !== 'string') {
|
||||||
|
result.errors.push({
|
||||||
|
type: 'invalid_type',
|
||||||
|
property: 'nodeType',
|
||||||
|
message: `Invalid nodeType: expected string, got ${typeof nodeType}`,
|
||||||
|
fix: 'Provide a valid node type string (e.g., "nodes-base.webhook")'
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
// First, validate fixedCollection properties for known problematic nodes
|
// First, validate fixedCollection properties for known problematic nodes
|
||||||
this.validateFixedCollectionStructures(nodeType, config, result);
|
this.validateFixedCollectionStructures(nodeType, config, result);
|
||||||
|
|
||||||
|
|||||||
@@ -79,6 +79,18 @@ export class WorkflowValidator {
|
|||||||
private nodeValidator: typeof EnhancedConfigValidator
|
private nodeValidator: typeof EnhancedConfigValidator
|
||||||
) {}
|
) {}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Check if a node is a Sticky Note or other non-executable node
|
||||||
|
*/
|
||||||
|
private isStickyNote(node: WorkflowNode): boolean {
|
||||||
|
const stickyNoteTypes = [
|
||||||
|
'n8n-nodes-base.stickyNote',
|
||||||
|
'nodes-base.stickyNote',
|
||||||
|
'@n8n/n8n-nodes-base.stickyNote'
|
||||||
|
];
|
||||||
|
return stickyNoteTypes.includes(node.type);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Validate a complete workflow
|
* Validate a complete workflow
|
||||||
*/
|
*/
|
||||||
@@ -127,9 +139,10 @@ export class WorkflowValidator {
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Update statistics after null check
|
// Update statistics after null check (exclude sticky notes from counts)
|
||||||
result.statistics.totalNodes = Array.isArray(workflow.nodes) ? workflow.nodes.length : 0;
|
const executableNodes = Array.isArray(workflow.nodes) ? workflow.nodes.filter(n => !this.isStickyNote(n)) : [];
|
||||||
result.statistics.enabledNodes = Array.isArray(workflow.nodes) ? workflow.nodes.filter(n => !n.disabled).length : 0;
|
result.statistics.totalNodes = executableNodes.length;
|
||||||
|
result.statistics.enabledNodes = executableNodes.filter(n => !n.disabled).length;
|
||||||
|
|
||||||
// Basic workflow structure validation
|
// Basic workflow structure validation
|
||||||
this.validateWorkflowStructure(workflow, result);
|
this.validateWorkflowStructure(workflow, result);
|
||||||
@@ -143,21 +156,26 @@ export class WorkflowValidator {
|
|||||||
|
|
||||||
// Validate connections if requested
|
// Validate connections if requested
|
||||||
if (validateConnections) {
|
if (validateConnections) {
|
||||||
this.validateConnections(workflow, result);
|
this.validateConnections(workflow, result, profile);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Validate expressions if requested
|
// Validate expressions if requested
|
||||||
if (validateExpressions && workflow.nodes.length > 0) {
|
if (validateExpressions && workflow.nodes.length > 0) {
|
||||||
this.validateExpressions(workflow, result);
|
this.validateExpressions(workflow, result, profile);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check workflow patterns and best practices
|
// Check workflow patterns and best practices
|
||||||
if (workflow.nodes.length > 0) {
|
if (workflow.nodes.length > 0) {
|
||||||
this.checkWorkflowPatterns(workflow, result);
|
this.checkWorkflowPatterns(workflow, result, profile);
|
||||||
}
|
}
|
||||||
|
|
||||||
// Add suggestions based on findings
|
// Add suggestions based on findings
|
||||||
this.generateSuggestions(workflow, result);
|
this.generateSuggestions(workflow, result);
|
||||||
|
|
||||||
|
// Add AI-specific recovery suggestions if there are errors
|
||||||
|
if (result.errors.length > 0) {
|
||||||
|
this.addErrorRecoverySuggestions(result);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
@@ -308,7 +326,7 @@ export class WorkflowValidator {
|
|||||||
profile: string
|
profile: string
|
||||||
): Promise<void> {
|
): Promise<void> {
|
||||||
for (const node of workflow.nodes) {
|
for (const node of workflow.nodes) {
|
||||||
if (node.disabled) continue;
|
if (node.disabled || this.isStickyNote(node)) continue;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
// Validate node name length
|
// Validate node name length
|
||||||
@@ -500,7 +518,8 @@ export class WorkflowValidator {
|
|||||||
*/
|
*/
|
||||||
private validateConnections(
|
private validateConnections(
|
||||||
workflow: WorkflowJson,
|
workflow: WorkflowJson,
|
||||||
result: WorkflowValidationResult
|
result: WorkflowValidationResult,
|
||||||
|
profile: string = 'runtime'
|
||||||
): void {
|
): void {
|
||||||
const nodeMap = new Map(workflow.nodes.map(n => [n.name, n]));
|
const nodeMap = new Map(workflow.nodes.map(n => [n.name, n]));
|
||||||
const nodeIdMap = new Map(workflow.nodes.map(n => [n.id, n]));
|
const nodeIdMap = new Map(workflow.nodes.map(n => [n.id, n]));
|
||||||
@@ -591,9 +610,9 @@ export class WorkflowValidator {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
// Check for orphaned nodes
|
// Check for orphaned nodes (exclude sticky notes)
|
||||||
for (const node of workflow.nodes) {
|
for (const node of workflow.nodes) {
|
||||||
if (node.disabled) continue;
|
if (node.disabled || this.isStickyNote(node)) continue;
|
||||||
|
|
||||||
const normalizedType = node.type.replace('n8n-nodes-base.', 'nodes-base.');
|
const normalizedType = node.type.replace('n8n-nodes-base.', 'nodes-base.');
|
||||||
const isTrigger = normalizedType.toLowerCase().includes('trigger') ||
|
const isTrigger = normalizedType.toLowerCase().includes('trigger') ||
|
||||||
@@ -612,8 +631,8 @@ export class WorkflowValidator {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check for cycles
|
// Check for cycles (skip in minimal profile to reduce false positives)
|
||||||
if (this.hasCycle(workflow)) {
|
if (profile !== 'minimal' && this.hasCycle(workflow)) {
|
||||||
result.errors.push({
|
result.errors.push({
|
||||||
type: 'error',
|
type: 'error',
|
||||||
message: 'Workflow contains a cycle (infinite loop)'
|
message: 'Workflow contains a cycle (infinite loop)'
|
||||||
@@ -757,11 +776,23 @@ export class WorkflowValidator {
|
|||||||
const recursionStack = new Set<string>();
|
const recursionStack = new Set<string>();
|
||||||
const nodeTypeMap = new Map<string, string>();
|
const nodeTypeMap = new Map<string, string>();
|
||||||
|
|
||||||
// Build node type map
|
// Build node type map (exclude sticky notes)
|
||||||
workflow.nodes.forEach(node => {
|
workflow.nodes.forEach(node => {
|
||||||
|
if (!this.isStickyNote(node)) {
|
||||||
nodeTypeMap.set(node.name, node.type);
|
nodeTypeMap.set(node.name, node.type);
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Known legitimate loop node types
|
||||||
|
const loopNodeTypes = [
|
||||||
|
'n8n-nodes-base.splitInBatches',
|
||||||
|
'nodes-base.splitInBatches',
|
||||||
|
'n8n-nodes-base.itemLists',
|
||||||
|
'nodes-base.itemLists',
|
||||||
|
'n8n-nodes-base.loop',
|
||||||
|
'nodes-base.loop'
|
||||||
|
];
|
||||||
|
|
||||||
const hasCycleDFS = (nodeName: string, pathFromLoopNode: boolean = false): boolean => {
|
const hasCycleDFS = (nodeName: string, pathFromLoopNode: boolean = false): boolean => {
|
||||||
visited.add(nodeName);
|
visited.add(nodeName);
|
||||||
recursionStack.add(nodeName);
|
recursionStack.add(nodeName);
|
||||||
@@ -789,18 +820,18 @@ export class WorkflowValidator {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const currentNodeType = nodeTypeMap.get(nodeName);
|
const currentNodeType = nodeTypeMap.get(nodeName);
|
||||||
const isLoopNode = currentNodeType === 'n8n-nodes-base.splitInBatches';
|
const isLoopNode = loopNodeTypes.includes(currentNodeType || '');
|
||||||
|
|
||||||
for (const target of allTargets) {
|
for (const target of allTargets) {
|
||||||
if (!visited.has(target)) {
|
if (!visited.has(target)) {
|
||||||
if (hasCycleDFS(target, pathFromLoopNode || isLoopNode)) return true;
|
if (hasCycleDFS(target, pathFromLoopNode || isLoopNode)) return true;
|
||||||
} else if (recursionStack.has(target)) {
|
} else if (recursionStack.has(target)) {
|
||||||
// Allow cycles that involve loop nodes like SplitInBatches
|
// Allow cycles that involve legitimate loop nodes
|
||||||
const targetNodeType = nodeTypeMap.get(target);
|
const targetNodeType = nodeTypeMap.get(target);
|
||||||
const isTargetLoopNode = targetNodeType === 'n8n-nodes-base.splitInBatches';
|
const isTargetLoopNode = loopNodeTypes.includes(targetNodeType || '');
|
||||||
|
|
||||||
// If this cycle involves a loop node, it's legitimate
|
// If this cycle involves a loop node, it's legitimate
|
||||||
if (isTargetLoopNode || pathFromLoopNode) {
|
if (isTargetLoopNode || pathFromLoopNode || isLoopNode) {
|
||||||
continue; // Allow this cycle
|
continue; // Allow this cycle
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -813,9 +844,9 @@ export class WorkflowValidator {
|
|||||||
return false;
|
return false;
|
||||||
};
|
};
|
||||||
|
|
||||||
// Check from all nodes
|
// Check from all executable nodes (exclude sticky notes)
|
||||||
for (const node of workflow.nodes) {
|
for (const node of workflow.nodes) {
|
||||||
if (!visited.has(node.name)) {
|
if (!this.isStickyNote(node) && !visited.has(node.name)) {
|
||||||
if (hasCycleDFS(node.name)) return true;
|
if (hasCycleDFS(node.name)) return true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -828,12 +859,13 @@ export class WorkflowValidator {
|
|||||||
*/
|
*/
|
||||||
private validateExpressions(
|
private validateExpressions(
|
||||||
workflow: WorkflowJson,
|
workflow: WorkflowJson,
|
||||||
result: WorkflowValidationResult
|
result: WorkflowValidationResult,
|
||||||
|
profile: string = 'runtime'
|
||||||
): void {
|
): void {
|
||||||
const nodeNames = workflow.nodes.map(n => n.name);
|
const nodeNames = workflow.nodes.map(n => n.name);
|
||||||
|
|
||||||
for (const node of workflow.nodes) {
|
for (const node of workflow.nodes) {
|
||||||
if (node.disabled) continue;
|
if (node.disabled || this.isStickyNote(node)) continue;
|
||||||
|
|
||||||
// Create expression context
|
// Create expression context
|
||||||
const context = {
|
const context = {
|
||||||
@@ -922,24 +954,28 @@ export class WorkflowValidator {
|
|||||||
*/
|
*/
|
||||||
private checkWorkflowPatterns(
|
private checkWorkflowPatterns(
|
||||||
workflow: WorkflowJson,
|
workflow: WorkflowJson,
|
||||||
result: WorkflowValidationResult
|
result: WorkflowValidationResult,
|
||||||
|
profile: string = 'runtime'
|
||||||
): void {
|
): void {
|
||||||
// Check for error handling
|
// Check for error handling
|
||||||
const hasErrorHandling = Object.values(workflow.connections).some(
|
const hasErrorHandling = Object.values(workflow.connections).some(
|
||||||
outputs => outputs.error && outputs.error.length > 0
|
outputs => outputs.error && outputs.error.length > 0
|
||||||
);
|
);
|
||||||
|
|
||||||
if (!hasErrorHandling && workflow.nodes.length > 3) {
|
// Only suggest error handling in stricter profiles
|
||||||
|
if (!hasErrorHandling && workflow.nodes.length > 3 && profile !== 'minimal') {
|
||||||
result.warnings.push({
|
result.warnings.push({
|
||||||
type: 'warning',
|
type: 'warning',
|
||||||
message: 'Consider adding error handling to your workflow'
|
message: 'Consider adding error handling to your workflow'
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check node-level error handling properties for ALL nodes
|
// Check node-level error handling properties for ALL executable nodes
|
||||||
for (const node of workflow.nodes) {
|
for (const node of workflow.nodes) {
|
||||||
|
if (!this.isStickyNote(node)) {
|
||||||
this.checkNodeErrorHandling(node, workflow, result);
|
this.checkNodeErrorHandling(node, workflow, result);
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Check for very long linear workflows
|
// Check for very long linear workflows
|
||||||
const linearChainLength = this.getLongestLinearChain(workflow);
|
const linearChainLength = this.getLongestLinearChain(workflow);
|
||||||
@@ -1641,4 +1677,75 @@ export class WorkflowValidator {
|
|||||||
|
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Add AI-specific error recovery suggestions
|
||||||
|
*/
|
||||||
|
private addErrorRecoverySuggestions(result: WorkflowValidationResult): void {
|
||||||
|
// Categorize errors and provide specific recovery actions
|
||||||
|
const errorTypes = {
|
||||||
|
nodeType: result.errors.filter(e => e.message.includes('node type') || e.message.includes('Node type')),
|
||||||
|
connection: result.errors.filter(e => e.message.includes('connection') || e.message.includes('Connection')),
|
||||||
|
structure: result.errors.filter(e => e.message.includes('structure') || e.message.includes('nodes must be')),
|
||||||
|
configuration: result.errors.filter(e => e.message.includes('property') || e.message.includes('field')),
|
||||||
|
typeVersion: result.errors.filter(e => e.message.includes('typeVersion'))
|
||||||
|
};
|
||||||
|
|
||||||
|
// Add recovery suggestions based on error types
|
||||||
|
if (errorTypes.nodeType.length > 0) {
|
||||||
|
result.suggestions.unshift(
|
||||||
|
'🔧 RECOVERY: Invalid node types detected. Use these patterns:',
|
||||||
|
' • For core nodes: "n8n-nodes-base.nodeName" (e.g., "n8n-nodes-base.webhook")',
|
||||||
|
' • For AI nodes: "@n8n/n8n-nodes-langchain.nodeName"',
|
||||||
|
' • Never use just the node name without package prefix'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (errorTypes.connection.length > 0) {
|
||||||
|
result.suggestions.unshift(
|
||||||
|
'🔧 RECOVERY: Connection errors detected. Fix with:',
|
||||||
|
' • Use node NAMES in connections, not IDs or types',
|
||||||
|
' • Structure: { "Source Node Name": { "main": [[{ "node": "Target Node Name", "type": "main", "index": 0 }]] } }',
|
||||||
|
' • Ensure all referenced nodes exist in the workflow'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (errorTypes.structure.length > 0) {
|
||||||
|
result.suggestions.unshift(
|
||||||
|
'🔧 RECOVERY: Workflow structure errors. Fix with:',
|
||||||
|
' • Ensure "nodes" is an array: "nodes": [...]',
|
||||||
|
' • Ensure "connections" is an object: "connections": {...}',
|
||||||
|
' • Add at least one node to create a valid workflow'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (errorTypes.configuration.length > 0) {
|
||||||
|
result.suggestions.unshift(
|
||||||
|
'🔧 RECOVERY: Node configuration errors. Fix with:',
|
||||||
|
' • Check required fields using validate_node_minimal first',
|
||||||
|
' • Use get_node_essentials to see what fields are needed',
|
||||||
|
' • Ensure operation-specific fields match the node\'s requirements'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (errorTypes.typeVersion.length > 0) {
|
||||||
|
result.suggestions.unshift(
|
||||||
|
'🔧 RECOVERY: TypeVersion errors. Fix with:',
|
||||||
|
' • Add "typeVersion": 1 (or latest version) to each node',
|
||||||
|
' • Use get_node_info to check the correct version for each node type'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Add general recovery workflow
|
||||||
|
if (result.errors.length > 3) {
|
||||||
|
result.suggestions.push(
|
||||||
|
'📋 SUGGESTED WORKFLOW: Too many errors detected. Try this approach:',
|
||||||
|
' 1. Fix structural issues first (nodes array, connections object)',
|
||||||
|
' 2. Validate node types and fix invalid ones',
|
||||||
|
' 3. Add required typeVersion to all nodes',
|
||||||
|
' 4. Test connections step by step',
|
||||||
|
' 5. Use validate_node_minimal on individual nodes to verify configuration'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
312
src/utils/validation-schemas.ts
Normal file
312
src/utils/validation-schemas.ts
Normal file
@@ -0,0 +1,312 @@
|
|||||||
|
/**
|
||||||
|
* Zod validation schemas for MCP tool parameters
|
||||||
|
* Provides robust input validation with detailed error messages
|
||||||
|
*/
|
||||||
|
|
||||||
|
// Simple validation without zod for now, since it's not installed
|
||||||
|
// We can use TypeScript's built-in validation with better error messages
|
||||||
|
|
||||||
|
export class ValidationError extends Error {
|
||||||
|
constructor(message: string, public field?: string, public value?: any) {
|
||||||
|
super(message);
|
||||||
|
this.name = 'ValidationError';
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface ValidationResult {
|
||||||
|
valid: boolean;
|
||||||
|
errors: Array<{
|
||||||
|
field: string;
|
||||||
|
message: string;
|
||||||
|
value?: any;
|
||||||
|
}>;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Basic validation utilities
|
||||||
|
*/
|
||||||
|
export class Validator {
|
||||||
|
/**
|
||||||
|
* Validate that a value is a non-empty string
|
||||||
|
*/
|
||||||
|
static validateString(value: any, fieldName: string, required: boolean = true): ValidationResult {
|
||||||
|
const errors: Array<{field: string, message: string, value?: any}> = [];
|
||||||
|
|
||||||
|
if (required && (value === undefined || value === null)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} is required`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (value !== undefined && value !== null && typeof value !== 'string') {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be a string, got ${typeof value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (required && typeof value === 'string' && value.trim().length === 0) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} cannot be empty`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
valid: errors.length === 0,
|
||||||
|
errors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate that a value is a valid object (not null, not array)
|
||||||
|
*/
|
||||||
|
static validateObject(value: any, fieldName: string, required: boolean = true): ValidationResult {
|
||||||
|
const errors: Array<{field: string, message: string, value?: any}> = [];
|
||||||
|
|
||||||
|
if (required && (value === undefined || value === null)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} is required`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (value !== undefined && value !== null) {
|
||||||
|
if (typeof value !== 'object') {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be an object, got ${typeof value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (Array.isArray(value)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be an object, not an array`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
valid: errors.length === 0,
|
||||||
|
errors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate that a value is an array
|
||||||
|
*/
|
||||||
|
static validateArray(value: any, fieldName: string, required: boolean = true): ValidationResult {
|
||||||
|
const errors: Array<{field: string, message: string, value?: any}> = [];
|
||||||
|
|
||||||
|
if (required && (value === undefined || value === null)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} is required`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (value !== undefined && value !== null && !Array.isArray(value)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be an array, got ${typeof value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
valid: errors.length === 0,
|
||||||
|
errors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate that a value is a number
|
||||||
|
*/
|
||||||
|
static validateNumber(value: any, fieldName: string, required: boolean = true, min?: number, max?: number): ValidationResult {
|
||||||
|
const errors: Array<{field: string, message: string, value?: any}> = [];
|
||||||
|
|
||||||
|
if (required && (value === undefined || value === null)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} is required`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (value !== undefined && value !== null) {
|
||||||
|
if (typeof value !== 'number' || isNaN(value)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be a number, got ${typeof value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
if (min !== undefined && value < min) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be at least ${min}, got ${value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
if (max !== undefined && value > max) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be at most ${max}, got ${value}`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
valid: errors.length === 0,
|
||||||
|
errors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate that a value is one of allowed values
|
||||||
|
*/
|
||||||
|
static validateEnum<T>(value: any, fieldName: string, allowedValues: T[], required: boolean = true): ValidationResult {
|
||||||
|
const errors: Array<{field: string, message: string, value?: any}> = [];
|
||||||
|
|
||||||
|
if (required && (value === undefined || value === null)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} is required`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
} else if (value !== undefined && value !== null && !allowedValues.includes(value)) {
|
||||||
|
errors.push({
|
||||||
|
field: fieldName,
|
||||||
|
message: `${fieldName} must be one of: ${allowedValues.join(', ')}, got "${value}"`,
|
||||||
|
value
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
valid: errors.length === 0,
|
||||||
|
errors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Combine multiple validation results
|
||||||
|
*/
|
||||||
|
static combineResults(...results: ValidationResult[]): ValidationResult {
|
||||||
|
const allErrors = results.flatMap(r => r.errors);
|
||||||
|
return {
|
||||||
|
valid: allErrors.length === 0,
|
||||||
|
errors: allErrors
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Create a detailed error message from validation result
|
||||||
|
*/
|
||||||
|
static formatErrors(result: ValidationResult, toolName?: string): string {
|
||||||
|
if (result.valid) return '';
|
||||||
|
|
||||||
|
const prefix = toolName ? `${toolName}: ` : '';
|
||||||
|
const errors = result.errors.map(e => ` • ${e.field}: ${e.message}`).join('\n');
|
||||||
|
|
||||||
|
return `${prefix}Validation failed:\n${errors}`;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tool-specific validation schemas
|
||||||
|
*/
|
||||||
|
export class ToolValidation {
|
||||||
|
/**
|
||||||
|
* Validate parameters for validate_node_operation tool
|
||||||
|
*/
|
||||||
|
static validateNodeOperation(args: any): ValidationResult {
|
||||||
|
const nodeTypeResult = Validator.validateString(args.nodeType, 'nodeType');
|
||||||
|
const configResult = Validator.validateObject(args.config, 'config');
|
||||||
|
const profileResult = Validator.validateEnum(
|
||||||
|
args.profile,
|
||||||
|
'profile',
|
||||||
|
['minimal', 'runtime', 'ai-friendly', 'strict'],
|
||||||
|
false // optional
|
||||||
|
);
|
||||||
|
|
||||||
|
return Validator.combineResults(nodeTypeResult, configResult, profileResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for validate_node_minimal tool
|
||||||
|
*/
|
||||||
|
static validateNodeMinimal(args: any): ValidationResult {
|
||||||
|
const nodeTypeResult = Validator.validateString(args.nodeType, 'nodeType');
|
||||||
|
const configResult = Validator.validateObject(args.config, 'config');
|
||||||
|
|
||||||
|
return Validator.combineResults(nodeTypeResult, configResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for validate_workflow tool
|
||||||
|
*/
|
||||||
|
static validateWorkflow(args: any): ValidationResult {
|
||||||
|
const workflowResult = Validator.validateObject(args.workflow, 'workflow');
|
||||||
|
|
||||||
|
// Validate workflow structure if it's an object
|
||||||
|
let nodesResult: ValidationResult = { valid: true, errors: [] };
|
||||||
|
let connectionsResult: ValidationResult = { valid: true, errors: [] };
|
||||||
|
|
||||||
|
if (workflowResult.valid && args.workflow) {
|
||||||
|
nodesResult = Validator.validateArray(args.workflow.nodes, 'workflow.nodes');
|
||||||
|
connectionsResult = Validator.validateObject(args.workflow.connections, 'workflow.connections');
|
||||||
|
}
|
||||||
|
|
||||||
|
const optionsResult = args.options ?
|
||||||
|
Validator.validateObject(args.options, 'options', false) :
|
||||||
|
{ valid: true, errors: [] };
|
||||||
|
|
||||||
|
return Validator.combineResults(workflowResult, nodesResult, connectionsResult, optionsResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for search_nodes tool
|
||||||
|
*/
|
||||||
|
static validateSearchNodes(args: any): ValidationResult {
|
||||||
|
const queryResult = Validator.validateString(args.query, 'query');
|
||||||
|
const limitResult = Validator.validateNumber(args.limit, 'limit', false, 1, 200);
|
||||||
|
const modeResult = Validator.validateEnum(
|
||||||
|
args.mode,
|
||||||
|
'mode',
|
||||||
|
['OR', 'AND', 'FUZZY'],
|
||||||
|
false
|
||||||
|
);
|
||||||
|
|
||||||
|
return Validator.combineResults(queryResult, limitResult, modeResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for list_node_templates tool
|
||||||
|
*/
|
||||||
|
static validateListNodeTemplates(args: any): ValidationResult {
|
||||||
|
const nodeTypesResult = Validator.validateArray(args.nodeTypes, 'nodeTypes');
|
||||||
|
const limitResult = Validator.validateNumber(args.limit, 'limit', false, 1, 50);
|
||||||
|
|
||||||
|
return Validator.combineResults(nodeTypesResult, limitResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for n8n workflow operations
|
||||||
|
*/
|
||||||
|
static validateWorkflowId(args: any): ValidationResult {
|
||||||
|
return Validator.validateString(args.id, 'id');
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Validate parameters for n8n_create_workflow tool
|
||||||
|
*/
|
||||||
|
static validateCreateWorkflow(args: any): ValidationResult {
|
||||||
|
const nameResult = Validator.validateString(args.name, 'name');
|
||||||
|
const nodesResult = Validator.validateArray(args.nodes, 'nodes');
|
||||||
|
const connectionsResult = Validator.validateObject(args.connections, 'connections');
|
||||||
|
const settingsResult = args.settings ?
|
||||||
|
Validator.validateObject(args.settings, 'settings', false) :
|
||||||
|
{ valid: true, errors: [] };
|
||||||
|
|
||||||
|
return Validator.combineResults(nameResult, nodesResult, connectionsResult, settingsResult);
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -109,16 +109,16 @@ describe('MCP Error Handling', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('should handle empty search query', async () => {
|
it('should handle empty search query', async () => {
|
||||||
// Empty query returns empty results
|
try {
|
||||||
const response = await client.callTool({ name: 'search_nodes', arguments: {
|
await client.callTool({ name: 'search_nodes', arguments: {
|
||||||
query: ''
|
query: ''
|
||||||
} });
|
} });
|
||||||
|
expect.fail('Should have thrown an error');
|
||||||
const result = JSON.parse((response as any).content[0].text);
|
} catch (error: any) {
|
||||||
// search_nodes returns 'results' not 'nodes'
|
expect(error).toBeDefined();
|
||||||
expect(result).toHaveProperty('results');
|
expect(error.message).toContain("search_nodes: Validation failed:");
|
||||||
expect(Array.isArray(result.results)).toBe(true);
|
expect(error.message).toContain("query: query cannot be empty");
|
||||||
expect(result.results).toHaveLength(0);
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should handle non-existent node types', async () => {
|
it('should handle non-existent node types', async () => {
|
||||||
@@ -149,19 +149,19 @@ describe('MCP Error Handling', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('should handle malformed workflow structure', async () => {
|
it('should handle malformed workflow structure', async () => {
|
||||||
const response = await client.callTool({ name: 'validate_workflow', arguments: {
|
try {
|
||||||
|
await client.callTool({ name: 'validate_workflow', arguments: {
|
||||||
workflow: {
|
workflow: {
|
||||||
// Missing required 'nodes' array
|
// Missing required 'nodes' array
|
||||||
connections: {}
|
connections: {}
|
||||||
}
|
}
|
||||||
} });
|
} });
|
||||||
|
expect.fail('Should have thrown an error');
|
||||||
// Should return validation error, not throw
|
} catch (error: any) {
|
||||||
const validation = JSON.parse((response as any).content[0].text);
|
expect(error).toBeDefined();
|
||||||
expect(validation.valid).toBe(false);
|
expect(error.message).toContain("validate_workflow: Validation failed:");
|
||||||
expect(validation.errors).toBeDefined();
|
expect(error.message).toContain("workflow.nodes: workflow.nodes is required");
|
||||||
expect(validation.errors.length).toBeGreaterThan(0);
|
}
|
||||||
expect(validation.errors[0].message).toContain('nodes');
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should handle circular workflow references', async () => {
|
it('should handle circular workflow references', async () => {
|
||||||
@@ -501,7 +501,8 @@ describe('MCP Error Handling', () => {
|
|||||||
} catch (error: any) {
|
} catch (error: any) {
|
||||||
expect(error).toBeDefined();
|
expect(error).toBeDefined();
|
||||||
// The error now properly validates required parameters
|
// The error now properly validates required parameters
|
||||||
expect(error.message).toContain("Missing required parameters");
|
expect(error.message).toContain("search_nodes: Validation failed:");
|
||||||
|
expect(error.message).toContain("query: query is required");
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -176,7 +176,7 @@ describe('Parameter Validation', () => {
|
|||||||
describe('search_nodes', () => {
|
describe('search_nodes', () => {
|
||||||
it('should require query parameter', async () => {
|
it('should require query parameter', async () => {
|
||||||
await expect(server.testExecuteTool('search_nodes', {}))
|
await expect(server.testExecuteTool('search_nodes', {}))
|
||||||
.rejects.toThrow('Missing required parameters for search_nodes: query');
|
.rejects.toThrow('search_nodes: Validation failed:\n • query: query is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should succeed with valid query', async () => {
|
it('should succeed with valid query', async () => {
|
||||||
@@ -194,29 +194,28 @@ describe('Parameter Validation', () => {
|
|||||||
expect(result).toEqual({ results: [] });
|
expect(result).toEqual({ results: [] });
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should convert limit to number and use default on invalid value', async () => {
|
it('should reject invalid limit value', async () => {
|
||||||
const result = await server.testExecuteTool('search_nodes', {
|
await expect(server.testExecuteTool('search_nodes', {
|
||||||
query: 'http',
|
query: 'http',
|
||||||
limit: 'invalid'
|
limit: 'invalid'
|
||||||
});
|
})).rejects.toThrow('search_nodes: Validation failed:\n • limit: limit must be a number, got string');
|
||||||
expect(result).toEqual({ results: [] });
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('validate_node_operation', () => {
|
describe('validate_node_operation', () => {
|
||||||
it('should require nodeType and config parameters', async () => {
|
it('should require nodeType and config parameters', async () => {
|
||||||
await expect(server.testExecuteTool('validate_node_operation', {}))
|
await expect(server.testExecuteTool('validate_node_operation', {}))
|
||||||
.rejects.toThrow('Missing required parameters for validate_node_operation: nodeType, config');
|
.rejects.toThrow('validate_node_operation: Validation failed:\n • nodeType: nodeType is required\n • config: config is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should require nodeType parameter when config is provided', async () => {
|
it('should require nodeType parameter when config is provided', async () => {
|
||||||
await expect(server.testExecuteTool('validate_node_operation', { config: {} }))
|
await expect(server.testExecuteTool('validate_node_operation', { config: {} }))
|
||||||
.rejects.toThrow('Missing required parameters for validate_node_operation: nodeType');
|
.rejects.toThrow('validate_node_operation: Validation failed:\n • nodeType: nodeType is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should require config parameter when nodeType is provided', async () => {
|
it('should require config parameter when nodeType is provided', async () => {
|
||||||
await expect(server.testExecuteTool('validate_node_operation', { nodeType: 'nodes-base.httpRequest' }))
|
await expect(server.testExecuteTool('validate_node_operation', { nodeType: 'nodes-base.httpRequest' }))
|
||||||
.rejects.toThrow('Missing required parameters for validate_node_operation: config');
|
.rejects.toThrow('validate_node_operation: Validation failed:\n • config: config is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should succeed with valid parameters', async () => {
|
it('should succeed with valid parameters', async () => {
|
||||||
@@ -255,7 +254,7 @@ describe('Parameter Validation', () => {
|
|||||||
describe('list_node_templates', () => {
|
describe('list_node_templates', () => {
|
||||||
it('should require nodeTypes parameter', async () => {
|
it('should require nodeTypes parameter', async () => {
|
||||||
await expect(server.testExecuteTool('list_node_templates', {}))
|
await expect(server.testExecuteTool('list_node_templates', {}))
|
||||||
.rejects.toThrow('Missing required parameters for list_node_templates: nodeTypes');
|
.rejects.toThrow('list_node_templates: Validation failed:\n • nodeTypes: nodeTypes is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should succeed with valid nodeTypes array', async () => {
|
it('should succeed with valid nodeTypes array', async () => {
|
||||||
@@ -290,26 +289,18 @@ describe('Parameter Validation', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe('limit parameter conversion', () => {
|
describe('limit parameter conversion', () => {
|
||||||
it('should convert string numbers to numbers', async () => {
|
it('should reject string limit values', async () => {
|
||||||
const mockSearchNodes = vi.spyOn(server as any, 'searchNodes');
|
await expect(server.testExecuteTool('search_nodes', {
|
||||||
|
|
||||||
await server.testExecuteTool('search_nodes', {
|
|
||||||
query: 'test',
|
query: 'test',
|
||||||
limit: '15'
|
limit: '15'
|
||||||
|
})).rejects.toThrow('search_nodes: Validation failed:\n • limit: limit must be a number, got string');
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(mockSearchNodes).toHaveBeenCalledWith('test', 15, { mode: undefined });
|
it('should reject invalid string limit values', async () => {
|
||||||
});
|
await expect(server.testExecuteTool('search_nodes', {
|
||||||
|
|
||||||
it('should use default when limit is invalid string', async () => {
|
|
||||||
const mockSearchNodes = vi.spyOn(server as any, 'searchNodes');
|
|
||||||
|
|
||||||
await server.testExecuteTool('search_nodes', {
|
|
||||||
query: 'test',
|
query: 'test',
|
||||||
limit: 'invalid'
|
limit: 'invalid'
|
||||||
});
|
})).rejects.toThrow('search_nodes: Validation failed:\n • limit: limit must be a number, got string');
|
||||||
|
|
||||||
expect(mockSearchNodes).toHaveBeenCalledWith('test', 20, { mode: undefined });
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should use default when limit is undefined', async () => {
|
it('should use default when limit is undefined', async () => {
|
||||||
@@ -322,15 +313,11 @@ describe('Parameter Validation', () => {
|
|||||||
expect(mockSearchNodes).toHaveBeenCalledWith('test', 20, { mode: undefined });
|
expect(mockSearchNodes).toHaveBeenCalledWith('test', 20, { mode: undefined });
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should handle zero as valid limit', async () => {
|
it('should reject zero as limit due to minimum constraint', async () => {
|
||||||
const mockSearchNodes = vi.spyOn(server as any, 'searchNodes');
|
await expect(server.testExecuteTool('search_nodes', {
|
||||||
|
|
||||||
await server.testExecuteTool('search_nodes', {
|
|
||||||
query: 'test',
|
query: 'test',
|
||||||
limit: 0
|
limit: 0
|
||||||
});
|
})).rejects.toThrow('search_nodes: Validation failed:\n • limit: limit must be at least 1, got 0');
|
||||||
|
|
||||||
expect(mockSearchNodes).toHaveBeenCalledWith('test', 20, { mode: undefined }); // 0 converts to falsy, uses default
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -361,26 +348,18 @@ describe('Parameter Validation', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe('templateLimit parameter conversion', () => {
|
describe('templateLimit parameter conversion', () => {
|
||||||
it('should convert string numbers to numbers', async () => {
|
it('should reject string limit values', async () => {
|
||||||
const mockListNodeTemplates = vi.spyOn(server as any, 'listNodeTemplates');
|
await expect(server.testExecuteTool('list_node_templates', {
|
||||||
|
|
||||||
await server.testExecuteTool('list_node_templates', {
|
|
||||||
nodeTypes: ['nodes-base.httpRequest'],
|
nodeTypes: ['nodes-base.httpRequest'],
|
||||||
limit: '5'
|
limit: '5'
|
||||||
|
})).rejects.toThrow('list_node_templates: Validation failed:\n • limit: limit must be a number, got string');
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(mockListNodeTemplates).toHaveBeenCalledWith(['nodes-base.httpRequest'], 5);
|
it('should reject invalid string limit values', async () => {
|
||||||
});
|
await expect(server.testExecuteTool('list_node_templates', {
|
||||||
|
|
||||||
it('should use default when templateLimit is invalid', async () => {
|
|
||||||
const mockListNodeTemplates = vi.spyOn(server as any, 'listNodeTemplates');
|
|
||||||
|
|
||||||
await server.testExecuteTool('list_node_templates', {
|
|
||||||
nodeTypes: ['nodes-base.httpRequest'],
|
nodeTypes: ['nodes-base.httpRequest'],
|
||||||
limit: 'invalid'
|
limit: 'invalid'
|
||||||
});
|
})).rejects.toThrow('list_node_templates: Validation failed:\n • limit: limit must be a number, got string');
|
||||||
|
|
||||||
expect(mockListNodeTemplates).toHaveBeenCalledWith(['nodes-base.httpRequest'], 10);
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -452,7 +431,7 @@ describe('Parameter Validation', () => {
|
|||||||
it('should list all missing parameters', () => {
|
it('should list all missing parameters', () => {
|
||||||
expect(() => {
|
expect(() => {
|
||||||
server.testValidateToolParams('validate_node_operation', { profile: 'strict' }, ['nodeType', 'config']);
|
server.testValidateToolParams('validate_node_operation', { profile: 'strict' }, ['nodeType', 'config']);
|
||||||
}).toThrow('Missing required parameters for validate_node_operation: nodeType, config');
|
}).toThrow('validate_node_operation: Validation failed:\n • nodeType: nodeType is required\n • config: config is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should include helpful guidance', () => {
|
it('should include helpful guidance', () => {
|
||||||
@@ -475,10 +454,10 @@ describe('Parameter Validation', () => {
|
|||||||
.rejects.toThrow('Missing required parameters for get_node_info: nodeType');
|
.rejects.toThrow('Missing required parameters for get_node_info: nodeType');
|
||||||
|
|
||||||
await expect(server.testExecuteTool('search_nodes', {}))
|
await expect(server.testExecuteTool('search_nodes', {}))
|
||||||
.rejects.toThrow('Missing required parameters for search_nodes: query');
|
.rejects.toThrow('search_nodes: Validation failed:\n • query: query is required');
|
||||||
|
|
||||||
await expect(server.testExecuteTool('validate_node_operation', { nodeType: 'test' }))
|
await expect(server.testExecuteTool('validate_node_operation', { nodeType: 'test' }))
|
||||||
.rejects.toThrow('Missing required parameters for validate_node_operation: config');
|
.rejects.toThrow('validate_node_operation: Validation failed:\n • config: config is required');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should handle edge cases in parameter validation gracefully', async () => {
|
it('should handle edge cases in parameter validation gracefully', async () => {
|
||||||
@@ -492,24 +471,34 @@ describe('Parameter Validation', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('should provide consistent error format across all tools', async () => {
|
it('should provide consistent error format across all tools', async () => {
|
||||||
const toolsWithRequiredParams = [
|
// Tools using legacy validation
|
||||||
{ name: 'get_node_info', args: {}, missing: 'nodeType' },
|
const legacyValidationTools = [
|
||||||
{ name: 'search_nodes', args: {}, missing: 'query' },
|
{ name: 'get_node_info', args: {}, expected: 'Missing required parameters for get_node_info: nodeType' },
|
||||||
{ name: 'get_node_documentation', args: {}, missing: 'nodeType' },
|
{ name: 'get_node_documentation', args: {}, expected: 'Missing required parameters for get_node_documentation: nodeType' },
|
||||||
{ name: 'get_node_essentials', args: {}, missing: 'nodeType' },
|
{ name: 'get_node_essentials', args: {}, expected: 'Missing required parameters for get_node_essentials: nodeType' },
|
||||||
{ name: 'search_node_properties', args: {}, missing: 'nodeType, query' },
|
{ name: 'search_node_properties', args: {}, expected: 'Missing required parameters for search_node_properties: nodeType, query' },
|
||||||
{ name: 'get_node_for_task', args: {}, missing: 'task' },
|
{ name: 'get_node_for_task', args: {}, expected: 'Missing required parameters for get_node_for_task: task' },
|
||||||
{ name: 'validate_node_operation', args: {}, missing: 'nodeType, config' },
|
{ name: 'get_property_dependencies', args: {}, expected: 'Missing required parameters for get_property_dependencies: nodeType' },
|
||||||
{ name: 'validate_node_minimal', args: {}, missing: 'nodeType, config' },
|
{ name: 'get_node_as_tool_info', args: {}, expected: 'Missing required parameters for get_node_as_tool_info: nodeType' },
|
||||||
{ name: 'get_property_dependencies', args: {}, missing: 'nodeType' },
|
{ name: 'get_template', args: {}, expected: 'Missing required parameters for get_template: templateId' },
|
||||||
{ name: 'get_node_as_tool_info', args: {}, missing: 'nodeType' },
|
|
||||||
{ name: 'list_node_templates', args: {}, missing: 'nodeTypes' },
|
|
||||||
{ name: 'get_template', args: {}, missing: 'templateId' },
|
|
||||||
];
|
];
|
||||||
|
|
||||||
for (const tool of toolsWithRequiredParams) {
|
for (const tool of legacyValidationTools) {
|
||||||
await expect(server.testExecuteTool(tool.name, tool.args))
|
await expect(server.testExecuteTool(tool.name, tool.args))
|
||||||
.rejects.toThrow(`Missing required parameters for ${tool.name}: ${tool.missing}`);
|
.rejects.toThrow(tool.expected);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Tools using new schema validation
|
||||||
|
const schemaValidationTools = [
|
||||||
|
{ name: 'search_nodes', args: {}, expected: 'search_nodes: Validation failed:\n • query: query is required' },
|
||||||
|
{ name: 'validate_node_operation', args: {}, expected: 'validate_node_operation: Validation failed:\n • nodeType: nodeType is required\n • config: config is required' },
|
||||||
|
{ name: 'validate_node_minimal', args: {}, expected: 'validate_node_minimal: Validation failed:\n • nodeType: nodeType is required\n • config: config is required' },
|
||||||
|
{ name: 'list_node_templates', args: {}, expected: 'list_node_templates: Validation failed:\n • nodeTypes: nodeTypes is required' },
|
||||||
|
];
|
||||||
|
|
||||||
|
for (const tool of schemaValidationTools) {
|
||||||
|
await expect(server.testExecuteTool(tool.name, tool.args))
|
||||||
|
.rejects.toThrow(tool.expected);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -540,23 +529,28 @@ describe('Parameter Validation', () => {
|
|||||||
}));
|
}));
|
||||||
|
|
||||||
const n8nToolsWithRequiredParams = [
|
const n8nToolsWithRequiredParams = [
|
||||||
{ name: 'n8n_create_workflow', args: {}, missing: 'name, nodes, connections' },
|
{ name: 'n8n_create_workflow', args: {}, expected: 'n8n_create_workflow: Validation failed:\n • name: name is required\n • nodes: nodes is required\n • connections: connections is required' },
|
||||||
{ name: 'n8n_get_workflow', args: {}, missing: 'id' },
|
{ name: 'n8n_get_workflow', args: {}, expected: 'n8n_get_workflow: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_get_workflow_details', args: {}, missing: 'id' },
|
{ name: 'n8n_get_workflow_details', args: {}, expected: 'n8n_get_workflow_details: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_get_workflow_structure', args: {}, missing: 'id' },
|
{ name: 'n8n_get_workflow_structure', args: {}, expected: 'n8n_get_workflow_structure: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_get_workflow_minimal', args: {}, missing: 'id' },
|
{ name: 'n8n_get_workflow_minimal', args: {}, expected: 'n8n_get_workflow_minimal: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_update_full_workflow', args: {}, missing: 'id' },
|
{ name: 'n8n_update_full_workflow', args: {}, expected: 'n8n_update_full_workflow: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_update_partial_workflow', args: {}, missing: 'id, operations' },
|
{ name: 'n8n_delete_workflow', args: {}, expected: 'n8n_delete_workflow: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_delete_workflow', args: {}, missing: 'id' },
|
{ name: 'n8n_validate_workflow', args: {}, expected: 'n8n_validate_workflow: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_validate_workflow', args: {}, missing: 'id' },
|
{ name: 'n8n_get_execution', args: {}, expected: 'n8n_get_execution: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_trigger_webhook_workflow', args: {}, missing: 'webhookUrl' },
|
{ name: 'n8n_delete_execution', args: {}, expected: 'n8n_delete_execution: Validation failed:\n • id: id is required' },
|
||||||
{ name: 'n8n_get_execution', args: {}, missing: 'id' },
|
|
||||||
{ name: 'n8n_delete_execution', args: {}, missing: 'id' },
|
|
||||||
];
|
];
|
||||||
|
|
||||||
|
// n8n_update_partial_workflow and n8n_trigger_webhook_workflow use legacy validation
|
||||||
|
await expect(server.testExecuteTool('n8n_update_partial_workflow', {}))
|
||||||
|
.rejects.toThrow('Missing required parameters for n8n_update_partial_workflow: id, operations');
|
||||||
|
|
||||||
|
await expect(server.testExecuteTool('n8n_trigger_webhook_workflow', {}))
|
||||||
|
.rejects.toThrow('Missing required parameters for n8n_trigger_webhook_workflow: webhookUrl');
|
||||||
|
|
||||||
for (const tool of n8nToolsWithRequiredParams) {
|
for (const tool of n8nToolsWithRequiredParams) {
|
||||||
await expect(server.testExecuteTool(tool.name, tool.args))
|
await expect(server.testExecuteTool(tool.name, tool.args))
|
||||||
.rejects.toThrow(`Missing required parameters for ${tool.name}: ${tool.missing}`);
|
.rejects.toThrow(tool.expected);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -223,7 +223,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
it('should error when nodes array is missing', async () => {
|
it('should error when nodes array is missing', async () => {
|
||||||
const workflow = { connections: {} } as any;
|
const workflow = { connections: {} } as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message === 'Workflow must have a nodes array')).toBe(true);
|
expect(result.errors.some(e => e.message === 'Workflow must have a nodes array')).toBe(true);
|
||||||
@@ -232,7 +232,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
it('should error when connections object is missing', async () => {
|
it('should error when connections object is missing', async () => {
|
||||||
const workflow = { nodes: [] } as any;
|
const workflow = { nodes: [] } as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message === 'Workflow must have a connections object')).toBe(true);
|
expect(result.errors.some(e => e.message === 'Workflow must have a connections object')).toBe(true);
|
||||||
@@ -241,7 +241,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
it('should warn when workflow has no nodes', async () => {
|
it('should warn when workflow has no nodes', async () => {
|
||||||
const workflow = { nodes: [], connections: {} } as any;
|
const workflow = { nodes: [], connections: {} } as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(true); // Empty workflows are valid but get a warning
|
expect(result.valid).toBe(true); // Empty workflows are valid but get a warning
|
||||||
expect(result.warnings).toHaveLength(1);
|
expect(result.warnings).toHaveLength(1);
|
||||||
@@ -260,7 +260,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message.includes('Single-node workflows are only valid for webhook endpoints'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Single-node workflows are only valid for webhook endpoints'))).toBe(true);
|
||||||
@@ -279,7 +279,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
expect(result.warnings.some(w => w.message.includes('Webhook node has no connections'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Webhook node has no connections'))).toBe(true);
|
||||||
@@ -306,7 +306,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message.includes('Multi-node workflow has no connections'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Multi-node workflow has no connections'))).toBe(true);
|
||||||
@@ -333,7 +333,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Duplicate node name: "Webhook"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Duplicate node name: "Webhook"'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -359,7 +359,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Duplicate node ID: "1"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Duplicate node ID: "1"'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -392,7 +392,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.triggerNodes).toBe(3);
|
expect(result.statistics.triggerNodes).toBe(3);
|
||||||
});
|
});
|
||||||
@@ -422,7 +422,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Workflow has no trigger nodes'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Workflow has no trigger nodes'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -449,7 +449,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.totalNodes).toBe(2);
|
expect(result.statistics.totalNodes).toBe(2);
|
||||||
expect(result.statistics.enabledNodes).toBe(1);
|
expect(result.statistics.enabledNodes).toBe(1);
|
||||||
@@ -472,7 +472,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(mockNodeRepository.getNode).not.toHaveBeenCalled();
|
expect(mockNodeRepository.getNode).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
@@ -491,7 +491,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message.includes('Invalid node type: "nodes-base.webhook"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Invalid node type: "nodes-base.webhook"'))).toBe(true);
|
||||||
@@ -512,7 +512,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
expect(result.errors.some(e => e.message.includes('Unknown node type: "httpRequest"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Unknown node type: "httpRequest"'))).toBe(true);
|
||||||
@@ -533,7 +533,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('n8n-nodes-base.webhook');
|
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('n8n-nodes-base.webhook');
|
||||||
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-base.webhook');
|
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-base.webhook');
|
||||||
@@ -553,7 +553,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('@n8n/n8n-nodes-langchain.agent');
|
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('@n8n/n8n-nodes-langchain.agent');
|
||||||
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-langchain.agent');
|
expect(mockNodeRepository.getNode).toHaveBeenCalledWith('nodes-langchain.agent');
|
||||||
@@ -574,7 +574,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Missing required property \'typeVersion\''))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Missing required property \'typeVersion\''))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -594,7 +594,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Invalid typeVersion: invalid'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Invalid typeVersion: invalid'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -614,7 +614,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Outdated typeVersion: 1. Latest is 2'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Outdated typeVersion: 1. Latest is 2'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -634,7 +634,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('typeVersion 10 exceeds maximum supported version 2'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('typeVersion 10 exceeds maximum supported version 2'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -664,7 +664,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Missing required field: url'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Missing required field: url'))).toBe(true);
|
||||||
expect(result.warnings.some(w => w.message.includes('Consider using HTTPS'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Consider using HTTPS'))).toBe(true);
|
||||||
@@ -689,7 +689,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Failed to validate node: Validation error'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Failed to validate node: Validation error'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -721,7 +721,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.validConnections).toBe(1);
|
expect(result.statistics.validConnections).toBe(1);
|
||||||
expect(result.statistics.invalidConnections).toBe(0);
|
expect(result.statistics.invalidConnections).toBe(0);
|
||||||
@@ -745,7 +745,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Connection from non-existent node: "NonExistent"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Connection from non-existent node: "NonExistent"'))).toBe(true);
|
||||||
expect(result.statistics.invalidConnections).toBe(1);
|
expect(result.statistics.invalidConnections).toBe(1);
|
||||||
@@ -776,7 +776,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Connection uses node ID \'webhook-id\' instead of node name \'Webhook\''))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Connection uses node ID \'webhook-id\' instead of node name \'Webhook\''))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -799,7 +799,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Connection to non-existent node: "NonExistent"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Connection to non-existent node: "NonExistent"'))).toBe(true);
|
||||||
expect(result.statistics.invalidConnections).toBe(1);
|
expect(result.statistics.invalidConnections).toBe(1);
|
||||||
@@ -830,7 +830,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Connection target uses node ID \'set-id\' instead of node name \'Set\''))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Connection target uses node ID \'set-id\' instead of node name \'Set\''))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -861,7 +861,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Connection to disabled node: "Set"'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Connection to disabled node: "Set"'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -891,7 +891,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.validConnections).toBe(1);
|
expect(result.statistics.validConnections).toBe(1);
|
||||||
});
|
});
|
||||||
@@ -921,7 +921,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.validConnections).toBe(1);
|
expect(result.statistics.validConnections).toBe(1);
|
||||||
});
|
});
|
||||||
@@ -953,7 +953,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Community node "CustomTool" is being used as an AI tool'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Community node "CustomTool" is being used as an AI tool'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -990,7 +990,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Node is not connected to any other nodes') && w.nodeName === 'Orphaned')).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Node is not connected to any other nodes') && w.nodeName === 'Orphaned')).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1033,7 +1033,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Workflow contains a cycle'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Workflow contains a cycle'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1068,7 +1068,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.statistics.validConnections).toBe(1);
|
expect(result.statistics.validConnections).toBe(1);
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
@@ -1110,7 +1110,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(ExpressionValidator.validateNodeExpressions).toHaveBeenCalledWith(
|
expect(ExpressionValidator.validateNodeExpressions).toHaveBeenCalledWith(
|
||||||
expect.objectContaining({ values: expect.any(Object) }),
|
expect.objectContaining({ values: expect.any(Object) }),
|
||||||
@@ -1146,7 +1146,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Expression error: Invalid expression syntax'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Expression error: Invalid expression syntax'))).toBe(true);
|
||||||
expect(result.warnings.some(w => w.message.includes('Expression warning: Deprecated variable usage'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Expression warning: Deprecated variable usage'))).toBe(true);
|
||||||
@@ -1170,7 +1170,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(ExpressionValidator.validateNodeExpressions).not.toHaveBeenCalled();
|
expect(ExpressionValidator.validateNodeExpressions).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
@@ -1187,7 +1187,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
|
|
||||||
const workflow = builder.build() as any;
|
const workflow = builder.build() as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Consider adding error handling'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Consider adding error handling'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1208,7 +1208,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
|
|
||||||
const workflow = builder.build() as any;
|
const workflow = builder.build() as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Long linear chain detected'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Long linear chain detected'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1230,7 +1230,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Missing credentials configuration for slackApi'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Missing credentials configuration for slackApi'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1249,7 +1249,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('AI Agent has no tools connected'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('AI Agent has no tools connected'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1279,7 +1279,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('N8N_COMMUNITY_PACKAGES_ALLOW_TOOL_USAGE'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('N8N_COMMUNITY_PACKAGES_ALLOW_TOOL_USAGE'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1306,7 +1306,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Node-level properties onError, retryOnFail, credentials are in the wrong location'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Node-level properties onError, retryOnFail, credentials are in the wrong location'))).toBe(true);
|
||||||
expect(result.errors.some(e => e.details?.fix?.includes('Move these properties from node.parameters to the node level'))).toBe(true);
|
expect(result.errors.some(e => e.details?.fix?.includes('Move these properties from node.parameters to the node level'))).toBe(true);
|
||||||
@@ -1327,7 +1327,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Invalid onError value: "invalidValue"'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Invalid onError value: "invalidValue"'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1347,7 +1347,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Using deprecated "continueOnFail: true"'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Using deprecated "continueOnFail: true"'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1368,7 +1368,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('Cannot use both "continueOnFail" and "onError" properties'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Cannot use both "continueOnFail" and "onError" properties'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1390,7 +1390,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('maxTries must be a positive number'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('maxTries must be a positive number'))).toBe(true);
|
||||||
expect(result.errors.some(e => e.message.includes('waitBetweenTries must be a non-negative number'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('waitBetweenTries must be a non-negative number'))).toBe(true);
|
||||||
@@ -1413,7 +1413,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('maxTries is set to 15'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('maxTries is set to 15'))).toBe(true);
|
||||||
expect(result.warnings.some(w => w.message.includes('waitBetweenTries is set to 400000ms'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('waitBetweenTries is set to 400000ms'))).toBe(true);
|
||||||
@@ -1434,7 +1434,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('retryOnFail is enabled but maxTries is not specified'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('retryOnFail is enabled but maxTries is not specified'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1459,7 +1459,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes('alwaysOutputData must be a boolean'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('alwaysOutputData must be a boolean'))).toBe(true);
|
||||||
@@ -1484,7 +1484,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('executeOnce is enabled'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('executeOnce is enabled'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1512,7 +1512,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes(nodeInfo.message) && w.message.includes('without error handling'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes(nodeInfo.message) && w.message.includes('without error handling'))).toBe(true);
|
||||||
}
|
}
|
||||||
@@ -1534,7 +1534,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.warnings.some(w => w.message.includes('Both continueOnFail and retryOnFail are enabled'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Both continueOnFail and retryOnFail are enabled'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1554,7 +1554,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Consider enabling alwaysOutputData'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Consider enabling alwaysOutputData'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1569,7 +1569,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
|
|
||||||
const workflow = builder.build() as any;
|
const workflow = builder.build() as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Most nodes lack error handling'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Most nodes lack error handling'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1589,7 +1589,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Replace "continueOnFail: true" with "onError:'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Replace "continueOnFail: true" with "onError:'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1610,7 +1610,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Add a trigger node'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Add a trigger node'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1636,7 +1636,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {} // Missing connections
|
connections: {} // Missing connections
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Example connection structure'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Example connection structure'))).toBe(true);
|
||||||
expect(result.suggestions.some(s => s.includes('Use node NAMES (not IDs) in connections'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Use node NAMES (not IDs) in connections'))).toBe(true);
|
||||||
@@ -1667,7 +1667,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Add error handling'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Add error handling'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1682,7 +1682,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
|
|
||||||
const workflow = builder.build() as any;
|
const workflow = builder.build() as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Consider breaking this workflow into smaller sub-workflows'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Consider breaking this workflow into smaller sub-workflows'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1708,7 +1708,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('Consider using a Code node for complex data transformations'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('Consider using a Code node for complex data transformations'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1727,7 +1727,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.suggestions.some(s => s.includes('A minimal workflow needs'))).toBe(true);
|
expect(result.suggestions.some(s => s.includes('A minimal workflow needs'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -1756,7 +1756,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.errors.some(e => e.message.includes(`Did you mean`) && e.message.includes(testCase.suggestion))).toBe(true);
|
expect(result.errors.some(e => e.message.includes(`Did you mean`) && e.message.includes(testCase.suggestion))).toBe(true);
|
||||||
}
|
}
|
||||||
@@ -1848,7 +1848,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Should have multiple errors
|
// Should have multiple errors
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
@@ -1940,7 +1940,7 @@ describe('WorkflowValidator - Comprehensive Tests', () => {
|
|||||||
}
|
}
|
||||||
} as any;
|
} as any;
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
expect(result.errors).toHaveLength(0);
|
expect(result.errors).toHaveLength(0);
|
||||||
|
|||||||
@@ -157,7 +157,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
nodes: [],
|
nodes: [],
|
||||||
connections: {}
|
connections: {}
|
||||||
};
|
};
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
expect(result.warnings.some(w => w.message.includes('empty'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('empty'))).toBe(true);
|
||||||
});
|
});
|
||||||
@@ -181,7 +181,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
const workflow = { nodes, connections };
|
const workflow = { nodes, connections };
|
||||||
|
|
||||||
const start = Date.now();
|
const start = Date.now();
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
const duration = Date.now() - start;
|
const duration = Date.now() - start;
|
||||||
|
|
||||||
expect(result).toBeDefined();
|
expect(result).toBeDefined();
|
||||||
@@ -207,7 +207,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.statistics.invalidConnections).toBe(0);
|
expect(result.statistics.invalidConnections).toBe(0);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -228,7 +228,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@@ -264,7 +264,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.errors.length).toBeGreaterThan(0);
|
expect(result.errors.length).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -292,7 +292,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.warnings.some(w => w.message.includes('self-referencing'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('self-referencing'))).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -308,7 +308,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.errors.some(e => e.message.includes('non-existent'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('non-existent'))).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -324,7 +324,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.errors.length).toBeGreaterThan(0);
|
expect(result.errors.length).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -341,7 +341,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
} as any
|
} as any
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
// Should still work as type and index can have defaults
|
// Should still work as type and index can have defaults
|
||||||
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
@@ -359,7 +359,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.errors.some(e => e.message.includes('Invalid'))).toBe(true);
|
expect(result.errors.some(e => e.message.includes('Invalid'))).toBe(true);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@@ -382,7 +382,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -395,7 +395,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
connections: {}
|
connections: {}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.warnings.some(w => w.message.includes('very long'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('very long'))).toBe(true);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@@ -479,7 +479,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@@ -499,7 +499,7 @@ describe('WorkflowValidator - Edge Cases', () => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
expect(result.errors.length).toBeGreaterThan(0);
|
expect(result.errors.length).toBeGreaterThan(0);
|
||||||
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
expect(result.statistics.validConnections).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -77,7 +77,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
@@ -113,7 +113,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
@@ -154,7 +154,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
@@ -229,7 +229,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(true);
|
expect(result.valid).toBe(true);
|
||||||
@@ -297,7 +297,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
@@ -386,7 +386,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
@@ -438,7 +438,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.warnings.some(w => w.message.includes('Outdated typeVersion'))).toBe(true);
|
expect(result.warnings.some(w => w.message.includes('Outdated typeVersion'))).toBe(true);
|
||||||
@@ -471,7 +471,7 @@ describe('WorkflowValidator - Simple Unit Tests', () => {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Act
|
// Act
|
||||||
const result = await validator.validateWorkflow(workflow);
|
const result = await validator.validateWorkflow(workflow as any);
|
||||||
|
|
||||||
// Assert
|
// Assert
|
||||||
expect(result.valid).toBe(false);
|
expect(result.valid).toBe(false);
|
||||||
|
|||||||
411
tests/unit/validation-fixes.test.ts
Normal file
411
tests/unit/validation-fixes.test.ts
Normal file
@@ -0,0 +1,411 @@
|
|||||||
|
/**
|
||||||
|
* Test suite for validation system fixes
|
||||||
|
* Covers issues #58, #68, #70, #73
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { describe, test, expect, beforeAll, afterAll } from 'vitest';
|
||||||
|
import { WorkflowValidator } from '../../src/services/workflow-validator';
|
||||||
|
import { EnhancedConfigValidator } from '../../src/services/enhanced-config-validator';
|
||||||
|
import { ToolValidation, Validator, ValidationError } from '../../src/utils/validation-schemas';
|
||||||
|
|
||||||
|
describe('Validation System Fixes', () => {
|
||||||
|
let workflowValidator: WorkflowValidator;
|
||||||
|
let mockNodeRepository: any;
|
||||||
|
|
||||||
|
beforeAll(async () => {
|
||||||
|
// Initialize test environment
|
||||||
|
process.env.NODE_ENV = 'test';
|
||||||
|
|
||||||
|
// Mock repository for testing
|
||||||
|
mockNodeRepository = {
|
||||||
|
getNode: (nodeType: string) => {
|
||||||
|
if (nodeType === 'nodes-base.webhook' || nodeType === 'n8n-nodes-base.webhook') {
|
||||||
|
return {
|
||||||
|
nodeType: 'nodes-base.webhook',
|
||||||
|
displayName: 'Webhook',
|
||||||
|
properties: [
|
||||||
|
{ name: 'path', required: true, displayName: 'Path' },
|
||||||
|
{ name: 'httpMethod', required: true, displayName: 'HTTP Method' }
|
||||||
|
]
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (nodeType === 'nodes-base.set' || nodeType === 'n8n-nodes-base.set') {
|
||||||
|
return {
|
||||||
|
nodeType: 'nodes-base.set',
|
||||||
|
displayName: 'Set',
|
||||||
|
properties: [
|
||||||
|
{ name: 'values', required: false, displayName: 'Values' }
|
||||||
|
]
|
||||||
|
};
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
} as any;
|
||||||
|
|
||||||
|
workflowValidator = new WorkflowValidator(mockNodeRepository, EnhancedConfigValidator);
|
||||||
|
});
|
||||||
|
|
||||||
|
afterAll(() => {
|
||||||
|
// Reset NODE_ENV instead of deleting it
|
||||||
|
delete (process.env as any).NODE_ENV;
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Issue #73: validate_node_minimal crashes without input validation', () => {
|
||||||
|
test('should handle empty config in validation schemas', () => {
|
||||||
|
// Test the validation schema handles empty config
|
||||||
|
const result = ToolValidation.validateNodeMinimal({
|
||||||
|
nodeType: 'nodes-base.webhook',
|
||||||
|
config: undefined
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(false);
|
||||||
|
expect(result.errors.length).toBeGreaterThan(0);
|
||||||
|
expect(result.errors[0].field).toBe('config');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle null config in validation schemas', () => {
|
||||||
|
const result = ToolValidation.validateNodeMinimal({
|
||||||
|
nodeType: 'nodes-base.webhook',
|
||||||
|
config: null
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(false);
|
||||||
|
expect(result.errors.length).toBeGreaterThan(0);
|
||||||
|
expect(result.errors[0].field).toBe('config');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should accept valid config object', () => {
|
||||||
|
const result = ToolValidation.validateNodeMinimal({
|
||||||
|
nodeType: 'nodes-base.webhook',
|
||||||
|
config: { path: '/webhook', httpMethod: 'POST' }
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(true);
|
||||||
|
expect(result.errors).toHaveLength(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Issue #58: validate_node_operation crashes on nested input', () => {
|
||||||
|
test('should handle invalid nodeType gracefully', () => {
|
||||||
|
expect(() => {
|
||||||
|
EnhancedConfigValidator.validateWithMode(
|
||||||
|
undefined as any,
|
||||||
|
{ resource: 'channel', operation: 'create' },
|
||||||
|
[],
|
||||||
|
'operation',
|
||||||
|
'ai-friendly'
|
||||||
|
);
|
||||||
|
}).toThrow(Error);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle null nodeType gracefully', () => {
|
||||||
|
expect(() => {
|
||||||
|
EnhancedConfigValidator.validateWithMode(
|
||||||
|
null as any,
|
||||||
|
{ resource: 'channel', operation: 'create' },
|
||||||
|
[],
|
||||||
|
'operation',
|
||||||
|
'ai-friendly'
|
||||||
|
);
|
||||||
|
}).toThrow(Error);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle non-string nodeType gracefully', () => {
|
||||||
|
expect(() => {
|
||||||
|
EnhancedConfigValidator.validateWithMode(
|
||||||
|
{ type: 'nodes-base.slack' } as any,
|
||||||
|
{ resource: 'channel', operation: 'create' },
|
||||||
|
[],
|
||||||
|
'operation',
|
||||||
|
'ai-friendly'
|
||||||
|
);
|
||||||
|
}).toThrow(Error);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle valid nodeType properly', () => {
|
||||||
|
const result = EnhancedConfigValidator.validateWithMode(
|
||||||
|
'nodes-base.set',
|
||||||
|
{ values: {} },
|
||||||
|
[],
|
||||||
|
'operation',
|
||||||
|
'ai-friendly'
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(typeof result.valid).toBe('boolean');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Issue #70: Profile settings not respected', () => {
|
||||||
|
test('should pass profile parameter to all validation phases', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Webhook',
|
||||||
|
type: 'n8n-nodes-base.webhook',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: { path: '/test', httpMethod: 'POST' },
|
||||||
|
typeVersion: 1
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '2',
|
||||||
|
name: 'Set',
|
||||||
|
type: 'n8n-nodes-base.set',
|
||||||
|
position: [300, 200] as [number, number],
|
||||||
|
parameters: { values: {} },
|
||||||
|
typeVersion: 1
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {
|
||||||
|
'Webhook': {
|
||||||
|
main: [[{ node: 'Set', type: 'main', index: 0 }]]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow, {
|
||||||
|
validateNodes: true,
|
||||||
|
validateConnections: true,
|
||||||
|
validateExpressions: true,
|
||||||
|
profile: 'minimal'
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(true);
|
||||||
|
// In minimal profile, should have fewer warnings/errors - just check it's reasonable
|
||||||
|
expect(result.warnings.length).toBeLessThanOrEqual(5);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should filter out sticky notes from validation', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Webhook',
|
||||||
|
type: 'n8n-nodes-base.webhook',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: { path: '/test', httpMethod: 'POST' },
|
||||||
|
typeVersion: 1
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '2',
|
||||||
|
name: 'Sticky Note',
|
||||||
|
type: 'n8n-nodes-base.stickyNote',
|
||||||
|
position: [300, 100] as [number, number],
|
||||||
|
parameters: { content: 'This is a note' },
|
||||||
|
typeVersion: 1
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.statistics.totalNodes).toBe(1); // Only webhook, sticky note excluded
|
||||||
|
expect(result.statistics.enabledNodes).toBe(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should allow legitimate loops in cycle detection', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Manual Trigger',
|
||||||
|
type: 'n8n-nodes-base.manualTrigger',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: {},
|
||||||
|
typeVersion: 1
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '2',
|
||||||
|
name: 'SplitInBatches',
|
||||||
|
type: 'n8n-nodes-base.splitInBatches',
|
||||||
|
position: [300, 200] as [number, number],
|
||||||
|
parameters: { batchSize: 1 },
|
||||||
|
typeVersion: 1
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '3',
|
||||||
|
name: 'Set',
|
||||||
|
type: 'n8n-nodes-base.set',
|
||||||
|
position: [500, 200] as [number, number],
|
||||||
|
parameters: { values: {} },
|
||||||
|
typeVersion: 1
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {
|
||||||
|
'Manual Trigger': {
|
||||||
|
main: [[{ node: 'SplitInBatches', type: 'main', index: 0 }]]
|
||||||
|
},
|
||||||
|
'SplitInBatches': {
|
||||||
|
main: [
|
||||||
|
[{ node: 'Set', type: 'main', index: 0 }], // Done output
|
||||||
|
[{ node: 'Set', type: 'main', index: 0 }] // Loop output
|
||||||
|
]
|
||||||
|
},
|
||||||
|
'Set': {
|
||||||
|
main: [[{ node: 'SplitInBatches', type: 'main', index: 0 }]] // Loop back
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
// Should not report cycle error for legitimate SplitInBatches loop
|
||||||
|
const cycleErrors = result.errors.filter(e => e.message.includes('cycle'));
|
||||||
|
expect(cycleErrors).toHaveLength(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Issue #68: Better error recovery suggestions', () => {
|
||||||
|
test('should provide recovery suggestions for invalid node types', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Invalid Node',
|
||||||
|
type: 'invalid-node-type',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: {},
|
||||||
|
typeVersion: 1
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(false);
|
||||||
|
expect(result.suggestions.length).toBeGreaterThan(0);
|
||||||
|
|
||||||
|
// Should contain recovery suggestions
|
||||||
|
const recoveryStarted = result.suggestions.some(s => s.includes('🔧 RECOVERY'));
|
||||||
|
expect(recoveryStarted).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should provide recovery suggestions for connection errors', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Webhook',
|
||||||
|
type: 'n8n-nodes-base.webhook',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: { path: '/test', httpMethod: 'POST' },
|
||||||
|
typeVersion: 1
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {
|
||||||
|
'Webhook': {
|
||||||
|
main: [[{ node: 'NonExistentNode', type: 'main', index: 0 }]]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(false);
|
||||||
|
expect(result.suggestions.length).toBeGreaterThan(0);
|
||||||
|
|
||||||
|
// Should contain connection recovery suggestions
|
||||||
|
const connectionRecovery = result.suggestions.some(s =>
|
||||||
|
s.includes('Connection errors detected') || s.includes('connection')
|
||||||
|
);
|
||||||
|
expect(connectionRecovery).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should provide workflow for multiple errors', async () => {
|
||||||
|
const workflow = {
|
||||||
|
nodes: [
|
||||||
|
{
|
||||||
|
id: '1',
|
||||||
|
name: 'Invalid Node 1',
|
||||||
|
type: 'invalid-type-1',
|
||||||
|
position: [100, 200] as [number, number],
|
||||||
|
parameters: {}
|
||||||
|
// Missing typeVersion
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '2',
|
||||||
|
name: 'Invalid Node 2',
|
||||||
|
type: 'invalid-type-2',
|
||||||
|
position: [300, 200] as [number, number],
|
||||||
|
parameters: {}
|
||||||
|
// Missing typeVersion
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: '3',
|
||||||
|
name: 'Invalid Node 3',
|
||||||
|
type: 'invalid-type-3',
|
||||||
|
position: [500, 200] as [number, number],
|
||||||
|
parameters: {}
|
||||||
|
// Missing typeVersion
|
||||||
|
}
|
||||||
|
],
|
||||||
|
connections: {
|
||||||
|
'Invalid Node 1': {
|
||||||
|
main: [[{ node: 'NonExistent', type: 'main', index: 0 }]]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const result = await workflowValidator.validateWorkflow(workflow);
|
||||||
|
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.valid).toBe(false);
|
||||||
|
expect(result.errors.length).toBeGreaterThan(3);
|
||||||
|
|
||||||
|
// Should provide step-by-step recovery workflow
|
||||||
|
const workflowSuggestion = result.suggestions.some(s =>
|
||||||
|
s.includes('SUGGESTED WORKFLOW') && s.includes('Too many errors detected')
|
||||||
|
);
|
||||||
|
expect(workflowSuggestion).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Enhanced Input Validation', () => {
|
||||||
|
test('should validate tool parameters with schemas', () => {
|
||||||
|
// Test validate_node_operation parameters
|
||||||
|
const validationResult = ToolValidation.validateNodeOperation({
|
||||||
|
nodeType: 'nodes-base.webhook',
|
||||||
|
config: { path: '/test' },
|
||||||
|
profile: 'ai-friendly'
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(validationResult.valid).toBe(true);
|
||||||
|
expect(validationResult.errors).toHaveLength(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should reject invalid parameters', () => {
|
||||||
|
const validationResult = ToolValidation.validateNodeOperation({
|
||||||
|
nodeType: 123, // Invalid type
|
||||||
|
config: 'not an object', // Invalid type
|
||||||
|
profile: 'invalid-profile' // Invalid enum value
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(validationResult.valid).toBe(false);
|
||||||
|
expect(validationResult.errors.length).toBeGreaterThan(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should format validation errors properly', () => {
|
||||||
|
const validationResult = ToolValidation.validateNodeOperation({
|
||||||
|
nodeType: null,
|
||||||
|
config: null
|
||||||
|
});
|
||||||
|
|
||||||
|
const errorMessage = Validator.formatErrors(validationResult, 'validate_node_operation');
|
||||||
|
|
||||||
|
expect(errorMessage).toContain('validate_node_operation: Validation failed:');
|
||||||
|
expect(errorMessage).toContain('nodeType');
|
||||||
|
expect(errorMessage).toContain('config');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
Reference in New Issue
Block a user