ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-02-06 05:23:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: resolve merge conflict in mcp-context.ts

Browse Source
This commit is contained in:
czlonkowski
2025-10-04 12:27:19 +02:00
parent 7a402bc7ad 00289e90d7
commit 62d01ab237
4 changed files with 275 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

192
tests/integration/n8n-api/workflows/create-workflow.test.ts
View File

@@ -10,6 +10,7 @@ import { describe, it, expect, beforeEach, afterEach, afterAll } from 'vitest';
import { createTestContext, TestContext, createTestWorkflowName } from '../utils/test-context';
import { getTestN8nClient } from '../utils/n8n-client';
import { N8nApiClient } from '../../../../src/services/n8n-api-client';
import { Workflow } from '../../../../src/types/n8n-api';
import {
SIMPLE_WEBHOOK_WORKFLOW,
SIMPLE_HTTP_WORKFLOW,
@@ -20,14 +21,19 @@ import {
getFixture
} from '../utils/fixtures';
import { cleanupOrphanedWorkflows } from '../utils/cleanup-helpers';
import { createMcpContext } from '../utils/mcp-context';
import { InstanceContext } from '../../../../src/types/instance-context';
import { handleCreateWorkflow } from '../../../../src/mcp/handlers-n8n-manager';
describe('Integration: handleCreateWorkflow', () => {
let context: TestContext;
let client: N8nApiClient;
let mcpContext: InstanceContext;
beforeEach(() => {
context = createTestContext();
client = getTestN8nClient();
mcpContext = createMcpContext();
});
afterEach(async () => {
@@ -62,8 +68,10 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('simple-webhook')
};
// Create workflow
const result = await client.createWorkflow(workflow);
// Create workflow using MCP handler
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
// Verify workflow created successfully
expect(result).toBeDefined();
@@ -92,7 +100,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('simple-http')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -102,8 +112,8 @@ describe('Integration: handleCreateWorkflow', () => {
expect(result.nodes).toHaveLength(2);
// Verify both nodes created with FULL type format
const webhookNode = result.nodes.find(n => n.name === 'Webhook');
const httpNode = result.nodes.find(n => n.name === 'HTTP Request');
const webhookNode = result.nodes.find((n: any) => n.name === 'Webhook');
const httpNode = result.nodes.find((n: any) => n.name === 'HTTP Request');
expect(webhookNode).toBeDefined();
expect(webhookNode!.type).toBe('n8n-nodes-base.webhook');
@@ -123,7 +133,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('ai-agent')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -133,7 +145,7 @@ describe('Integration: handleCreateWorkflow', () => {
expect(result.nodes).toHaveLength(2);
// Verify langchain node type format
const agentNode = result.nodes.find(n => n.name === 'AI Agent');
const agentNode = result.nodes.find((n: any) => n.name === 'AI Agent');
expect(agentNode).toBeDefined();
expect(agentNode!.type).toBe('@n8n/n8n-nodes-langchain.agent');
});
@@ -145,7 +157,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('multi-node')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -155,7 +169,7 @@ describe('Integration: handleCreateWorkflow', () => {
expect(result.nodes).toHaveLength(4);
// Verify all node types preserved
const nodeTypes = result.nodes.map(n => n.type);
const nodeTypes = result.nodes.map((n: any) => n.type);
expect(nodeTypes).toContain('n8n-nodes-base.webhook');
expect(nodeTypes).toContain('n8n-nodes-base.set');
expect(nodeTypes).toContain('n8n-nodes-base.merge');
@@ -177,7 +191,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('multi-node')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -214,7 +230,9 @@ describe('Integration: handleCreateWorkflow', () => {
}
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -231,7 +249,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('expression')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -240,7 +260,7 @@ describe('Integration: handleCreateWorkflow', () => {
expect(result.nodes).toHaveLength(2);
// Verify Set node with expressions
const setNode = result.nodes.find(n => n.name === 'Set Variables');
const setNode = result.nodes.find((n: any) => n.name === 'Set Variables');
expect(setNode).toBeDefined();
expect(setNode!.parameters.assignments).toBeDefined();
@@ -259,7 +279,9 @@ describe('Integration: handleCreateWorkflow', () => {
...getFixture('error-handling')
};
const result = await client.createWorkflow(workflow);
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(true);
const result = response.data as Workflow;
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
@@ -268,7 +290,7 @@ describe('Integration: handleCreateWorkflow', () => {
expect(result.nodes).toHaveLength(3);
// Verify HTTP node with error handling
const httpNode = result.nodes.find(n => n.name === 'HTTP Request');
const httpNode = result.nodes.find((n: any) => n.name === 'HTTP Request');
expect(httpNode).toBeDefined();
expect(httpNode!.continueOnFail).toBe(true);
expect(httpNode!.onError).toBe('continueErrorOutput');
@@ -284,10 +306,12 @@ describe('Integration: handleCreateWorkflow', () => {
// ======================================================================
describe('Error Scenarios', () => {
it('should accept workflow with invalid node type (fails at execution time)', async () => {
// Note: n8n API accepts workflows with invalid node types at creation time.
// The error only occurs when trying to execute the workflow.
// This documents the actual API behavior.
it('should reject workflow with invalid node type (MCP validation)', async () => {
// MCP handler correctly validates workflows before sending to n8n API.
// Invalid node types are caught during MCP validation.
//
// Note: Raw n8n API would accept this and only fail at execution time,
// but MCP handler does proper pre-validation (correct behavior).
const workflowName = createTestWorkflowName('Invalid Node Type');
const workflow = {
@@ -306,17 +330,19 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
// n8n API accepts the workflow (validation happens at execution time)
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
expect(result.nodes[0].type).toBe('n8n-nodes-base.nonexistentnode');
// MCP handler rejects invalid workflows (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
expect(response.error).toContain('validation');
});
it('should accept workflow with missing required node parameters (fails at execution time)', async () => {
it('should reject workflow with missing required node parameters (MCP validation)', async () => {
// MCP handler validates required parameters before sending to n8n API.
//
// Note: Raw n8n API would accept this and only fail at execution time,
// but MCP handler does proper pre-validation (correct behavior).
const workflowName = createTestWorkflowName('Missing Parameters');
const workflow = {
name: workflowName,
@@ -337,18 +363,18 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
// n8n API accepts this during creation but fails during execution
// This test documents the actual API behavior
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
// Note: Validation happens at execution time, not creation time
// MCP handler rejects workflows with validation errors (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
});
it('should handle workflow with duplicate node names', async () => {
it('should reject workflow with duplicate node names (MCP validation)', async () => {
// MCP handler validates that node names are unique.
//
// Note: Raw n8n API might auto-rename duplicates, but MCP handler
// enforces unique names upfront (correct behavior).
const workflowName = createTestWorkflowName('Duplicate Node Names');
const workflow = {
name: workflowName,
@@ -380,23 +406,17 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
// n8n API should handle this - it may auto-rename or reject
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
// Verify n8n's handling of duplicate names
const nodeNames = result.nodes.map(n => n.name);
// Either both have same name or n8n renamed one
expect(nodeNames.length).toBe(2);
// MCP handler rejects workflows with validation errors (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
});
it('should accept workflow with invalid connection references (fails at execution time)', async () => {
// Note: n8n API accepts workflows with invalid connection references at creation time.
// The error only occurs when trying to execute the workflow.
// This documents the actual API behavior.
it('should reject workflow with invalid connection references (MCP validation)', async () => {
// MCP handler validates that connection references point to existing nodes.
//
// Note: Raw n8n API would accept this and only fail at execution time,
// but MCP handler does proper connection validation (correct behavior).
const workflowName = createTestWorkflowName('Invalid Connections');
const workflow = {
@@ -423,16 +443,11 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
// n8n API accepts the workflow (validation happens at execution time)
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
// Connection is preserved even though it references non-existent node
expect(result.connections.Webhook).toBeDefined();
expect(result.connections.Webhook.main[0][0].node).toBe('NonExistent');
// MCP handler rejects workflows with invalid connections (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
expect(response.error).toContain('validation');
});
});
@@ -441,7 +456,10 @@ describe('Integration: handleCreateWorkflow', () => {
// ======================================================================
describe('Edge Cases', () => {
it('should create minimal workflow with single node', async () => {
it('should reject single-node non-webhook workflow (MCP validation)', async () => {
// MCP handler enforces that single-node workflows are only valid for webhooks.
// This is a best practice validation.
const workflowName = createTestWorkflowName('Minimal Single Node');
const workflow = {
name: workflowName,
@@ -459,17 +477,17 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
expect(result.nodes).toHaveLength(1);
expect(result.nodes[0].type).toBe('n8n-nodes-base.manualTrigger');
// MCP handler rejects single-node non-webhook workflows (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
expect(response.error).toContain('validation');
});
it('should create workflow with empty connections object', async () => {
it('should reject single-node non-trigger workflow (MCP validation)', async () => {
// MCP handler enforces workflow best practices.
// Single isolated nodes without connections are rejected.
const workflowName = createTestWorkflowName('Empty Connections');
const workflow = {
name: workflowName,
@@ -490,16 +508,16 @@ describe('Integration: handleCreateWorkflow', () => {
settings: { executionOrder: 'v1' as const }
};
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
expect(result.connections).toEqual({});
// MCP handler rejects single-node workflows (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
});
it('should create workflow without settings object', async () => {
it('should reject single-node workflow without settings (MCP validation)', async () => {
// MCP handler enforces workflow best practices.
// Single-node non-webhook workflows are rejected.
const workflowName = createTestWorkflowName('No Settings');
const workflow = {
name: workflowName,
@@ -517,14 +535,10 @@ describe('Integration: handleCreateWorkflow', () => {
// No settings property
};
const result = await client.createWorkflow(workflow);
expect(result).toBeDefined();
expect(result.id).toBeTruthy();
if (!result.id) throw new Error('Workflow ID is missing');
context.trackWorkflow(result.id);
// n8n should apply default settings
expect(result.settings).toBeDefined();
// MCP handler rejects single-node workflows (correct behavior)
const response = await handleCreateWorkflow({ ...workflow }, mcpContext);
expect(response.success).toBe(false);
expect(response.error).toBeDefined();
});
});
});