mirror of
https://github.com/czlonkowski/n8n-mcp.git
synced 2026-03-23 02:43:08 +00:00
Add transferWorkflow diff operation to move workflows between n8n projects:
- TransferWorkflowOperation type with destinationProjectId field
- WorkflowDiffEngine validates and tracks transfer intent
- Handler calls PUT /workflows/{id}/transfer after update
- N8nApiClient.transferWorkflow() method
- Zod schema validates destinationProjectId is non-empty
- Tool description and documentation updated
- inferIntentFromOperations case for transfer
Also fixes two pre-existing bugs found during review:
- continueOnError path now properly extracts/propagates activation flags
- Debug log in updateConnectionReferences shows correct old name
Based on work by @djakielski in PR #645.
Conceived by Romuald Członkowski - https://www.aiadvisors.pl/en
This commit is contained in:
committed by
GitHub
parent
14962a39b6
commit
47a1cb135d
@@ -1250,6 +1250,56 @@ describe('N8nApiClient', () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe('transferWorkflow', () => {
|
||||
beforeEach(() => {
|
||||
client = new N8nApiClient(defaultConfig);
|
||||
});
|
||||
|
||||
it('should transfer workflow successfully via PUT', async () => {
|
||||
mockAxiosInstance.put.mockResolvedValue({ data: undefined });
|
||||
|
||||
await client.transferWorkflow('123', 'project-456');
|
||||
|
||||
expect(mockAxiosInstance.put).toHaveBeenCalledWith(
|
||||
'/workflows/123/transfer',
|
||||
{ destinationProjectId: 'project-456' }
|
||||
);
|
||||
});
|
||||
|
||||
it('should throw N8nNotFoundError on 404', async () => {
|
||||
const error = {
|
||||
message: 'Request failed',
|
||||
response: { status: 404, data: { message: 'Workflow not found' } }
|
||||
};
|
||||
await mockAxiosInstance.simulateError('put', error);
|
||||
|
||||
try {
|
||||
await client.transferWorkflow('123', 'project-456');
|
||||
expect.fail('Should have thrown an error');
|
||||
} catch (err) {
|
||||
expect(err).toBeInstanceOf(N8nNotFoundError);
|
||||
expect((err as N8nNotFoundError).message).toContain('not found');
|
||||
expect((err as N8nNotFoundError).statusCode).toBe(404);
|
||||
}
|
||||
});
|
||||
|
||||
it('should throw appropriate error on 403 forbidden', async () => {
|
||||
const error = {
|
||||
message: 'Request failed',
|
||||
response: { status: 403, data: { message: 'Forbidden' } }
|
||||
};
|
||||
await mockAxiosInstance.simulateError('put', error);
|
||||
|
||||
try {
|
||||
await client.transferWorkflow('123', 'project-456');
|
||||
expect.fail('Should have thrown an error');
|
||||
} catch (err) {
|
||||
expect(err).toBeInstanceOf(N8nApiError);
|
||||
expect((err as N8nApiError).statusCode).toBe(403);
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
describe('interceptors', () => {
|
||||
let requestInterceptor: any;
|
||||
let responseInterceptor: any;
|
||||
@@ -1317,4 +1367,4 @@ describe('N8nApiClient', () => {
|
||||
expect(result.message).toBe('Bad request');
|
||||
});
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -17,7 +17,8 @@ import {
|
||||
AddTagOperation,
|
||||
RemoveTagOperation,
|
||||
CleanStaleConnectionsOperation,
|
||||
ReplaceConnectionsOperation
|
||||
ReplaceConnectionsOperation,
|
||||
TransferWorkflowOperation
|
||||
} from '@/types/workflow-diff';
|
||||
import { Workflow } from '@/types/n8n-api';
|
||||
|
||||
@@ -4989,4 +4990,151 @@ describe('WorkflowDiffEngine', () => {
|
||||
expect('nonExistent' in updatedNode).toBe(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
describe('transferWorkflow operation', () => {
|
||||
it('should set transferToProjectId in result for valid transferWorkflow', async () => {
|
||||
const operation: TransferWorkflowOperation = {
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: 'project-abc-123'
|
||||
};
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations: [operation]
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.transferToProjectId).toBe('project-abc-123');
|
||||
});
|
||||
|
||||
it('should fail validation when destinationProjectId is empty', async () => {
|
||||
const operation: TransferWorkflowOperation = {
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: ''
|
||||
};
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations: [operation]
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.errors).toBeDefined();
|
||||
expect(result.errors![0].message).toContain('destinationProjectId');
|
||||
});
|
||||
|
||||
it('should fail validation when destinationProjectId is undefined', async () => {
|
||||
const operation = {
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: undefined
|
||||
} as any as TransferWorkflowOperation;
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations: [operation]
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.errors).toBeDefined();
|
||||
expect(result.errors![0].message).toContain('destinationProjectId');
|
||||
});
|
||||
|
||||
it('should not include transferToProjectId when no transferWorkflow operation is present', async () => {
|
||||
const operation: UpdateNameOperation = {
|
||||
type: 'updateName',
|
||||
name: 'Renamed Workflow'
|
||||
};
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations: [operation]
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.transferToProjectId).toBeUndefined();
|
||||
});
|
||||
|
||||
it('should combine updateName and transferWorkflow operations', async () => {
|
||||
const operations: WorkflowDiffOperation[] = [
|
||||
{
|
||||
type: 'updateName',
|
||||
name: 'Transferred Workflow'
|
||||
} as UpdateNameOperation,
|
||||
{
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: 'project-xyz-789'
|
||||
} as TransferWorkflowOperation
|
||||
];
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.operationsApplied).toBe(2);
|
||||
expect(result.workflow!.name).toBe('Transferred Workflow');
|
||||
expect(result.transferToProjectId).toBe('project-xyz-789');
|
||||
});
|
||||
|
||||
it('should combine removeTag and transferWorkflow in continueOnError mode', async () => {
|
||||
const operations: WorkflowDiffOperation[] = [
|
||||
{
|
||||
type: 'removeTag',
|
||||
tag: 'non-existent-tag'
|
||||
} as RemoveTagOperation,
|
||||
{
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: 'project-target-456'
|
||||
} as TransferWorkflowOperation
|
||||
];
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations,
|
||||
continueOnError: true
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(true);
|
||||
expect(result.transferToProjectId).toBe('project-target-456');
|
||||
});
|
||||
|
||||
it('should fail entire batch in atomic mode when transferWorkflow has empty destinationProjectId alongside updateName', async () => {
|
||||
const operations: WorkflowDiffOperation[] = [
|
||||
{
|
||||
type: 'updateName',
|
||||
name: 'Should Not Apply'
|
||||
} as UpdateNameOperation,
|
||||
{
|
||||
type: 'transferWorkflow',
|
||||
destinationProjectId: ''
|
||||
} as TransferWorkflowOperation
|
||||
];
|
||||
|
||||
const request: WorkflowDiffRequest = {
|
||||
id: 'test-workflow',
|
||||
operations
|
||||
};
|
||||
|
||||
const result = await diffEngine.applyDiff(baseWorkflow, request);
|
||||
|
||||
expect(result.success).toBe(false);
|
||||
expect(result.errors).toBeDefined();
|
||||
expect(result.errors![0].message).toContain('destinationProjectId');
|
||||
// In atomic mode, the workflow should not be returned since the batch failed
|
||||
expect(result.workflow).toBeUndefined();
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user