ros/n8n-mcp
1
0
Fork 0
mirror of https://github.com/czlonkowski/n8n-mcp.git synced 2026-03-20 17:33:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: improve test coverage with comprehensive test suites

Browse Source 
- Add comprehensive tests for ValidationServiceError (25 tests)
- Add tests for NodeRepository operations methods (23 tests)
- Add comprehensive tests for ResourceSimilarityService (66 tests)
- Add comprehensive tests for OperationSimilarityService (58 tests)
- Add integration tests for EnhancedConfigValidator (15 tests)
- Fix EnhancedConfigValidator to handle errors gracefully
- Add suggestions to both error objects and result.suggestions array
- Improve overall test coverage from 69.76% towards 80%+ target

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
czlonkowski
2025-09-25 09:17:02 +02:00
parent 3506497412
commit 370b063fe4
6 changed files with 3333 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
src/services/enhanced-config-validator.ts
View File

@@ -687,11 +687,17 @@ export class EnhancedConfigValidator extends ConfigValidator {
if (!resourceIsValid && config.resource !== '') {
// Find similar resources
const suggestions = this.resourceSimilarityService.findSimilarResources(
nodeType,
config.resource,
3
);
let suggestions: any[] = [];
try {
suggestions = this.resourceSimilarityService.findSimilarResources(
nodeType,
config.resource,
3
);
} catch (error) {
// If similarity service fails, continue with validation without suggestions
console.error('Resource similarity service error:', error);
}
// Build error message with suggestions
let errorMessage = `Invalid resource "${config.resource}" for node ${nodeType}.`;
@@ -718,12 +724,28 @@ export class EnhancedConfigValidator extends ConfigValidator {
}).join(', ')}${validResources.length > 5 ? '...' : ''}`;
}
result.errors.push({
const error: any = {
type: 'invalid_value',
property: 'resource',
message: errorMessage,
fix
});
};
// Add suggestion property if we have high confidence suggestions
if (suggestions.length > 0 && suggestions[0].confidence >= 0.5) {
error.suggestion = `Did you mean "${suggestions[0].value}"? ${suggestions[0].reason}`;
}
result.errors.push(error);
// Add suggestions to result.suggestions array
if (suggestions.length > 0) {
for (const suggestion of suggestions) {
result.suggestions.push(
`Resource "${config.resource}" not found. Did you mean "${suggestion.value}"? ${suggestion.reason}`
);
}
}
}
}
@@ -739,12 +761,18 @@ export class EnhancedConfigValidator extends ConfigValidator {
if (!operationIsValid && config.operation !== '') {
// Find similar operations
const suggestions = this.operationSimilarityService.findSimilarOperations(
nodeType,
config.operation,
config.resource,
3
);
let suggestions: any[] = [];
try {
suggestions = this.operationSimilarityService.findSimilarOperations(
nodeType,
config.operation,
config.resource,
3
);
} catch (error) {
// If similarity service fails, continue with validation without suggestions
console.error('Operation similarity service error:', error);
}
// Build error message with suggestions
let errorMessage = `Invalid operation "${config.operation}" for node ${nodeType}`;
@@ -775,12 +803,28 @@ export class EnhancedConfigValidator extends ConfigValidator {
}).join(', ')}${validOperations.length > 5 ? '...' : ''}`;
}
result.errors.push({
const error: any = {
type: 'invalid_value',
property: 'operation',
message: errorMessage,
fix
});
};
// Add suggestion property if we have high confidence suggestions
if (suggestions.length > 0 && suggestions[0].confidence >= 0.5) {
error.suggestion = `Did you mean "${suggestions[0].value}"? ${suggestions[0].reason}`;
}
result.errors.push(error);
// Add suggestions to result.suggestions array
if (suggestions.length > 0) {
for (const suggestion of suggestions) {
result.suggestions.push(
`Operation "${config.operation}" not found. Did you mean "${suggestion.value}"? ${suggestion.reason}`
);
}
}
}
}
}