fix: add error handling to repository methods per code review

- Added try-catch blocks to getNodePropertyDefaults and getDefaultOperationForResource
- Validates displayOptions structure before accessing to prevent crashes
- Returns safe defaults (empty object or undefined) on errors
- Ensures validation continues even with malformed node data
- Addresses code review feedback about error boundaries

src/database/node-repository.ts

@@ -382,24 +382,31 @@ export class NodeRepository {
    * Get default values for node properties
    */
   getNodePropertyDefaults(nodeType: string): Record<string, any> {
+    try {
       const node = this.getNode(nodeType);
       if (!node || !node.properties) return {};
 
       const defaults: Record<string, any> = {};
 
       for (const prop of node.properties) {
-      if (prop.default !== undefined) {
+        if (prop.name && prop.default !== undefined) {
           defaults[prop.name] = prop.default;
         }
       }
 
       return defaults;
+    } catch (error) {
+      // Log error and return empty defaults rather than throwing
+      console.error(`Error getting property defaults for ${nodeType}:`, error);
+      return {};
+    }
   }
 
   /**
    * Get the default operation for a specific resource
    */
   getDefaultOperationForResource(nodeType: string, resource?: string): string | undefined {
+    try {
       const node = this.getNode(nodeType);
       if (!node || !node.properties) return undefined;
 
@@ -408,9 +415,15 @@ export class NodeRepository {
         if (prop.name === 'operation') {
           // If there's a resource dependency, check if it matches
           if (resource && prop.displayOptions?.show?.resource) {
-          const allowedResources = Array.isArray(prop.displayOptions.show.resource)
-            ? prop.displayOptions.show.resource
-            : [prop.displayOptions.show.resource];
+            // Validate displayOptions structure
+            const resourceDep = prop.displayOptions.show.resource;
+            if (!Array.isArray(resourceDep) && typeof resourceDep !== 'string') {
+              continue; // Skip malformed displayOptions
+            }
+
+            const allowedResources = Array.isArray(resourceDep)
+              ? resourceDep
+              : [resourceDep];
 
             if (!allowedResources.includes(resource)) {
               continue; // This operation property doesn't apply to our resource
@@ -423,12 +436,18 @@ export class NodeRepository {
           }
 
           // If no default but has options, return the first option's value
-        if (prop.options && prop.options.length > 0) {
+          if (prop.options && Array.isArray(prop.options) && prop.options.length > 0) {
             const firstOption = prop.options[0];
             return typeof firstOption === 'string' ? firstOption : firstOption.value;
           }
         }
       }
+    } catch (error) {
+      // Log error and return undefined rather than throwing
+      // This ensures validation continues even with malformed node data
+      console.error(`Error getting default operation for ${nodeType}:`, error);
+      return undefined;
+    }
 
     return undefined;
   }