- Add projectRoot and tag context to all dependency commands
- Add projectRoot and tag context to remove-subtask command
- Add --tag option to remove-subtask command
- Fixes critical bug where remove-subtask was deleting other tags due to missing context
- All dependency and subtask commands now properly handle tagged task lists
Major Issues Fixed:
1. Tag Deletion Bug: Fixed critical issue where creating subtasks would delete other tags
- Root cause: writeJSON function wasn't accepting projectRoot/tag parameters
- Fixed writeJSON signature and logic to handle tagged data structure
- Added proper merging of resolved tag data back into full tagged structure
2. Persistent Migration Notice: Fixed FYI notice showing after every command
- Root cause: markMigrationForNotice was resetting migrationNoticeShown to false
- Fixed migration logic to only trigger on actual legacy->tagged migrations
- Added proper _rawTaggedData checks to prevent false migration detection
3. Data Corruption Prevention: Enhanced data integrity safeguards
- Fixed writeJSON to filter out internal properties
- Added automatic cleanup of rogue properties
- Improved hasTaggedStructure detection logic
Commands Fixed: add-subtask, remove-subtask, and all commands now preserve tags correctly
This commit focuses on standardizing configuration and API key access patterns across key modules as part of subtask 61.34.
Key changes include:
- Refactored `ai-services.js` to remove global AI clients and use `resolveEnvVariable` for API key checks. Client instantiation now relies on `getAnthropicClient`/`getPerplexityClient` accepting a session object.
- Refactored `task-manager.js` (`analyzeTaskComplexity` function) to use the unified `generateTextService` from `ai-services-unified.js`, removing direct AI client calls.
- Replaced direct `process.env` access for model parameters and other configurations (`PERPLEXITY_MODEL`, `CONFIG.*`) in `task-manager.js` with calls to the appropriate getters from `config-manager.js` (e.g., `getResearchModelId(session)`, `getMainMaxTokens(session)`).
- Ensured `utils.js` (`resolveEnvVariable`) correctly handles potentially undefined session objects.
- Updated function signatures where necessary to propagate the `session` object for correct context-aware configuration/key retrieval.
This moves towards the goal of using `ai-client-factory.js` and `ai-services-unified.js` as the standard pattern for AI interactions and centralizing configuration management through `config-manager.js`.
