Commit Graph

1010 Commits

Author SHA1 Message Date
Eyal Toledano
a5370ebdb7 Merge pull request #61 from eyaltoledano/update-subtask
Okay, focusing specifically on the `update-subtask` functionality and the related fix we worked on, here's a succinct description suitable for a commit message body or PR:

*   **`update-subtask` Feature:**
    *   Allows appending additional information (details, context) to an *existing* subtask using AI (`updateSubtaskById` function in `task-manager.js`).
    *   Crucially, it *adds* information rather than overwriting existing content.
    *   Uses XML-like tags (`<info added on ...>`) with timestamps to mark the added content within the subtask's `details` field in `tasks.json`.
    *   Preserves completed subtasks, preventing modification of 'done' items.
*   **Associated UI Fix:**
    *   Corrected the `show <subtask_id>` command (`displayTaskById` in `ui.js`) to display the `details` field for subtasks.
    *   This ensures the information appended by `update-subtask` is actually visible to the user.
2025-03-29 20:36:36 -04:00
Eyal Toledano
7fbaab6eaa Merge pull request #61 from eyaltoledano/update-subtask
Okay, focusing specifically on the `update-subtask` functionality and the related fix we worked on, here's a succinct description suitable for a commit message body or PR:

*   **`update-subtask` Feature:**
    *   Allows appending additional information (details, context) to an *existing* subtask using AI (`updateSubtaskById` function in `task-manager.js`).
    *   Crucially, it *adds* information rather than overwriting existing content.
    *   Uses XML-like tags (`<info added on ...>`) with timestamps to mark the added content within the subtask's `details` field in `tasks.json`.
    *   Preserves completed subtasks, preventing modification of 'done' items.
*   **Associated UI Fix:**
    *   Corrected the `show <subtask_id>` command (`displayTaskById` in `ui.js`) to display the `details` field for subtasks.
    *   This ensures the information appended by `update-subtask` is actually visible to the user.
2025-03-29 20:36:36 -04:00
Eyal Toledano
1094f50014 fix(ui): Display subtask details in 'show' command output
Ensures that the 'details' field, which can be updated via 'update-subtask', is correctly rendered when viewing a specific subtask.

fix(test): Remove empty describe block causing Jest error

Removes a redundant  block in  that contained a  hook but no tests.

chore: Add  npm script
2025-03-29 20:33:18 -04:00
Eyal Toledano
e0005c75bb fix(ui): Display subtask details in 'show' command output
Ensures that the 'details' field, which can be updated via 'update-subtask', is correctly rendered when viewing a specific subtask.

fix(test): Remove empty describe block causing Jest error

Removes a redundant  block in  that contained a  hook but no tests.

chore: Add  npm script
2025-03-29 20:33:18 -04:00
Eyal Toledano
4604f96a92 New update-subtask command. 2025-03-29 19:14:44 -04:00
Eyal Toledano
31d6bd59e8 New update-subtask command. 2025-03-29 19:14:44 -04:00
Eyal Toledano
e70f44b6fb fix: Correct handling of dependencies between subtasks
This commit fixes an issue with the dependency management system where
dependencies between subtasks of the same parent task were not being
handled correctly. Previously, when trying to add a dependency between
subtasks (e.g., making 23.8 depend on 23.13), the system incorrectly
interpreted it as a circular dependency of the parent task depending
on itself.

Changes:
- Modified add-dependency and remove-dependency commands to preserve
  string format for subtask IDs containing dots instead of converting
  them to integers
- Updated dependency detection logic to properly handle string-based
  subtask IDs
- Added specific tests verifying both successful dependency chains
  and circular dependency detection between subtasks of the same parent

The fix ensures proper task ordering for development workflows where
related subtasks must be completed in sequence (like establishing tests
before implementing a feature). It maintains backward compatibility with
existing task structures while correctly enforcing dependency chains
within subtask groups.

Tests:
- Added tests for valid dependency chains between subtasks of the same parent
- Added tests for circular dependency detection in subtask relationships
- Added specific test for the 23.8->23.13->23.10 subtask dependency chain

Resolves the issue where the suggested task development workflow couldn't
be properly enforced through the dependency management system.
2025-03-29 18:19:39 -04:00
Eyal Toledano
f3e8ff315d fix: Correct handling of dependencies between subtasks
This commit fixes an issue with the dependency management system where
dependencies between subtasks of the same parent task were not being
handled correctly. Previously, when trying to add a dependency between
subtasks (e.g., making 23.8 depend on 23.13), the system incorrectly
interpreted it as a circular dependency of the parent task depending
on itself.

Changes:
- Modified add-dependency and remove-dependency commands to preserve
  string format for subtask IDs containing dots instead of converting
  them to integers
- Updated dependency detection logic to properly handle string-based
  subtask IDs
- Added specific tests verifying both successful dependency chains
  and circular dependency detection between subtasks of the same parent

The fix ensures proper task ordering for development workflows where
related subtasks must be completed in sequence (like establishing tests
before implementing a feature). It maintains backward compatibility with
existing task structures while correctly enforcing dependency chains
within subtask groups.

Tests:
- Added tests for valid dependency chains between subtasks of the same parent
- Added tests for circular dependency detection in subtask relationships
- Added specific test for the 23.8->23.13->23.10 subtask dependency chain

Resolves the issue where the suggested task development workflow couldn't
be properly enforced through the dependency management system.
2025-03-29 18:19:39 -04:00
Eyal Toledano
57f655affd adds mcp protocol spec and docs. 2025-03-29 18:07:51 -04:00
Eyal Toledano
d87c544d48 adds mcp protocol spec and docs. 2025-03-29 18:07:51 -04:00
Eyal Toledano
38cd889ccd chore: expands some tasks and adds 'inspector' commands to scripts in package json to easily get inspector up for our mcp server at http://localhost:8888/?proxyPort=9000 which should play nice for those of us who have shit running on 3000 2025-03-29 17:52:11 -04:00
Eyal Toledano
3a2d9670f1 chore: expands some tasks and adds 'inspector' commands to scripts in package json to easily get inspector up for our mcp server at http://localhost:8888/?proxyPort=9000 which should play nice for those of us who have shit running on 3000 2025-03-29 17:52:11 -04:00
Eyal Toledano
18ea4dd4a8 Restore correct versions of task files from feature branch 2025-03-29 17:31:30 -04:00
Eyal Toledano
4e45a09279 Restore correct versions of task files from feature branch 2025-03-29 17:31:30 -04:00
Eyal Toledano
ba651645b0 Merge crunchyman/feat.add.mcp.2 into next 2025-03-29 17:26:04 -04:00
Eyal Toledano
0d7ee31c82 Merge crunchyman/feat.add.mcp.2 into next 2025-03-29 17:26:04 -04:00
Eyal Toledano
42cac13f2c Merge remote changes and resolve conflicts 2025-03-29 17:23:59 -04:00
Eyal Toledano
22d3cf5314 Merge remote changes and resolve conflicts 2025-03-29 17:23:59 -04:00
Ralph Khreish
257160a967 fix: addTask mcp tool (#50) 2025-03-29 17:16:41 +01:00
Ralph Khreish
abab50d2ee fix: addTask mcp tool (#50) 2025-03-29 17:16:41 +01:00
Ralph Khreish
9fd42eeafd fix: cursor connecting to mcp server and typo task-master-mcp 2025-03-29 12:10:48 +01:00
Ralph Khreish
b8b1faf1f0 fix: cursor connecting to mcp server and typo task-master-mcp 2025-03-29 12:10:48 +01:00
Ralph Khreish
eeae027d2b chore: fix ci p1 2025-03-29 09:29:50 +01:00
Ralph Khreish
2bb848e344 chore: fix ci p1 2025-03-29 09:29:50 +01:00
Ralph Khreish
a10470ba2f chore: change node-fetch override version for changeset 2025-03-29 09:09:15 +01:00
Ralph Khreish
010080af96 chore: change node-fetch override version for changeset 2025-03-29 09:09:15 +01:00
Ralph Khreish
397c181202 chore: fix changesets/action job 2025-03-29 08:54:54 +01:00
Ralph Khreish
01a71df26d chore: fix changesets/action job 2025-03-29 08:54:54 +01:00
Ralph Khreish
179eb85a4c chore: fix CI 2025-03-28 21:03:01 +01:00
Ralph Khreish
09740e1758 chore: fix CI 2025-03-28 21:03:01 +01:00
Ralph Khreish
fb336ded3e fix: changeset action (#49) 2025-03-28 20:51:06 +01:00
Ralph Khreish
c371805812 fix: changeset action (#49) 2025-03-28 20:51:06 +01:00
Ralph Khreish
5ec3651e64 fix: bug workflow being in the wrong directory (#48) 2025-03-28 20:43:36 +01:00
Ralph Khreish
a2f920a318 fix: bug workflow being in the wrong directory (#48) 2025-03-28 20:43:36 +01:00
Ralph Khreish
b41946c485 Merge remote-tracking branch 'origin/main' into next 2025-03-28 20:41:34 +01:00
Ralph Khreish
6d964418d7 Merge remote-tracking branch 'origin/main' into next 2025-03-28 20:41:34 +01:00
Ralph Khreish
4eed269378 feat: Implement MCP (#20) v0.10.2 2025-03-28 20:38:53 +01:00
Ralph Khreish
6da3e927de feat: Implement MCP (#20) 2025-03-28 20:38:53 +01:00
Ralph Khreish
a8b055f05d chore: add changeset for PR 2025-03-28 20:38:37 +01:00
Ralph Khreish
2faa5755f7 chore: add changeset for PR 2025-03-28 20:38:37 +01:00
Ralph Khreish
a8e4bb0407 fix: apply @rtuin suggestions 2025-03-28 20:36:27 +01:00
Ralph Khreish
71fe603e03 fix: apply @rtuin suggestions 2025-03-28 20:36:27 +01:00
Ralph Khreish
0663ff1bea chore: cleanup 2025-03-28 20:36:27 +01:00
Ralph Khreish
ad3a58ba3e chore: cleanup 2025-03-28 20:36:27 +01:00
Ralph Khreish
3582798293 fix(mcp): get everything working, cleanup, and test all tools 2025-03-28 20:36:15 +01:00
Ralph Khreish
bde3422341 fix(mcp): get everything working, cleanup, and test all tools 2025-03-28 20:36:15 +01:00
Ralph Khreish
37c5b83f60 feat(wip): set up mcp server and tools, but mcp on cursor not working despite working in inspector 2025-03-28 20:36:00 +01:00
Ralph Khreish
e91e65479e feat(wip): set up mcp server and tools, but mcp on cursor not working despite working in inspector 2025-03-28 20:36:00 +01:00
Ralph Khreish
f3e6f0b70e feat(wip): initial commits for sub-tasks 1,2,3 for task 23 2025-03-28 20:36:00 +01:00
Ralph Khreish
b5f8490944 feat(wip): initial commits for sub-tasks 1,2,3 for task 23 2025-03-28 20:36:00 +01:00