ros/claude-task-master
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(commands): Add missing context parameters to dependency and remove-subtask commands

Browse Source 
- Add projectRoot and tag context to all dependency commands
- Add projectRoot and tag context to remove-subtask command
- Add --tag option to remove-subtask command
- Fixes critical bug where remove-subtask was deleting other tags due to missing context
- All dependency and subtask commands now properly handle tagged task lists
This commit is contained in:
Eyal Toledano
2025-06-13 00:46:45 -04:00
parent cac8c234d6
commit ddaa1dceef
118 changed files with 141 additions and 17437 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
scripts/modules/dependency-manager.js
View File

@@ -26,11 +26,12 @@ import { generateTaskFiles } from './task-manager.js';
* @param {string} tasksPath - Path to the tasks.json file
* @param {number|string} taskId - ID of the task to add dependency to
* @param {number|string} dependencyId - ID of the task to add as dependency
* @param {Object} context - Context object containing projectRoot and tag information
*/
async function addDependency(tasksPath, taskId, dependencyId) {
async function addDependency(tasksPath, taskId, dependencyId, context = {}) {
log('info', `Adding dependency ${dependencyId} to task ${taskId}...`);
const data = readJSON(tasksPath);
const data = readJSON(tasksPath, context.projectRoot, context.tag);
if (!data || !data.tasks) {
log('error', 'No valid tasks found in tasks.json');
process.exit(1);
@@ -172,7 +173,7 @@ async function addDependency(tasksPath, taskId, dependencyId) {
});
// Save changes
writeJSON(tasksPath, data);
writeJSON(tasksPath, data, context.projectRoot, context.tag);
log(
'success',
`Added dependency ${formattedDependencyId} to task ${formattedTaskId}`
@@ -195,7 +196,7 @@ async function addDependency(tasksPath, taskId, dependencyId) {
}
// Generate updated task files
await generateTaskFiles(tasksPath, path.dirname(tasksPath));
// await generateTaskFiles(tasksPath, path.dirname(tasksPath));
log('info', 'Task files regenerated with updated dependencies.');
} else {
@@ -212,12 +213,13 @@ async function addDependency(tasksPath, taskId, dependencyId) {
* @param {string} tasksPath - Path to the tasks.json file
* @param {number|string} taskId - ID of the task to remove dependency from
* @param {number|string} dependencyId - ID of the task to remove as dependency
* @param {Object} context - Context object containing projectRoot and tag information
*/
async function removeDependency(tasksPath, taskId, dependencyId) {
async function removeDependency(tasksPath, taskId, dependencyId, context = {}) {
log('info', `Removing dependency ${dependencyId} from task ${taskId}...`);
// Read tasks file
const data = readJSON(tasksPath);
const data = readJSON(tasksPath, context.projectRoot, context.tag);
if (!data || !data.tasks) {
log('error', 'No valid tasks found.');
process.exit(1);
@@ -309,7 +311,7 @@ async function removeDependency(tasksPath, taskId, dependencyId) {
targetTask.dependencies.splice(dependencyIndex, 1);
// Save the updated tasks
writeJSON(tasksPath, data);
writeJSON(tasksPath, data, context.projectRoot, context.tag);
// Success message
log(
@@ -334,7 +336,7 @@ async function removeDependency(tasksPath, taskId, dependencyId) {
}
// Regenerate task files
await generateTaskFiles(tasksPath, path.dirname(tasksPath));
// await generateTaskFiles(tasksPath, path.dirname(tasksPath));
}
/**
@@ -561,12 +563,14 @@ function cleanupSubtaskDependencies(tasksData) {
/**
* Validate dependencies in task files
* @param {string} tasksPath - Path to tasks.json
* @param {Object} options - Options object, including context
*/
async function validateDependenciesCommand(tasksPath, options = {}) {
const { context = {} } = options;
log('info', 'Checking for invalid dependencies in task files...');
// Read tasks data
const data = readJSON(tasksPath);
const data = readJSON(tasksPath, context.projectRoot, context.tag);
if (!data || !data.tasks) {
log('error', 'No valid tasks found in tasks.json');
process.exit(1);
@@ -683,14 +687,15 @@ function countAllDependencies(tasks) {
/**
* Fixes invalid dependencies in tasks.json
* @param {string} tasksPath - Path to tasks.json
* @param {Object} options - Options object
* @param {Object} options - Options object, including context
*/
async function fixDependenciesCommand(tasksPath, options = {}) {
const { context = {} } = options;
log('info', 'Checking for and fixing invalid dependencies in tasks.json...');
try {
// Read tasks data
const data = readJSON(tasksPath);
const data = readJSON(tasksPath, context.projectRoot, context.tag);
if (!data || !data.tasks) {
log('error', 'No valid tasks found in tasks.json');
process.exit(1);
@@ -1004,12 +1009,12 @@ async function fixDependenciesCommand(tasksPath, options = {}) {
if (dataChanged) {
// Save the changes
writeJSON(tasksPath, data);
writeJSON(tasksPath, data, context.projectRoot, context.tag);
log('success', 'Fixed dependency issues in tasks.json');
// Regenerate task files
log('info', 'Regenerating task files to reflect dependency changes...');
await generateTaskFiles(tasksPath, path.dirname(tasksPath));
// await generateTaskFiles(tasksPath, path.dirname(tasksPath));
} else {
log('info', 'No changes needed to fix dependencies');
}