fix: replace tool parameter inputs with root directory paths (#147)

* wip: replace tool parameter inputs with root directory paths

* fix: moved path resolving responsibility to tools

- made path in parameters to optional for AI
- internalised path resolving using session roots

* chore: update package-lock.json

* chore: fix regressions and fix CI

* fix: make projectRoot required

* fix: add-task tool

* fix: updateTask tool

* fix: remove reportProgress

* chore: cleanup

* fix: expand-task tool

* chore: remove usless logs

* fix: dependency manager logging in mcp server

mcp-server/src/core/direct-functions/remove-dependency.js

@@ -3,7 +3,6 @@
  */
 
 import { removeDependency } from '../../../../scripts/modules/dependency-manager.js';
-import { findTasksJsonPath } from '../utils/path-utils.js';
 import {
 	enableSilentMode,
 	disableSilentMode
@@ -12,19 +11,32 @@ import {
 /**
  * Remove a dependency from a task
  * @param {Object} args - Function arguments
+ * @param {string} args.tasksJsonPath - Explicit path to the tasks.json file.
  * @param {string|number} args.id - Task ID to remove dependency from
  * @param {string|number} args.dependsOn - Task ID to remove as a dependency
- * @param {string} [args.file] - Path to the tasks file
- * @param {string} [args.projectRoot] - Project root directory
  * @param {Object} log - Logger object
  * @returns {Promise<{success: boolean, data?: Object, error?: {code: string, message: string}}>}
  */
 export async function removeDependencyDirect(args, log) {
+	// Destructure expected args
+	const { tasksJsonPath, id, dependsOn } = args;
 	try {
 		log.info(`Removing dependency with args: ${JSON.stringify(args)}`);
 
+		// Check if tasksJsonPath was provided
+		if (!tasksJsonPath) {
+			log.error('removeDependencyDirect called without tasksJsonPath');
+			return {
+				success: false,
+				error: {
+					code: 'MISSING_ARGUMENT',
+					message: 'tasksJsonPath is required'
+				}
+			};
+		}
+
 		// Validate required parameters
-		if (!args.id) {
+		if (!id) {
 			return {
 				success: false,
 				error: {
@@ -34,7 +46,7 @@ export async function removeDependencyDirect(args, log) {
 			};
 		}
 
-		if (!args.dependsOn) {
+		if (!dependsOn) {
 			return {
 				success: false,
 				error: {
@@ -44,18 +56,16 @@ export async function removeDependencyDirect(args, log) {
 			};
 		}
 
-		// Find the tasks.json path
-		const tasksPath = findTasksJsonPath(args, log);
+		// Use provided path
+		const tasksPath = tasksJsonPath;
 
 		// Format IDs for the core function
 		const taskId =
-			args.id.includes && args.id.includes('.')
-				? args.id
-				: parseInt(args.id, 10);
+			id && id.includes && id.includes('.') ? id : parseInt(id, 10);
 		const dependencyId =
-			args.dependsOn.includes && args.dependsOn.includes('.')
-				? args.dependsOn
-				: parseInt(args.dependsOn, 10);
+			dependsOn && dependsOn.includes && dependsOn.includes('.')
+				? dependsOn
+				: parseInt(dependsOn, 10);
 
 		log.info(
 			`Removing dependency: task ${taskId} no longer depends on ${dependencyId}`
@@ -64,7 +74,7 @@ export async function removeDependencyDirect(args, log) {
 		// Enable silent mode to prevent console logs from interfering with JSON response
 		enableSilentMode();
 
-		// Call the core function
+		// Call the core function using the provided tasksPath
 		await removeDependency(tasksPath, taskId, dependencyId);
 
 		// Restore normal logging