ros/claude-task-master
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Improve CLI flag validation for single-word flags

Browse Source 
Fix issue with kebab-case validator incorrectly flagging single-word flags like --prompt. Refactor detectCamelCaseFlags to properly handle all single-word flags. Update tests to verify correct behavior with single-word and camelCase flags. Add support for alternative flag formats in init command (e.g., -my_name). This fixes a bug where users couldn't use the --prompt flag directly and had to use -p instead.
This commit is contained in:
Eyal Toledano
2025-03-26 15:54:51 -04:00
parent 6322a1a66f
commit c59bd8c9fc
9 changed files with 188 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
tests/unit/utils.test.js
View File

@@ -43,17 +43,19 @@ function testDetectCamelCaseFlags(args) {
if (arg.startsWith('--')) {
const flagName = arg.split('=')[0].slice(2); // Remove -- and anything after =
// Skip if it's a single word (no hyphens) or already in kebab-case
if (!flagName.includes('-')) {
// Check for camelCase pattern (lowercase followed by uppercase)
if (/[a-z][A-Z]/.test(flagName)) {
const kebabVersion = toKebabCase(flagName);
if (kebabVersion !== flagName) {
camelCaseFlags.push({
original: flagName,
kebabCase: kebabVersion
});
}
// Skip single-word flags - they can't be camelCase
if (!flagName.includes('-') && !/[A-Z]/.test(flagName)) {
continue;
}
// Check for camelCase pattern (lowercase followed by uppercase)
if (/[a-z][A-Z]/.test(flagName)) {
const kebabVersion = toKebabCase(flagName);
if (kebabVersion !== flagName) {
camelCaseFlags.push({
original: flagName,
kebabCase: kebabVersion
});
}
}
}
@@ -538,10 +540,15 @@ describe('CLI Flag Format Validation', () => {
expect(flags).toHaveLength(0);
});
test('detectCamelCaseFlags should not flag simple lowercase flags', () => {
const args = ['node', 'task-master', 'add-task', '--prompt=test', '--file=tasks.json'];
test('detectCamelCaseFlags should respect single-word flags', () => {
const args = ['node', 'task-master', 'add-task', '--prompt=test', '--file=test.json', '--priority=high', '--promptText=test'];
const flags = testDetectCamelCaseFlags(args);
expect(flags).toHaveLength(0);
// Should only flag promptText, not the single-word flags
expect(flags).toHaveLength(1);
expect(flags).toContainEqual({
original: 'promptText',
kebabCase: 'prompt-text'
});
});
});