From bc3e154f4cb75ba38e400cca1379ef84d6594d9a Mon Sep 17 00:00:00 2001
From: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
Date: Wed, 6 Aug 2025 12:32:59 +0200
Subject: [PATCH] chore: refactor newly added feature and fix unit tests

---
 .../modules/task-manager/analyze-task-complexity.js    |  5 +----
 scripts/modules/task-manager/expand-task.js            | 10 ++++++----
 scripts/modules/task-manager/parse-prd.js              |  4 +---
 .../scripts/modules/task-manager/expand-task.test.js   |  4 +++-
 .../scripts/modules/task-manager/parse-prd.test.js     |  4 +++-
 5 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/scripts/modules/task-manager/analyze-task-complexity.js b/scripts/modules/task-manager/analyze-task-complexity.js
index b37b943d..ef87dc20 100644
--- a/scripts/modules/task-manager/analyze-task-complexity.js
+++ b/scripts/modules/task-manager/analyze-task-complexity.js
@@ -13,7 +13,7 @@ import {
 
 import { generateTextService } from '../ai-services-unified.js';
 
-import { getDebugFlag, getProjectName } from '../config-manager.js';
+import { getDebugFlag, getProjectName, getMainProvider, getResearchProvider } from '../config-manager.js';
 import { getPromptManager } from '../prompt-manager.js';
 import {
 	COMPLEXITY_REPORT_FILE,
@@ -410,9 +410,6 @@ async function analyzeTaskComplexity(options, context = {}) {
 		const promptManager = getPromptManager();
 
 		// Check if Claude Code is being used as the provider
-		const { getMainProvider, getResearchProvider } = await import(
-			'../config-manager.js'
-		);
 		const currentProvider = useResearch
 			? getResearchProvider(projectRoot)
 			: getMainProvider(projectRoot);
diff --git a/scripts/modules/task-manager/expand-task.js b/scripts/modules/task-manager/expand-task.js
index ffdde545..6b041807 100644
--- a/scripts/modules/task-manager/expand-task.js
+++ b/scripts/modules/task-manager/expand-task.js
@@ -18,7 +18,12 @@ import {
 
 import { generateTextService } from '../ai-services-unified.js';
 
-import { getDefaultSubtasks, getDebugFlag } from '../config-manager.js';
+import { 
+	getDefaultSubtasks, 
+	getDebugFlag,
+	getMainProvider,
+	getResearchProvider
+} from '../config-manager.js';
 import { getPromptManager } from '../prompt-manager.js';
 import generateTaskFiles from './generate-task-files.js';
 import { COMPLEXITY_REPORT_FILE } from '../../../src/constants/paths.js';
@@ -453,9 +458,6 @@ async function expandTask(
 		const promptManager = getPromptManager();
 
 		// Check if Claude Code is being used as the provider
-		const { getMainProvider, getResearchProvider } = await import(
-			'../config-manager.js'
-		);
 		const currentProvider = useResearch
 			? getResearchProvider(projectRoot)
 			: getMainProvider(projectRoot);
diff --git a/scripts/modules/task-manager/parse-prd.js b/scripts/modules/task-manager/parse-prd.js
index 1495bc6f..8ffe95bb 100644
--- a/scripts/modules/task-manager/parse-prd.js
+++ b/scripts/modules/task-manager/parse-prd.js
@@ -17,7 +17,7 @@ import {
 } from '../utils.js';
 
 import { generateObjectService } from '../ai-services-unified.js';
-import { getDebugFlag } from '../config-manager.js';
+import { getDebugFlag, getMainProvider, getResearchProvider, getDefaultPriority } from '../config-manager.js';
 import { getPromptManager } from '../prompt-manager.js';
 import { displayAiUsageSummary } from '../ui.js';
 import { CUSTOM_PROVIDERS } from '../../../src/constants/providers.js';
@@ -175,8 +175,6 @@ async function parsePRD(prdPath, tasksPath, numTasks, options = {}) {
 		const promptManager = getPromptManager();
 
 		// Get defaultTaskPriority from config
-		const { getDefaultPriority, getMainProvider, getResearchProvider } =
-			await import('../config-manager.js');
 		const defaultTaskPriority = getDefaultPriority(projectRoot) || 'medium';
 
 		// Check if Claude Code is being used as the provider
diff --git a/tests/unit/scripts/modules/task-manager/expand-task.test.js b/tests/unit/scripts/modules/task-manager/expand-task.test.js
index 49fb11b0..3f1949e4 100644
--- a/tests/unit/scripts/modules/task-manager/expand-task.test.js
+++ b/tests/unit/scripts/modules/task-manager/expand-task.test.js
@@ -123,7 +123,9 @@ jest.unstable_mockModule(
 	() => ({
 		getDefaultSubtasks: jest.fn(() => 3),
 		getDebugFlag: jest.fn(() => false),
-		getDefaultNumTasks: jest.fn(() => 10)
+		getDefaultNumTasks: jest.fn(() => 10),
+		getMainProvider: jest.fn(() => 'openai'),
+		getResearchProvider: jest.fn(() => 'perplexity')
 	})
 );
 
diff --git a/tests/unit/scripts/modules/task-manager/parse-prd.test.js b/tests/unit/scripts/modules/task-manager/parse-prd.test.js
index eb40bcc3..f8cdc8a7 100644
--- a/tests/unit/scripts/modules/task-manager/parse-prd.test.js
+++ b/tests/unit/scripts/modules/task-manager/parse-prd.test.js
@@ -49,7 +49,9 @@ jest.unstable_mockModule(
 	() => ({
 		getDebugFlag: jest.fn(() => false),
 		getDefaultNumTasks: jest.fn(() => 10),
-		getDefaultPriority: jest.fn(() => 'medium')
+		getDefaultPriority: jest.fn(() => 'medium'),
+		getMainProvider: jest.fn(() => 'openai'),
+		getResearchProvider: jest.fn(() => 'perplexity')
 	})
 );