refactor: Standardize configuration and environment variable access

This commit centralizes configuration and environment variable access across various modules by consistently utilizing getters from scripts/modules/config-manager.js. This replaces direct access to process.env and the global CONFIG object, leading to improved consistency, maintainability, testability, and better handling of session-specific configurations within the MCP context.

Key changes include:

- Centralized Getters: Replaced numerous instances of process.env.* and CONFIG.* with corresponding getter functions (e.g., getLogLevel, getMainModelId, getResearchMaxTokens, getMainTemperature, isApiKeySet, getDebugFlag, getDefaultSubtasks).

- Session Awareness: Ensured that the session object is passed to config getters where necessary, particularly within AI service calls (ai-services.js, add-task.js) and error handling (ai-services.js), allowing for session-specific environment overrides.

- API Key Checks: Standardized API key availability checks using isApiKeySet() instead of directly checking process.env.* (e.g., for Perplexity in commands.js and ai-services.js).

- Client Instantiation Cleanup: Removed now-redundant/obsolete local client instantiation functions (getAnthropicClient, getPerplexityClient) from ai-services.js and the global Anthropic client initialization from dependency-manager.js. Client creation should now rely on the config manager and factory patterns.

- Consistent Debug Flag Usage: Standardized calls to getDebugFlag() in commands.js, removing potentially unnecessary null arguments.

- Accurate Progress Calculation: Updated AI stream progress reporting (ai-services.js, add-task.js) to use getMainMaxTokens(session) for more accurate calculations.

- Minor Cleanup: Removed unused  import from scripts/modules/commands.js.

Specific module updates:

- :

  - Uses getLogLevel() instead of process.env.LOG_LEVEL.

- :

  - Replaced direct env/config access for model IDs, tokens, temperature, API keys, and default subtasks with appropriate getters.

  - Passed session to handleClaudeError.

  - Removed local getPerplexityClient and getAnthropicClient functions.

  - Updated progress calculations to use getMainMaxTokens(session).

- :

  - Uses isApiKeySet('perplexity') for API key checks.

  - Uses getDebugFlag() consistently for debug checks.

  - Removed unused  import.

- :

  - Removed global Anthropic client initialization.

- :

  - Uses config getters (getResearch..., getMain...) for Perplexity and Claude API call parameters, preserving customEnv override logic.

This refactoring also resolves a potential SyntaxError: Identifier 'getPerplexityClient' has already been declared by removing the duplicated/obsolete function definition previously present in ai-services.js.

scripts/modules/task-manager/add-task.js

@@ -11,7 +11,15 @@ import {
 } from '../ui.js';
 import { log, readJSON, writeJSON, truncate } from '../utils.js';
 import { _handleAnthropicStream } from '../ai-services.js';
-import { getDefaultPriority } from '../config-manager.js';
+import {
+	getDefaultPriority,
+	getResearchModelId,
+	getResearchTemperature,
+	getResearchMaxTokens,
+	getMainModelId,
+	getMainTemperature,
+	getMainMaxTokens
+} from '../config-manager.js';
 
 /**
  * Add a new task using AI
@@ -183,46 +191,26 @@ async function addTask(
 
 						if (modelType === 'perplexity') {
 							// Use Perplexity AI
-							const perplexityModel =
-								process.env.PERPLEXITY_MODEL ||
-								session?.env?.PERPLEXITY_MODEL ||
-								'sonar-pro';
 							const response = await client.chat.completions.create({
-								model: perplexityModel,
+								model: getResearchModelId(session),
 								messages: [
 									{ role: 'system', content: systemPrompt },
 									{ role: 'user', content: userPrompt }
 								],
-								temperature: parseFloat(
-									process.env.TEMPERATURE ||
-										session?.env?.TEMPERATURE ||
-										CONFIG.temperature
-								),
-								max_tokens: parseInt(
-									process.env.MAX_TOKENS ||
-										session?.env?.MAX_TOKENS ||
-										CONFIG.maxTokens
-								)
+								temperature: getResearchTemperature(session),
+								max_tokens: getResearchMaxTokens(session)
 							});
 
 							const responseText = response.choices[0].message.content;
 							aiGeneratedTaskData = parseTaskJsonResponse(responseText);
 						} else {
 							// Use Claude (default)
-							// Prepare API parameters
+							// Prepare API parameters using getters, preserving customEnv override
 							const apiParams = {
-								model:
-									session?.env?.ANTHROPIC_MODEL ||
-									CONFIG.model ||
-									customEnv?.ANTHROPIC_MODEL,
-								max_tokens:
-									session?.env?.MAX_TOKENS ||
-									CONFIG.maxTokens ||
-									customEnv?.MAX_TOKENS,
+								model: customEnv?.ANTHROPIC_MODEL || getMainModelId(session),
+								max_tokens: customEnv?.MAX_TOKENS || getMainMaxTokens(session),
 								temperature:
-									session?.env?.TEMPERATURE ||
-									CONFIG.temperature ||
-									customEnv?.TEMPERATURE,
+									customEnv?.TEMPERATURE || getMainTemperature(session),
 								system: systemPrompt,
 								messages: [{ role: 'user', content: userPrompt }]
 							};