ros/claude-task-master
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(extension): address PR review comments and improve implementation

Browse Source 
- Fixed InternalError class definition in errorHandler.ts
- Updated extension configuration and CI workflows
- Improved error handling and type safety
- Enhanced build and release automation
- Updated documentation and changelogs

Addresses review feedback on PR #997
This commit is contained in:
DavidMaliglowka
2025-07-23 12:27:54 -05:00
parent 14bd559bd6
commit a79fd29036
18 changed files with 610 additions and 200 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
apps/extension/src/webview/index.tsx
View File

@@ -648,14 +648,14 @@ const TaskEditModal: React.FC<{
// Only include changed fields
const updates: TaskUpdates = {};
if (formData.title !== task.title) updates.title = formData.title;
if (formData.title !== task.title) {updates.title = formData.title;}
if (formData.description !== task.description)
updates.description = formData.description;
if (formData.details !== task.details) updates.details = formData.details;
{updates.description = formData.description;}
if (formData.details !== task.details) {updates.details = formData.details;}
if (formData.priority !== task.priority)
updates.priority = formData.priority;
{updates.priority = formData.priority;}
if (formData.testStrategy !== task.testStrategy)
updates.testStrategy = formData.testStrategy;
{updates.testStrategy = formData.testStrategy;}
if (
JSON.stringify(formData.dependencies) !==
JSON.stringify(task.dependencies)
@@ -875,7 +875,7 @@ const TaskCard: React.FC<{
const TaskMasterKanban: React.FC = () => {
const context = useContext(VSCodeContext);
if (!context)
throw new Error('TaskMasterKanban must be used within VSCodeContext');
{throw new Error('TaskMasterKanban must be used within VSCodeContext');}
const { state, dispatch, sendMessage, availableHeight } = context;
const {
@@ -984,14 +984,14 @@ const TaskMasterKanban: React.FC = () => {
dispatch({ type: 'SET_USER_INTERACTING', payload: false });
}, 1000); // 1 second delay to ensure smooth completion
if (!over) return;
if (!over) {return;}
const taskId = active.id as string;
const newStatus = over.id as TaskMasterTask['status'];
// Find the task that was moved
const task = tasks.find((t) => t.id === taskId);
if (!task || task.status === newStatus) return;
if (!task || task.status === newStatus) {return;}
console.log(`🔄 Moving task ${taskId} from ${task.status} to ${newStatus}`);
@@ -1382,7 +1382,7 @@ const App: React.FC = () => {
// Handle messages from extension
useEffect(() => {
if (!vscode) return;
if (!vscode) {return;}
const handleMessage = (event: MessageEvent) => {
const message: WebviewMessage = event.data;
@@ -1526,13 +1526,13 @@ const App: React.FC = () => {
// Map error severity to toast type
let toastType: ToastNotification['type'] = 'error';
if (errorData.severity === 'low') toastType = 'info';
else if (errorData.severity === 'medium') toastType = 'warning';
if (errorData.severity === 'low') {toastType = 'info';}
else if (errorData.severity === 'medium') {toastType = 'warning';}
else if (
errorData.severity === 'high' ||
errorData.severity === 'critical'
)
toastType = 'error';
{toastType = 'error';}
// Create appropriate toast based on error category
const title =