From a6a94e3a185027347b58fd3a56fc0844be16524c Mon Sep 17 00:00:00 2001 From: Eyal Toledano Date: Mon, 31 Mar 2025 13:51:39 -0400 Subject: [PATCH] Implement remove-dependency MCP command for removing dependencies from tasks --- .changeset/two-bats-smoke.md | 1 + .../direct-functions/remove-dependency.js | 73 +++++++++++++++++++ mcp-server/src/core/task-master-core.js | 7 +- mcp-server/src/tools/index.js | 2 + mcp-server/src/tools/remove-dependency.js | 49 +++++++++++++ tasks/task_023.txt | 2 +- tasks/tasks.json | 2 +- 7 files changed, 132 insertions(+), 4 deletions(-) create mode 100644 mcp-server/src/core/direct-functions/remove-dependency.js create mode 100644 mcp-server/src/tools/remove-dependency.js diff --git a/.changeset/two-bats-smoke.md b/.changeset/two-bats-smoke.md index 8531859d..0524cd15 100644 --- a/.changeset/two-bats-smoke.md +++ b/.changeset/two-bats-smoke.md @@ -16,5 +16,6 @@ - Implement analyze-complexity MCP command for analyzing task complexity and generating recommendations - Implement clear-subtasks MCP command for clearing subtasks from parent tasks - Implement expand-all MCP command for expanding all pending tasks with subtasks +- Implement remove-dependency MCP command for removing dependencies from tasks - Document MCP server naming conventions in architecture.mdc and mcp.mdc files (file names use kebab-case, direct functions use camelCase with Direct suffix, tool registration functions use camelCase with Tool suffix, and MCP tool names use snake_case) - Enhance task show view with a color-coded progress bar for visualizing subtask completion percentage diff --git a/mcp-server/src/core/direct-functions/remove-dependency.js b/mcp-server/src/core/direct-functions/remove-dependency.js new file mode 100644 index 00000000..16ab652c --- /dev/null +++ b/mcp-server/src/core/direct-functions/remove-dependency.js @@ -0,0 +1,73 @@ +/** + * Direct function wrapper for removeDependency + */ + +import { removeDependency } from '../../../../scripts/modules/dependency-manager.js'; +import { findTasksJsonPath } from '../utils/path-utils.js'; + +/** + * Remove a dependency from a task + * @param {Object} args - Function arguments + * @param {string|number} args.id - Task ID to remove dependency from + * @param {string|number} args.dependsOn - Task ID to remove as a dependency + * @param {string} [args.file] - Path to the tasks file + * @param {string} [args.projectRoot] - Project root directory + * @param {Object} log - Logger object + * @returns {Promise<{success: boolean, data?: Object, error?: {code: string, message: string}}>} + */ +export async function removeDependencyDirect(args, log) { + try { + log.info(`Removing dependency with args: ${JSON.stringify(args)}`); + + // Validate required parameters + if (!args.id) { + return { + success: false, + error: { + code: 'INPUT_VALIDATION_ERROR', + message: 'Task ID (id) is required' + } + }; + } + + if (!args.dependsOn) { + return { + success: false, + error: { + code: 'INPUT_VALIDATION_ERROR', + message: 'Dependency ID (dependsOn) is required' + } + }; + } + + // Find the tasks.json path + const tasksPath = findTasksJsonPath(args.file, args.projectRoot); + + // Format IDs for the core function + const taskId = args.id.includes && args.id.includes('.') ? args.id : parseInt(args.id, 10); + const dependencyId = args.dependsOn.includes && args.dependsOn.includes('.') ? args.dependsOn : parseInt(args.dependsOn, 10); + + log.info(`Removing dependency: task ${taskId} no longer depends on ${dependencyId}`); + + // Call the core function + await removeDependency(tasksPath, taskId, dependencyId); + + return { + success: true, + data: { + message: `Successfully removed dependency: Task ${taskId} no longer depends on ${dependencyId}`, + taskId: taskId, + dependencyId: dependencyId + } + }; + } catch (error) { + log.error(`Error in removeDependencyDirect: ${error.message}`); + return { + success: false, + error: { + code: 'CORE_FUNCTION_ERROR', + message: error.message + } + }; + } +} \ No newline at end of file diff --git a/mcp-server/src/core/task-master-core.js b/mcp-server/src/core/task-master-core.js index 72c2ded2..1e505714 100644 --- a/mcp-server/src/core/task-master-core.js +++ b/mcp-server/src/core/task-master-core.js @@ -22,6 +22,7 @@ import { removeSubtaskDirect } from './direct-functions/remove-subtask.js'; import { analyzeTaskComplexityDirect } from './direct-functions/analyze-task-complexity.js'; import { clearSubtasksDirect } from './direct-functions/clear-subtasks.js'; import { expandAllTasksDirect } from './direct-functions/expand-all-tasks.js'; +import { removeDependencyDirect } from './direct-functions/remove-dependency.js'; // Re-export utility functions export { findTasksJsonPath } from './utils/path-utils.js'; @@ -44,7 +45,8 @@ export const directFunctions = new Map([ ['removeSubtaskDirect', removeSubtaskDirect], ['analyzeTaskComplexityDirect', analyzeTaskComplexityDirect], ['clearSubtasksDirect', clearSubtasksDirect], - ['expandAllTasksDirect', expandAllTasksDirect] + ['expandAllTasksDirect', expandAllTasksDirect], + ['removeDependencyDirect', removeDependencyDirect] ]); // Re-export all direct function implementations @@ -65,5 +67,6 @@ export { removeSubtaskDirect, analyzeTaskComplexityDirect, clearSubtasksDirect, - expandAllTasksDirect + expandAllTasksDirect, + removeDependencyDirect }; \ No newline at end of file diff --git a/mcp-server/src/tools/index.js b/mcp-server/src/tools/index.js index b4f724b0..5b95bc6c 100644 --- a/mcp-server/src/tools/index.js +++ b/mcp-server/src/tools/index.js @@ -20,6 +20,7 @@ import { registerRemoveSubtaskTool } from "./remove-subtask.js"; import { registerAnalyzeTool } from "./analyze.js"; import { registerClearSubtasksTool } from "./clear-subtasks.js"; import { registerExpandAllTool } from "./expand-all.js"; +import { registerRemoveDependencyTool } from "./remove-dependency.js"; /** * Register all Task Master tools with the MCP server @@ -42,6 +43,7 @@ export function registerTaskMasterTools(server) { registerAnalyzeTool(server); registerClearSubtasksTool(server); registerExpandAllTool(server); + registerRemoveDependencyTool(server); logger.info("Registered all Task Master tools with MCP server"); } diff --git a/mcp-server/src/tools/remove-dependency.js b/mcp-server/src/tools/remove-dependency.js new file mode 100644 index 00000000..2cecf3d6 --- /dev/null +++ b/mcp-server/src/tools/remove-dependency.js @@ -0,0 +1,49 @@ +/** + * tools/remove-dependency.js + * Tool for removing a dependency from a task + */ + +import { z } from "zod"; +import { + handleApiResult, + createErrorResponse +} from "./utils.js"; +import { removeDependencyDirect } from "../core/task-master-core.js"; + +/** + * Register the removeDependency tool with the MCP server + * @param {Object} server - FastMCP server instance + */ +export function registerRemoveDependencyTool(server) { + server.addTool({ + name: "remove_dependency", + description: "Remove a dependency from a task", + parameters: z.object({ + id: z.string().describe("Task ID to remove dependency from"), + dependsOn: z.string().describe("Task ID to remove as a dependency"), + file: z.string().optional().describe("Path to the tasks file (default: tasks/tasks.json)"), + projectRoot: z.string().optional().describe("Root directory of the project (default: current working directory)") + }), + execute: async (args, { log }) => { + try { + log.info(`Removing dependency for task ${args.id} from ${args.dependsOn} with args: ${JSON.stringify(args)}`); + + // Call the direct function wrapper + const result = await removeDependencyDirect(args, log); + + // Log result + if (result.success) { + log.info(`Successfully removed dependency: ${result.data.message}`); + } else { + log.error(`Failed to remove dependency: ${result.error.message}`); + } + + // Use handleApiResult to format the response + return handleApiResult(result, log, 'Error removing dependency'); + } catch (error) { + log.error(`Error in removeDependency tool: ${error.message}`); + return createErrorResponse(error.message); + } + }, + }); +} \ No newline at end of file diff --git a/tasks/task_023.txt b/tasks/task_023.txt index a74e5603..3894a777 100644 --- a/tasks/task_023.txt +++ b/tasks/task_023.txt @@ -878,7 +878,7 @@ Analyze and refactor the project root handling mechanism to ensure consistent fi ### Details: -## 40. Implement remove-dependency MCP command [pending] +## 40. Implement remove-dependency MCP command [done] ### Dependencies: 23.31 ### Description: Create MCP tool implementation for the remove-dependency command ### Details: diff --git a/tasks/tasks.json b/tasks/tasks.json index e7e2f5f6..f9056b0b 100644 --- a/tasks/tasks.json +++ b/tasks/tasks.json @@ -1712,7 +1712,7 @@ "title": "Implement remove-dependency MCP command", "description": "Create MCP tool implementation for the remove-dependency command", "details": "", - "status": "pending", + "status": "done", "dependencies": [ "23.31" ],