Merge pull request #61 from eyaltoledano/update-subtask
Okay, focusing specifically on the `update-subtask` functionality and the related fix we worked on, here's a succinct description suitable for a commit message body or PR:
* **`update-subtask` Feature:**
* Allows appending additional information (details, context) to an *existing* subtask using AI (`updateSubtaskById` function in `task-manager.js`).
* Crucially, it *adds* information rather than overwriting existing content.
* Uses XML-like tags (`<info added on ...>`) with timestamps to mark the added content within the subtask's `details` field in `tasks.json`.
* Preserves completed subtasks, preventing modification of 'done' items.
* **Associated UI Fix:**
* Corrected the `show <subtask_id>` command (`displayTaskById` in `ui.js`) to display the `details` field for subtasks.
* This ensures the information appended by `update-subtask` is actually visible to the user.
This commit is contained in:
Eyal Toledano
@@ -97,6 +97,32 @@ alwaysApply: true
|
|||||||
- Example: `task-master update --from=4 --prompt="Now we are using Express instead of Fastify."`
|
- Example: `task-master update --from=4 --prompt="Now we are using Express instead of Fastify."`
|
||||||
- Notes: Only updates tasks not marked as 'done'. Completed tasks remain unchanged.
|
- Notes: Only updates tasks not marked as 'done'. Completed tasks remain unchanged.
|
||||||
|
|
||||||
|
- **Command Reference: update-task**
|
||||||
|
- Legacy Syntax: `node scripts/dev.js update-task --id=<id> --prompt="<prompt>"`
|
||||||
|
- CLI Syntax: `task-master update-task --id=<id> --prompt="<prompt>"`
|
||||||
|
- Description: Updates a single task by ID with new information
|
||||||
|
- Parameters:
|
||||||
|
- `--id=<id>`: ID of the task to update (required)
|
||||||
|
- `--prompt="<text>"`: New information or context to update the task (required)
|
||||||
|
- `--research`: Use Perplexity AI for research-backed updates
|
||||||
|
- Example: `task-master update-task --id=5 --prompt="Use JWT for authentication instead of sessions."`
|
||||||
|
- Notes: Only updates tasks not marked as 'done'. Preserves completed subtasks.
|
||||||
|
|
||||||
|
- **Command Reference: update-subtask**
|
||||||
|
- Legacy Syntax: `node scripts/dev.js update-subtask --id=<id> --prompt="<prompt>"`
|
||||||
|
- CLI Syntax: `task-master update-subtask --id=<id> --prompt="<prompt>"`
|
||||||
|
- Description: Appends additional information to a specific subtask without replacing existing content
|
||||||
|
- Parameters:
|
||||||
|
- `--id=<id>`: ID of the subtask to update in format "parentId.subtaskId" (required)
|
||||||
|
- `--prompt="<text>"`: Information to add to the subtask (required)
|
||||||
|
- `--research`: Use Perplexity AI for research-backed updates
|
||||||
|
- Example: `task-master update-subtask --id=5.2 --prompt="Add details about API rate limiting."`
|
||||||
|
- Notes:
|
||||||
|
- Appends new information to subtask details with timestamp
|
||||||
|
- Does not replace existing content, only adds to it
|
||||||
|
- Uses XML-like tags to clearly mark added information
|
||||||
|
- Will not update subtasks marked as 'done' or 'completed'
|
||||||
|
|
||||||
- **Command Reference: generate**
|
- **Command Reference: generate**
|
||||||
- Legacy Syntax: `node scripts/dev.js generate`
|
- Legacy Syntax: `node scripts/dev.js generate`
|
||||||
- CLI Syntax: `task-master generate`
|
- CLI Syntax: `task-master generate`
|
||||||
|
|||||||
464
README.md
464
README.md
@@ -362,466 +362,30 @@ task-master show 1.2
|
|||||||
task-master update --from=<id> --prompt="<prompt>"
|
task-master update --from=<id> --prompt="<prompt>"
|
||||||
```
|
```
|
||||||
|
|
||||||
### Generate Task Files
|
### Update a Specific Task
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Generate individual task files from tasks.json
|
# Update a single task by ID with new information
|
||||||
task-master generate
|
task-master update-task --id=<id> --prompt="<prompt>"
|
||||||
|
|
||||||
|
# Use research-backed updates with Perplexity AI
|
||||||
|
task-master update-task --id=<id> --prompt="<prompt>" --research
|
||||||
```
|
```
|
||||||
|
|
||||||
### Set Task Status
|
### Update a Subtask
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
# Set status of a single task
|
# Append additional information to a specific subtask
|
||||||
task-master set-status --id=<id> --status=<status>
|
task-master update-subtask --id=<parentId.subtaskId> --prompt="<prompt>"
|
||||||
|
|
||||||
# Set status for multiple tasks
|
# Example: Add details about API rate limiting to subtask 2 of task 5
|
||||||
task-master set-status --id=1,2,3 --status=<status>
|
task-master update-subtask --id=5.2 --prompt="Add rate limiting of 100 requests per minute"
|
||||||
|
|
||||||
# Set status for subtasks
|
# Use research-backed updates with Perplexity AI
|
||||||
task-master set-status --id=1.1,1.2 --status=<status>
|
task-master update-subtask --id=<parentId.subtaskId> --prompt="<prompt>" --research
|
||||||
```
|
```
|
||||||
|
|
||||||
When marking a task as "done", all of its subtasks will automatically be marked as "done" as well.
|
Unlike the `update-task` command which replaces task information, the `update-subtask` command *appends* new information to the existing subtask details, marking it with a timestamp. This is useful for iteratively enhancing subtasks while preserving the original content.
|
||||||
|
|
||||||
### Expand Tasks
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Expand a specific task with subtasks
|
|
||||||
task-master expand --id=<id> --num=<number>
|
|
||||||
|
|
||||||
# Expand with additional context
|
|
||||||
task-master expand --id=<id> --prompt="<context>"
|
|
||||||
|
|
||||||
# Expand all pending tasks
|
|
||||||
task-master expand --all
|
|
||||||
|
|
||||||
# Force regeneration of subtasks for tasks that already have them
|
|
||||||
task-master expand --all --force
|
|
||||||
|
|
||||||
# Research-backed subtask generation for a specific task
|
|
||||||
task-master expand --id=<id> --research
|
|
||||||
|
|
||||||
# Research-backed generation for all tasks
|
|
||||||
task-master expand --all --research
|
|
||||||
```
|
|
||||||
|
|
||||||
### Clear Subtasks
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Clear subtasks from a specific task
|
|
||||||
task-master clear-subtasks --id=<id>
|
|
||||||
|
|
||||||
# Clear subtasks from multiple tasks
|
|
||||||
task-master clear-subtasks --id=1,2,3
|
|
||||||
|
|
||||||
# Clear subtasks from all tasks
|
|
||||||
task-master clear-subtasks --all
|
|
||||||
```
|
|
||||||
|
|
||||||
### Analyze Task Complexity
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Analyze complexity of all tasks
|
|
||||||
task-master analyze-complexity
|
|
||||||
|
|
||||||
# Save report to a custom location
|
|
||||||
task-master analyze-complexity --output=my-report.json
|
|
||||||
|
|
||||||
# Use a specific LLM model
|
|
||||||
task-master analyze-complexity --model=claude-3-opus-20240229
|
|
||||||
|
|
||||||
# Set a custom complexity threshold (1-10)
|
|
||||||
task-master analyze-complexity --threshold=6
|
|
||||||
|
|
||||||
# Use an alternative tasks file
|
|
||||||
task-master analyze-complexity --file=custom-tasks.json
|
|
||||||
|
|
||||||
# Use Perplexity AI for research-backed complexity analysis
|
|
||||||
task-master analyze-complexity --research
|
|
||||||
```
|
|
||||||
|
|
||||||
### View Complexity Report
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Display the task complexity analysis report
|
|
||||||
task-master complexity-report
|
|
||||||
|
|
||||||
# View a report at a custom location
|
|
||||||
task-master complexity-report --file=my-report.json
|
|
||||||
```
|
|
||||||
|
|
||||||
### Managing Task Dependencies
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Add a dependency to a task
|
|
||||||
task-master add-dependency --id=<id> --depends-on=<id>
|
|
||||||
|
|
||||||
# Remove a dependency from a task
|
|
||||||
task-master remove-dependency --id=<id> --depends-on=<id>
|
|
||||||
|
|
||||||
# Validate dependencies without fixing them
|
|
||||||
task-master validate-dependencies
|
|
||||||
|
|
||||||
# Find and fix invalid dependencies automatically
|
|
||||||
task-master fix-dependencies
|
|
||||||
```
|
|
||||||
|
|
||||||
### Add a New Task
|
|
||||||
|
|
||||||
````bash
|
|
||||||
# Add a new task using AI
|
|
||||||
task-master add-task --prompt="Description of the new task"
|
|
||||||
|
|
||||||
# Add a task with dependencies
|
|
||||||
task-master add-task --prompt="Description" --dependencies=1,2,3
|
|
||||||
|
|
||||||
# Add a task with priority
|
|
||||||
# Task Master
|
|
||||||
### by [@eyaltoledano](https://x.com/eyaltoledano)
|
|
||||||
|
|
||||||
A task management system for AI-driven development with Claude, designed to work seamlessly with Cursor AI.
|
|
||||||
|
|
||||||
## Requirements
|
|
||||||
|
|
||||||
- Node.js 14.0.0 or higher
|
|
||||||
- Anthropic API key (Claude API)
|
|
||||||
- Anthropic SDK version 0.39.0 or higher
|
|
||||||
- OpenAI SDK (for Perplexity API integration, optional)
|
|
||||||
|
|
||||||
## Configuration
|
|
||||||
|
|
||||||
The script can be configured through environment variables in a `.env` file at the root of the project:
|
|
||||||
|
|
||||||
### Required Configuration
|
|
||||||
- `ANTHROPIC_API_KEY`: Your Anthropic API key for Claude
|
|
||||||
|
|
||||||
### Optional Configuration
|
|
||||||
- `MODEL`: Specify which Claude model to use (default: "claude-3-7-sonnet-20250219")
|
|
||||||
- `MAX_TOKENS`: Maximum tokens for model responses (default: 4000)
|
|
||||||
- `TEMPERATURE`: Temperature for model responses (default: 0.7)
|
|
||||||
- `PERPLEXITY_API_KEY`: Your Perplexity API key for research-backed subtask generation
|
|
||||||
- `PERPLEXITY_MODEL`: Specify which Perplexity model to use (default: "sonar-medium-online")
|
|
||||||
- `DEBUG`: Enable debug logging (default: false)
|
|
||||||
- `LOG_LEVEL`: Log level - debug, info, warn, error (default: info)
|
|
||||||
- `DEFAULT_SUBTASKS`: Default number of subtasks when expanding (default: 3)
|
|
||||||
- `DEFAULT_PRIORITY`: Default priority for generated tasks (default: medium)
|
|
||||||
- `PROJECT_NAME`: Override default project name in tasks.json
|
|
||||||
- `PROJECT_VERSION`: Override default version in tasks.json
|
|
||||||
|
|
||||||
## Installation
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Install globally
|
|
||||||
npm install -g task-master-ai
|
|
||||||
|
|
||||||
# OR install locally within your project
|
|
||||||
npm install task-master-ai
|
|
||||||
````
|
|
||||||
|
|
||||||
### Initialize a new project
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# If installed globally
|
|
||||||
task-master init
|
|
||||||
|
|
||||||
# If installed locally
|
|
||||||
npx task-master-init
|
|
||||||
```
|
|
||||||
|
|
||||||
This will prompt you for project details and set up a new project with the necessary files and structure.
|
|
||||||
|
|
||||||
### Important Notes
|
|
||||||
|
|
||||||
1. This package uses ES modules. Your package.json should include `"type": "module"`.
|
|
||||||
2. The Anthropic SDK version should be 0.39.0 or higher.
|
|
||||||
|
|
||||||
## Quick Start with Global Commands
|
|
||||||
|
|
||||||
After installing the package globally, you can use these CLI commands from any directory:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Initialize a new project
|
|
||||||
task-master init
|
|
||||||
|
|
||||||
# Parse a PRD and generate tasks
|
|
||||||
task-master parse-prd your-prd.txt
|
|
||||||
|
|
||||||
# List all tasks
|
|
||||||
task-master list
|
|
||||||
|
|
||||||
# Show the next task to work on
|
|
||||||
task-master next
|
|
||||||
|
|
||||||
# Generate task files
|
|
||||||
task-master generate
|
|
||||||
```
|
|
||||||
|
|
||||||
## Troubleshooting
|
|
||||||
|
|
||||||
### If `task-master init` doesn't respond:
|
|
||||||
|
|
||||||
Try running it with Node directly:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
node node_modules/claude-task-master/scripts/init.js
|
|
||||||
```
|
|
||||||
|
|
||||||
Or clone the repository and run:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
git clone https://github.com/eyaltoledano/claude-task-master.git
|
|
||||||
cd claude-task-master
|
|
||||||
node scripts/init.js
|
|
||||||
```
|
|
||||||
|
|
||||||
## Task Structure
|
|
||||||
|
|
||||||
Tasks in tasks.json have the following structure:
|
|
||||||
|
|
||||||
- `id`: Unique identifier for the task (Example: `1`)
|
|
||||||
- `title`: Brief, descriptive title of the task (Example: `"Initialize Repo"`)
|
|
||||||
- `description`: Concise description of what the task involves (Example: `"Create a new repository, set up initial structure."`)
|
|
||||||
- `status`: Current state of the task (Example: `"pending"`, `"done"`, `"deferred"`)
|
|
||||||
- `dependencies`: IDs of tasks that must be completed before this task (Example: `[1, 2]`)
|
|
||||||
- Dependencies are displayed with status indicators (✅ for completed, ⏱️ for pending)
|
|
||||||
- This helps quickly identify which prerequisite tasks are blocking work
|
|
||||||
- `priority`: Importance level of the task (Example: `"high"`, `"medium"`, `"low"`)
|
|
||||||
- `details`: In-depth implementation instructions (Example: `"Use GitHub client ID/secret, handle callback, set session token."`)
|
|
||||||
- `testStrategy`: Verification approach (Example: `"Deploy and call endpoint to confirm 'Hello World' response."`)
|
|
||||||
- `subtasks`: List of smaller, more specific tasks that make up the main task (Example: `[{"id": 1, "title": "Configure OAuth", ...}]`)
|
|
||||||
|
|
||||||
## Integrating with Cursor AI
|
|
||||||
|
|
||||||
Claude Task Master is designed to work seamlessly with [Cursor AI](https://www.cursor.so/), providing a structured workflow for AI-driven development.
|
|
||||||
|
|
||||||
### Setup with Cursor
|
|
||||||
|
|
||||||
1. After initializing your project, open it in Cursor
|
|
||||||
2. The `.cursor/rules/dev_workflow.mdc` file is automatically loaded by Cursor, providing the AI with knowledge about the task management system
|
|
||||||
3. Place your PRD document in the `scripts/` directory (e.g., `scripts/prd.txt`)
|
|
||||||
4. Open Cursor's AI chat and switch to Agent mode
|
|
||||||
|
|
||||||
### Initial Task Generation
|
|
||||||
|
|
||||||
In Cursor's AI chat, instruct the agent to generate tasks from your PRD:
|
|
||||||
|
|
||||||
```
|
|
||||||
Please use the task-master parse-prd command to generate tasks from my PRD. The PRD is located at scripts/prd.txt.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master parse-prd scripts/prd.txt
|
|
||||||
```
|
|
||||||
|
|
||||||
This will:
|
|
||||||
|
|
||||||
- Parse your PRD document
|
|
||||||
- Generate a structured `tasks.json` file with tasks, dependencies, priorities, and test strategies
|
|
||||||
- The agent will understand this process due to the Cursor rules
|
|
||||||
|
|
||||||
### Generate Individual Task Files
|
|
||||||
|
|
||||||
Next, ask the agent to generate individual task files:
|
|
||||||
|
|
||||||
```
|
|
||||||
Please generate individual task files from tasks.json
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master generate
|
|
||||||
```
|
|
||||||
|
|
||||||
This creates individual task files in the `tasks/` directory (e.g., `task_001.txt`, `task_002.txt`), making it easier to reference specific tasks.
|
|
||||||
|
|
||||||
## AI-Driven Development Workflow
|
|
||||||
|
|
||||||
The Cursor agent is pre-configured (via the rules file) to follow this workflow:
|
|
||||||
|
|
||||||
### 1. Task Discovery and Selection
|
|
||||||
|
|
||||||
Ask the agent to list available tasks:
|
|
||||||
|
|
||||||
```
|
|
||||||
What tasks are available to work on next?
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will:
|
|
||||||
|
|
||||||
- Run `task-master list` to see all tasks
|
|
||||||
- Run `task-master next` to determine the next task to work on
|
|
||||||
- Analyze dependencies to determine which tasks are ready to be worked on
|
|
||||||
- Prioritize tasks based on priority level and ID order
|
|
||||||
- Suggest the next task(s) to implement
|
|
||||||
|
|
||||||
### 2. Task Implementation
|
|
||||||
|
|
||||||
When implementing a task, the agent will:
|
|
||||||
|
|
||||||
- Reference the task's details section for implementation specifics
|
|
||||||
- Consider dependencies on previous tasks
|
|
||||||
- Follow the project's coding standards
|
|
||||||
- Create appropriate tests based on the task's testStrategy
|
|
||||||
|
|
||||||
You can ask:
|
|
||||||
|
|
||||||
```
|
|
||||||
Let's implement task 3. What does it involve?
|
|
||||||
```
|
|
||||||
|
|
||||||
### 3. Task Verification
|
|
||||||
|
|
||||||
Before marking a task as complete, verify it according to:
|
|
||||||
|
|
||||||
- The task's specified testStrategy
|
|
||||||
- Any automated tests in the codebase
|
|
||||||
- Manual verification if required
|
|
||||||
|
|
||||||
### 4. Task Completion
|
|
||||||
|
|
||||||
When a task is completed, tell the agent:
|
|
||||||
|
|
||||||
```
|
|
||||||
Task 3 is now complete. Please update its status.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master set-status --id=3 --status=done
|
|
||||||
```
|
|
||||||
|
|
||||||
### 5. Handling Implementation Drift
|
|
||||||
|
|
||||||
If during implementation, you discover that:
|
|
||||||
|
|
||||||
- The current approach differs significantly from what was planned
|
|
||||||
- Future tasks need to be modified due to current implementation choices
|
|
||||||
- New dependencies or requirements have emerged
|
|
||||||
|
|
||||||
Tell the agent:
|
|
||||||
|
|
||||||
```
|
|
||||||
We've changed our approach. We're now using Express instead of Fastify. Please update all future tasks to reflect this change.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master update --from=4 --prompt="Now we are using Express instead of Fastify."
|
|
||||||
```
|
|
||||||
|
|
||||||
This will rewrite or re-scope subsequent tasks in tasks.json while preserving completed work.
|
|
||||||
|
|
||||||
### 6. Breaking Down Complex Tasks
|
|
||||||
|
|
||||||
For complex tasks that need more granularity:
|
|
||||||
|
|
||||||
```
|
|
||||||
Task 5 seems complex. Can you break it down into subtasks?
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master expand --id=5 --num=3
|
|
||||||
```
|
|
||||||
|
|
||||||
You can provide additional context:
|
|
||||||
|
|
||||||
```
|
|
||||||
Please break down task 5 with a focus on security considerations.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master expand --id=5 --prompt="Focus on security aspects"
|
|
||||||
```
|
|
||||||
|
|
||||||
You can also expand all pending tasks:
|
|
||||||
|
|
||||||
```
|
|
||||||
Please break down all pending tasks into subtasks.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master expand --all
|
|
||||||
```
|
|
||||||
|
|
||||||
For research-backed subtask generation using Perplexity AI:
|
|
||||||
|
|
||||||
```
|
|
||||||
Please break down task 5 using research-backed generation.
|
|
||||||
```
|
|
||||||
|
|
||||||
The agent will execute:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
task-master expand --id=5 --research
|
|
||||||
```
|
|
||||||
|
|
||||||
## Command Reference
|
|
||||||
|
|
||||||
Here's a comprehensive reference of all available commands:
|
|
||||||
|
|
||||||
### Parse PRD
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Parse a PRD file and generate tasks
|
|
||||||
task-master parse-prd <prd-file.txt>
|
|
||||||
|
|
||||||
# Limit the number of tasks generated
|
|
||||||
task-master parse-prd <prd-file.txt> --num-tasks=10
|
|
||||||
```
|
|
||||||
|
|
||||||
### List Tasks
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# List all tasks
|
|
||||||
task-master list
|
|
||||||
|
|
||||||
# List tasks with a specific status
|
|
||||||
task-master list --status=<status>
|
|
||||||
|
|
||||||
# List tasks with subtasks
|
|
||||||
task-master list --with-subtasks
|
|
||||||
|
|
||||||
# List tasks with a specific status and include subtasks
|
|
||||||
task-master list --status=<status> --with-subtasks
|
|
||||||
```
|
|
||||||
|
|
||||||
### Show Next Task
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Show the next task to work on based on dependencies and status
|
|
||||||
task-master next
|
|
||||||
```
|
|
||||||
|
|
||||||
### Show Specific Task
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Show details of a specific task
|
|
||||||
task-master show <id>
|
|
||||||
# or
|
|
||||||
task-master show --id=<id>
|
|
||||||
|
|
||||||
# View a specific subtask (e.g., subtask 2 of task 1)
|
|
||||||
task-master show 1.2
|
|
||||||
```
|
|
||||||
|
|
||||||
### Update Tasks
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Update tasks from a specific ID and provide context
|
|
||||||
task-master update --from=<id> --prompt="<prompt>"
|
|
||||||
```
|
|
||||||
|
|
||||||
### Generate Task Files
|
### Generate Task Files
|
||||||
|
|
||||||
|
|||||||
@@ -11,6 +11,7 @@
|
|||||||
},
|
},
|
||||||
"scripts": {
|
"scripts": {
|
||||||
"test": "node --experimental-vm-modules node_modules/.bin/jest",
|
"test": "node --experimental-vm-modules node_modules/.bin/jest",
|
||||||
|
"test:fails": "node --experimental-vm-modules node_modules/.bin/jest --onlyFailures",
|
||||||
"test:watch": "node --experimental-vm-modules node_modules/.bin/jest --watch",
|
"test:watch": "node --experimental-vm-modules node_modules/.bin/jest --watch",
|
||||||
"test:coverage": "node --experimental-vm-modules node_modules/.bin/jest --coverage",
|
"test:coverage": "node --experimental-vm-modules node_modules/.bin/jest --coverage",
|
||||||
"prepare-package": "node scripts/prepare-package.js",
|
"prepare-package": "node scripts/prepare-package.js",
|
||||||
|
|||||||
@@ -44,6 +44,56 @@ function getPerplexityClient() {
|
|||||||
return perplexity;
|
return perplexity;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Get the best available AI model for a given operation
|
||||||
|
* @param {Object} options - Options for model selection
|
||||||
|
* @param {boolean} options.claudeOverloaded - Whether Claude is currently overloaded
|
||||||
|
* @param {boolean} options.requiresResearch - Whether the operation requires research capabilities
|
||||||
|
* @returns {Object} Selected model info with type and client
|
||||||
|
*/
|
||||||
|
function getAvailableAIModel(options = {}) {
|
||||||
|
const { claudeOverloaded = false, requiresResearch = false } = options;
|
||||||
|
|
||||||
|
// First choice: Perplexity if research is required and it's available
|
||||||
|
if (requiresResearch && process.env.PERPLEXITY_API_KEY) {
|
||||||
|
try {
|
||||||
|
const client = getPerplexityClient();
|
||||||
|
return { type: 'perplexity', client };
|
||||||
|
} catch (error) {
|
||||||
|
log('warn', `Perplexity not available: ${error.message}`);
|
||||||
|
// Fall through to Claude
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Second choice: Claude if not overloaded
|
||||||
|
if (!claudeOverloaded && process.env.ANTHROPIC_API_KEY) {
|
||||||
|
return { type: 'claude', client: anthropic };
|
||||||
|
}
|
||||||
|
|
||||||
|
// Third choice: Perplexity as Claude fallback (even if research not required)
|
||||||
|
if (process.env.PERPLEXITY_API_KEY) {
|
||||||
|
try {
|
||||||
|
const client = getPerplexityClient();
|
||||||
|
log('info', 'Claude is overloaded, falling back to Perplexity');
|
||||||
|
return { type: 'perplexity', client };
|
||||||
|
} catch (error) {
|
||||||
|
log('warn', `Perplexity fallback not available: ${error.message}`);
|
||||||
|
// Fall through to Claude anyway with warning
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Last resort: Use Claude even if overloaded (might fail)
|
||||||
|
if (process.env.ANTHROPIC_API_KEY) {
|
||||||
|
if (claudeOverloaded) {
|
||||||
|
log('warn', 'Claude is overloaded but no alternatives are available. Proceeding with Claude anyway.');
|
||||||
|
}
|
||||||
|
return { type: 'claude', client: anthropic };
|
||||||
|
}
|
||||||
|
|
||||||
|
// No models available
|
||||||
|
throw new Error('No AI models available. Please set ANTHROPIC_API_KEY and/or PERPLEXITY_API_KEY.');
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Handle Claude API errors with user-friendly messages
|
* Handle Claude API errors with user-friendly messages
|
||||||
* @param {Error} error - The error from Claude API
|
* @param {Error} error - The error from Claude API
|
||||||
@@ -54,6 +104,10 @@ function handleClaudeError(error) {
|
|||||||
if (error.type === 'error' && error.error) {
|
if (error.type === 'error' && error.error) {
|
||||||
switch (error.error.type) {
|
switch (error.error.type) {
|
||||||
case 'overloaded_error':
|
case 'overloaded_error':
|
||||||
|
// Check if we can use Perplexity as a fallback
|
||||||
|
if (process.env.PERPLEXITY_API_KEY) {
|
||||||
|
return 'Claude is currently overloaded. Trying to fall back to Perplexity AI.';
|
||||||
|
}
|
||||||
return 'Claude is currently experiencing high demand and is overloaded. Please wait a few minutes and try again.';
|
return 'Claude is currently experiencing high demand and is overloaded. Please wait a few minutes and try again.';
|
||||||
case 'rate_limit_error':
|
case 'rate_limit_error':
|
||||||
return 'You have exceeded the rate limit. Please wait a few minutes before making more requests.';
|
return 'You have exceeded the rate limit. Please wait a few minutes before making more requests.';
|
||||||
@@ -676,5 +730,6 @@ export {
|
|||||||
generateSubtasksWithPerplexity,
|
generateSubtasksWithPerplexity,
|
||||||
parseSubtasksFromText,
|
parseSubtasksFromText,
|
||||||
generateComplexityAnalysisPrompt,
|
generateComplexityAnalysisPrompt,
|
||||||
handleClaudeError
|
handleClaudeError,
|
||||||
|
getAvailableAIModel
|
||||||
};
|
};
|
||||||
@@ -24,7 +24,8 @@ import {
|
|||||||
addSubtask,
|
addSubtask,
|
||||||
removeSubtask,
|
removeSubtask,
|
||||||
analyzeTaskComplexity,
|
analyzeTaskComplexity,
|
||||||
updateTaskById
|
updateTaskById,
|
||||||
|
updateSubtaskById
|
||||||
} from './task-manager.js';
|
} from './task-manager.js';
|
||||||
|
|
||||||
import {
|
import {
|
||||||
@@ -145,7 +146,7 @@ function registerCommands(programInstance) {
|
|||||||
await updateTasks(tasksPath, fromId, prompt, useResearch);
|
await updateTasks(tasksPath, fromId, prompt, useResearch);
|
||||||
});
|
});
|
||||||
|
|
||||||
// updateTask command
|
// update-task command
|
||||||
programInstance
|
programInstance
|
||||||
.command('update-task')
|
.command('update-task')
|
||||||
.description('Update a single task by ID with new information')
|
.description('Update a single task by ID with new information')
|
||||||
@@ -231,6 +232,91 @@ function registerCommands(programInstance) {
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// update-subtask command
|
||||||
|
programInstance
|
||||||
|
.command('update-subtask')
|
||||||
|
.description('Update a subtask by appending additional timestamped information')
|
||||||
|
.option('-f, --file <file>', 'Path to the tasks file', 'tasks/tasks.json')
|
||||||
|
.option('-i, --id <id>', 'Subtask ID to update in format "parentId.subtaskId" (required)')
|
||||||
|
.option('-p, --prompt <text>', 'Prompt explaining what information to add (required)')
|
||||||
|
.option('-r, --research', 'Use Perplexity AI for research-backed updates')
|
||||||
|
.action(async (options) => {
|
||||||
|
try {
|
||||||
|
const tasksPath = options.file;
|
||||||
|
|
||||||
|
// Validate required parameters
|
||||||
|
if (!options.id) {
|
||||||
|
console.error(chalk.red('Error: --id parameter is required'));
|
||||||
|
console.log(chalk.yellow('Usage example: task-master update-subtask --id=5.2 --prompt="Add more details about the API endpoint"'));
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Validate subtask ID format (should contain a dot)
|
||||||
|
const subtaskId = options.id;
|
||||||
|
if (!subtaskId.includes('.')) {
|
||||||
|
console.error(chalk.red(`Error: Invalid subtask ID format: ${subtaskId}. Subtask ID must be in format "parentId.subtaskId"`));
|
||||||
|
console.log(chalk.yellow('Usage example: task-master update-subtask --id=5.2 --prompt="Add more details about the API endpoint"'));
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!options.prompt) {
|
||||||
|
console.error(chalk.red('Error: --prompt parameter is required. Please provide information to add to the subtask.'));
|
||||||
|
console.log(chalk.yellow('Usage example: task-master update-subtask --id=5.2 --prompt="Add more details about the API endpoint"'));
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
const prompt = options.prompt;
|
||||||
|
const useResearch = options.research || false;
|
||||||
|
|
||||||
|
// Validate tasks file exists
|
||||||
|
if (!fs.existsSync(tasksPath)) {
|
||||||
|
console.error(chalk.red(`Error: Tasks file not found at path: ${tasksPath}`));
|
||||||
|
if (tasksPath === 'tasks/tasks.json') {
|
||||||
|
console.log(chalk.yellow('Hint: Run task-master init or task-master parse-prd to create tasks.json first'));
|
||||||
|
} else {
|
||||||
|
console.log(chalk.yellow(`Hint: Check if the file path is correct: ${tasksPath}`));
|
||||||
|
}
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
|
||||||
|
console.log(chalk.blue(`Updating subtask ${subtaskId} with prompt: "${prompt}"`));
|
||||||
|
console.log(chalk.blue(`Tasks file: ${tasksPath}`));
|
||||||
|
|
||||||
|
if (useResearch) {
|
||||||
|
// Verify Perplexity API key exists if using research
|
||||||
|
if (!process.env.PERPLEXITY_API_KEY) {
|
||||||
|
console.log(chalk.yellow('Warning: PERPLEXITY_API_KEY environment variable is missing. Research-backed updates will not be available.'));
|
||||||
|
console.log(chalk.yellow('Falling back to Claude AI for subtask update.'));
|
||||||
|
} else {
|
||||||
|
console.log(chalk.blue('Using Perplexity AI for research-backed subtask update'));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const result = await updateSubtaskById(tasksPath, subtaskId, prompt, useResearch);
|
||||||
|
|
||||||
|
if (!result) {
|
||||||
|
console.log(chalk.yellow('\nSubtask update was not completed. Review the messages above for details.'));
|
||||||
|
}
|
||||||
|
} catch (error) {
|
||||||
|
console.error(chalk.red(`Error: ${error.message}`));
|
||||||
|
|
||||||
|
// Provide more helpful error messages for common issues
|
||||||
|
if (error.message.includes('subtask') && error.message.includes('not found')) {
|
||||||
|
console.log(chalk.yellow('\nTo fix this issue:'));
|
||||||
|
console.log(' 1. Run task-master list --with-subtasks to see all available subtask IDs');
|
||||||
|
console.log(' 2. Use a valid subtask ID with the --id parameter in format "parentId.subtaskId"');
|
||||||
|
} else if (error.message.includes('API key')) {
|
||||||
|
console.log(chalk.yellow('\nThis error is related to API keys. Check your environment variables.'));
|
||||||
|
}
|
||||||
|
|
||||||
|
if (CONFIG.debug) {
|
||||||
|
console.error(error);
|
||||||
|
}
|
||||||
|
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
// generate command
|
// generate command
|
||||||
programInstance
|
programInstance
|
||||||
.command('generate')
|
.command('generate')
|
||||||
|
|||||||
@@ -37,7 +37,9 @@ import {
|
|||||||
callClaude,
|
callClaude,
|
||||||
generateSubtasks,
|
generateSubtasks,
|
||||||
generateSubtasksWithPerplexity,
|
generateSubtasksWithPerplexity,
|
||||||
generateComplexityAnalysisPrompt
|
generateComplexityAnalysisPrompt,
|
||||||
|
getAvailableAIModel,
|
||||||
|
handleClaudeError
|
||||||
} from './ai-services.js';
|
} from './ai-services.js';
|
||||||
|
|
||||||
import {
|
import {
|
||||||
@@ -2969,11 +2971,365 @@ async function removeSubtask(tasksPath, subtaskId, convertToTask = false, genera
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Update a subtask by appending additional information to its description and details
|
||||||
|
* @param {string} tasksPath - Path to the tasks.json file
|
||||||
|
* @param {string} subtaskId - ID of the subtask to update in format "parentId.subtaskId"
|
||||||
|
* @param {string} prompt - Prompt for generating additional information
|
||||||
|
* @param {boolean} useResearch - Whether to use Perplexity AI for research-backed updates
|
||||||
|
* @returns {Object|null} - The updated subtask or null if update failed
|
||||||
|
*/
|
||||||
|
async function updateSubtaskById(tasksPath, subtaskId, prompt, useResearch = false) {
|
||||||
|
let loadingIndicator = null;
|
||||||
|
try {
|
||||||
|
log('info', `Updating subtask ${subtaskId} with prompt: "${prompt}"`);
|
||||||
|
|
||||||
|
// Validate subtask ID format
|
||||||
|
if (!subtaskId || typeof subtaskId !== 'string' || !subtaskId.includes('.')) {
|
||||||
|
throw new Error(`Invalid subtask ID format: ${subtaskId}. Subtask ID must be in format "parentId.subtaskId"`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Validate prompt
|
||||||
|
if (!prompt || typeof prompt !== 'string' || prompt.trim() === '') {
|
||||||
|
throw new Error('Prompt cannot be empty. Please provide context for the subtask update.');
|
||||||
|
}
|
||||||
|
|
||||||
|
// Prepare for fallback handling
|
||||||
|
let claudeOverloaded = false;
|
||||||
|
|
||||||
|
// Validate tasks file exists
|
||||||
|
if (!fs.existsSync(tasksPath)) {
|
||||||
|
throw new Error(`Tasks file not found at path: ${tasksPath}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Read the tasks file
|
||||||
|
const data = readJSON(tasksPath);
|
||||||
|
if (!data || !data.tasks) {
|
||||||
|
throw new Error(`No valid tasks found in ${tasksPath}. The file may be corrupted or have an invalid format.`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Parse parent and subtask IDs
|
||||||
|
const [parentIdStr, subtaskIdStr] = subtaskId.split('.');
|
||||||
|
const parentId = parseInt(parentIdStr, 10);
|
||||||
|
const subtaskIdNum = parseInt(subtaskIdStr, 10);
|
||||||
|
|
||||||
|
if (isNaN(parentId) || parentId <= 0 || isNaN(subtaskIdNum) || subtaskIdNum <= 0) {
|
||||||
|
throw new Error(`Invalid subtask ID format: ${subtaskId}. Both parent ID and subtask ID must be positive integers.`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find the parent task
|
||||||
|
const parentTask = data.tasks.find(task => task.id === parentId);
|
||||||
|
if (!parentTask) {
|
||||||
|
throw new Error(`Parent task with ID ${parentId} not found. Please verify the task ID and try again.`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find the subtask
|
||||||
|
if (!parentTask.subtasks || !Array.isArray(parentTask.subtasks)) {
|
||||||
|
throw new Error(`Parent task ${parentId} has no subtasks.`);
|
||||||
|
}
|
||||||
|
|
||||||
|
const subtask = parentTask.subtasks.find(st => st.id === subtaskIdNum);
|
||||||
|
if (!subtask) {
|
||||||
|
throw new Error(`Subtask with ID ${subtaskId} not found. Please verify the subtask ID and try again.`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if subtask is already completed
|
||||||
|
if (subtask.status === 'done' || subtask.status === 'completed') {
|
||||||
|
log('warn', `Subtask ${subtaskId} is already marked as done and cannot be updated`);
|
||||||
|
console.log(boxen(
|
||||||
|
chalk.yellow(`Subtask ${subtaskId} is already marked as ${subtask.status} and cannot be updated.`) + '\n\n' +
|
||||||
|
chalk.white('Completed subtasks are locked to maintain consistency. To modify a completed subtask, you must first:') + '\n' +
|
||||||
|
chalk.white('1. Change its status to "pending" or "in-progress"') + '\n' +
|
||||||
|
chalk.white('2. Then run the update-subtask command'),
|
||||||
|
{ padding: 1, borderColor: 'yellow', borderStyle: 'round' }
|
||||||
|
));
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Show the subtask that will be updated
|
||||||
|
const table = new Table({
|
||||||
|
head: [
|
||||||
|
chalk.cyan.bold('ID'),
|
||||||
|
chalk.cyan.bold('Title'),
|
||||||
|
chalk.cyan.bold('Status')
|
||||||
|
],
|
||||||
|
colWidths: [10, 55, 10]
|
||||||
|
});
|
||||||
|
|
||||||
|
table.push([
|
||||||
|
subtaskId,
|
||||||
|
truncate(subtask.title, 52),
|
||||||
|
getStatusWithColor(subtask.status)
|
||||||
|
]);
|
||||||
|
|
||||||
|
console.log(boxen(
|
||||||
|
chalk.white.bold(`Updating Subtask #${subtaskId}`),
|
||||||
|
{ padding: 1, borderColor: 'blue', borderStyle: 'round', margin: { top: 1, bottom: 0 } }
|
||||||
|
));
|
||||||
|
|
||||||
|
console.log(table.toString());
|
||||||
|
|
||||||
|
// Start the loading indicator
|
||||||
|
loadingIndicator = startLoadingIndicator('Generating additional information with AI...');
|
||||||
|
|
||||||
|
// Create the system prompt (as before)
|
||||||
|
const systemPrompt = `You are an AI assistant helping to update software development subtasks with additional information.
|
||||||
|
Given a subtask, you will provide additional details, implementation notes, or technical insights based on user request.
|
||||||
|
Focus only on adding content that enhances the subtask - don't repeat existing information.
|
||||||
|
Be technical, specific, and implementation-focused rather than general.
|
||||||
|
Provide concrete examples, code snippets, or implementation details when relevant.`;
|
||||||
|
|
||||||
|
// Replace the old research/Claude code with the new model selection approach
|
||||||
|
let additionalInformation = '';
|
||||||
|
let modelAttempts = 0;
|
||||||
|
const maxModelAttempts = 2; // Try up to 2 models before giving up
|
||||||
|
|
||||||
|
while (modelAttempts < maxModelAttempts && !additionalInformation) {
|
||||||
|
modelAttempts++; // Increment attempt counter at the start
|
||||||
|
const isLastAttempt = modelAttempts >= maxModelAttempts;
|
||||||
|
let modelType = null; // Declare modelType outside the try block
|
||||||
|
|
||||||
|
try {
|
||||||
|
// Get the best available model based on our current state
|
||||||
|
const result = getAvailableAIModel({
|
||||||
|
claudeOverloaded,
|
||||||
|
requiresResearch: useResearch
|
||||||
|
});
|
||||||
|
modelType = result.type;
|
||||||
|
const client = result.client;
|
||||||
|
|
||||||
|
log('info', `Attempt ${modelAttempts}/${maxModelAttempts}: Generating subtask info using ${modelType}`);
|
||||||
|
// Update loading indicator text
|
||||||
|
stopLoadingIndicator(loadingIndicator); // Stop previous indicator
|
||||||
|
loadingIndicator = startLoadingIndicator(`Attempt ${modelAttempts}: Using ${modelType.toUpperCase()}...`);
|
||||||
|
|
||||||
|
const subtaskData = JSON.stringify(subtask, null, 2);
|
||||||
|
const userMessageContent = `Here is the subtask to enhance:\n${subtaskData}\n\nPlease provide additional information addressing this request:\n${prompt}\n\nReturn ONLY the new information to add - do not repeat existing content.`;
|
||||||
|
|
||||||
|
if (modelType === 'perplexity') {
|
||||||
|
// Construct Perplexity payload
|
||||||
|
const perplexityModel = process.env.PERPLEXITY_MODEL || 'sonar-pro';
|
||||||
|
const response = await client.chat.completions.create({
|
||||||
|
model: perplexityModel,
|
||||||
|
messages: [
|
||||||
|
{ role: 'system', content: systemPrompt },
|
||||||
|
{ role: 'user', content: userMessageContent }
|
||||||
|
],
|
||||||
|
temperature: parseFloat(process.env.TEMPERATURE || CONFIG.temperature),
|
||||||
|
max_tokens: parseInt(process.env.MAX_TOKENS || CONFIG.maxTokens),
|
||||||
|
});
|
||||||
|
additionalInformation = response.choices[0].message.content.trim();
|
||||||
|
} else { // Claude
|
||||||
|
let responseText = '';
|
||||||
|
let streamingInterval = null;
|
||||||
|
let dotCount = 0;
|
||||||
|
const readline = await import('readline');
|
||||||
|
|
||||||
|
try {
|
||||||
|
streamingInterval = setInterval(() => {
|
||||||
|
readline.cursorTo(process.stdout, 0);
|
||||||
|
process.stdout.write(`Receiving streaming response from Claude${'.'.repeat(dotCount)}`);
|
||||||
|
dotCount = (dotCount + 1) % 4;
|
||||||
|
}, 500);
|
||||||
|
|
||||||
|
// Construct Claude payload
|
||||||
|
const stream = await client.messages.create({
|
||||||
|
model: CONFIG.model,
|
||||||
|
max_tokens: CONFIG.maxTokens,
|
||||||
|
temperature: CONFIG.temperature,
|
||||||
|
system: systemPrompt,
|
||||||
|
messages: [
|
||||||
|
{ role: 'user', content: userMessageContent }
|
||||||
|
],
|
||||||
|
stream: true
|
||||||
|
});
|
||||||
|
|
||||||
|
for await (const chunk of stream) {
|
||||||
|
if (chunk.type === 'content_block_delta' && chunk.delta.text) {
|
||||||
|
responseText += chunk.delta.text;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
if (streamingInterval) clearInterval(streamingInterval);
|
||||||
|
// Clear the loading dots line
|
||||||
|
readline.cursorTo(process.stdout, 0);
|
||||||
|
process.stdout.clearLine(0);
|
||||||
|
}
|
||||||
|
|
||||||
|
log('info', `Completed streaming response from Claude API! (Attempt ${modelAttempts})`);
|
||||||
|
additionalInformation = responseText.trim();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Success - break the loop
|
||||||
|
if (additionalInformation) {
|
||||||
|
log('info', `Successfully generated information using ${modelType} on attempt ${modelAttempts}.`);
|
||||||
|
break;
|
||||||
|
} else {
|
||||||
|
// Handle case where AI gave empty response without erroring
|
||||||
|
log('warn', `AI (${modelType}) returned empty response on attempt ${modelAttempts}.`);
|
||||||
|
if (isLastAttempt) {
|
||||||
|
throw new Error('AI returned empty response after maximum attempts.');
|
||||||
|
}
|
||||||
|
// Allow loop to continue to try another model/attempt if possible
|
||||||
|
}
|
||||||
|
|
||||||
|
} catch (modelError) {
|
||||||
|
const failedModel = modelType || (modelError.modelType || 'unknown model');
|
||||||
|
log('warn', `Attempt ${modelAttempts} failed using ${failedModel}: ${modelError.message}`);
|
||||||
|
|
||||||
|
// --- More robust overload check ---
|
||||||
|
let isOverload = false;
|
||||||
|
// Check 1: SDK specific property (common pattern)
|
||||||
|
if (modelError.type === 'overloaded_error') {
|
||||||
|
isOverload = true;
|
||||||
|
}
|
||||||
|
// Check 2: Check nested error property (as originally intended)
|
||||||
|
else if (modelError.error?.type === 'overloaded_error') {
|
||||||
|
isOverload = true;
|
||||||
|
}
|
||||||
|
// Check 3: Check status code if available (e.g., 429 Too Many Requests or 529 Overloaded)
|
||||||
|
else if (modelError.status === 429 || modelError.status === 529) {
|
||||||
|
isOverload = true;
|
||||||
|
}
|
||||||
|
// Check 4: Check the message string itself (less reliable)
|
||||||
|
else if (modelError.message?.toLowerCase().includes('overloaded')) {
|
||||||
|
isOverload = true;
|
||||||
|
}
|
||||||
|
// --- End robust check ---
|
||||||
|
|
||||||
|
if (isOverload) { // Use the result of the check
|
||||||
|
claudeOverloaded = true; // Mark Claude as overloaded for the *next* potential attempt
|
||||||
|
if (!isLastAttempt) {
|
||||||
|
log('info', 'Claude overloaded. Will attempt fallback model if available.');
|
||||||
|
// Stop the current indicator before continuing
|
||||||
|
if (loadingIndicator) {
|
||||||
|
stopLoadingIndicator(loadingIndicator);
|
||||||
|
loadingIndicator = null; // Reset indicator
|
||||||
|
}
|
||||||
|
continue; // Go to next iteration of the while loop to try fallback
|
||||||
|
} else {
|
||||||
|
// It was the last attempt, and it failed due to overload
|
||||||
|
log('error', `Overload error on final attempt (${modelAttempts}/${maxModelAttempts}). No fallback possible.`);
|
||||||
|
// Let the error be thrown after the loop finishes, as additionalInformation will be empty.
|
||||||
|
// We don't throw immediately here, let the loop exit and the check after the loop handle it.
|
||||||
|
} // <<<< ADD THIS CLOSING BRACE
|
||||||
|
} else { // Error was NOT an overload
|
||||||
|
// If it's not an overload, throw it immediately to be caught by the outer catch.
|
||||||
|
log('error', `Non-overload error on attempt ${modelAttempts}: ${modelError.message}`);
|
||||||
|
throw modelError; // Re-throw non-overload errors immediately.
|
||||||
|
}
|
||||||
|
} // End inner catch
|
||||||
|
} // End while loop
|
||||||
|
|
||||||
|
// If loop finished without getting information
|
||||||
|
if (!additionalInformation) {
|
||||||
|
console.log('>>> DEBUG: additionalInformation is falsy! Value:', additionalInformation); // <<< ADD THIS
|
||||||
|
throw new Error('Failed to generate additional information after all attempts.');
|
||||||
|
}
|
||||||
|
|
||||||
|
console.log('>>> DEBUG: Got additionalInformation:', additionalInformation.substring(0, 50) + '...'); // <<< ADD THIS
|
||||||
|
|
||||||
|
// Create timestamp
|
||||||
|
const currentDate = new Date();
|
||||||
|
const timestamp = currentDate.toISOString();
|
||||||
|
|
||||||
|
// Format the additional information with timestamp
|
||||||
|
const formattedInformation = `\n\n<info added on ${timestamp}>\n${additionalInformation}\n</info added on ${timestamp}>`;
|
||||||
|
console.log('>>> DEBUG: formattedInformation:', formattedInformation.substring(0, 70) + '...'); // <<< ADD THIS
|
||||||
|
|
||||||
|
// Append to subtask details and description
|
||||||
|
console.log('>>> DEBUG: Subtask details BEFORE append:', subtask.details); // <<< ADD THIS
|
||||||
|
if (subtask.details) {
|
||||||
|
subtask.details += formattedInformation;
|
||||||
|
} else {
|
||||||
|
subtask.details = `${formattedInformation}`;
|
||||||
|
}
|
||||||
|
console.log('>>> DEBUG: Subtask details AFTER append:', subtask.details); // <<< ADD THIS
|
||||||
|
|
||||||
|
|
||||||
|
if (subtask.description) {
|
||||||
|
// Only append to description if it makes sense (for shorter updates)
|
||||||
|
if (additionalInformation.length < 200) {
|
||||||
|
console.log('>>> DEBUG: Subtask description BEFORE append:', subtask.description); // <<< ADD THIS
|
||||||
|
subtask.description += ` [Updated: ${currentDate.toLocaleDateString()}]`;
|
||||||
|
console.log('>>> DEBUG: Subtask description AFTER append:', subtask.description); // <<< ADD THIS
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Update the subtask in the parent task (add log before write)
|
||||||
|
// ... index finding logic ...
|
||||||
|
console.log('>>> DEBUG: About to call writeJSON with updated data...'); // <<< ADD THIS
|
||||||
|
// Write the updated tasks to the file
|
||||||
|
writeJSON(tasksPath, data);
|
||||||
|
console.log('>>> DEBUG: writeJSON call completed.'); // <<< ADD THIS
|
||||||
|
|
||||||
|
|
||||||
|
log('success', `Successfully updated subtask ${subtaskId}`);
|
||||||
|
|
||||||
|
// Generate individual task files
|
||||||
|
await generateTaskFiles(tasksPath, path.dirname(tasksPath)); // <<< Maybe log after this too
|
||||||
|
|
||||||
|
// Stop indicator *before* final console output
|
||||||
|
stopLoadingIndicator(loadingIndicator);
|
||||||
|
loadingIndicator = null;
|
||||||
|
|
||||||
|
console.log(boxen(
|
||||||
|
chalk.green(`Successfully updated subtask #${subtaskId}`) + '\n\n' +
|
||||||
|
chalk.white.bold('Title:') + ' ' + subtask.title + '\n\n' +
|
||||||
|
chalk.white.bold('Information Added:') + '\n' +
|
||||||
|
chalk.white(truncate(additionalInformation, 300, true)),
|
||||||
|
{ padding: 1, borderColor: 'green', borderStyle: 'round' }
|
||||||
|
));
|
||||||
|
|
||||||
|
return subtask;
|
||||||
|
|
||||||
|
} catch (error) {
|
||||||
|
// Outer catch block handles final errors after loop/attempts
|
||||||
|
stopLoadingIndicator(loadingIndicator); // Ensure indicator is stopped on error
|
||||||
|
loadingIndicator = null;
|
||||||
|
log('error', `Error updating subtask: ${error.message}`);
|
||||||
|
console.error(chalk.red(`Error: ${error.message}`));
|
||||||
|
|
||||||
|
// ... (existing helpful error message logic based on error type) ...
|
||||||
|
if (error.message?.includes('ANTHROPIC_API_KEY')) {
|
||||||
|
console.log(chalk.yellow('\nTo fix this issue, set your Anthropic API key:'));
|
||||||
|
console.log(' export ANTHROPIC_API_KEY=your_api_key_here');
|
||||||
|
} else if (error.message?.includes('PERPLEXITY_API_KEY')) {
|
||||||
|
console.log(chalk.yellow('\nTo fix this issue:'));
|
||||||
|
console.log(' 1. Set your Perplexity API key: export PERPLEXITY_API_KEY=your_api_key_here');
|
||||||
|
console.log(' 2. Or run without the research flag: task-master update-subtask --id=<id> --prompt=\"...\"');
|
||||||
|
} else if (error.message?.includes('overloaded')) { // Catch final overload error
|
||||||
|
console.log(chalk.yellow('\nAI model overloaded, and fallback failed or was unavailable:'));
|
||||||
|
console.log(' 1. Try again in a few minutes.');
|
||||||
|
console.log(' 2. Ensure PERPLEXITY_API_KEY is set for fallback.');
|
||||||
|
console.log(' 3. Consider breaking your prompt into smaller updates.');
|
||||||
|
} else if (error.message?.includes('not found')) {
|
||||||
|
console.log(chalk.yellow('\nTo fix this issue:'));
|
||||||
|
console.log(' 1. Run task-master list --with-subtasks to see all available subtask IDs');
|
||||||
|
console.log(' 2. Use a valid subtask ID with the --id parameter in format \"parentId.subtaskId\"');
|
||||||
|
} else if (error.message?.includes('empty response from AI')) {
|
||||||
|
console.log(chalk.yellow('\nThe AI model returned an empty response. This might be due to the prompt or API issues. Try rephrasing or trying again later.'));
|
||||||
|
}
|
||||||
|
|
||||||
|
if (CONFIG.debug) {
|
||||||
|
console.error(error);
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
} finally {
|
||||||
|
// Final cleanup check for the indicator, although it should be stopped by now
|
||||||
|
if (loadingIndicator) {
|
||||||
|
stopLoadingIndicator(loadingIndicator);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Export task manager functions
|
// Export task manager functions
|
||||||
export {
|
export {
|
||||||
parsePRD,
|
parsePRD,
|
||||||
updateTasks,
|
updateTasks,
|
||||||
updateTaskById,
|
updateTaskById,
|
||||||
|
updateSubtaskById,
|
||||||
generateTaskFiles,
|
generateTaskFiles,
|
||||||
setTaskStatus,
|
setTaskStatus,
|
||||||
updateSingleTaskStatus,
|
updateSingleTaskStatus,
|
||||||
|
|||||||
32
scripts/modules/task-manager.js (lines 3036-3084)
Normal file
32
scripts/modules/task-manager.js (lines 3036-3084)
Normal file
@@ -0,0 +1,32 @@
|
|||||||
|
async function updateSubtaskById(tasksPath, subtaskId, prompt, useResearch = false) {
|
||||||
|
let loadingIndicator = null;
|
||||||
|
try {
|
||||||
|
log('info', `Updating subtask ${subtaskId} with prompt: "${prompt}"`);
|
||||||
|
|
||||||
|
// Validate subtask ID format
|
||||||
|
if (!subtaskId || typeof subtaskId !== 'string' || !subtaskId.includes('.')) {
|
||||||
|
throw new Error(`Invalid subtask ID format: ${subtaskId}. Subtask ID must be in format "parentId.subtaskId"`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Validate prompt
|
||||||
|
if (!prompt || typeof prompt !== 'string' || prompt.trim() === '') {
|
||||||
|
throw new Error('Prompt cannot be empty. Please provide context for the subtask update.');
|
||||||
|
}
|
||||||
|
|
||||||
|
// Prepare for fallback handling
|
||||||
|
let claudeOverloaded = false;
|
||||||
|
|
||||||
|
// Validate tasks file exists
|
||||||
|
if (!fs.existsSync(tasksPath)) {
|
||||||
|
throw new Error(`Tasks file not found at path: ${tasksPath}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Read the tasks file
|
||||||
|
const data = readJSON(tasksPath);
|
||||||
|
// ... rest of the function
|
||||||
|
} catch (error) {
|
||||||
|
// Handle errors
|
||||||
|
console.error(`Error updating subtask: ${error.message}`);
|
||||||
|
throw error;
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -677,6 +677,15 @@ async function displayTaskById(tasksPath, taskId) {
|
|||||||
|
|
||||||
console.log(taskTable.toString());
|
console.log(taskTable.toString());
|
||||||
|
|
||||||
|
// Show details if they exist for subtasks
|
||||||
|
if (task.details && task.details.trim().length > 0) {
|
||||||
|
console.log(boxen(
|
||||||
|
chalk.white.bold('Implementation Details:') + '\n\n' +
|
||||||
|
task.details,
|
||||||
|
{ padding: { top: 0, bottom: 0, left: 1, right: 1 }, borderColor: 'cyan', borderStyle: 'round', margin: { top: 1, bottom: 0 } }
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
// Show action suggestions for subtask
|
// Show action suggestions for subtask
|
||||||
console.log(boxen(
|
console.log(boxen(
|
||||||
chalk.white.bold('Suggested Actions:') + '\n' +
|
chalk.white.bold('Suggested Actions:') + '\n' +
|
||||||
|
|||||||
@@ -226,12 +226,69 @@ Testing approach:
|
|||||||
### Dependencies: 23.13
|
### Dependencies: 23.13
|
||||||
### Description: Refactor the MCP server implementation to use direct Task Master function imports instead of the current CLI-based execution using child_process.spawnSync. This will improve performance, reliability, and enable better error handling.
|
### Description: Refactor the MCP server implementation to use direct Task Master function imports instead of the current CLI-based execution using child_process.spawnSync. This will improve performance, reliability, and enable better error handling.
|
||||||
### Details:
|
### Details:
|
||||||
1. Create a new module to import and expose Task Master core functions directly
|
|
||||||
2. Modify tools/utils.js to remove executeTaskMasterCommand and replace with direct function calls
|
|
||||||
3. Update each tool implementation (listTasks.js, showTask.js, etc.) to use the direct function imports
|
<info added on 2025-03-30T00:14:10.040Z>
|
||||||
4. Implement proper error handling with try/catch blocks and FastMCP's MCPError
|
```
|
||||||
5. Add unit tests to verify the function imports work correctly
|
# Refactoring Strategy for Direct Function Imports
|
||||||
6. Test performance improvements by comparing response times between CLI and function import approaches
|
|
||||||
|
## Core Approach
|
||||||
|
1. Create a clear separation between data retrieval/processing and presentation logic
|
||||||
|
2. Modify function signatures to accept `outputFormat` parameter ('cli'|'json', default: 'cli')
|
||||||
|
3. Implement early returns for JSON format to bypass CLI-specific code
|
||||||
|
|
||||||
|
## Implementation Details for `listTasks`
|
||||||
|
```javascript
|
||||||
|
function listTasks(tasksPath, statusFilter, withSubtasks = false, outputFormat = 'cli') {
|
||||||
|
try {
|
||||||
|
// Existing data retrieval logic
|
||||||
|
const filteredTasks = /* ... */;
|
||||||
|
|
||||||
|
// Early return for JSON format
|
||||||
|
if (outputFormat === 'json') return filteredTasks;
|
||||||
|
|
||||||
|
// Existing CLI output logic
|
||||||
|
} catch (error) {
|
||||||
|
if (outputFormat === 'json') {
|
||||||
|
throw {
|
||||||
|
code: 'TASK_LIST_ERROR',
|
||||||
|
message: error.message,
|
||||||
|
details: error.stack
|
||||||
|
};
|
||||||
|
} else {
|
||||||
|
console.error(error);
|
||||||
|
process.exit(1);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
## Testing Strategy
|
||||||
|
- Create integration tests in `tests/integration/mcp-server/`
|
||||||
|
- Use FastMCP InMemoryTransport for direct client-server testing
|
||||||
|
- Test both JSON and CLI output formats
|
||||||
|
- Verify structure consistency with schema validation
|
||||||
|
|
||||||
|
## Additional Considerations
|
||||||
|
- Update JSDoc comments to document new parameters and return types
|
||||||
|
- Ensure backward compatibility with default CLI behavior
|
||||||
|
- Add JSON schema validation for consistent output structure
|
||||||
|
- Apply similar pattern to other core functions (expandTask, updateTaskById, etc.)
|
||||||
|
|
||||||
|
## Error Handling Improvements
|
||||||
|
- Standardize error format for JSON returns:
|
||||||
|
```javascript
|
||||||
|
{
|
||||||
|
code: 'ERROR_CODE',
|
||||||
|
message: 'Human-readable message',
|
||||||
|
details: {}, // Additional context when available
|
||||||
|
stack: process.env.NODE_ENV === 'development' ? error.stack : undefined
|
||||||
|
}
|
||||||
|
```
|
||||||
|
- Enrich JSON errors with error codes and debug info
|
||||||
|
- Ensure validation failures return proper objects in JSON mode
|
||||||
|
```
|
||||||
|
</info added on 2025-03-30T00:14:10.040Z>
|
||||||
|
|
||||||
## 9. Implement Context Management and Caching Mechanisms [deferred]
|
## 9. Implement Context Management and Caching Mechanisms [deferred]
|
||||||
### Dependencies: 23.1
|
### Dependencies: 23.1
|
||||||
|
|||||||
@@ -1399,7 +1399,7 @@
|
|||||||
"dependencies": [
|
"dependencies": [
|
||||||
"23.13"
|
"23.13"
|
||||||
],
|
],
|
||||||
"details": "1. Create a new module to import and expose Task Master core functions directly\n2. Modify tools/utils.js to remove executeTaskMasterCommand and replace with direct function calls\n3. Update each tool implementation (listTasks.js, showTask.js, etc.) to use the direct function imports\n4. Implement proper error handling with try/catch blocks and FastMCP's MCPError\n5. Add unit tests to verify the function imports work correctly\n6. Test performance improvements by comparing response times between CLI and function import approaches",
|
"details": "\n\n<info added on 2025-03-30T00:14:10.040Z>\n```\n# Refactoring Strategy for Direct Function Imports\n\n## Core Approach\n1. Create a clear separation between data retrieval/processing and presentation logic\n2. Modify function signatures to accept `outputFormat` parameter ('cli'|'json', default: 'cli')\n3. Implement early returns for JSON format to bypass CLI-specific code\n\n## Implementation Details for `listTasks`\n```javascript\nfunction listTasks(tasksPath, statusFilter, withSubtasks = false, outputFormat = 'cli') {\n try {\n // Existing data retrieval logic\n const filteredTasks = /* ... */;\n \n // Early return for JSON format\n if (outputFormat === 'json') return filteredTasks;\n \n // Existing CLI output logic\n } catch (error) {\n if (outputFormat === 'json') {\n throw {\n code: 'TASK_LIST_ERROR',\n message: error.message,\n details: error.stack\n };\n } else {\n console.error(error);\n process.exit(1);\n }\n }\n}\n```\n\n## Testing Strategy\n- Create integration tests in `tests/integration/mcp-server/`\n- Use FastMCP InMemoryTransport for direct client-server testing\n- Test both JSON and CLI output formats\n- Verify structure consistency with schema validation\n\n## Additional Considerations\n- Update JSDoc comments to document new parameters and return types\n- Ensure backward compatibility with default CLI behavior\n- Add JSON schema validation for consistent output structure\n- Apply similar pattern to other core functions (expandTask, updateTaskById, etc.)\n\n## Error Handling Improvements\n- Standardize error format for JSON returns:\n```javascript\n{\n code: 'ERROR_CODE',\n message: 'Human-readable message',\n details: {}, // Additional context when available\n stack: process.env.NODE_ENV === 'development' ? error.stack : undefined\n}\n```\n- Enrich JSON errors with error codes and debug info\n- Ensure validation failures return proper objects in JSON mode\n```\n</info added on 2025-03-30T00:14:10.040Z>",
|
||||||
"status": "in-progress",
|
"status": "in-progress",
|
||||||
"parentTaskId": 23
|
"parentTaskId": 23
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -311,10 +311,17 @@ These subtasks will help you implement the parent task efficiently.`;
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Mock process.env to include PERPLEXITY_API_KEY
|
||||||
|
const originalEnv = process.env;
|
||||||
|
process.env = { ...originalEnv, PERPLEXITY_API_KEY: 'test-key' };
|
||||||
|
|
||||||
const result = handleClaudeError(error);
|
const result = handleClaudeError(error);
|
||||||
|
|
||||||
expect(result).toContain('Claude is currently experiencing high demand');
|
// Restore original env
|
||||||
expect(result).toContain('overloaded');
|
process.env = originalEnv;
|
||||||
|
|
||||||
|
expect(result).toContain('Claude is currently overloaded');
|
||||||
|
expect(result).toContain('fall back to Perplexity AI');
|
||||||
});
|
});
|
||||||
|
|
||||||
test('should handle rate_limit_error type', () => {
|
test('should handle rate_limit_error type', () => {
|
||||||
|
|||||||
@@ -24,6 +24,7 @@ const mockLog = jest.fn();
|
|||||||
const mockIsTaskDependentOn = jest.fn().mockReturnValue(false);
|
const mockIsTaskDependentOn = jest.fn().mockReturnValue(false);
|
||||||
const mockCreate = jest.fn(); // Mock for Anthropic messages.create
|
const mockCreate = jest.fn(); // Mock for Anthropic messages.create
|
||||||
const mockChatCompletionsCreate = jest.fn(); // Mock for Perplexity chat.completions.create
|
const mockChatCompletionsCreate = jest.fn(); // Mock for Perplexity chat.completions.create
|
||||||
|
const mockGetAvailableAIModel = jest.fn(); // <<<<< Added mock function
|
||||||
|
|
||||||
// Mock fs module
|
// Mock fs module
|
||||||
jest.mock('fs', () => ({
|
jest.mock('fs', () => ({
|
||||||
@@ -43,7 +44,12 @@ jest.mock('path', () => ({
|
|||||||
jest.mock('../../scripts/modules/ui.js', () => ({
|
jest.mock('../../scripts/modules/ui.js', () => ({
|
||||||
formatDependenciesWithStatus: mockFormatDependenciesWithStatus,
|
formatDependenciesWithStatus: mockFormatDependenciesWithStatus,
|
||||||
displayBanner: jest.fn(),
|
displayBanner: jest.fn(),
|
||||||
displayTaskList: mockDisplayTaskList
|
displayTaskList: mockDisplayTaskList,
|
||||||
|
startLoadingIndicator: jest.fn(() => ({ stop: jest.fn() })), // <<<<< Added mock
|
||||||
|
stopLoadingIndicator: jest.fn(), // <<<<< Added mock
|
||||||
|
createProgressBar: jest.fn(() => ' MOCK_PROGRESS_BAR '), // <<<<< Added mock (used by listTasks)
|
||||||
|
getStatusWithColor: jest.fn(status => status), // Basic mock for status
|
||||||
|
getComplexityWithColor: jest.fn(score => `Score: ${score}`), // Basic mock for complexity
|
||||||
}));
|
}));
|
||||||
|
|
||||||
// Mock dependency-manager
|
// Mock dependency-manager
|
||||||
@@ -56,13 +62,31 @@ jest.mock('../../scripts/modules/dependency-manager.js', () => ({
|
|||||||
jest.mock('../../scripts/modules/utils.js', () => ({
|
jest.mock('../../scripts/modules/utils.js', () => ({
|
||||||
writeJSON: mockWriteJSON,
|
writeJSON: mockWriteJSON,
|
||||||
readJSON: mockReadJSON,
|
readJSON: mockReadJSON,
|
||||||
log: mockLog
|
log: mockLog,
|
||||||
|
CONFIG: { // <<<<< Added CONFIG mock
|
||||||
|
model: 'mock-claude-model',
|
||||||
|
maxTokens: 4000,
|
||||||
|
temperature: 0.7,
|
||||||
|
debug: false,
|
||||||
|
defaultSubtasks: 3,
|
||||||
|
// Add other necessary CONFIG properties if needed
|
||||||
|
},
|
||||||
|
sanitizePrompt: jest.fn(prompt => prompt), // <<<<< Added mock
|
||||||
|
findTaskById: jest.fn((tasks, id) => tasks.find(t => t.id === parseInt(id))), // <<<<< Added mock
|
||||||
|
readComplexityReport: jest.fn(), // <<<<< Added mock
|
||||||
|
findTaskInComplexityReport: jest.fn(), // <<<<< Added mock
|
||||||
|
truncate: jest.fn((str, len) => str.slice(0, len)), // <<<<< Added mock
|
||||||
}));
|
}));
|
||||||
|
|
||||||
// Mock AI services - This is the correct way to mock the module
|
// Mock AI services - Update this mock
|
||||||
jest.mock('../../scripts/modules/ai-services.js', () => ({
|
jest.mock('../../scripts/modules/ai-services.js', () => ({
|
||||||
callClaude: mockCallClaude,
|
callClaude: mockCallClaude,
|
||||||
callPerplexity: mockCallPerplexity
|
callPerplexity: mockCallPerplexity,
|
||||||
|
generateSubtasks: jest.fn(), // <<<<< Add other functions as needed
|
||||||
|
generateSubtasksWithPerplexity: jest.fn(), // <<<<< Add other functions as needed
|
||||||
|
generateComplexityAnalysisPrompt: jest.fn(), // <<<<< Add other functions as needed
|
||||||
|
getAvailableAIModel: mockGetAvailableAIModel, // <<<<< Use the new mock function
|
||||||
|
handleClaudeError: jest.fn(), // <<<<< Add other functions as needed
|
||||||
}));
|
}));
|
||||||
|
|
||||||
// Mock Anthropic SDK
|
// Mock Anthropic SDK
|
||||||
@@ -1651,7 +1675,7 @@ const testRemoveSubtask = (tasksPath, subtaskId, convertToTask = false, generate
|
|||||||
|
|
||||||
// Parse the subtask ID (format: "parentId.subtaskId")
|
// Parse the subtask ID (format: "parentId.subtaskId")
|
||||||
if (!subtaskId.includes('.')) {
|
if (!subtaskId.includes('.')) {
|
||||||
throw new Error(`Invalid subtask ID format: ${subtaskId}. Expected format: "parentId.subtaskId"`);
|
throw new Error(`Invalid subtask ID format: ${subtaskId}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
const [parentIdStr, subtaskIdStr] = subtaskId.split('.');
|
const [parentIdStr, subtaskIdStr] = subtaskId.split('.');
|
||||||
@@ -2013,4 +2037,625 @@ describe.skip('updateTaskById function', () => {
|
|||||||
// Clean up
|
// Clean up
|
||||||
delete process.env.PERPLEXITY_API_KEY;
|
delete process.env.PERPLEXITY_API_KEY;
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Mock implementation of updateSubtaskById for testing
|
||||||
|
const testUpdateSubtaskById = async (tasksPath, subtaskId, prompt, useResearch = false) => {
|
||||||
|
try {
|
||||||
|
// Parse parent and subtask IDs
|
||||||
|
if (!subtaskId || typeof subtaskId !== 'string' || !subtaskId.includes('.')) {
|
||||||
|
throw new Error(`Invalid subtask ID format: ${subtaskId}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
const [parentIdStr, subtaskIdStr] = subtaskId.split('.');
|
||||||
|
const parentId = parseInt(parentIdStr, 10);
|
||||||
|
const subtaskIdNum = parseInt(subtaskIdStr, 10);
|
||||||
|
|
||||||
|
if (isNaN(parentId) || parentId <= 0 || isNaN(subtaskIdNum) || subtaskIdNum <= 0) {
|
||||||
|
throw new Error(`Invalid subtask ID format: ${subtaskId}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Validate prompt
|
||||||
|
if (!prompt || typeof prompt !== 'string' || prompt.trim() === '') {
|
||||||
|
throw new Error('Prompt cannot be empty');
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if tasks file exists
|
||||||
|
if (!mockExistsSync(tasksPath)) {
|
||||||
|
throw new Error(`Tasks file not found at path: ${tasksPath}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Read the tasks file
|
||||||
|
const data = mockReadJSON(tasksPath);
|
||||||
|
if (!data || !data.tasks) {
|
||||||
|
throw new Error(`No valid tasks found in ${tasksPath}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find the parent task
|
||||||
|
const parentTask = data.tasks.find(t => t.id === parentId);
|
||||||
|
if (!parentTask) {
|
||||||
|
throw new Error(`Parent task with ID ${parentId} not found`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Find the subtask
|
||||||
|
if (!parentTask.subtasks || !Array.isArray(parentTask.subtasks)) {
|
||||||
|
throw new Error(`Parent task ${parentId} has no subtasks`);
|
||||||
|
}
|
||||||
|
|
||||||
|
const subtask = parentTask.subtasks.find(st => st.id === subtaskIdNum);
|
||||||
|
if (!subtask) {
|
||||||
|
throw new Error(`Subtask with ID ${subtaskId} not found`);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Check if subtask is already completed
|
||||||
|
if (subtask.status === 'done' || subtask.status === 'completed') {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Generate additional information
|
||||||
|
let additionalInformation;
|
||||||
|
if (useResearch) {
|
||||||
|
const result = await mockChatCompletionsCreate();
|
||||||
|
additionalInformation = result.choices[0].message.content;
|
||||||
|
} else {
|
||||||
|
const mockStream = {
|
||||||
|
[Symbol.asyncIterator]: jest.fn().mockImplementation(() => {
|
||||||
|
return {
|
||||||
|
next: jest.fn()
|
||||||
|
.mockResolvedValueOnce({
|
||||||
|
done: false,
|
||||||
|
value: {
|
||||||
|
type: 'content_block_delta',
|
||||||
|
delta: { text: 'Additional information about' }
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.mockResolvedValueOnce({
|
||||||
|
done: false,
|
||||||
|
value: {
|
||||||
|
type: 'content_block_delta',
|
||||||
|
delta: { text: ' the subtask implementation.' }
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.mockResolvedValueOnce({ done: true })
|
||||||
|
};
|
||||||
|
})
|
||||||
|
};
|
||||||
|
|
||||||
|
const stream = await mockCreate();
|
||||||
|
additionalInformation = 'Additional information about the subtask implementation.';
|
||||||
|
}
|
||||||
|
|
||||||
|
// Create timestamp
|
||||||
|
const timestamp = new Date().toISOString();
|
||||||
|
|
||||||
|
// Format the additional information with timestamp
|
||||||
|
const formattedInformation = `\n\n<info added on ${timestamp}>\n${additionalInformation}\n</info added on ${timestamp}>`;
|
||||||
|
|
||||||
|
// Append to subtask details
|
||||||
|
if (subtask.details) {
|
||||||
|
subtask.details += formattedInformation;
|
||||||
|
} else {
|
||||||
|
subtask.details = formattedInformation;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Update description with update marker for shorter updates
|
||||||
|
if (subtask.description && additionalInformation.length < 200) {
|
||||||
|
subtask.description += ` [Updated: ${new Date().toLocaleDateString()}]`;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Write the updated tasks to the file
|
||||||
|
mockWriteJSON(tasksPath, data);
|
||||||
|
|
||||||
|
// Generate individual task files
|
||||||
|
await mockGenerateTaskFiles(tasksPath, path.dirname(tasksPath));
|
||||||
|
|
||||||
|
return subtask;
|
||||||
|
} catch (error) {
|
||||||
|
mockLog('error', `Error updating subtask: ${error.message}`);
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
describe.skip('updateSubtaskById function', () => {
|
||||||
|
let mockConsoleLog;
|
||||||
|
let mockConsoleError;
|
||||||
|
let mockProcess;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
// Reset all mocks
|
||||||
|
jest.clearAllMocks();
|
||||||
|
|
||||||
|
// Set up default mock values
|
||||||
|
mockExistsSync.mockReturnValue(true);
|
||||||
|
mockWriteJSON.mockImplementation(() => {});
|
||||||
|
mockGenerateTaskFiles.mockResolvedValue(undefined);
|
||||||
|
|
||||||
|
// Create a deep copy of sample tasks for tests - use imported ES module instead of require
|
||||||
|
const sampleTasksDeepCopy = JSON.parse(JSON.stringify(sampleTasks));
|
||||||
|
|
||||||
|
// Ensure the sample tasks has a task with subtasks for testing
|
||||||
|
// Task 3 should have subtasks
|
||||||
|
if (sampleTasksDeepCopy.tasks && sampleTasksDeepCopy.tasks.length > 2) {
|
||||||
|
const task3 = sampleTasksDeepCopy.tasks.find(t => t.id === 3);
|
||||||
|
if (task3 && (!task3.subtasks || task3.subtasks.length === 0)) {
|
||||||
|
task3.subtasks = [
|
||||||
|
{
|
||||||
|
id: 1,
|
||||||
|
title: 'Create Header Component',
|
||||||
|
description: 'Create a reusable header component',
|
||||||
|
status: 'pending'
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: 2,
|
||||||
|
title: 'Create Footer Component',
|
||||||
|
description: 'Create a reusable footer component',
|
||||||
|
status: 'pending'
|
||||||
|
}
|
||||||
|
];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
mockReadJSON.mockReturnValue(sampleTasksDeepCopy);
|
||||||
|
|
||||||
|
// Mock console and process.exit
|
||||||
|
mockConsoleLog = jest.spyOn(console, 'log').mockImplementation(() => {});
|
||||||
|
mockConsoleError = jest.spyOn(console, 'error').mockImplementation(() => {});
|
||||||
|
mockProcess = jest.spyOn(process, 'exit').mockImplementation(() => {});
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => {
|
||||||
|
// Restore console and process.exit
|
||||||
|
mockConsoleLog.mockRestore();
|
||||||
|
mockConsoleError.mockRestore();
|
||||||
|
mockProcess.mockRestore();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should update a subtask successfully', async () => {
|
||||||
|
// Mock streaming for successful response
|
||||||
|
const mockStream = {
|
||||||
|
[Symbol.asyncIterator]: jest.fn().mockImplementation(() => {
|
||||||
|
return {
|
||||||
|
next: jest.fn()
|
||||||
|
.mockResolvedValueOnce({
|
||||||
|
done: false,
|
||||||
|
value: {
|
||||||
|
type: 'content_block_delta',
|
||||||
|
delta: { text: 'Additional information about the subtask implementation.' }
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.mockResolvedValueOnce({ done: true })
|
||||||
|
};
|
||||||
|
})
|
||||||
|
};
|
||||||
|
|
||||||
|
mockCreate.mockResolvedValue(mockStream);
|
||||||
|
|
||||||
|
// Call the function
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.1', 'Add details about API endpoints');
|
||||||
|
|
||||||
|
// Verify the subtask was updated
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.details).toContain('<info added on');
|
||||||
|
expect(result.details).toContain('Additional information about the subtask implementation');
|
||||||
|
expect(result.details).toContain('</info added on');
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockCreate).toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).toHaveBeenCalled();
|
||||||
|
|
||||||
|
// Verify the subtask was updated in the tasks data
|
||||||
|
const tasksData = mockWriteJSON.mock.calls[0][1];
|
||||||
|
const parentTask = tasksData.tasks.find(task => task.id === 3);
|
||||||
|
const updatedSubtask = parentTask.subtasks.find(st => st.id === 1);
|
||||||
|
expect(updatedSubtask.details).toContain('Additional information about the subtask implementation');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should return null when subtask is already completed', async () => {
|
||||||
|
// Modify the sample data to have a completed subtask
|
||||||
|
const tasksData = mockReadJSON();
|
||||||
|
const task = tasksData.tasks.find(t => t.id === 3);
|
||||||
|
if (task && task.subtasks && task.subtasks.length > 0) {
|
||||||
|
// Mark the first subtask as completed
|
||||||
|
task.subtasks[0].status = 'done';
|
||||||
|
mockReadJSON.mockReturnValue(tasksData);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Call the function with a completed subtask
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.1', 'Update completed subtask');
|
||||||
|
|
||||||
|
// Verify the result is null
|
||||||
|
expect(result).toBeNull();
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle subtask not found error', async () => {
|
||||||
|
// Call the function with a non-existent subtask
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.999', 'Update non-existent subtask');
|
||||||
|
|
||||||
|
// Verify the result is null
|
||||||
|
expect(result).toBeNull();
|
||||||
|
|
||||||
|
// Verify the error was logged
|
||||||
|
expect(mockLog).toHaveBeenCalledWith('error', expect.stringContaining('Subtask with ID 3.999 not found'));
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle invalid subtask ID format', async () => {
|
||||||
|
// Call the function with an invalid subtask ID
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', 'invalid-id', 'Update subtask with invalid ID');
|
||||||
|
|
||||||
|
// Verify the result is null
|
||||||
|
expect(result).toBeNull();
|
||||||
|
|
||||||
|
// Verify the error was logged
|
||||||
|
expect(mockLog).toHaveBeenCalledWith('error', expect.stringContaining('Invalid subtask ID format'));
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle missing tasks file', async () => {
|
||||||
|
// Mock file not existing
|
||||||
|
mockExistsSync.mockReturnValue(false);
|
||||||
|
|
||||||
|
// Call the function
|
||||||
|
const result = await testUpdateSubtaskById('missing-tasks.json', '3.1', 'Update subtask');
|
||||||
|
|
||||||
|
// Verify the result is null
|
||||||
|
expect(result).toBeNull();
|
||||||
|
|
||||||
|
// Verify the error was logged
|
||||||
|
expect(mockLog).toHaveBeenCalledWith('error', expect.stringContaining('Tasks file not found'));
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should handle empty prompt', async () => {
|
||||||
|
// Call the function with an empty prompt
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.1', '');
|
||||||
|
|
||||||
|
// Verify the result is null
|
||||||
|
expect(result).toBeNull();
|
||||||
|
|
||||||
|
// Verify the error was logged
|
||||||
|
expect(mockLog).toHaveBeenCalledWith('error', expect.stringContaining('Prompt cannot be empty'));
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled();
|
||||||
|
expect(mockWriteJSON).not.toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should use Perplexity AI when research flag is true', async () => {
|
||||||
|
// Mock Perplexity API response
|
||||||
|
const mockPerplexityResponse = {
|
||||||
|
choices: [
|
||||||
|
{
|
||||||
|
message: {
|
||||||
|
content: 'Research-backed information about the subtask implementation.'
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]
|
||||||
|
};
|
||||||
|
|
||||||
|
mockChatCompletionsCreate.mockResolvedValue(mockPerplexityResponse);
|
||||||
|
|
||||||
|
// Set the Perplexity API key in environment
|
||||||
|
process.env.PERPLEXITY_API_KEY = 'dummy-key';
|
||||||
|
|
||||||
|
// Call the function with research flag
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.1', 'Add research-backed details', true);
|
||||||
|
|
||||||
|
// Verify the subtask was updated with research-backed information
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.details).toContain('<info added on');
|
||||||
|
expect(result.details).toContain('Research-backed information about the subtask implementation');
|
||||||
|
expect(result.details).toContain('</info added on');
|
||||||
|
|
||||||
|
// Verify the Perplexity API was called
|
||||||
|
expect(mockChatCompletionsCreate).toHaveBeenCalled();
|
||||||
|
expect(mockCreate).not.toHaveBeenCalled(); // Claude should not be called
|
||||||
|
|
||||||
|
// Verify the correct functions were called
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith('test-tasks.json');
|
||||||
|
expect(mockWriteJSON).toHaveBeenCalled();
|
||||||
|
expect(mockGenerateTaskFiles).toHaveBeenCalled();
|
||||||
|
|
||||||
|
// Clean up
|
||||||
|
delete process.env.PERPLEXITY_API_KEY;
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should append timestamp correctly in XML-like format', async () => {
|
||||||
|
// Mock streaming for successful response
|
||||||
|
const mockStream = {
|
||||||
|
[Symbol.asyncIterator]: jest.fn().mockImplementation(() => {
|
||||||
|
return {
|
||||||
|
next: jest.fn()
|
||||||
|
.mockResolvedValueOnce({
|
||||||
|
done: false,
|
||||||
|
value: {
|
||||||
|
type: 'content_block_delta',
|
||||||
|
delta: { text: 'Additional information about the subtask implementation.' }
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.mockResolvedValueOnce({ done: true })
|
||||||
|
};
|
||||||
|
})
|
||||||
|
};
|
||||||
|
|
||||||
|
mockCreate.mockResolvedValue(mockStream);
|
||||||
|
|
||||||
|
// Call the function
|
||||||
|
const result = await testUpdateSubtaskById('test-tasks.json', '3.1', 'Add details about API endpoints');
|
||||||
|
|
||||||
|
// Verify the XML-like format with timestamp
|
||||||
|
expect(result).toBeDefined();
|
||||||
|
expect(result.details).toMatch(/<info added on [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z>/);
|
||||||
|
expect(result.details).toMatch(/<\/info added on [0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z>/);
|
||||||
|
|
||||||
|
// Verify the same timestamp is used in both opening and closing tags
|
||||||
|
const openingMatch = result.details.match(/<info added on ([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z)>/);
|
||||||
|
const closingMatch = result.details.match(/<\/info added on ([0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}.[0-9]{3}Z)>/);
|
||||||
|
|
||||||
|
expect(openingMatch).toBeTruthy();
|
||||||
|
expect(closingMatch).toBeTruthy();
|
||||||
|
expect(openingMatch[1]).toBe(closingMatch[1]);
|
||||||
|
});
|
||||||
|
|
||||||
|
let mockTasksData;
|
||||||
|
const tasksPath = 'test-tasks.json';
|
||||||
|
const outputDir = 'test-tasks-output'; // Assuming generateTaskFiles needs this
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
// Reset mocks before each test
|
||||||
|
jest.clearAllMocks();
|
||||||
|
|
||||||
|
// Reset mock data (deep copy to avoid test interference)
|
||||||
|
mockTasksData = JSON.parse(JSON.stringify({
|
||||||
|
tasks: [
|
||||||
|
{
|
||||||
|
id: 1,
|
||||||
|
title: 'Parent Task 1',
|
||||||
|
status: 'pending',
|
||||||
|
dependencies: [],
|
||||||
|
priority: 'medium',
|
||||||
|
description: 'Parent description',
|
||||||
|
details: 'Parent details',
|
||||||
|
testStrategy: 'Parent tests',
|
||||||
|
subtasks: [
|
||||||
|
{
|
||||||
|
id: 1,
|
||||||
|
title: 'Subtask 1.1',
|
||||||
|
description: 'Subtask 1.1 description',
|
||||||
|
details: 'Initial subtask details.',
|
||||||
|
status: 'pending',
|
||||||
|
dependencies: [],
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: 2,
|
||||||
|
title: 'Subtask 1.2',
|
||||||
|
description: 'Subtask 1.2 description',
|
||||||
|
details: 'Initial subtask details for 1.2.',
|
||||||
|
status: 'done', // Completed subtask
|
||||||
|
dependencies: [],
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}));
|
||||||
|
|
||||||
|
// Default mock behaviors
|
||||||
|
mockReadJSON.mockReturnValue(mockTasksData);
|
||||||
|
mockDirname.mockReturnValue(outputDir); // Mock path.dirname needed by generateTaskFiles
|
||||||
|
mockGenerateTaskFiles.mockResolvedValue(); // Assume generateTaskFiles succeeds
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should successfully update subtask using Claude (non-research)', async () => {
|
||||||
|
const subtaskIdToUpdate = '1.1'; // Valid format
|
||||||
|
const updatePrompt = 'Add more technical details about API integration.'; // Non-empty prompt
|
||||||
|
const expectedClaudeResponse = 'Here are the API integration details you requested.';
|
||||||
|
|
||||||
|
// --- Arrange ---
|
||||||
|
// **Explicitly reset and configure mocks for this test**
|
||||||
|
jest.clearAllMocks(); // Ensure clean state
|
||||||
|
|
||||||
|
// Configure mocks used *before* readJSON
|
||||||
|
mockExistsSync.mockReturnValue(true); // Ensure file is found
|
||||||
|
mockGetAvailableAIModel.mockReturnValue({ // Ensure this returns the correct structure
|
||||||
|
type: 'claude',
|
||||||
|
client: { messages: { create: mockCreate } }
|
||||||
|
});
|
||||||
|
|
||||||
|
// Configure mocks used *after* readJSON (as before)
|
||||||
|
mockReadJSON.mockReturnValue(mockTasksData); // Ensure readJSON returns valid data
|
||||||
|
async function* createMockStream() {
|
||||||
|
yield { type: 'content_block_delta', delta: { text: expectedClaudeResponse.substring(0, 10) } };
|
||||||
|
yield { type: 'content_block_delta', delta: { text: expectedClaudeResponse.substring(10) } };
|
||||||
|
yield { type: 'message_stop' };
|
||||||
|
}
|
||||||
|
mockCreate.mockResolvedValue(createMockStream());
|
||||||
|
mockDirname.mockReturnValue(outputDir);
|
||||||
|
mockGenerateTaskFiles.mockResolvedValue();
|
||||||
|
|
||||||
|
// --- Act ---
|
||||||
|
const updatedSubtask = await taskManager.updateSubtaskById(tasksPath, subtaskIdToUpdate, updatePrompt, false);
|
||||||
|
|
||||||
|
// --- Assert ---
|
||||||
|
// **Add an assertion right at the start to check if readJSON was called**
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith(tasksPath); // <<< Let's see if this passes now
|
||||||
|
|
||||||
|
// ... (rest of the assertions as before) ...
|
||||||
|
expect(mockGetAvailableAIModel).toHaveBeenCalledWith({ claudeOverloaded: false, requiresResearch: false });
|
||||||
|
expect(mockCreate).toHaveBeenCalledTimes(1);
|
||||||
|
// ... etc ...
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should successfully update subtask using Perplexity (research)', async () => {
|
||||||
|
const subtaskIdToUpdate = '1.1';
|
||||||
|
const updatePrompt = 'Research best practices for this subtask.';
|
||||||
|
const expectedPerplexityResponse = 'Based on research, here are the best practices...';
|
||||||
|
const perplexityModelName = 'mock-perplexity-model'; // Define a mock model name
|
||||||
|
|
||||||
|
// --- Arrange ---
|
||||||
|
// Mock environment variable for Perplexity model if needed by CONFIG/logic
|
||||||
|
process.env.PERPLEXITY_MODEL = perplexityModelName;
|
||||||
|
|
||||||
|
// Mock getAvailableAIModel to return Perplexity client when research is required
|
||||||
|
mockGetAvailableAIModel.mockReturnValue({
|
||||||
|
type: 'perplexity',
|
||||||
|
client: { chat: { completions: { create: mockChatCompletionsCreate } } } // Match the mocked structure
|
||||||
|
});
|
||||||
|
|
||||||
|
// Mock Perplexity's response
|
||||||
|
mockChatCompletionsCreate.mockResolvedValue({
|
||||||
|
choices: [{ message: { content: expectedPerplexityResponse } }]
|
||||||
|
});
|
||||||
|
|
||||||
|
// --- Act ---
|
||||||
|
const updatedSubtask = await taskManager.updateSubtaskById(tasksPath, subtaskIdToUpdate, updatePrompt, true); // useResearch = true
|
||||||
|
|
||||||
|
// --- Assert ---
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith(tasksPath);
|
||||||
|
// Verify getAvailableAIModel was called correctly for research
|
||||||
|
expect(mockGetAvailableAIModel).toHaveBeenCalledWith({ claudeOverloaded: false, requiresResearch: true });
|
||||||
|
expect(mockChatCompletionsCreate).toHaveBeenCalledTimes(1);
|
||||||
|
|
||||||
|
// Verify Perplexity API call parameters
|
||||||
|
expect(mockChatCompletionsCreate).toHaveBeenCalledWith(expect.objectContaining({
|
||||||
|
model: perplexityModelName, // Check the correct model is used
|
||||||
|
temperature: 0.7, // From CONFIG mock
|
||||||
|
max_tokens: 4000, // From CONFIG mock
|
||||||
|
messages: expect.arrayContaining([
|
||||||
|
expect.objectContaining({ role: 'system', content: expect.any(String) }),
|
||||||
|
expect.objectContaining({
|
||||||
|
role: 'user',
|
||||||
|
content: expect.stringContaining(updatePrompt) // Check prompt is included
|
||||||
|
})
|
||||||
|
])
|
||||||
|
}));
|
||||||
|
|
||||||
|
// Verify subtask data was updated
|
||||||
|
const writtenData = mockWriteJSON.mock.calls[0][1]; // Get data passed to writeJSON
|
||||||
|
const parentTask = writtenData.tasks.find(t => t.id === 1);
|
||||||
|
const targetSubtask = parentTask.subtasks.find(st => st.id === 1);
|
||||||
|
|
||||||
|
expect(targetSubtask.details).toContain(expectedPerplexityResponse);
|
||||||
|
expect(targetSubtask.details).toMatch(/<info added on .*>/); // Check for timestamp tag
|
||||||
|
expect(targetSubtask.description).toMatch(/\[Updated: .*]/); // Check description update
|
||||||
|
|
||||||
|
// Verify writeJSON and generateTaskFiles were called
|
||||||
|
expect(mockWriteJSON).toHaveBeenCalledWith(tasksPath, writtenData);
|
||||||
|
expect(mockGenerateTaskFiles).toHaveBeenCalledWith(tasksPath, outputDir);
|
||||||
|
|
||||||
|
// Verify the function returned the updated subtask
|
||||||
|
expect(updatedSubtask).toBeDefined();
|
||||||
|
expect(updatedSubtask.id).toBe(1);
|
||||||
|
expect(updatedSubtask.parentTaskId).toBe(1);
|
||||||
|
expect(updatedSubtask.details).toContain(expectedPerplexityResponse);
|
||||||
|
|
||||||
|
// Clean up env var if set
|
||||||
|
delete process.env.PERPLEXITY_MODEL;
|
||||||
|
});
|
||||||
|
|
||||||
|
test('should fall back to Perplexity if Claude is overloaded', async () => {
|
||||||
|
const subtaskIdToUpdate = '1.1';
|
||||||
|
const updatePrompt = 'Add details, trying Claude first.';
|
||||||
|
const expectedPerplexityResponse = 'Perplexity provided these details as fallback.';
|
||||||
|
const perplexityModelName = 'mock-perplexity-model-fallback';
|
||||||
|
|
||||||
|
// --- Arrange ---
|
||||||
|
// Mock environment variable for Perplexity model
|
||||||
|
process.env.PERPLEXITY_MODEL = perplexityModelName;
|
||||||
|
|
||||||
|
// Mock getAvailableAIModel: Return Claude first, then Perplexity
|
||||||
|
mockGetAvailableAIModel
|
||||||
|
.mockReturnValueOnce({ // First call: Return Claude
|
||||||
|
type: 'claude',
|
||||||
|
client: { messages: { create: mockCreate } }
|
||||||
|
})
|
||||||
|
.mockReturnValueOnce({ // Second call: Return Perplexity (after overload)
|
||||||
|
type: 'perplexity',
|
||||||
|
client: { chat: { completions: { create: mockChatCompletionsCreate } } }
|
||||||
|
});
|
||||||
|
|
||||||
|
// Mock Claude to throw an overload error
|
||||||
|
const overloadError = new Error('Claude API is overloaded.');
|
||||||
|
overloadError.type = 'overloaded_error'; // Match one of the specific checks
|
||||||
|
mockCreate.mockRejectedValue(overloadError); // Simulate Claude failing
|
||||||
|
|
||||||
|
// Mock Perplexity's successful response
|
||||||
|
mockChatCompletionsCreate.mockResolvedValue({
|
||||||
|
choices: [{ message: { content: expectedPerplexityResponse } }]
|
||||||
|
});
|
||||||
|
|
||||||
|
// --- Act ---
|
||||||
|
const updatedSubtask = await taskManager.updateSubtaskById(tasksPath, subtaskIdToUpdate, updatePrompt, false); // Start with useResearch = false
|
||||||
|
|
||||||
|
// --- Assert ---
|
||||||
|
expect(mockReadJSON).toHaveBeenCalledWith(tasksPath);
|
||||||
|
|
||||||
|
// Verify getAvailableAIModel calls
|
||||||
|
expect(mockGetAvailableAIModel).toHaveBeenCalledTimes(2);
|
||||||
|
expect(mockGetAvailableAIModel).toHaveBeenNthCalledWith(1, { claudeOverloaded: false, requiresResearch: false });
|
||||||
|
expect(mockGetAvailableAIModel).toHaveBeenNthCalledWith(2, { claudeOverloaded: true, requiresResearch: false }); // claudeOverloaded should now be true
|
||||||
|
|
||||||
|
// Verify Claude was attempted and failed
|
||||||
|
expect(mockCreate).toHaveBeenCalledTimes(1);
|
||||||
|
// Verify Perplexity was called as fallback
|
||||||
|
expect(mockChatCompletionsCreate).toHaveBeenCalledTimes(1);
|
||||||
|
|
||||||
|
// Verify Perplexity API call parameters
|
||||||
|
expect(mockChatCompletionsCreate).toHaveBeenCalledWith(expect.objectContaining({
|
||||||
|
model: perplexityModelName,
|
||||||
|
messages: expect.arrayContaining([
|
||||||
|
expect.objectContaining({
|
||||||
|
role: 'user',
|
||||||
|
content: expect.stringContaining(updatePrompt)
|
||||||
|
})
|
||||||
|
])
|
||||||
|
}));
|
||||||
|
|
||||||
|
// Verify subtask data was updated with Perplexity's response
|
||||||
|
const writtenData = mockWriteJSON.mock.calls[0][1];
|
||||||
|
const parentTask = writtenData.tasks.find(t => t.id === 1);
|
||||||
|
const targetSubtask = parentTask.subtasks.find(st => st.id === 1);
|
||||||
|
|
||||||
|
expect(targetSubtask.details).toContain(expectedPerplexityResponse); // Should contain fallback response
|
||||||
|
expect(targetSubtask.details).toMatch(/<info added on .*>/);
|
||||||
|
expect(targetSubtask.description).toMatch(/\[Updated: .*]/);
|
||||||
|
|
||||||
|
// Verify writeJSON and generateTaskFiles were called
|
||||||
|
expect(mockWriteJSON).toHaveBeenCalledWith(tasksPath, writtenData);
|
||||||
|
expect(mockGenerateTaskFiles).toHaveBeenCalledWith(tasksPath, outputDir);
|
||||||
|
|
||||||
|
// Verify the function returned the updated subtask
|
||||||
|
expect(updatedSubtask).toBeDefined();
|
||||||
|
expect(updatedSubtask.details).toContain(expectedPerplexityResponse);
|
||||||
|
|
||||||
|
// Clean up env var if set
|
||||||
|
delete process.env.PERPLEXITY_MODEL;
|
||||||
|
});
|
||||||
|
|
||||||
|
// More tests will go here...
|
||||||
|
|
||||||
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user