From 6c54a2821dbc18608b6b51433a1aec4d9a79edf2 Mon Sep 17 00:00:00 2001
From: Ralph Khreish <35776126+Crunchyman-ralph@users.noreply.github.com>
Date: Mon, 22 Sep 2025 15:25:05 +0200
Subject: [PATCH] fix: correct merged vs closed terminology for PR metrics

- Prefer 'Number of items merged' over 'Number of items closed' for accuracy
- Prefer 'Average time to merge' over 'Time to close' for PR timing
- Add safe fallbacks if action doesn't provide merged-specific metrics
- Fixes Discord report showing 'merged' but parsing 'closed' data
---
 .github/scripts/parse-metrics.mjs | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/.github/scripts/parse-metrics.mjs b/.github/scripts/parse-metrics.mjs
index dd95375b..ba1390e5 100644
--- a/.github/scripts/parse-metrics.mjs
+++ b/.github/scripts/parse-metrics.mjs
@@ -82,12 +82,19 @@ function main() {
 			prContent,
 			'Total number of items created'
 		);
-		metrics.prs_merged = parseCountMetric(prContent, 'Number of items closed');
+		// Prefer merged; fall back to closed if the generator doesn't emit "merged"
+		const mergedCount = parseCountMetric(prContent, 'Number of items merged');
+		metrics.prs_merged = mergedCount || parseCountMetric(prContent, 'Number of items closed');
+
 		metrics.pr_avg_first_response = parseMetricsTable(
 			prContent,
 			'Time to first response'
 		);
-		metrics.pr_avg_merge_time = parseMetricsTable(prContent, 'Time to close');
+		// Prefer "Average time to merge"; fall back to "Time to close"
+		const maybeMergeTime = parseMetricsTable(prContent, 'Average time to merge');
+		metrics.pr_avg_merge_time = maybeMergeTime !== 'N/A'
+			? maybeMergeTime
+			: parseMetricsTable(prContent, 'Time to close');
 	} else {
 		console.log('⚠️  No pr_metrics.md found');
 	}